Re: [PATCH 87/87] fs: move i_blocks up a few places in struct inode

2023-09-28 Thread Amir Goldstein
On Thu, Sep 28, 2023 at 2:06 PM Jeff Layton wrote: > > The recent change to use discrete integers instead of struct timespec64 > in struct inode shaved 8 bytes off of it, but it also moves the i_lock > into the previous cacheline, away from the fields that it protects. > > Move i_blocks up above t

Re: [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers

2023-09-28 Thread Amir Goldstein
On Thu, Sep 28, 2023 at 8:19 PM Darrick J. Wong wrote: > > On Thu, Sep 28, 2023 at 01:06:03PM -0400, Jeff Layton wrote: > > On Thu, 2023-09-28 at 11:48 -0400, Arnd Bergmann wrote: > > > On Thu, Sep 28, 2023, at 07:05, Jeff Layton wrote: > > > > This shaves 8 bytes off struct inode, according to pa

Re: [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers

2023-09-28 Thread Amir Goldstein
On Fri, Sep 29, 2023 at 3:19 AM Linus Torvalds wrote: ... > So yes, real programs to cache stat information, and it matters for > performance. > > But I don't think any actual reasonable program will have > *correctness* issues, though - I beg to disagree. > because there are certainly filesyst

Re: [RFC PATCH v2] fs/xattr: add *at family syscalls

2023-05-15 Thread Amir Goldstein
On Mon, May 15, 2023 at 1:33 PM Christian Brauner wrote: > > On Thu, May 11, 2023 at 05:08:02PM +0200, Christian Göttsche wrote: > > Add the four syscalls setxattrat(), getxattrat(), listxattrat() and > > removexattrat(). Those can be used to operate on extended attributes, > > especially securit

Re: [RFC PATCH v2] fs/xattr: add *at family syscalls

2023-05-15 Thread Amir Goldstein
On Mon, May 15, 2023 at 4:52 PM Christian Brauner wrote: > > On Mon, May 15, 2023 at 04:04:21PM +0300, Amir Goldstein wrote: > > On Mon, May 15, 2023 at 1:33 PM Christian Brauner > > wrote: > > > > > > On Thu, May 11, 2023 at 05:08:02PM +0200, Christian

Re: [PATCH v4 3/3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-03-23 Thread Amir Goldstein
On Fri, Mar 21, 2025 at 8:49 PM Andrey Albershteyn wrote: > > From: Andrey Albershteyn > > Introduce getfsxattrat and setfsxattrat syscalls to manipulate inode > extended attributes/flags. The syscalls take parent directory fd and > path to the child together with struct fsxattr. > > This is an a

Re: [PATCH v4 0/3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-03-27 Thread Amir Goldstein
On Thu, Mar 27, 2025 at 8:26 PM Pali Rohár wrote: > > On Thursday 27 March 2025 12:47:02 Amir Goldstein wrote: > > On Sun, Mar 23, 2025 at 11:32 AM Pali Rohár wrote: > > > > > > On Sunday 23 March 2025 09:45:06 Amir Goldstein wrote: > > > > On Fri,

Re: [PATCH v4 0/3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-03-28 Thread Amir Goldstein
On Thu, Mar 27, 2025 at 10:13 PM Pali Rohár wrote: > > On Thursday 27 March 2025 21:57:34 Amir Goldstein wrote: > > On Thu, Mar 27, 2025 at 8:26 PM Pali Rohár wrote: > > > > > > On Thursday 27 March 2025 12:47:02 Amir Goldstein wrote: > > > > On Sun,

Re: [PATCH v3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-02-21 Thread Amir Goldstein
On Fri, Feb 21, 2025 at 7:13 PM Darrick J. Wong wrote: > > On Tue, Feb 11, 2025 at 06:22:47PM +0100, Andrey Albershteyn wrote: > > From: Andrey Albershteyn > > > > Introduce getfsxattrat and setfsxattrat syscalls to manipulate inode > > extended attributes/flags. The syscalls take parent director

Re: [PATCH v4 0/3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-03-23 Thread Amir Goldstein
On Fri, Mar 21, 2025 at 8:50 PM Andrey Albershteyn wrote: > > This patchset introduced two new syscalls getfsxattrat() and > setfsxattrat(). These syscalls are similar to FS_IOC_FSSETXATTR ioctl() > except they use *at() semantics. Therefore, there's no need to open the > file to get an fd. > > Th

Re: [PATCH v4 3/3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-03-27 Thread Amir Goldstein
On Thu, Mar 27, 2025 at 10:33 AM Andrey Albershteyn wrote: > > On 2025-03-23 09:56:25, Amir Goldstein wrote: > > On Fri, Mar 21, 2025 at 8:49 PM Andrey Albershteyn > > wrote: > > > > > > From: Andrey Albershteyn > > > > > > Introduce getf

Re: [PATCH v4 0/3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-03-27 Thread Amir Goldstein
On Sun, Mar 23, 2025 at 11:32 AM Pali Rohár wrote: > > On Sunday 23 March 2025 09:45:06 Amir Goldstein wrote: > > On Fri, Mar 21, 2025 at 8:50 PM Andrey Albershteyn > > wrote: > > > > > > This patchset introduced two new syscalls getfsxattrat() and >

Re: [PATCH v5 0/7] fs: introduce file_getattr and file_setattr syscalls

2025-05-13 Thread Amir Goldstein
On Tue, May 13, 2025 at 11:53 AM Arnd Bergmann wrote: > > On Tue, May 13, 2025, at 11:17, Andrey Albershteyn wrote: > > > > > long syscall(SYS_file_getattr, int dirfd, const char *pathname, > > struct fsxattr *fsx, size_t size, unsigned int at_flags); > > long syscall(SYS

Re: [PATCH v5 0/7] fs: introduce file_getattr and file_setattr syscalls

2025-05-21 Thread Amir Goldstein
On Wed, May 21, 2025 at 10:48 AM Andrey Albershteyn wrote: > > On 2025-05-19 21:37:04, Dave Chinner wrote: > > On Thu, May 15, 2025 at 12:33:31PM +0200, Amir Goldstein wrote: > > > On Thu, May 15, 2025 at 11:02 AM Christian Brauner > > > wrote: > > > >

Re: [PATCH v5 0/7] fs: introduce file_getattr and file_setattr syscalls

2025-05-21 Thread Amir Goldstein
On Wed, May 21, 2025 at 12:06 PM Andrey Albershteyn wrote: > > On 2025-05-21 11:36:31, Amir Goldstein wrote: > > On Wed, May 21, 2025 at 10:48 AM Andrey Albershteyn > > wrote: > > > > > > On 2025-05-19 21:37:04, Dave Chinner wrote: > > > >

Re: [PATCH v5 0/7] fs: introduce file_getattr and file_setattr syscalls

2025-05-15 Thread Amir Goldstein
On Thu, May 15, 2025 at 11:02 AM Christian Brauner wrote: > > On Tue, May 13, 2025 at 11:53:23AM +0200, Arnd Bergmann wrote: > > On Tue, May 13, 2025, at 11:17, Andrey Albershteyn wrote: > > > > > > > > long syscall(SYS_file_getattr, int dirfd, const char *pathname, > > > struct fs