Re: [PATCH net-next v2 1/2] net: ibmveth: make ibmveth use WARN_ON instead of BUG_ON

2025-04-16 Thread Simon Horman
On Mon, Apr 14, 2025 at 02:40:15PM -0500, Dave Marquardt wrote: > Replaced BUG_ON calls with WARN_ON calls with error handling, with > calls to a new ibmveth_reset routine, which resets the device. Removed > conflicting and unneeded forward declaration. To me the most important change here is addi

Re: [PATCH 2/4] PCI/ERR: Add support for resetting the slot in a platforms specific way

2025-04-16 Thread Lukas Wunner
On Wed, Apr 16, 2025 at 08:34:21PM +0530, Manivannan Sadhasivam wrote: > I don't think it is possible to get rid of the powerpc version. It has > its own pci_dev::sysdata pointing to 'struct pci_controller' pointer > which is internal to powerpc arch code. And the generic code would need > 'struct

[PATCH v10 0/7] Add character devices for indices, platform-dump and physical-attestation RTAS

2025-04-16 Thread Haren Myneni
Several APIs such as rtas_get_indices(), rtas_get_dynamic_sensor(), rtas_set_dynamic_indicator(), rtas_platform_dump() and rtas_physical_attestation() provided by librtas library are implemented in user space using rtas syscall in combination with writable mappings of /dev/mem. But this implementa

Re: [PATCH] powerpc/boot: Fix build with gcc 15

2025-04-16 Thread Mukesh Kumar Chaurasiya
On Fri, Mar 07, 2025 at 10:20:52AM +0100, Michal Suchanek wrote: > Similar to x86 the ppc boot code does not build with GCC 15. > > Copy the fix from > commit ee2ab467bddf ("x86/boot: Use '-std=gnu11' to fix build with GCC 15") > > Signed-off-by: Michal Suchanek > --- > arch/powerpc/boot/Makefi

Re: [PATCH 1/1] arch/powerpc: Remove redundant typedef for bool

2025-04-16 Thread Mukesh Kumar Chaurasiya
On Sun, Mar 23, 2025 at 11:36:06AM -0500, Misbah Anjum N wrote: > Hi, > > I noticed that a patch addressing the same issue has been proposed by > Michal Suchanek: > https://lore.kernel.org/linuxppc-dev/z86liwlwp5wvr...@kitsune.suse.cz/T/#t > > The existing patch addresses the compilation error by

[powerpc:fixes-test] BUILD SUCCESS 3700976f2ae8dfec4c17433f8a16c9e6c334cf89

2025-04-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git fixes-test branch HEAD: 3700976f2ae8dfec4c17433f8a16c9e6c334cf89 powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE elapsed time: 1441m configs tested: 9 configs skipped: 144 The following configs have been bui

Re: [PATCH 2/4] PCI/ERR: Add support for resetting the slot in a platforms specific way

2025-04-16 Thread Manivannan Sadhasivam
On Wed, Apr 16, 2025 at 04:38:01PM +0200, Lukas Wunner wrote: > On Tue, Apr 15, 2025 at 07:03:17PM +0530, Manivannan Sadhasivam wrote: > > On Fri, Apr 04, 2025 at 10:46:27AM +0200, Lukas Wunner wrote: > > > On Fri, Apr 04, 2025 at 01:52:22PM +0530, Manivannan Sadhasivam via B4 > > > Relay wrote: >

[PATCH] powerpc/crc: include

2025-04-16 Thread Eric Biggers
From: Eric Biggers Since no longer transitively includes which provides pagefault_disable() and pagefault_enable(), now needs to be included directly. Fixes: 7ba8df47810f ("asm-generic: Make simd.h more resilient") Signed-off-by: Eric Biggers --- I can take this via the crc tree, but it rea

Re: [PATCH v2 3/4] PCI: Add link down handling for host bridges

2025-04-16 Thread Lukas Wunner
On Wed, Apr 16, 2025 at 09:59:05PM +0530, Manivannan Sadhasivam via B4 Relay wrote: > --- a/drivers/pci/pcie/err.c > +++ b/drivers/pci/pcie/err.c > @@ -270,3 +270,30 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev, > > return status; > } > + > +static pci_ers_result_t pcie_do_slo

Re: early soft lockup in 6.15-rc2 on PowerNV

2025-04-16 Thread Dan Horák
Hi Ritesh, On Wed, 16 Apr 2025 15:55:15 +0530 Ritesh Harjani (IBM) wrote: > Dan Horák writes: > > > Hi, > > > > after updating to Fedora built 6.15-rc2 kernel from 6.14 I am getting a > > soft lockup early in the boot and NVME related timeout/crash later > > (could it be related?). I am first

Re: [PATCH 2/4] PCI/ERR: Add support for resetting the slot in a platforms specific way

2025-04-16 Thread Lukas Wunner
On Tue, Apr 15, 2025 at 07:03:17PM +0530, Manivannan Sadhasivam wrote: > On Fri, Apr 04, 2025 at 10:46:27AM +0200, Lukas Wunner wrote: > > On Fri, Apr 04, 2025 at 01:52:22PM +0530, Manivannan Sadhasivam via B4 > > Relay wrote: > > > When the PCI error handling requires resetting the slot, reset it

[RESEND PATCH v5 3/6] kvm powerpc/book3s-apiv2: Add kunit tests for Hostwide GSB elements

2025-04-16 Thread Vaibhav Jain
Update 'test-guest-state-buffer.c' to add two new KUNIT test cases for validating correctness of changes to Guest-state-buffer management infrastructure for adding support for Hostwide GSB elements. The newly introduced test test_gs_hostwide_msg() checks if the Hostwide elements can be set and par

[RESEND PATCH v5 0/6] kvm powerpc/book3s-hv: Expose Hostwide counters as perf-events

2025-04-16 Thread Vaibhav Jain
Changes from v5 Link: https://lore.kernel.org/all/20250317100834.451452-1-vaib...@linux.ibm.com/ * Rebased to latest upstream kernel tree * Added review-by from Athira to a patch. Cover Letter This patch-series adds support for reporting Hostwide(L1-Lpar) counters via pe

[RESEND PATCH v5 1/6] powerpc: Document APIv2 KVM hcall spec for Hostwide counters

2025-04-16 Thread Vaibhav Jain
Update kvm-nested APIv2 documentation to include five new Guest-State-Elements to fetch the hostwide counters. These counters are per L1-Lpar and indicate the amount of Heap/Page-table memory allocated, available and Page-table memory reclaimed for all L2-Guests active instances Cc: linux-...@vger

[RESEND PATCH v5 4/6] kvm powerpc/book3s-apiv2: Introduce kvm-hv specific PMU

2025-04-16 Thread Vaibhav Jain
Introduce a new PMU named 'kvm-hv' inside a new module named 'kvm-hv-pmu' to report Book3s kvm-hv specific performance counters. This will expose KVM-HV specific performance attributes to user-space via kernel's PMU infrastructure and would enableusers to monitor active kvm-hv based guests. The pa

[RESEND PATCH v5 5/6] powerpc/kvm-hv-pmu: Implement GSB message-ops for hostwide counters

2025-04-16 Thread Vaibhav Jain
Implement and setup necessary structures to send a prepolulated Guest-State-Buffer(GSB) requesting hostwide counters to L0-PowerVM and have the returned GSB holding the values of these counters parsed. This is done via existing GSB implementation and with the newly added support of Hostwide element

[PATCH v2 0/4] PCI: Add support for resetting the slots in a platform specific way

2025-04-16 Thread Manivannan Sadhasivam via B4 Relay
Hi, Currently, in the event of AER/DPC, PCI core will try to reset the slot and its subordinate devices by invoking bridge control reset and FLR. But in some cases like AER Fatal error, it might be necessary to reset the slots using the PCI host bridge drivers in a platform specific way (as indica

[PATCH v2 2/4] PCI/ERR: Add support for resetting the slots in a platform specific way

2025-04-16 Thread Manivannan Sadhasivam via B4 Relay
From: Manivannan Sadhasivam Some host bridge devices require resetting the slots in a platform specific way to recover them from error conditions such as Fatal AER errors, Link Down etc... So introduce pci_host_bridge::reset_slot callback and call it from pcibios_reset_secondary_bus() if availabl

[PATCH v2 1/4] PCI/ERR: Remove misleading TODO regarding kernel panic

2025-04-16 Thread Manivannan Sadhasivam via B4 Relay
From: Manivannan Sadhasivam A PCI device is just another peripheral in a system. So failure to recover it, must not result in a kernel panic. So remove the TODO which is quite misleading. Signed-off-by: Manivannan Sadhasivam --- drivers/pci/pcie/err.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v2 4/4] PCI: qcom: Add support for resetting the slot due to link down event

2025-04-16 Thread Manivannan Sadhasivam via B4 Relay
From: Manivannan Sadhasivam The PCIe link can go down under circumstances such as the device firmware crash, link instability, etc... When that happens, the PCIe slot needs to be reset to make it operational again. Currently, the driver is not handling the link down event, due to which the users

[PATCH v2 3/4] PCI: Add link down handling for host bridges

2025-04-16 Thread Manivannan Sadhasivam via B4 Relay
From: Manivannan Sadhasivam The PCI link, when down, needs to be recovered to bring it back. But that cannot be done in a generic way as link recovery procedure is specific to host bridges. So add a new API pci_host_handle_link_down() that could be called by the host bridge drivers when the link

[RESEND PATCH v5 2/6] kvm powerpc/book3s-apiv2: Add support for Hostwide GSB elements

2025-04-16 Thread Vaibhav Jain
Add support for adding and parsing Hostwide elements to the Guest-state-buffer data structure used in apiv2. These elements are used to share meta-information pertaining to entire L1-Lpar and this meta-information is maintained by L0-PowerVM hypervisor. Example of this include the amount of the pag

Re: [PATCH net-next v2 1/2] net: ibmveth: make ibmveth use WARN_ON instead of BUG_ON

2025-04-16 Thread Dave Marquardt
Simon Horman writes: > On Mon, Apr 14, 2025 at 02:40:15PM -0500, Dave Marquardt wrote: >> Replaced BUG_ON calls with WARN_ON calls with error handling, with >> calls to a new ibmveth_reset routine, which resets the device. Removed >> conflicting and unneeded forward declaration. > > To me the mos

[PATCH net-next v3 2/3] net: ibmveth: Reset the adapter when unexpected states are detected

2025-04-16 Thread Dave Marquardt
Reset the adapter through new function ibmveth_reset, called in WARN_ON situations. Removed conflicting and unneeded forward declaration. Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/ibmveth.c | 116 - drivers/net/ethernet/ibm/ibmveth.h | 1 + 2 files

[PATCH net-next v3 1/3] net: ibmveth: Indented struct ibmveth_adapter correctly

2025-04-16 Thread Dave Marquardt
Made struct ibmveth_adapter follow indentation rules Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/ibmveth.h | 64 +++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.h b/drivers/net/ethernet/ibm/ibmveth.h

[PATCH v10 3/7] powerpc/pseries: Add papr-indices char driver for ibm,get-indices

2025-04-16 Thread Haren Myneni
The RTAS call ibm,get-indices is used to obtain indices and location codes for a specified indicator or sensor token. The current implementation uses rtas_get_indices() API provided by librtas library which allocates RMO buffer and issue this RTAS call in the user space. But writable mapping /dev/m

Re: [PATCH v3] powerpc/boot: Fix build with gcc 15

2025-04-16 Thread Venkat Rao Bagalkote
On 31/03/25 4:27 pm, Michal Suchanek wrote: Similar to x86 the ppc boot code does not build with GCC 15. Copy the fix from commit ee2ab467bddf ("x86/boot: Use '-std=gnu11' to fix build with GCC 15") Signed-off-by: Michal Suchanek --- v2: Move the fix outside of ifdef to apply to all subarchit

Re: [PATCH 2/4] PCI/ERR: Add support for resetting the slot in a platforms specific way

2025-04-16 Thread Manivannan Sadhasivam
On Thu, Apr 17, 2025 at 02:23:26AM +0200, Lukas Wunner wrote: > On Wed, Apr 16, 2025 at 08:34:21PM +0530, Manivannan Sadhasivam wrote: > > I don't think it is possible to get rid of the powerpc version. It has > > its own pci_dev::sysdata pointing to 'struct pci_controller' pointer > > which is int

[PATCH net-next v3 0/3] net: ibmveth: Make ibmveth use new reset function and new KUnit tests

2025-04-16 Thread Dave Marquardt
- Fixed struct ibmveth_adapter indentation - Made ibmveth driver use WARN_ON with recovery rather than BUG_ON. Some recovery code schedules a reset through new function ibmveth_reset. Also removed a conflicting and unneeded forward declaration. - Added KUnit tests for some areas changed by the

Re: [PATCH 0/9] Remove per-architecture poly1305 shash glue code

2025-04-16 Thread Herbert Xu
Eric Biggers wrote: > This series removes the per-architecture poly1305 shash glue code and > re-implements the poly1305 shashes on top of the Poly1305 library > functions. This ends up being much simpler, and it is how it should > have been done originally. This follows similar changes to crc32

early soft lockup in 6.15-rc2 on PowerNV

2025-04-16 Thread Dan Horák
Hi, after updating to Fedora built 6.15-rc2 kernel from 6.14 I am getting a soft lockup early in the boot and NVME related timeout/crash later (could it be related?). I am first checking if this is a known issue as I have not started bisecting yet. [0.00] dt-cpu-ftrs: setup for ISA 3000 [

Re: [PATCH] ASoC: fsl_rpmsg: Remove useless return variable

2025-04-16 Thread Daniel Baluta
On Wed, Apr 16, 2025 at 7:15 AM Chen Ni wrote: > > Remove unnecessary return variable and compress the return logic. > > Signed-off-by: Chen Ni Reviewed-by: Daniel Baluta

Re: early soft lockup in 6.15-rc2 on PowerNV

2025-04-16 Thread IBM
Dan Horák writes: > Hi, > > after updating to Fedora built 6.15-rc2 kernel from 6.14 I am getting a > soft lockup early in the boot and NVME related timeout/crash later > (could it be related?). I am first checking if this is a known issue > as I have not started bisecting yet. > > [2.866399]

[PATCH] powerpc64/ftrace: fix clobbered r15 during livepatching

2025-04-16 Thread Hari Bathini
While r15 is clobbered always with PPC_FTRACE_OUT_OF_LINE, it is not restored in livepatch sequence leading to not so obvious fails like below: BUG: Unable to handle kernel data access on write at 0xc00f9078 Faulting instruction address: 0xc18ff958 Oops: Kernel access of bad

Re: [PATCH] ASoC: fsl_rpmsg: Remove useless return variable

2025-04-16 Thread Mark Brown
On Wed, 16 Apr 2025 12:14:31 +0800, Chen Ni wrote: > Remove unnecessary return variable and compress the return logic. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_rpmsg: Remove useless return variable commit: ba05b

Re: [PATCH v2 3/4] PCI: Add link down handling for host bridges

2025-04-16 Thread Krishna Chaitanya Chundru
On 4/16/2025 9:59 PM, Manivannan Sadhasivam via B4 Relay wrote: From: Manivannan Sadhasivam The PCI link, when down, needs to be recovered to bring it back. But that cannot be done in a generic way as link recovery procedure is specific to host bridges. So add a new API pci_host_handle_link_

[PATCH v10 1/7] powerpc/pseries: Define common functions for RTAS sequence calls

2025-04-16 Thread Haren Myneni
The RTAS call can be normal where retrieves the data form the hypervisor once or sequence based RTAS call which has to issue multiple times until the complete data is obtained. For some of these sequence RTAS calls, the OS should not interleave calls with different input until the sequence is compl

[PATCH v10 4/7] powerpc/pseries: Add ibm,set-dynamic-indicator RTAS call support

2025-04-16 Thread Haren Myneni
The RTAS call ibm,set-dynamic-indicator is used to set the new indicator state identified by a location code. The current implementation uses rtas_set_dynamic_indicator() API provided by librtas library which allocates RMO buffer and issue this RTAS call in the user space. But /dev/mem access by th

[PATCH v10 2/7] powerpc/pseries: Define papr_indices_io_block for papr-indices ioctls

2025-04-16 Thread Haren Myneni
To issue ibm,get-indices, ibm,set-dynamic-indicator and ibm,get-dynamic-sensor-state in the user space, the RMO buffer is allocated for the work area which is restricted under system lockdown. So instead of user space execution, the kernel will provide /dev/papr-indices interface to execute these R

[PATCH v10 6/7] powerpc/pseries: Add papr-platform-dump character driver for dump retrieval

2025-04-16 Thread Haren Myneni
ibm,platform-dump RTAS call in combination with writable mapping /dev/mem is issued to collect platform dump from the hypervisor and may need multiple calls to get the complete dump. The current implementation uses rtas_platform_dump() API provided by librtas library to issue these RTAS calls. But

[PATCH v10 5/7] powerpc/pseries: Add ibm,get-dynamic-sensor-state RTAS call support

2025-04-16 Thread Haren Myneni
The RTAS call ibm,get-dynamic-sensor-state is used to get the sensor state identified by the location code and the sensor token. The librtas library provides an API rtas_get_dynamic_sensor() which uses /dev/mem access for work area allocation but is restricted under system lockdown. This patch pro

[PATCH v2] powerpc64/bpf: fix JIT code size calculation of bpf trampoline

2025-04-16 Thread Hari Bathini
arch_bpf_trampoline_size() provides JIT size of the BPF trampoline before the buffer for JIT'ing it is allocated. The total number of instructions emitted for BPF trampoline JIT code depends on where the final image is located. So, the size arrived at with the dummy pass in arch_bpf_trampoline_size