Re: [PATCH v3 15/17] mm: pgtable: remove tlb_remove_page_ptdesc()

2025-01-03 Thread Peter Zijlstra
On Sat, Dec 28, 2024 at 11:26:22AM +0200, Mike Rapoport wrote: > On Mon, Dec 23, 2024 at 05:41:01PM +0800, Qi Zheng wrote: > > Here we are explicitly dealing with struct page, and the following logic > > semms strange: > > > > tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); > > > > tlb_remove_

Re: [PATCH] PCI/AER:Add error message when unable to handle additional devices

2025-01-03 Thread Jonathan Cameron
On Fri, 3 Jan 2025 18:50:35 +0530 Atharva Tiwari wrote: > i completed the todo on line 886 thats why > It is a question, not a todo. So if you wish to make the change you need to discuss why the answer to that question was 'yes it makes sense to print an error message here'. Jonathan

Re: [PATCH v8 4/7] PCI: Use unsigned int i in pcie_read_tlp_log()

2025-01-03 Thread Jonathan Cameron
On Wed, 18 Dec 2024 16:37:44 +0200 Ilpo Järvinen wrote: > Loop variable i counting from 0 upwards does not need to be signed so > make it unsigned int. > > Signed-off-by: Ilpo Järvinen Whilst I find it hard to care, it is harmless so up to Bjorn if he wants the churn or not. Reviewed-by: Jona

Re: [PATCH v8 5/7] PCI: Store # of supported End-End TLP Prefixes

2025-01-03 Thread Jonathan Cameron
On Wed, 18 Dec 2024 16:37:45 +0200 Ilpo Järvinen wrote: > eetlp_prefix_path in the struct pci_dev tells if End-End TLP Prefixes > are supported by the path or not, the value is only calculated if > CONFIG_PCI_PASID is set. > > The Max End-End TLP Prefixes field in the Device Capabilities Registe

Re: [PATCH v2 1/1] powerpc: Enable dynamic preemption

2025-01-03 Thread kernel test robot
'--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shrikanth-Hegde/powerpc-Enable-dynamic-preemption/20250103-032131 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git

Re: [PATCH 11/19] dt-bindings: gpio: fsl,qoriq-gpio: Add compatible string fsl,mpc8314-gpio

2025-01-03 Thread Krzysztof Kozlowski
On Thu, Jan 02, 2025 at 07:31:52PM +0100, J. Neuschäfer wrote: > This is for the MPC831{4,5}{,E} SoCs. > > Signed-off-by: J. Neuschäfer > --- > Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysz

Re: [PATCH 15/19] dt-bindings: vendor-prefixes: Add LANCOM Systems GmbH

2025-01-03 Thread Krzysztof Kozlowski
On Thu, Jan 02, 2025 at 07:31:56PM +0100, J. Neuschäfer wrote: > LANCOM Systems is a manufacturer of networking equipment. > > https://www.lancom-systems.com/ > > Signed-off-by: J. Neuschäfer > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions

Re: [PATCH v2 1/3] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read()

2025-01-03 Thread Mahesh J Salgaonkar
On 2024-12-28 09:43:41 Sat, Thomas Weißschuh wrote: > Most users use this function through the BIN_ATTR_SIMPLE* macros, > they can handle the switch transparently. > Also adapt the two non-macro users in the same change. > > Signed-off-by: Thomas Weißschuh > --- > arch/powerpc/platforms/powernv/

Re: [PATCH] ps3disk: Do not use dev->bounce_size before it is set

2025-01-03 Thread Christoph Hellwig
On Fri, Jan 03, 2025 at 09:51:25AM +0100, Geert Uytterhoeven wrote: > dev->bounce_size is only initialized after it is used to set the queue > limits. Fix this by using BOUNCE_SIZE instead. > > Fixes: a7f18b74dbe17162 ("ps3disk: pass queue_limits to blk_mq_alloc_disk") > Reported-by: Philipp Hort

Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

2025-01-03 Thread Geert Uytterhoeven
Hi Philipp, CC hch On Fri, Jan 3, 2025 at 7:44 AM Philipp Hortmann wrote: > T2 is working but to make this happen the T2 Author has an own repo for > patches to apply. In the following video he publishes his view on how > well the ps3disk is maintained and tested by the linux kernel community. >

[PATCH] ps3disk: Do not use dev->bounce_size before it is set

2025-01-03 Thread Geert Uytterhoeven
dev->bounce_size is only initialized after it is used to set the queue limits. Fix this by using BOUNCE_SIZE instead. Fixes: a7f18b74dbe17162 ("ps3disk: pass queue_limits to blk_mq_alloc_disk") Reported-by: Philipp Hortmann Closes: https://lore.kernel.org/39256db9-3d73-4e86-a49b-300dfd670...@gma

Re: [PATCH v4 10/15] riscv: pgtable: move pagetable_dtor() to __tlb_remove_table()

2025-01-03 Thread Qi Zheng
On 2025/1/3 16:02, Kevin Brodsky wrote: On 03/01/2025 04:48, Qi Zheng wrote: Hi Kevin, On 2025/1/3 00:53, Kevin Brodsky wrote: On 30/12/2024 10:07, Qi Zheng wrote:   static inline void riscv_tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt)   { -    if (riscv_use_sbi_for_rfence()) +   

Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

2025-01-03 Thread David Woodhouse
On Fri, 2025-01-03 at 09:53 +0100, Geert Uytterhoeven wrote: > > > The following points are also in the list of reasons: > > - This driver has a maximum 54MBit/s as it supports only 802.11 b/g. > > - Using this hardware is security wise not state of the art as WPA3 is > >     not supported. > > I

Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

2025-01-03 Thread Geert Uytterhoeven
Hi David, On Fri, Jan 3, 2025 at 10:14 AM David Woodhouse wrote: > On Fri, 2025-01-03 at 09:53 +0100, Geert Uytterhoeven wrote: > > > The following points are also in the list of reasons: > > > - This driver has a maximum 54MBit/s as it supports only 802.11 b/g. > > > - Using this hardware is sec

Re: [PATCH] ps3disk: Do not use dev->bounce_size before it is set

2025-01-03 Thread Geert Uytterhoeven
Hi Christoph, On Fri, Jan 3, 2025 at 9:56 AM Christoph Hellwig wrote: > On Fri, Jan 03, 2025 at 09:51:25AM +0100, Geert Uytterhoeven wrote: > > dev->bounce_size is only initialized after it is used to set the queue > > limits. Fix this by using BOUNCE_SIZE instead. > > > > Fixes: a7f18b74dbe1716

Re: [PATCH v4 10/15] riscv: pgtable: move pagetable_dtor() to __tlb_remove_table()

2025-01-03 Thread Qi Zheng
On 2025/1/3 17:13, Qi Zheng wrote: On 2025/1/3 16:02, Kevin Brodsky wrote: On 03/01/2025 04:48, Qi Zheng wrote: Hi Kevin, On 2025/1/3 00:53, Kevin Brodsky wrote: On 30/12/2024 10:07, Qi Zheng wrote:    static inline void riscv_tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt)    { -  

Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

2025-01-03 Thread Johannes Berg
On Fri, 2025-01-03 at 10:25 +0100, Geert Uytterhoeven wrote: > > I was also considering it from the side of the wireless access point: > if you have to provide an non-secure access point just for your PS3, It supports WPA2/PSK (~2004) which is plenty secure. It's not "non- secure", it's just "not

Re: [PATCH v4 10/15] riscv: pgtable: move pagetable_dtor() to __tlb_remove_table()

2025-01-03 Thread Kevin Brodsky
On 03/01/2025 04:48, Qi Zheng wrote: > Hi Kevin, > > On 2025/1/3 00:53, Kevin Brodsky wrote: >> On 30/12/2024 10:07, Qi Zheng wrote: >>>   static inline void riscv_tlb_remove_ptdesc(struct mmu_gather *tlb, >>> void *pt) >>>   { >>> -    if (riscv_use_sbi_for_rfence()) >>> +    if (riscv_use_sbi_for

[PATCH v13 1/5] modules: Support extended MODVERSIONS info

2025-01-03 Thread Matthew Maurer
Adds a new format for MODVERSIONS which stores each field in a separate ELF section. This initially adds support for variable length names, but could later be used to add additional fields to MODVERSIONS in a backwards compatible way if needed. Any new fields will be ignored by old user tooling, un

[PATCH v13 0/5] Extended MODVERSIONS Support

2025-01-03 Thread Matthew Maurer
This patch series is intended for use alongside the Implement DWARF modversions series [1] to enable RUST and MODVERSIONS at the same time. Elsewhere, we've seen a desire for long symbol name support for LTO symbol names [2], and the previous series came up [3] as a possible solution rather than h

[PATCH v13 2/5] modpost: Produce extended MODVERSIONS information

2025-01-03 Thread Matthew Maurer
Generate both the existing modversions format and the new extended one when running modpost. Presence of this metadata in the final .ko is guarded by CONFIG_EXTENDED_MODVERSIONS. We no longer generate an error on long symbols in modpost if CONFIG_EXTENDED_MODVERSIONS is set, as they can now be app

[PATCH v13 5/5] rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS

2025-01-03 Thread Matthew Maurer
From: Sami Tolvanen Previously, two things stopped Rust from using MODVERSIONS: 1. Rust symbols are occasionally too long to be represented in the original versions table 2. Rust types cannot be properly hashed by the existing genksyms approach because: * Looking up type definitions

[PATCH v13 3/5] modules: Allow extended modversions without basic MODVERSIONS

2025-01-03 Thread Matthew Maurer
If you know that your kernel modules will only ever be loaded by a newer kernel, you can disable BASIC_MODVERSIONS to save space. This also allows easy creation of test modules to see how tooling will respond to modules that only have the new format. Signed-off-by: Matthew Maurer --- kernel/modu

[PATCH v13 4/5] Documentation/kbuild: Document storage of symbol information

2025-01-03 Thread Matthew Maurer
Document where exported and imported symbols are kept, format options, and limitations. Signed-off-by: Matthew Maurer --- Documentation/kbuild/modules.rst | 20 1 file changed, 20 insertions(+) diff --git a/Documentation/kbuild/modules.rst b/Documentation/kbuild/modules.rst

Re: [PATCH 05/14] cpumask: deprecate cpumask_next_wrap()

2025-01-03 Thread Bjorn Helgaas
On Sat, Dec 28, 2024 at 10:49:37AM -0800, Yury Norov wrote: > The next patche aligns implementation of cpumask_next_wrap() with the > generic version in find.h which changes function signature. s/patche/patch/ I guess this is an indirect reference to find_next_bit_wrap()? If so, I think mentioni

Re: [PATCH 06/14] cpumask: re-introduce cpumask_next{,_and}_wrap()

2025-01-03 Thread Bjorn Helgaas
On Sat, Dec 28, 2024 at 10:49:38AM -0800, Yury Norov wrote: > cpumask_next_wrap_old() has two additional parameters, comparing to it's > analogue in linux/find.h find_next_bit_wrap(). The reason for that is > historical. s/it's/its/ Personally I think cscope/tags/git grep make "find_next_bit_wrap

Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

2025-01-03 Thread Johannes Berg
On Fri, 2025-01-03 at 07:44 +0100, Philipp Hortmann wrote: > > One of my big fears is the hand over to the next generation maintainers > and developers. The less code and the less exceptions due to old > interfaces the easier it will be. We loose maintainers and developers > for many reasons, l

Re: [PATCH] PCI/AER:Add error message when unable to handle additional devices

2025-01-03 Thread Jonathan Cameron
On Fri, 27 Dec 2024 12:49:10 +0530 Atharva Tiwari wrote: > Log an error message in `find_device_iter' > when the system cannot handle more error devices. Needs a statement of 'why' Jonathan > > Signed-off-by: Atharva Tiwari > --- > drivers/pci/pcie/aer.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

2025-01-03 Thread Philipp Hortmann
On 03.01.25 12:16, Geert Uytterhoeven wrote: Hi Philipp, On Fri, Jan 3, 2025 at 12:02 PM Philipp Hortmann wrote: On 03.01.25 09:53, Geert Uytterhoeven wrote: Care to tell us where the fix is? please find all patches for T2 on this page: https://wiki.t2linux.org/guides/kernel/ More exact her

Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

2025-01-03 Thread Philipp Hortmann
On 03.01.25 09:53, Geert Uytterhoeven wrote: Care to tell us where the fix is? Hi Geert, please find all patches for T2 on this page: https://wiki.t2linux.org/guides/kernel/ More exact here: git clone --depth=1 https://github.com/t2linux/linux-t2-patches patches Bye Philipp

Re: [PATCH 00/14] cpumask: cleanup cpumask_next_wrap() implementation and usage

2025-01-03 Thread Yury Norov
On Fri, Jan 03, 2025 at 08:02:29AM +0100, Christoph Hellwig wrote: > You've sent me less than a handfull of 14 patches, there's no way > to properly review this. Hi Christoph, You can find the whole series here: https://lore.kernel.org/linux-scsi/cabprks-uqfjmdp5ps+hsnvzggdmv0bnawpsvnpy4au4v+ud.

Re: [PATCH 00/19] powerpc: MPC83xx cleanup and LANCOM NWAPP2 board

2025-01-03 Thread Rob Herring (Arm)
On Thu, 02 Jan 2025 19:31:41 +0100, J. Neuschäfer wrote: > This patchset adds a devicetree for the LANCOM NWAPP2 board based on the > MPC8314E platform, and slightly modernizes the MPC83xx platform support > in the process. > > This board is nominally end-of-life, but available to hobbyists. > A

Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

2025-01-03 Thread Geert Uytterhoeven
Hi Philipp, On Fri, Jan 3, 2025 at 12:02 PM Philipp Hortmann wrote: > On 03.01.25 09:53, Geert Uytterhoeven wrote: > > Care to tell us where the fix is? > > please find all patches for T2 on this page: > https://wiki.t2linux.org/guides/kernel/ > More exact here: > git clone --depth=1 https://gith

Re: [PATCH] PCI/ERR: use panic instead pci_info for device recovery failure in PCIe

2025-01-03 Thread Jonathan Cameron
On Fri, 27 Dec 2024 12:22:53 +0530 Atharva Tiwari wrote: > update failed in drivers/pci/pcie/err.c to > trigger a kernel panic instead of pci_info > > Thanks Rewrite message as described in submitting patches documentation. Key thing here is question of 'why?' A question was in that comment, w

[PATCH] PCI/AER:Add error message when unable to handle additional devices

2025-01-03 Thread Atharva Tiwari
i completed the todo on line 886 thats why

Re: [PATCH v4 10/15] riscv: pgtable: move pagetable_dtor() to __tlb_remove_table()

2025-01-03 Thread Kevin Brodsky
On 03/01/2025 10:35, Qi Zheng wrote: > On 2025/1/3 17:13, Qi Zheng wrote: >> On 2025/1/3 16:02, Kevin Brodsky wrote: >>> On 03/01/2025 04:48, Qi Zheng wrote: [...] In __tlb_batch_free_encoded_pages(), we can indeed detect PageTable() and call pagetable_dtor() to dtor the page ta

Re: [PATCH net-next 01/13] net: enetc: add initial netc-lib driver to support NTMP

2025-01-03 Thread Andrew Lunn
> +#define NTMP_FILL_CRD(crd, tblv, qa, ua) \ > +({ \ > + typeof(crd) _crd = (crd); \ > + (_crd)->update_act = cpu_to_le16(ua); \ > + (_crd)->tblv_qact = NTMP_TBLV_QACT(tblv, qa); \ > +}) > + > +#define NTMP_FILL_CRD_EID(req, tblv, qa, ua, eid) \ > +({ \ > + typeof(req) _req = (req)

Re: [PATCH net-next 05/13] net: enetc: add debugfs interface to dump MAC filter

2025-01-03 Thread Andrew Lunn
On Fri, Jan 03, 2025 at 02:06:01PM +0800, Wei Fang wrote: > ENETC's MAC filter consists of hash MAC filter and exact MAC filter. Hash > MAC filter is a 64-entry hash table consisting of two 32-bit registers. > Exact MAC filter is implemented by configuring MAC address filter table > through command

Re: [PATCH] ps3disk: Do not use dev->bounce_size before it is set

2025-01-03 Thread Jens Axboe
On Fri, 03 Jan 2025 09:51:25 +0100, Geert Uytterhoeven wrote: > dev->bounce_size is only initialized after it is used to set the queue > limits. Fix this by using BOUNCE_SIZE instead. > > Applied, thanks! [1/1] ps3disk: Do not use dev->bounce_size before it is set commit: c2398e6d5f16e

Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

2025-01-03 Thread Arnd Bergmann
On Fri, Jan 3, 2025, at 13:44, Johannes Berg wrote: > On Fri, 2025-01-03 at 07:44 +0100, Philipp Hortmann wrote: >> >> One of my big fears is the hand over to the next generation maintainers >> and developers. The less code and the less exceptions due to old >> interfaces the easier it will be.