[PATCH v8 2/7] PCI: Move TLP Log handling to own file

TLP Log is PCIe feature and is processed only by AER and DPC. Configwise, DPC depends AER being enabled. In lack of better place, the TLP Log handling code was initially placed into pci.c but it can be easily placed in a separate file. Move TLP Log handling code to own file under pcie/ subdirector

[PATCH v8 3/7] PCI: Make pcie_read_tlp_log() signature same

pcie_read_tlp_log()'s prototype and function signature diverged due to changes made while applying. Make the parameters of pcie_read_tlp_log() named identically. Signed-off-by: Ilpo Järvinen Reviewed-by: Jonathan Cameron --- drivers/pci/pcie/tlp.c | 11 +-- 1 file changed, 5 insertions

[PATCH v8 5/7] PCI: Store # of supported End-End TLP Prefixes

eetlp_prefix_path in the struct pci_dev tells if End-End TLP Prefixes are supported by the path or not, the value is only calculated if CONFIG_PCI_PASID is set. The Max End-End TLP Prefixes field in the Device Capabilities Register 2 also tells how many (1-4) End-End TLP Prefixes are supported (PC

[PATCH v8 4/7] PCI: Use unsigned int i in pcie_read_tlp_log()

Loop variable i counting from 0 upwards does not need to be signed so make it unsigned int. Signed-off-by: Ilpo Järvinen --- drivers/pci/pcie/tlp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pcie/tlp.c b/drivers/pci/pcie/tlp.c index 2bf15749cd31..65ac7b5d8a

[PATCH v8 0/7] PCI: Consolidate TLP Log reading and printing

This series has the remaining patches of the AER & DPC TLP Log handling consolidation and now includes a few minor improvements to the earlier accepted TLP Logging code. v8: - Added missing parameter to kerneldoc. - Dropped last patch due to conflict with the pci_printk() cleanup series (will mo

[PATCH v8 1/7] PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem

pcie_read_tlp_log() was exposed by the commit 0a5a46a6a61b ("PCI/AER: Generalize TLP Header Log reading") but this is now considered a mistake. No drivers outside of PCI subsystem should build their own diagnostic logging but should rely on PCI core doing it for them. There's currently one driver

[PATCH v8 7/7] PCI: Create helper to print TLP Header and Prefix Log

Add pcie_print_tlp_log() helper to print TLP Header and Prefix Log. Print End-End Prefixes only if they are non-zero. Consolidate the few places which currently print TLP using custom formatting. The first attempt used pr_cont() instead of building a string first but it turns out pr_cont() is not

[PATCH v8 6/7] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

pcie_read_tlp_log() handles only 4 Header Log DWORDs but TLP Prefix Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present. Generalize pcie_read_tlp_log() and struct pcie_tlp_log to handle also TLP Prefix Log. The relevant registers are formatted identically in AER and DPC Capability, but h

KVM: PPC: Book3E: KVM HV host module doesn't work anymore

On 18/12/24 12:10, Christian Zigotzky wrote: Hello, The KVM HV host module doesn't work anymore since the PowerPC updates 6.13-1 [1] and PowerPC MM updates [2]. We have tested it with our FSL P5020/P5040 boards [3]. The guest kernel doesn't boot. There is no output via the serial connection

Re: [PATCH v7 8/8] PCI/AER: Add prefixes to printouts

On Tue, 17 Dec 2024, Yazen Ghannam wrote: > On Tue, Dec 17, 2024 at 03:53:58PM +0200, Ilpo Järvinen wrote: > > Only part of the AER diagnostic printouts use "AER:" prefix because > > they use low-level pci_printk() directly to allow selecting level. > > > > Add "AER:" prefix to lines that are pri

Re: [PATCH 0/3] PCI: Add support for logging Flit Mode TLPs (PCIe6)

On Tue, 17 Dec 2024, Yazen Ghannam wrote: > On Fri, Jun 14, 2024 at 06:09:18PM +0300, Ilpo Järvinen wrote: > > This series adds support for Flit Mode (PCIe6). The series is built on > > top of the TLP Logging refactoring series: > > > > > > https://lore.kernel.org/linux-pci/20240514113109.6690

Re: [PATCH] ASoC: fsl_asrc_m2m: force cast for snd_pcm_format_t type

On Wed, Dec 18, 2024 at 4:46 AM Shengjiu Wang wrote: > > Fix sparse warnings: > > fsl_asrc_m2m.c:360:45: sparse: warning: incorrect type in argument 1 > (different base types) > fsl_asrc_m2m.c:360:45: sparse:expected restricted snd_pcm_format_t > [usertype] pcm_forma > fsl_asrc_m2m.c:360:45:

Re: [PATCH] ASoC: fsl_asrc_m2m: force cast for snd_pcm_format_t type

On Wed, Dec 18, 2024 at 4:46 AM Shengjiu Wang wrote: > > Fix sparse warnings: > > fsl_asrc_m2m.c:360:45: sparse: warning: incorrect type in argument 1 > (different base types) > fsl_asrc_m2m.c:360:45: sparse:expected restricted snd_pcm_format_t > [usertype] pcm_forma > fsl_asrc_m2m.c:360:45:

Re: [PATCH 07/17] riscv: vdso: Switch to generic storage implementation

Hi Conor, On Wed, Dec 18, 2024 at 03:08:28PM +, Conor Dooley wrote: > On Mon, Dec 16, 2024 at 03:10:03PM +0100, Thomas Weißschuh wrote: > > The generic storage implementation provides the same features as the > > custom one. However it can be shared between architectures, making > > maintenanc

Re: [PATCH] ASoC: fsl_asrc_m2m: force cast for snd_pcm_format_t type

On Wed, 18 Dec 2024 10:43:58 +0800, Shengjiu Wang wrote: > Fix sparse warnings: > > fsl_asrc_m2m.c:360:45: sparse: warning: incorrect type in argument 1 > (different base types) > fsl_asrc_m2m.c:360:45: sparse:expected restricted snd_pcm_format_t > [usertype] pcm_forma > fsl_asrc_m2m.c:360:4

Re: [PATCH 07/17] riscv: vdso: Switch to generic storage implementation

On Wed, Dec 18, 2024, at 16:46, Thomas Weißschuh wrote: > On Wed, Dec 18, 2024 at 03:08:28PM +, Conor Dooley wrote: >> On Mon, Dec 16, 2024 at 03:10:03PM +0100, Thomas Weißschuh wrote: >> Might be a clang thing, allmodconfig with clang doesn't build either. > > The proposed generic storage inf

[PATCH v2 08/25] powerpc: Remove PPC_OF_PLATFORM_PCI

The Cell blade support was the last user of PPC_OF_PLATFORM_PCI, so remove it. Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/Kconfig | 5 -- arch/powerpc/kernel/Makefile | 2 +- arch/powerpc/kernel/of_platform.c | 102 -- 3 fil

[PATCH v2 12/25] powerpc/io: Unhook MMIO accessors

Now that PPC_INDIRECT_MMIO is removed, it's not possible/necessary to hook any of the "memory" accessors, so turn them back into regular static inlines, and restrict the hooking mechanism to the "pio" accessors only. Move the #defines that signal each routine is implemented next to the implementat

[PATCH v2 03/25] powerpc: Remove PPC_PMI and driver

CONFIG_PPC_PMI is no longer selectable now that PPC_IBM_CELL_BLADE has been removed, via the dependency on PPC_IBM_CELL_POWERBUTTON. So remove it and the driver, and the pmi.h header which it was the only user of. Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/include/asm/pmi.

[PATCH v2 02/25] powerpc: Remove some Cell leftovers

Now that CONFIG_PPC_CELL_NATIVE is removed, iommu_fixed_is_weak will always be false, so remove it entirely. Also remove a hack/quirk in the HTAB code that was only used on Cell. Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/include/asm/iommu.h | 6 -- arch/powerpc/

[PATCH v2 10/25] powerpc/io: Remove PPC_INDIRECT_MMIO

The Cell blade support was the last user of PPC_INDIRECT_MMIO, so it can now be removed. PPC_INDIRECT_PIO is still used by Power8 powernv, so it needs to remain. Reviewed-by: Arnd Bergmann Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/include/asm/io.h | 58 +++--

[PATCH v2 09/25] powerpc/io: Remove PPC_IO_WORKAROUNDS

The Cell blade support was the last user of PPC_IO_WORKAROUNDS, so they can now be removed. Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/include/asm/io-workarounds.h | 55 -- arch/powerpc/kernel/Makefile | 2 - arch/powerpc/kernel/io-workarounds.c | 1

[PATCH v2 11/25] powerpc/io: Remove PCI_FIX_ADDR

Now that PPC_INDIRECT_MMIO is removed, PCI_FIX_ADDR does nothing, so remove it. Acked-by: Arnd Bergmann Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/include/asm/io.h | 86 +-- arch/powerpc/mm/ioremap_64.c | 2 +- 2 files changed, 43 insertio

[PATCH v2 22/25] cpufreq: ppc_cbe: Remove powerpc Cell driver

This driver can no longer be built since support for IBM Cell Blades was removed, in particular CBE_RAS. Remove the driver. Signed-off-by: Michael Ellerman --- v2: Unchanged. Cc: linux...@vger.kernel.org drivers/cpufreq/Kconfig.powerpc | 18 -- drivers/cpufreq/Makefile

[PATCH v2 24/25] net: spider_net: Remove powerpc Cell driver

This driver can no longer be built since support for IBM Cell Blades was removed, in particular PPC_IBM_CELL_BLADE. Remove the driver and the documentation. Remove the MAINTAINERS entry, and add Ishizaki and Geoff to CREDITS. Reviewed-by: Arnd Bergmann Signed-off-by: Michael Ellerman --- v2: Un

[PATCH v2 20/25] docs: Remove reference to removed CBE_CPUFREQ_SPU_GOVERNOR

Remove a reference to CBE_CPUFREQ_SPU_GOVERNOR which has been removed. Signed-off-by: Michael Ellerman --- v2: Unchanged. Documentation/admin-guide/kernel-per-CPU-kthreads.rst | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/Documentation/admin-guide/kernel-per-CPU-kthr

[PATCH v2 23/25] EDAC/cell: Remove powerpc Cell driver

This driver can no longer be built since support for IBM Cell Blades was removed, in particular PPC_CELL_COMMON. Remove the driver. Signed-off-by: Michael Ellerman --- v2: Rebase. Cc: linux-e...@vger.kernel.org drivers/edac/Kconfig | 8 -- drivers/edac/Makefile| 2 - drivers/edac/

[PATCH v2 25/25] net: toshiba: Remove reference to PPC_IBM_CELL_BLADE

Remove a reference to PPC_IBM_CELL_BLADE which has been removed. Signed-off-by: Michael Ellerman --- v2: Unchanged. Cc: net...@vger.kernel.org drivers/net/ethernet/toshiba/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/toshiba/Kconfig b/driver

[PATCH v2 05/25] powerpc/cell: Remove CBE_CPUFREQ_SPU_GOVERNOR

Although this driver is still buildable, it can't actually do anything in practice now that the low-level cpufreq driver for Cell has been disabled due to the removal of CBE_RAS. Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/platforms/cell/Kconfig | 9 -- arch/powe

[PATCH v2 07/25] powerpc: Remove DCR_MMIO and the DCR generic layer

The Cell blade support was the last user of DCR_MMIO, so it can now be removed. That only leaves DCR_NATIVE, meaning the DCR generic layer which allows using either DCR_NATIVE or DCR_MMIO is also unnecessary, remove it too. Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/Kconfi

[PATCH v2 04/25] powerpc: Remove IBM_CELL_BLADE & SPIDER_NET references

The symbols are no longer selectable so remove references to them. Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/boot/Makefile | 2 -- arch/powerpc/configs/cell_defconfig | 2 -- arch/powerpc/configs/ppc64_defconfig | 2 -- 3 files changed, 6 deletions(-) diff --gi

[PATCH v2 17/25] powerpc/io: Rename _insw_ns() etc.

The "_ns" suffix was "historical" in 2006, finally remove it. Signed-off-by: Michael Ellerman --- v2: New. arch/powerpc/include/asm/io.h | 23 +-- arch/powerpc/kernel/io.c | 16 2 files changed, 13 insertions(+), 26 deletions(-) diff --git a/arch/power

[PATCH v2 06/25] powerpc/xmon: Remove SPU debug and disassembly

Now that the IBM Cell Blade support is removed, the xmon SPU support is effectively unusable. That is because PS3 doesn't implement udbg_getc which is required to send input to xmon. So remove the xmon SPU support. Signed-off-by: Michael Ellerman --- v2: Unchanged. arch/powerpc/include/asm/xmo

[PATCH v2 18/25] powerpc/io: Use standard barrier macros in io.c

io.c uses open-coded barriers. Update it to use the equivalent but in macro form. Signed-off-by: Michael Ellerman --- v2: New. arch/powerpc/kernel/io.c | 42 +++- 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/kernel/io.c b/arch/

[PATCH v2 14/25] powerpc/io: Wrap port calculation in a macro

The calculation of the IO port is repeated several times, wrap it in a macro, in particular to avoid spelling out the cast multiple times. Signed-off-by: Michael Ellerman --- v2: New. arch/powerpc/include/asm/io.h | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-

[PATCH v2 16/25] powerpc/io: Use generic raw accessors

The raw accessors are identical to the generic versions, use the generic versions. Suggested-by: Arnd Bergmann Signed-off-by: Michael Ellerman --- v2: New. arch/powerpc/include/asm/io.h | 68 +-- 1 file changed, 9 insertions(+), 59 deletions(-) diff --git a/arc

[PATCH v2 19/25] powerpc: Remove UDBG_RTAS_CONSOLE

The IBM Cell blade support was the last user of UDBG_RTAS_CONSOLE. Although it's still possible to build it via PPC_EARLY_DEBUG_UDBG_RTAS_CONSOLE, AFAIK it's not useful on any other platfoms, because only Cell and JS20 era machines provided the RTAS get/put-term-char functions. If anyone is using

[PATCH v2 21/25] genirq: Remove IRQ_EDGE_EOI_HANDLER

The powerpc Cell blade support, now removed, was the only user of IRQ_EDGE_EOI_HANDLER, so remove it. Acked-by: Thomas Gleixner Signed-off-by: Michael Ellerman --- v2: Unchanged. kernel/irq/Kconfig | 4 kernel/irq/chip.c | 47 -- 2 files chang

[PATCH v2 13/25] powerpc/io: Remove unnecessary indirection

Some of the __do_xxx() defines do nothing useful, they just existed to make the previous hooking macros work. So remove them. Reviewed-by: Arnd Bergmann Signed-off-by: Michael Ellerman --- v2: Rebase. Also do _memset_io() and _memcpy_toio() arch/powerpc/include/asm/io.h | 30 +-

[PATCH v2 15/25] powerpc/io: Spell-out PCI_IO_ADDR

PCI_IO_ADDR is a ppc-ism, which obscures the fact that some of the powerpc accessors are identical to the generic ones. So remove it and spell out the type fully. Signed-off-by: Michael Ellerman --- v2: New. arch/powerpc/include/asm/io.h | 51 +-- 1 file changed,

KVM: PPC: Book3E: KVM HV host module doesn't work anymore

Hello, The KVM HV host module doesn't work anymore since the PowerPC updates 6.13-1 [1] and PowerPC MM updates [2]. We have tested it with our FSL P5020/P5040 boards [3]. The guest kernel doesn't boot. There is no output via the serial connection and no output via the graphics card. (QEMU)

Re: [PATCH 07/17] riscv: vdso: Switch to generic storage implementation

On Mon, Dec 16, 2024 at 03:10:03PM +0100, Thomas Weißschuh wrote: > The generic storage implementation provides the same features as the > custom one. However it can be shared between architectures, making > maintenance easier. > > Co-developed-by: Nam Cao > Signed-off-by: Nam Cao > Signed-off-b

[PATCH] powerpc/prom_init: Use IS_ENABLED()

Use IS_ENABLED() for the device tree checks, so that more code is checked by the compiler without having to build all the different configurations. Suggested-by: Rob Herring Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom_init.c | 39 - 1 file change

[PATCH] selftests/powerpc: Fix argument order to timer_sub()

Commit c814bf958926 ("powerpc/selftests: Use timersub() for gettimeofday()"), got the order of arguments to timersub() wrong, leading to a negative time delta being reported, eg: test: gettimeofday tags: git_version:v6.12-rc5-409-gdddf291c3030 time = -3.297781 success: gettimeofday The co

Re: [PATCH 12/17] powerpc/vdso: Switch to generic storage implementation

Hi Christophe, On Wed, Dec 18, 2024 at 08:20:51AM +0100, Christophe Leroy wrote: > Le 16/12/2024 à 15:10, Thomas Weißschuh a écrit : [..] > > #ifdef CONFIG_TIME_NS > > -static __always_inline > > -const struct vdso_data *__arch_get_timens_vdso_data(const struct vdso_data > > *vd) > > +static

Re: [PATCH 12/17] powerpc/vdso: Switch to generic storage implementation

  #ifdef CONFIG_TIME_NS -static __always_inline -const struct vdso_data *__arch_get_timens_vdso_data(const struct vdso_data *vd) +static __always_inline const struct vdso_time_data *__ppc_get_vdso_u_timens_data(void)   { -    return (void *)vd + (1U << CONFIG_PAGE_SHIFT); +    struct vdso_t

Re: [PATCH 03/17] vdso: Add generic time data storage

Hi Christophe, On Wed, Dec 18, 2024 at 08:32:14AM +0100, Christophe Leroy wrote: > Le 16/12/2024 à 15:09, Thomas Weißschuh a écrit : > > Historically each architecture defined their own way to store the vDSO > > data page. Add a generic mechanism to provide storage for that page. > > > > Furtherm

Re: [PATCH 07/17] riscv: vdso: Switch to generic storage implementation

On Thu, Dec 19, 2024, at 07:30, Thomas Weißschuh wrote: > On Wed, Dec 18, 2024 at 05:35:31PM +0100, Arnd Bergmann wrote: >> >> > There is precedence in providing 64bit only vDSO functions, for example >> > __vdso_clock_gettime64() in arm. >> > I do have a small, so far untested, proof-of-concept pa

Re: [PATCH 07/17] riscv: vdso: Switch to generic storage implementation

On Wed, Dec 18, 2024 at 05:35:31PM +0100, Arnd Bergmann wrote: > On Wed, Dec 18, 2024, at 16:46, Thomas Weißschuh wrote: > > On Wed, Dec 18, 2024 at 03:08:28PM +, Conor Dooley wrote: > >> On Mon, Dec 16, 2024 at 03:10:03PM +0100, Thomas Weißschuh wrote: > > >> Might be a clang thing, allmodcon

Re: [PATCH v4 10/25] mm/mm_init: Move p2pdma page refcount initialisation to p2pdma

On Tue, Dec 17, 2024 at 11:14:42PM +0100, David Hildenbrand wrote: > On 17.12.24 06:12, Alistair Popple wrote: > > Currently ZONE_DEVICE page reference counts are initialised by core > > memory management code in __init_zone_device_page() as part of the > > memremap() call which driver modules make

Re: [PATCH v4 14/25] rmap: Add support for PUD sized mappings to rmap

On Tue, Dec 17, 2024 at 11:27:13PM +0100, David Hildenbrand wrote: > On 17.12.24 06:12, Alistair Popple wrote: > > The rmap doesn't currently support adding a PUD mapping of a > > folio. This patch adds support for entire PUD mappings of folios, > > primarily to allow for more standard refcounting

Re: [PATCH v4 19/25] proc/task_mmu: Ignore ZONE_DEVICE pages

On Tue, Dec 17, 2024 at 11:31:25PM +0100, David Hildenbrand wrote: > On 17.12.24 06:13, Alistair Popple wrote: > > The procfs mmu files such as smaps currently ignore device dax and fs > > dax pages because these pages are considered special. To maintain > > existing behaviour once these pages are

Re: [PATCH v2 24/25] net: spider_net: Remove powerpc Cell driver

On Wed, 18 Dec 2024 21:55:12 +1100 Michael Ellerman wrote: > This driver can no longer be built since support for IBM Cell Blades was > removed, in particular PPC_IBM_CELL_BLADE. > > Remove the driver and the documentation. > Remove the MAINTAINERS entry, and add Ishizaki and Geoff to CREDITS. Ya

Re: [PATCH v2 24/25] net: spider_net: Remove powerpc Cell driver

On Wed, 18 Dec 2024 17:59:17 -0800 Jakub Kicinski wrote: > On Wed, 18 Dec 2024 21:55:12 +1100 Michael Ellerman wrote: > > This driver can no longer be built since support for IBM Cell Blades was > > removed, in particular PPC_IBM_CELL_BLADE. > > > > Remove the driver and the documentation. > > Rem