[powerpc:merge] BUILD SUCCESS bcaab141779a454059c8dd6bae50907caa7f5a57

2024-10-14 Thread kernel test robot
gclang-20 hexagon defconfiggcc-14.1.0 i386 allmodconfigclang-18 i386 allnoconfigclang-18 i386 allyesconfigclang-18 i386buildonly-randconfig-001-20241014cla

[RFC RESEND v2 09/13] book3s64/hash: Disable debug_pagealloc if it requires more memory

2024-10-14 Thread Ritesh Harjani (IBM)
Make size of the linear map to be allocated in RMA region to be of ppc64_rma_size / 4. If debug_pagealloc requires more memory than that then do not allocate any memory and disable debug_pagealloc. Signed-off-by: Ritesh Harjani (IBM) --- arch/powerpc/mm/book3s64/hash_utils.c | 15 ++-

[RFC RESEND v2 10/13] book3s64/hash: Add kfence functionality

2024-10-14 Thread Ritesh Harjani (IBM)
Now that linear map functionality of debug_pagealloc is made generic, enable kfence to use this generic infrastructure. 1. Define kfence related linear map variables. - u8 *linear_map_kf_hash_slots; - unsigned long linear_map_kf_hash_count; - DEFINE_RAW_SPINLOCK(linear_map_kf_hash_lock);

[RFC RESEND v2 11/13] book3s64/radix: Refactoring common kfence related functions

2024-10-14 Thread Ritesh Harjani (IBM)
Both radix and hash on book3s requires to detect if kfence early init is enabled or not. Hash needs to disable kfence if early init is not enabled because with kfence the linear map is mapped using PAGE_SIZE rather than 16M mapping. We don't support multiple page sizes for slb entry used for kernel

[RFC RESEND v2 13/13] book3s64/hash: Early detect debug_pagealloc size requirement

2024-10-14 Thread Ritesh Harjani (IBM)
Add hash_supports_debug_pagealloc() helper to detect whether debug_pagealloc can be supported on hash or not. This checks for both, whether debug_pagealloc config is enabled and the linear map should fit within rma_size/4 region size. This can then be used early during htab_init_page_sizes() to de

[RFC RESEND v2 12/13] book3s64/hash: Disable kfence if not early init

2024-10-14 Thread Ritesh Harjani (IBM)
Enable kfence on book3s64 hash only when early init is enabled. This is because, kfence could cause the kernel linear map to be mapped at PAGE_SIZE level instead of 16M (which I guess we don't want). Also currently there is no way to - 1. Make multiple page size entries for the SLB used for kernel

Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages

2024-10-14 Thread Luis Chamberlain
On Sun, Oct 13, 2024 at 08:26:26PM -0700, Andrew Morton wrote: > On Sun, 13 Oct 2024 11:43:41 +0300 Mike Rapoport wrote: > > > > > The idea is to keep everything together and have execmem_info describe > > > > all > > > > that architecture needs. > > > > > > But why? That's pretty different f

Re: [RFC PATCH v1 01/57] mm: Add macros ahead of supporting boot-time page size selection

2024-10-14 Thread Pingfan Liu
On Mon, Oct 14, 2024 at 10:07 PM Ryan Roberts wrote: > > On 14/10/2024 14:54, Pingfan Liu wrote: > > Hello Ryan, > > > > On Mon, Oct 14, 2024 at 11:58:08AM +0100, Ryan Roberts wrote: > >> arm64 can support multiple base page sizes. Instead of selecting a page > >> size at compile time, as is done

Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages

2024-10-14 Thread Mike Rapoport
On Mon, Oct 14, 2024 at 09:09:49PM -0700, Luis Chamberlain wrote: > Mike, please run this with kmemleak enabled and running, and also try to get > tools/testing/selftests/kmod/kmod.sh to pass. There was an issue with kmemleak, I fixed it here: https://lore.kernel.org/linux-mm/20241009180816.83591

Re: [RFC RESEND v2 02/13] powerpc: mm: Fix kfence page fault reporting

2024-10-14 Thread Christophe Leroy
Le 15/10/2024 à 03:33, Ritesh Harjani (IBM) a écrit : copy_from_kernel_nofault() can be called when doing read of /proc/kcore. /proc/kcore can have some unmapped kfence objects which when read via copy_from_kernel_nofault() can cause page faults. Since *_nofault() functions define their own fi

Re: [RFC PATCH v1 01/57] mm: Add macros ahead of supporting boot-time page size selection

2024-10-14 Thread Pingfan Liu
Hello Ryan, On Mon, Oct 14, 2024 at 11:58:08AM +0100, Ryan Roberts wrote: > arm64 can support multiple base page sizes. Instead of selecting a page > size at compile time, as is done today, we will make it possible to > select the desired page size on the command line. > > In this case PAGE_SHIFT

Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages

2024-10-14 Thread Luis Chamberlain
Mike, please run this with kmemleak enabled and running, and also try to get tools/testing/selftests/kmod/kmod.sh to pass. I run into silly boot issues with just a guest. Luis

[PATCHES] drm/radeon issues

2024-10-14 Thread Christian Zigotzky
On 14 October 2024 at 3:11pm, Christian Zigotzky wrote: >> On 14 October 2024 at 3:00pm, Alex Deucher wrote: >> >> Can whoever wrote this send it out as a proper patch? >> >> Alex >> > Patch source: https://lists.freedesktop.org/archives/dri-devel/2024-October/473314.html + ville.syrjala

[PATCH v6 3/4] arm64: topology: Support SMT control on ACPI based system

2024-10-14 Thread Yicong Yang
From: Yicong Yang For ACPI we'll build the topology from PPTT and we cannot directly get the SMT number of each core. Instead using a temporary xarray to record the heterogeneous information (from ACPI_PPTT_ACPI_IDENTICAL) and SMT information of the first core in its heterogeneous CPU cluster whe

[PATCH v6 0/4] Support SMT control on arm64

2024-10-14 Thread Yicong Yang
From: Yicong Yang The core CPU control framework supports runtime SMT control which is not yet supported on arm64. Besides the general vulnerabilities concerns we want this runtime control on our arm64 server for: - better single CPU performance in some cases - saving overall power consumption

[PATCH v6 4/4] arm64: Kconfig: Enable HOTPLUG_SMT

2024-10-14 Thread Yicong Yang
From: Yicong Yang Enable HOTPLUG_SMT for SMT control. Signed-off-by: Yicong Yang --- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 3e29b44d2d7b..99493fb616c1 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -242,

[PATCH v6 2/4] arch_topology: Support SMT control for OF based system

2024-10-14 Thread Yicong Yang
From: Yicong Yang On building the topology from the devicetree, we've already gotten the SMT thread number of each core. Update the largest SMT thread number and enable the SMT control by the end of topology parsing. The core's SMT control provides two interface to the users [1]: 1) enable/disab

[PATCH v6 1/4] cpu/SMT: Provide a default topology_is_primary_thread()

2024-10-14 Thread Yicong Yang
From: Yicong Yang Currently if architectures want to support HOTPLUG_SMT they need to provide a topology_is_primary_thread() telling the framework which thread in the SMT cannot offline. However arm64 doesn't have a restriction on which thread in the SMT cannot offline, a simplest choice is that

[RFC RESEND v2 00/13] powerpc/kfence: Improve kfence support

2024-10-14 Thread Ritesh Harjani (IBM)
Resending v2 for review comments. This patch series addresses following to improve kfence support on Powerpc. 1. Usage of copy_from_kernel_nofault() within kernel, such as read from /proc/kcore can cause kfence to report false negatives. This is similar to what was reported on s390. [1]

[RFC RESEND v2 08/13] book3s64/hash: Make kernel_map_linear_page() generic

2024-10-14 Thread Ritesh Harjani (IBM)
Currently kernel_map_linear_page() function assumes to be working on linear_map_hash_slots array. But since in later patches we need a separate linear map array for kfence, hence make kernel_map_linear_page() take a linear map array and lock in it's function argument. This is needed to separate ou

[RFC RESEND v2 01/13] mm/kfence: Add a new kunit test test_use_after_free_read_nofault()

2024-10-14 Thread Ritesh Harjani (IBM)
From: Nirjhar Roy Faults from copy_from_kernel_nofault() needs to be handled by fixup table and should not be handled by kfence. Otherwise while reading /proc/kcore which uses copy_from_kernel_nofault(), kfence can generate false negatives. This can happen when /proc/kcore ends up reading an unma

[RFC RESEND v2 04/13] book3s64/hash: Refactor kernel linear map related calls

2024-10-14 Thread Ritesh Harjani (IBM)
This just brings all linear map related handling at one place instead of having those functions scattered in hash_utils file. Makes it easy for review. No functionality changes in this patch. Signed-off-by: Ritesh Harjani (IBM) --- arch/powerpc/mm/book3s64/hash_utils.c | 164 +--

[RFC RESEND v2 07/13] book3s64/hash: Refactor hash__kernel_map_pages() function

2024-10-14 Thread Ritesh Harjani (IBM)
This refactors hash__kernel_map_pages() function to call hash_debug_pagealloc_map_pages(). This will come useful when we will add kfence support. No functionality changes in this patch. Signed-off-by: Ritesh Harjani (IBM) --- arch/powerpc/mm/book3s64/hash_utils.c | 9 - 1 file changed,

[RFC RESEND v2 06/13] book3s64/hash: Add hash_debug_pagealloc_alloc_slots() function

2024-10-14 Thread Ritesh Harjani (IBM)
This adds hash_debug_pagealloc_alloc_slots() function instead of open coding that in htab_initialize(). This is required since we will be separating the kfence functionality to not depend upon debug_pagealloc. Now that everything required for debug_pagealloc is under a #ifdef config. Bring in line

[RFC RESEND v2 03/13] book3s64/hash: Remove kfence support temporarily

2024-10-14 Thread Ritesh Harjani (IBM)
Kfence on book3s Hash on pseries is anyways broken. It fails to boot due to RMA size limitation. That is because, kfence with Hash uses debug_pagealloc infrastructure. debug_pagealloc allocates linear map for entire dram size instead of just kfence relevant objects. This means for 16TB of DRAM it w

[RFC RESEND v2 02/13] powerpc: mm: Fix kfence page fault reporting

2024-10-14 Thread Ritesh Harjani (IBM)
copy_from_kernel_nofault() can be called when doing read of /proc/kcore. /proc/kcore can have some unmapped kfence objects which when read via copy_from_kernel_nofault() can cause page faults. Since *_nofault() functions define their own fixup table for handling fault, use that instead of asking kf

[RFC RESEND v2 05/13] book3s64/hash: Add hash_debug_pagealloc_add_slot() function

2024-10-14 Thread Ritesh Harjani (IBM)
This adds hash_debug_pagealloc_add_slot() function instead of open coding that in htab_bolt_mapping(). This is required since we will be separating kfence functionality to not depend upon debug_pagealloc. No functionality change in this patch. Signed-off-by: Ritesh Harjani (IBM) --- arch/powerp

Re: [PATCH 2/2] asm-generic: add an optional pfn_valid check to pfn_valid

2024-10-14 Thread Thomas Huth
On 14/10/2024 16.44, Christoph Hellwig wrote: page_to_pfn is usually implemented by pointer arithmetics on the memory map, which means that bogus input can lead to even more bogus output. Powerpc had a pfn_valid check on the regult to it's page_to_phys s/regult/result/ implementation when CO

Re: [RFC v3 1/3] fadump: Refactor and prepare fadump_cma_init for late init

2024-10-14 Thread Madhavan Srinivasan
On 10/11/24 8:30 PM, Ritesh Harjani (IBM) wrote: > We anyway don't use any return values from fadump_cma_init(). Since > fadump_reserve_mem() from where fadump_cma_init() gets called today, > already has the required checks. > This patch makes this function return type as void. Let's also handle

[PATCH 0/2] net: ethernet: freescale: Use %pa to format resource_size_t

2024-10-14 Thread Simon Horman
Hi, This short series addersses the formatting of variables of type resource_size_t in freescale drivers. The correct format string for resource_size_t is %pa which acts on the address of the variable to be formatted [1]. [1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-ap

[PATCH 1/2] net: fec_mpc52xx_phy: Use %pa to format resource_size_t

2024-10-14 Thread Simon Horman
The correct format string for resource_size_t is %pa which acts on the address of the variable to be formatted [1]. [1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229 Introduced by commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string") F

[PATCH 2/2] net: ethernet: fs_enet: Use %pa to format resource_size_t

2024-10-14 Thread Simon Horman
The correct format string for resource_size_t is %pa which acts on the address of the variable to be formatted [1]. [1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229 Introduced by commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string") F

Re: Build regressions/improvements in v6.12-rc3

2024-10-14 Thread Simon Horman
On Mon, Oct 14, 2024 at 11:18:14AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Mon, Oct 14, 2024 at 10:58 AM Simon Horman wrote: > > On Mon, Oct 14, 2024 at 10:38:20AM +0200, Geert Uytterhoeven wrote: > > > + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: > > > error

[PATCH] powerpc/ep8248e: Use %pa to format resource_size_t

2024-10-14 Thread Simon Horman
The correct format string for resource_size_t is %pa which acts on the address of the variable to be formatted [1]. [1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229 Introduced by commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string") F

Re: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-14 Thread Andrew Cooper
On 14/10/2024 7:50 am, Linus Torvalds wrote: > On Sun, 13 Oct 2024 at 20:54, Josh Poimboeuf wrote: >> If I understand correctly, LAM bits are for the benefit of SW and are >> ignored by HW? That is what is written in the ISE today. But, I'll note that on ARM, MTE (Memory Tagging Extensions) use

Re: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-14 Thread Linus Torvalds
On Mon, 14 Oct 2024 at 02:59, David Laight wrote: > > Isn't LAM just plain stupid unless the hardware validates the bits > against the TLB? What? No. You can't do that. At some point, the TLB isn't filled, and then you have to do the access with lots of linear address bits masked. > Doesn't ARM6

Re: Build regressions/improvements in v6.12-rc3

2024-10-14 Thread Simon Horman
On Mon, Oct 14, 2024 at 10:38:20AM +0200, Geert Uytterhoeven wrote: > On Mon, 14 Oct 2024, Geert Uytterhoeven wrote: > > JFYI, when comparing v6.12-rc3[1] to v6.12-rc2[3], the summaries are: > > - build errors: +3/-1 > > + /kisskb/src/crypto/async_tx/async_tx.c: error: no previous prototype for

Re: Build regressions/improvements in v6.12-rc3

2024-10-14 Thread Geert Uytterhoeven
Hi Simon, On Mon, Oct 14, 2024 at 10:58 AM Simon Horman wrote: > On Mon, Oct 14, 2024 at 10:38:20AM +0200, Geert Uytterhoeven wrote: > > + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: > > error: format '%x' expects argument of type 'unsigned int', but argument 4 > > has t

Re: [PATCH 09/12] mm: Update vm_normal_page() callers to accept FS DAX pages

2024-10-14 Thread Alistair Popple
Dan Williams writes: > Alistair Popple wrote: >> Currently if a PTE points to a FS DAX page vm_normal_page() will >> return NULL as these have their own special refcounting scheme. A >> future change will allow FS DAX pages to be refcounted the same as any >> other normal page. >> >> Therefore

Re: [RFC] ipw2100 ipw2200 ps3_gelic rtl8712 --- Are we ready for wext cleanup?

2024-10-14 Thread Kalle Valo
Philipp Hortmann writes: > origin of this question was the following patch series from Arnd Bergmann > [PATCH 00/10] Remove obsolete and orphaned wifi drivers > https://lore.kernel.org/linux-staging/20231023131953.2876682-1-a...@kernel.org/ > > Here the remaining files that use iw_handler_def: >

[PATCH v3 00/16] timers: Cleanup delay/sleep related mess

2024-10-14 Thread Anna-Maria Behnsen
Hi, a question about which sleeping function should be used in acpi_os_sleep() started a discussion and examination about the existing documentation and implementation of functions which insert a sleep/delay. The result of the discussion was, that the documentation is outdated and the implemented

[PATCH v3 13/16] powerpc/rtas: Use fsleep() to minimize additional sleep duration

2024-10-14 Thread Anna-Maria Behnsen
When commit 38f7b7067dae ("powerpc/rtas: rtas_busy_delay() improvements") was introduced, documentation about proper usage of sleep related functions was outdated. The commit message references the usage of a HZ=100 system. When using a 20ms sleep duration on such a system and therefore using msle

Re: [RFC PATCH v3 4/4] sched+mm: Use hazard pointers to track lazy active mm existence

2024-10-14 Thread kernel test robot
e at: https://download.01.org/0day-ci/archive/20241014/202410141617.612a0f5b-...@intel.com -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

Re: Build regressions/improvements in v6.12-rc3

2024-10-14 Thread Geert Uytterhoeven
On Mon, 14 Oct 2024, Geert Uytterhoeven wrote: JFYI, when comparing v6.12-rc3[1] to v6.12-rc2[3], the summaries are: - build errors: +3/-1 + /kisskb/src/crypto/async_tx/async_tx.c: error: no previous prototype for '__async_tx_find_channel' [-Werror=missing-prototypes]: => 43:1 powerpc-gcc

Re: [RFC v3 1/3] fadump: Refactor and prepare fadump_cma_init for late init

2024-10-14 Thread IBM
Madhavan Srinivasan writes: > On 10/11/24 8:30 PM, Ritesh Harjani (IBM) wrote: >> We anyway don't use any return values from fadump_cma_init(). Since >> fadump_reserve_mem() from where fadump_cma_init() gets called today, >> already has the required checks. >> This patch makes this function retur

Re: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-14 Thread Kirill A. Shutemov
On Sat, Oct 12, 2024 at 05:53:19PM -0700, Linus Torvalds wrote: > On Sat, 12 Oct 2024 at 10:44, Linus Torvalds > wrote: > > > > Anyway, what's the speculation window size like? > > Note that this is important basically because we do *NOT* want to > check the address against TASK_SIZE_MAX like we

[RFC PATCH v1 01/57] mm: Add macros ahead of supporting boot-time page size selection

2024-10-14 Thread Ryan Roberts
arm64 can support multiple base page sizes. Instead of selecting a page size at compile time, as is done today, we will make it possible to select the desired page size on the command line. In this case PAGE_SHIFT and it's derivatives, PAGE_SIZE and PAGE_MASK (as well as a number of other macros r

[PATCH 1/2] asm-generic: provide generic page_to_phys and phys_to_page implementations

2024-10-14 Thread Christoph Hellwig
page_to_phys is duplicated by all architectures, and from some strange reason placed in where it doesn't fit at all. phys_to_page is only provided by a few architectures despite having a lot of open coded users. Provide generic versions in to make these helpers more easily usable. Note with th

provide generic page_to_phys and phys_to_page implementations v2

2024-10-14 Thread Christoph Hellwig
page_to_phys is duplicated by all architectures, and from some strange reason placed in where it doesn't fit at all. phys_to_page is only provided by a few architectures despite having a lot of open coded users. Provide generic versions in to make these helpers more easily usable. Changes s

[PATCH 2/2] asm-generic: add an optional pfn_valid check to pfn_valid

2024-10-14 Thread Christoph Hellwig
page_to_pfn is usually implemented by pointer arithmetics on the memory map, which means that bogus input can lead to even more bogus output. Powerpc had a pfn_valid check on the regult to it's page_to_phys implementation when CONFIG_DEBUG_VIRTUAL is defined, which seems generally useful, so add t

Re: (subset) [PATCH v3 00/16] timers: Cleanup delay/sleep related mess

2024-10-14 Thread Mark Brown
On Mon, 14 Oct 2024 10:22:17 +0200, Anna-Maria Behnsen wrote: > a question about which sleeping function should be used in acpi_os_sleep() > started a discussion and examination about the existing documentation and > implementation of functions which insert a sleep/delay. > > The result of the dis

Re: [PATCH] tools/perf/tests: Fix compilation error with strncpy in tests/tool_pmu

2024-10-14 Thread Namhyung Kim
On Sun, Oct 13, 2024 at 11:07:42PM +0530, Athira Rajeev wrote: > perf fails to compile on systems with GCC version11 > as below: I have one more build failure on 32 bit systems. I'll carry this as well. Thanks, Namhyung ---8<--- >From 2e2c7ca3691d223d94ea383a6b688e35579d14d5 Mon Sep 17 00:00:00

Re: [PATCH] tools/perf/tests: Fix compilation error with strncpy in tests/tool_pmu

2024-10-14 Thread Namhyung Kim
On Sun, 13 Oct 2024 23:07:42 +0530, Athira Rajeev wrote: > perf fails to compile on systems with GCC version11 > as below: > > In file included from /usr/include/string.h:519, > from > /home/athir/perf-tools-next/tools/include/linux/bitmap.h:5, > from /home/athi

Re: [PATCH] tools/perf/tests: Remove duplicate evlist__delete in tests/tool_pmu.c

2024-10-14 Thread Namhyung Kim
On Sun, 13 Oct 2024 22:37:32 +0530, Athira Rajeev wrote: > The testcase for tool_pmu failed in powerpc as below: > > ./perf test -v "Parsing without PMU name" > 8: Tool PMU: > 8.1: Parsing without PMU name

Re: [PATCH 08/12] gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages

2024-10-14 Thread Alistair Popple
Dan Williams writes: > Dan Williams wrote: >> Alistair Popple wrote: >> > Longterm pinning of FS DAX pages should already be disallowed by >> > various pXX_devmap checks. However a future change will cause these >> > checks to be invalid for FS DAX pages so make >> > folio_is_longterm_pinnable(

Re: [PATCH 11/12] mm: Remove pXX_devmap callers

2024-10-14 Thread Alistair Popple
Alexander Gordeev writes: > On Tue, Sep 10, 2024 at 02:14:36PM +1000, Alistair Popple wrote: > > Hi Alistair, > >> diff --git a/arch/powerpc/mm/book3s64/pgtable.c >> b/arch/powerpc/mm/book3s64/pgtable.c >> index 5a4a753..4537a29 100644 >> --- a/arch/powerpc/mm/book3s64/pgtable.c >> +++ b/arch/

Re: [PATCH 00/17] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-10-14 Thread Vlastimil Babka
On 10/13/24 22:16, Julia Lawall wrote: > Since SLOB was removed and since > commit 6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from > kmem_cache_destroy()"), > it is not necessary to use call_rcu when the callback only performs > kmem_cache_free. Use kfree_rcu() directly. > > The changes w

Re: [PATCH 07/12] huge_memory: Allow mappings of PMD sized pages

2024-10-14 Thread Alistair Popple
Dan Williams writes: > Alistair Popple wrote: >> Currently DAX folio/page reference counts are managed differently to >> normal pages. To allow these to be managed the same as normal pages >> introduce dax_insert_pfn_pmd. This will map the entire PMD-sized folio >> and take references as it wou

RE: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-14 Thread David Laight
... > > If I understand correctly, LAM bits are for the benefit of SW and are > > ignored by HW? Can we just mask those bits off? > > Yes. But then you waste time on the masking, but particularly if it > then causes silly extra overhead just to get the mask. Isn't LAM just plain stupid unless th

Re: [PATCH v4 0/7] ASoC: fsl: add memory to memory function for ASRC

2024-10-14 Thread Takashi Iwai
On Wed, 25 Sep 2024 08:55:09 +0200, Shengjiu Wang wrote: > > This function is base on the accelerator implementation > for compress API: > https://patchwork.kernel.org/project/alsa-devel/patch/20240731083843.59911-1-pe...@perex.cz/ > Add it to this patch set. > > Audio signal processing also has

Re: [PATCH] powerpc/pseries/iommu: Wait until all TCEs are unmapped before deleting DDW

2024-10-14 Thread Michael Ellerman
Hi Gaurav, Gaurav Batra writes: > Some of the network drivers, like Mellanox, use core linux page_pool APIs > to manage DMA buffers. These page_pool APIs cache DMA buffers with > infrequent map/unmap calls for DMA mappings, thus increasing performance. Can you please resend this and Cc the netde

Re: [RFC v3 1/3] fadump: Refactor and prepare fadump_cma_init for late init

2024-10-14 Thread Madhavan Srinivasan
On 10/14/24 4:54 PM, Ritesh Harjani (IBM) wrote: > Madhavan Srinivasan writes: > >> On 10/11/24 8:30 PM, Ritesh Harjani (IBM) wrote: >>> We anyway don't use any return values from fadump_cma_init(). Since >>> fadump_reserve_mem() from where fadump_cma_init() gets called today, >>> already has

Re: [PATCHES] drm/radeon issues

2024-10-14 Thread Alex Deucher
On Thu, Oct 10, 2024 at 11:54 PM Christian Zigotzky wrote: > > On 11 October 2024 at 01:49am, Jeff Johnson wrote: > > Can you provide links to all 3 patches? > > 6.12-rc2 was back merged to my ath.git project, but then my laptop > stopped booting correctly and I discovered a few Radeon KASAN repo

Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages

2024-10-14 Thread Mike Rapoport
On Sun, Oct 13, 2024 at 10:55:25PM -0700, Christoph Hellwig wrote: > On Sun, Oct 13, 2024 at 11:43:41AM +0300, Mike Rapoport wrote: > > > But why? That's pretty different from our normal style of arch hooks, > > > and introduces an indirect call in a security sensitive area. > > > > Will change t

[PATCHES] drm/radeon issues

2024-10-14 Thread Christian Zigotzky
On 14 October 2024 at 3:00pm, Alex Deucher wrote: Can whoever wrote this send it out as a proper patch? Alex Patch source: https://lists.freedesktop.org/archives/dri-devel/2024-October/473314.html

Re: drivers/nx: Invalid wait context issue when rebooting

2024-10-14 Thread IBM
Vishal Chourasia writes: > On Fri, Oct 11, 2024 at 09:37:27PM +1100, Michael Ellerman wrote: >> >> I don't see why of_reconfig_notifier_unregister() needs to be called >> with the devdata_mutext held, but I haven't looked that closely at it. >> >> So the change below might work. >> >> cheers >

Re: [PATCH 3/9] arm64: vdso: Remove timekeeper include

2024-10-14 Thread Will Deacon
On Thu, Oct 10, 2024 at 05:44:46PM +0200, Thomas Weißschuh wrote: > Since the generic VDSO clock mode storage is used, this header file is > unused and can be removed. > > Signed-off-by: Thomas Weißschuh > --- > arch/arm64/kernel/vdso.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ar

Re: [PATCH 1/9] vdso: Remove timekeeper argument of __arch_update_vsyscall()

2024-10-14 Thread Will Deacon
On Thu, Oct 10, 2024 at 05:44:44PM +0200, Thomas Weißschuh wrote: > No implementation of this hook uses the passed in timekeeper anymore. > > This avoids including a non-VDSO header while building the VDSO, > which can lead to compilation errors. > > Signed-off-by: Thomas Weißschuh > --- > arch

Re: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-14 Thread Andrew Cooper
On 14/10/2024 1:30 pm, Kirill A. Shutemov wrote: > On Sun, Oct 13, 2024 at 11:50:55PM -0700, Linus Torvalds wrote: >> Anyway, the attached patch >> >> diff --git a/arch/x86/lib/getuser.S b/arch/x86/lib/getuser.S >> index d066aecf8aeb..7d5730aa18b8 100644 >> --- a/arch/x86/lib/getuser.S >> +++ b/arc

[PATCH] tools/perf/tests/base_probe: Fix check for the count of existing probes in test_adding_kernel

2024-10-14 Thread Athira Rajeev
perftool-testsuite_probe fails in test_adding_kernel as below: Regexp not found: "probe:inode_permission_11" -- [ FAIL ] -- perf_probe :: test_adding_kernel :: force-adding probes :: second probe adding (with force) (output regexp parsing) event syntax error: 'probe

[PATCH] tools/perf/tests/shell/base_probe: Enhance print_overall_results to print summary information

2024-10-14 Thread Athira Rajeev
Currently print_overall_results prints the number of fails in the summary, example from base_probe tests in testsuite_probe: ## [ FAIL ] ## perf_probe :: test_invalid_options SUMMARY :: 11 failures found test_invalid_options contains multiple tests and out of that 11 failed. Sometimes it

Re: [PATCH v5 2/5] perf: Hoist perf_instruction_pointer() and perf_misc_flags()

2024-10-14 Thread Madhavan Srinivasan
On 9/20/24 11:17 PM, Colton Lewis wrote: > For clarity, rename the arch-specific definitions of these functions > to perf_arch_* to denote they are arch-specifc. Define the > generic-named functions in one place where they can call the > arch-specific ones as needed. > > Signed-off-by: Colton L

Re: [PATCH v5 3/5] powerpc: perf: Use perf_arch_instruction_pointer()

2024-10-14 Thread Madhavan Srinivasan
On 9/20/24 11:17 PM, Colton Lewis wrote: > Make sure powerpc uses the arch-specific function now that those have > been reorganized. > Changes looks fine to me. Acked-by: Madhavan Srinivasan > Signed-off-by: Colton Lewis > --- > arch/powerpc/perf/callchain.c| 2 +- > arch/powerpc/perf

Re: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-14 Thread Kirill A. Shutemov
On Sun, Oct 13, 2024 at 11:50:55PM -0700, Linus Torvalds wrote: > Anyway, the attached patch > > diff --git a/arch/x86/lib/getuser.S b/arch/x86/lib/getuser.S > index d066aecf8aeb..7d5730aa18b8 100644 > --- a/arch/x86/lib/getuser.S > +++ b/arch/x86/lib/getuser.S > @@ -37,11 +37,17 @@ > > #define

RE: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-14 Thread David Laight
From: Linus Torvalds > Sent: 14 October 2024 12:21 > > On Mon, 14 Oct 2024 at 02:59, David Laight wrote: > > > > Isn't LAM just plain stupid unless the hardware validates the bits > > against the TLB? > > What? No. You can't do that. At some point, the TLB isn't filled, and > then you have to do

Re: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-14 Thread Linus Torvalds
On Mon, 14 Oct 2024 at 05:30, Kirill A. Shutemov wrote: > > Given that LAM enforces bit 47/56 to be equal to bit 63 I think we can do > this unconditionally instead of masking: > > diff --git a/arch/x86/lib/getuser.S b/arch/x86/lib/getuser.S > index d066aecf8aeb..86d4511520b1 100644 > --- a/arch/x

Re: [PATCH v5 19/30] arm64: add POE signal support

2024-10-14 Thread Will Deacon
Kevin, Joey, On Wed, Oct 09, 2024 at 03:43:01PM +0100, Will Deacon wrote: > On Tue, Sep 24, 2024 at 01:27:58PM +0200, Kevin Brodsky wrote: > > On 22/08/2024 17:11, Joey Gouly wrote: > > > @@ -1178,6 +1237,9 @@ static void setup_return(struct pt_regs *regs, > > > struct k_sigaction *ka, > > >

Re: [RFC PATCH v1 01/57] mm: Add macros ahead of supporting boot-time page size selection

2024-10-14 Thread Ryan Roberts
On 14/10/2024 14:54, Pingfan Liu wrote: > Hello Ryan, > > On Mon, Oct 14, 2024 at 11:58:08AM +0100, Ryan Roberts wrote: >> arm64 can support multiple base page sizes. Instead of selecting a page >> size at compile time, as is done today, we will make it possible to >> select the desired page size

[PATCH] tpm: ibmvtpm: Set TPM_OPS_AUTO_STARTUP flag on driver

2024-10-14 Thread Stefan Berger
Set the TPM_OPS_AUTO_STARTUP on the driver so that the ibmvtpm driver now uses tpm2_auto_startup and tpm1_auto_startup like many other drivers do. Remove tpm_get_timeouts, tpm2_get_cc_attrs_tbl, and tpm2_sessions_init calls from it since these will all be called in tpm2_auto_startup and tpm1_auto_s

Re: [PATCH] tools/perf/tests: Fix compilation error with strncpy in tests/tool_pmu

2024-10-14 Thread Namhyung Kim
Hello Athira, On Sun, Oct 13, 2024 at 11:07:42PM +0530, Athira Rajeev wrote: > perf fails to compile on systems with GCC version11 > as below: > > In file included from /usr/include/string.h:519, > from > /home/athir/perf-tools-next/tools/include/linux/bitmap.h:5, >

Re: [RFC] ipw2100 ipw2200 ps3_gelic rtl8712 --- Are we ready for wext cleanup?

2024-10-14 Thread Philipp Hortmann
On 14.10.24 11:32, Kalle Valo wrote: Philipp Hortmann writes: origin of this question was the following patch series from Arnd Bergmann [PATCH 00/10] Remove obsolete and orphaned wifi drivers https://lore.kernel.org/linux-staging/20231023131953.2876682-1-a...@kernel.org/ Here the remaining fi

Re: [PATCH 00/17] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-10-14 Thread Pablo Neira Ayuso
On Sun, Oct 13, 2024 at 10:16:47PM +0200, Julia Lawall wrote: > Since SLOB was removed and since > commit 6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from > kmem_cache_destroy()"), > it is not necessary to use call_rcu when the callback only performs > kmem_cache_free. Use kfree_rcu() direc