Re: [PATCH v3] PowerPC: Replace kretprobe with rethook

2024-07-09 Thread Naveen N Rao
Masami Hiramatsu wrote: On Thu, 27 Jun 2024 09:21:01 -0400 Abhishek Dubey wrote: +/* rethook initializer */ +int __init arch_init_kprobes(void) +{ + return register_kprobe(&trampoline_p); +} No, please don't use arch_init_kprobes() for initializing rethook, since rethook is used from f

Re: [PATCH v4 17/29] arm64: implement PKEYS support

2024-07-09 Thread Szabolcs Nagy
The 07/08/2024 18:53, Catalin Marinas wrote: > Hi Szabolcs, > > On Mon, Jun 17, 2024 at 03:51:35PM +0100, Szabolcs Nagy wrote: > > The 06/17/2024 15:40, Florian Weimer wrote: > > > >> A user can still set it by interacting with the register directly, but > > > >> I guess > > > >> we want somethin

Re: [PATCH v4 17/29] arm64: implement PKEYS support

2024-07-09 Thread Florian Weimer
* Szabolcs Nagy: >> However, does it matter much? That's only for the initial setup, the >> user can then change the permissions directly via the sysreg. So maybe >> we don't need all those combinations upfront. A PKEY_DISABLE_EXECUTE >> together with the full PKEY_DISABLE_ACCESS would probably su

Re: WARNING&Oops in v6.6.37 on ppc64lea - Trying to vfree() bad address (00000000453be747)

2024-07-09 Thread Greg Kroah-Hartman
On Mon, Jul 08, 2024 at 11:16:48PM -0400, matoro wrote: > On 2024-07-05 16:34, Vitaly Chikunov wrote: > > Hi, > > > > There is new WARNING and Oops on ppc64le in v6.6.37 when running LTP tests: > > bpf_prog01, bpf_prog02, bpf_prog04, bpf_prog05, prctl04. Logs excerpt > > below. I > > see there is

Re: [PATCH 4/9] mtd: devices: add AT24 eeprom support

2024-07-09 Thread Marco Felsch
Hi Miquel, On 24-07-08, Miquel Raynal wrote: > Hi, > > > > >> >> Port the current misc/eeprom/at24.c driver to the MTD framework > > > >> >> since > > > >> >> EEPROMs are memory-technology devices and the framework already > > > >> >> supports > > > >> > > > > >> > I was under the impression

Re: WARNING&Oops in v6.6.37 on ppc64lea - Trying to vfree() bad address (00000000453be747)

2024-07-09 Thread Naveen N Rao
Greg Kroah-Hartman wrote: On Mon, Jul 08, 2024 at 11:16:48PM -0400, matoro wrote: On 2024-07-05 16:34, Vitaly Chikunov wrote: > Hi, > > There is new WARNING and Oops on ppc64le in v6.6.37 when running LTP tests: > bpf_prog01, bpf_prog02, bpf_prog04, bpf_prog05, prctl04. Logs excerpt > below. I

Re: WARNING&Oops in v6.6.37 on ppc64lea - Trying to vfree() bad address (00000000453be747)

2024-07-09 Thread Greg Kroah-Hartman
On Tue, Jul 09, 2024 at 03:02:13PM +0530, Naveen N Rao wrote: > Greg Kroah-Hartman wrote: > > On Mon, Jul 08, 2024 at 11:16:48PM -0400, matoro wrote: > > > On 2024-07-05 16:34, Vitaly Chikunov wrote: > > > > Hi, > > > > > There is new WARNING and Oops on ppc64le in v6.6.37 when running > > > LTP te

Re: [PATCH 4/9] mtd: devices: add AT24 eeprom support

2024-07-09 Thread Miquel Raynal
Hi Marco, > > > > >> I also found a thread from 2013 by Maxime Ripard (+Cc) suggesting > > > > >> adding > > > > >> EEPROMs to MTD [1]. The main purpose would have been unifying the > > > > >> EEPROM > > > > >> drivers under a single interface. I am not sure what came of it > > > > >> though, >

Re: [PATCH 4/9] mtd: devices: add AT24 eeprom support

2024-07-09 Thread Marco Felsch
On 24-07-09, Miquel Raynal wrote: > Hi Marco, > > > > > > >> I also found a thread from 2013 by Maxime Ripard (+Cc) suggesting > > > > > >> adding > > > > > >> EEPROMs to MTD [1]. The main purpose would have been unifying the > > > > > >> EEPROM > > > > > >> drivers under a single interface. I a

Re: [PATCH] powerpc/pseries: Fix scv instruction crash with kexec

2024-07-09 Thread Michal Suchánek
Hello, On Tue, Jun 25, 2024 at 11:40:47PM +1000, Nicholas Piggin wrote: > kexec on pseries disables AIL (reloc_on_exc), required for scv > instruction support, before other CPUs have been shut down. This means > they can execute scv instructions after AIL is disabled, which causes an > interrupt a

Re: WARNING&Oops in v6.6.37 on ppc64lea - Trying to vfree() bad address (00000000453be747)

2024-07-09 Thread Michael Ellerman
Greg Kroah-Hartman writes: > On Tue, Jul 09, 2024 at 03:02:13PM +0530, Naveen N Rao wrote: >> Greg Kroah-Hartman wrote: >> > On Mon, Jul 08, 2024 at 11:16:48PM -0400, matoro wrote: >> > > On 2024-07-05 16:34, Vitaly Chikunov wrote: >> > > > Hi, >> > > > > There is new WARNING and Oops on ppc64le i

Re: [PATCH 6/6] arm: defconfig: drop RT_GROUP_SCHED=y from bcm2855/tegra/omap2plus

2024-07-09 Thread Celeste Liu
On 2024-07-09 20:26, Stefan Wahren wrote: > Hi Celeste, > > there is a typo in the subject line > > s/bcm2855/bcm2835 Will be included in next version. > > Am 09.07.24 um 01:49 schrieb Kevin Hilman: >> Celeste Liu writes: >> >>> Commit 673ce00c5d6c ("ARM: omap2plus_defconfig: Add support fo

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-09 Thread Michael Ellerman
Damien Stewart writes: > Hello. > >> How does it fail? I've repeatedly asked for dmesg outputs >> for working and non-working configurations. > > I am the alleged tester. Attached are two dmesg logs. First one fails. > Second passes with 2nd IRQ patch. Also attached is device tree blob if > I've f

Re: WARNING&Oops in v6.6.37 on ppc64lea - Trying to vfree() bad address (00000000453be747)

2024-07-09 Thread Michael Ellerman
Michael Ellerman writes: > Greg Kroah-Hartman writes: >> On Tue, Jul 09, 2024 at 03:02:13PM +0530, Naveen N Rao wrote: >>> Greg Kroah-Hartman wrote: >>> > On Mon, Jul 08, 2024 at 11:16:48PM -0400, matoro wrote: >>> > > On 2024-07-05 16:34, Vitaly Chikunov wrote: >>> > > > Hi, >>> > > > > There is

Re: [PATCH] powerpc/pseries: Fix scv instruction crash with kexec

2024-07-09 Thread Michael Ellerman
Michal Suchánek writes: > Hello, > > On Tue, Jun 25, 2024 at 11:40:47PM +1000, Nicholas Piggin wrote: >> kexec on pseries disables AIL (reloc_on_exc), required for scv >> instruction support, before other CPUs have been shut down. This means >> they can execute scv instructions after AIL is disabl

Re: [PATCH] powerpc/pseries: Fix scv instruction crash with kexec

2024-07-09 Thread Michal Suchánek
On Tue, Jul 09, 2024 at 11:03:10PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > On Tue, Jun 25, 2024 at 11:40:47PM +1000, Nicholas Piggin wrote: > >> kexec on pseries disables AIL (reloc_on_exc), required for scv > >> instruction support, before other CPUs have been

Re: [PATCH] cxl: Fix possible null pointer dereference in read_handle()

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 09:17:54PM +0800, Ma Ke wrote: > In read_handle() of_get_address() may return NULL which is later > dereferenced. Fix this bug by adding NULL check. > > Cc: sta...@vger.kernel.org > Fixes: 14baf4d9c739 ("cxl: Add guest-specific code") > Signed-off-by: Ma Ke > --- > driver

Re: [PATCH 6/6] arm: defconfig: drop RT_GROUP_SCHED=y from bcm2855/tegra/omap2plus

2024-07-09 Thread Stefan Wahren
Hi Celeste, there is a typo in the subject line s/bcm2855/bcm2835 Am 09.07.24 um 01:49 schrieb Kevin Hilman: Celeste Liu writes: Commit 673ce00c5d6c ("ARM: omap2plus_defconfig: Add support for distros with systemd") said it's because of recommendation from systemd. But systemd changed their

Re: [PATCH v4 15/29] arm64: handle PKEY/POE faults

2024-07-09 Thread Kevin Brodsky
On 03/05/2024 15:01, Joey Gouly wrote: > [...] > > +static bool fault_from_pkey(unsigned long esr, struct vm_area_struct *vma, > + unsigned int mm_flags) > +{ > + unsigned long iss2 = ESR_ELx_ISS2(esr); > + > + if (!arch_pkeys_enabled()) > + return false; > +

Re: [PATCH v4 17/29] arm64: implement PKEYS support

2024-07-09 Thread Kevin Brodsky
On 03/05/2024 15:01, Joey Gouly wrote: > @@ -267,6 +294,28 @@ static inline unsigned long mm_untag_mask(struct > mm_struct *mm) > return -1UL >> 8; > } > > +/* > + * We only want to enforce protection keys on the current process > + * because we effectively have no access to POR_EL0 for o

Re: [PATCH v4 18/29] arm64: add POE signal support

2024-07-09 Thread Kevin Brodsky
On 03/05/2024 15:01, Joey Gouly wrote: > @@ -1020,6 +1060,15 @@ static int setup_sigframe(struct > rt_sigframe_user_layout *user, > __put_user_error(current->thread.fault_code, &esr_ctx->esr, > err); > } > > + if (system_supports_poe() && err == 0 && user->poe_offset) {

Re: [PATCH v4 22/29] arm64: add Permission Overlay Extension Kconfig

2024-07-09 Thread Kevin Brodsky
On 03/05/2024 15:01, Joey Gouly wrote: > Now that support for POE and Protection Keys has been implemented, add a > config to allow users to actually enable it. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/Kconfig | 22 ++ > 1 file

Re: [PATCH v4 28/29] kselftest/arm64: Add test case for POR_EL0 signal frame records

2024-07-09 Thread Kevin Brodsky
On 03/05/2024 15:01, Joey Gouly wrote: > +static uint64_t get_por_el0(void) > +{ > + uint64_t val; > + > + asm volatile ( > + "mrs%0, " SYS_POR_EL0 "\n" > + : "=r"(val) > + : > + : "cc"); Not sure why we would need "cc" for an MRS? __read

[PATCH] cxl: Fix possible null pointer dereference in read_handle()

2024-07-09 Thread Ma Ke
In read_handle() of_get_address() may return NULL which is later dereferenced. Fix this bug by adding NULL check. Cc: sta...@vger.kernel.org Fixes: 14baf4d9c739 ("cxl: Add guest-specific code") Signed-off-by: Ma Ke --- drivers/misc/cxl/of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] cxl: Fix possible null pointer dereference in read_handle()

2024-07-09 Thread Markus Elfring
… > Signed-off-by: Ma Ke Under which circumstances will this information be corrected anyhow? The usage of mailing list addresses is probably undesirable for the Developer's Certificate of Origin, isn't it? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/pro

Re: [PATCH 1/4] soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST

2024-07-09 Thread Vladimir Oltean
Hi Breno, On Mon, Jul 08, 2024 at 12:08:05PM -0700, Breno Leitao wrote: > I thought about a patch like the following (compile tested only). What > do you think? To be honest, there are several things I don't really like about this patch. - I really struggled with applying it in the current forma

Re: [PATCH v3] PowerPC: Replace kretprobe with rethook

2024-07-09 Thread Google
On Tue, 09 Jul 2024 12:28:29 +0530 Naveen N Rao wrote: > Masami Hiramatsu wrote: > > On Thu, 27 Jun 2024 09:21:01 -0400 > > Abhishek Dubey wrote: > > > >> +/* rethook initializer */ > >> +int __init arch_init_kprobes(void) > >> +{ > >> + return register_kprobe(&trampoline_p); > >> +} > > > >

Re: [PATCH 1/4] soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST

2024-07-09 Thread Breno Leitao
Hello Vladimir, On Tue, Jul 09, 2024 at 04:58:11PM +0300, Vladimir Oltean wrote: > On Mon, Jul 08, 2024 at 12:08:05PM -0700, Breno Leitao wrote: > > I thought about a patch like the following (compile tested only). What > > do you think? > > To be honest, there are several things I don't really

Re: [PATCH 1/4] soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST

2024-07-09 Thread Vladimir Oltean
On Tue, Jul 09, 2024 at 08:15:23AM -0700, Breno Leitao wrote: > Hello Vladimir, > > On Tue, Jul 09, 2024 at 04:58:11PM +0300, Vladimir Oltean wrote: > > > On Mon, Jul 08, 2024 at 12:08:05PM -0700, Breno Leitao wrote: > > > I thought about a patch like the following (compile tested only). What > >

[PATCH] Documentation/powerpc: Remove retired CPUs from list of supported CPUs

2024-07-09 Thread Christophe Leroy
601, power4, 401, 403, 405, e200 and IBM-A2 support was removed by by following commits: - Commit 8b14e1dff067 ("powerpc: Remove support for PowerPC 601") - Commit 471d7ff8b51b ("powerpc/64s: Remove POWER4 support") - Commit 1b5c0967ab8a ("powerpc/40x: Remove support for IBM 403GCX") - Commit 39c8b

Re: [PATCH 11/13] huge_memory: Remove dead vmf_insert_pXd code

2024-07-09 Thread Peter Xu
On Tue, Jul 09, 2024 at 02:07:31PM +1000, Alistair Popple wrote: > > Peter Xu writes: > > > Hi, Alistair, > > > > On Thu, Jun 27, 2024 at 10:54:26AM +1000, Alistair Popple wrote: > >> Now that DAX is managing page reference counts the same as normal > >> pages there are no callers for vmf_insert

[PATCH AUTOSEL 6.9 33/40] ibmvnic: Add tx check to prevent skb leak

2024-07-09 Thread Sasha Levin
From: Nick Child [ Upstream commit 0983d288caf984de0202c66641577b739caad561 ] Below is a summary of how the driver stores a reference to an skb during transmit: tx_buff[free_map[consumer_index]]->skb = new_skb; free_map[consumer_index] = IBMVNIC_INVALID_MAP; consumer_index ++; Where

[PATCH AUTOSEL 6.6 27/33] ibmvnic: Add tx check to prevent skb leak

2024-07-09 Thread Sasha Levin
From: Nick Child [ Upstream commit 0983d288caf984de0202c66641577b739caad561 ] Below is a summary of how the driver stores a reference to an skb during transmit: tx_buff[free_map[consumer_index]]->skb = new_skb; free_map[consumer_index] = IBMVNIC_INVALID_MAP; consumer_index ++; Where

[PATCH AUTOSEL 6.1 21/27] ibmvnic: Add tx check to prevent skb leak

2024-07-09 Thread Sasha Levin
From: Nick Child [ Upstream commit 0983d288caf984de0202c66641577b739caad561 ] Below is a summary of how the driver stores a reference to an skb during transmit: tx_buff[free_map[consumer_index]]->skb = new_skb; free_map[consumer_index] = IBMVNIC_INVALID_MAP; consumer_index ++; Where

Re: [PATCH v2 7/8] mm/x86: Add missing pud helpers

2024-07-09 Thread Peter Xu
On Sat, Jul 06, 2024 at 05:16:15PM +0800, kernel test robot wrote: > Hi Peter, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: > https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-dax-Dump-start-address-in-fault-

[PATCH] powerpc-km82xx.c: replace of_node_put with __free improves cleanup

2024-07-09 Thread David Hunter
The use of the __free function allows the cleanup to be based on scope instead of on another function called later. This makes the cleanup automatic and less susceptible to errors later. This code was compiled without errors or warnings. Signed-off-by: David Hunter --- arch/powerpc/platforms/82

[powerpc:merge] BUILD SUCCESS 79d16b1da1df0b2e70193ac54d34a8efc5750e24

2024-07-09 Thread kernel test robot
defconfig gcc-13.2.0 arc allmodconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc randconfig-001-2024

Fwd: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-09 Thread Damien Stewart
On 9/7/24 10:48 pm, Michael Ellerman wrote: Thanks. Which kernel is the bad log from? Just plain rc6 with no patches? So, no, the bad log is actually from a patched kernel. I've attached the diff for clarity. What happened when you tried the patch from me? I think Christian called it vmlin

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-09 Thread Christian Zigotzky
Hi All, The RC7 of kernel 6.10 boots without any problems [1] if we use the second irq patch [2]. Is it possible to add this patch to the mainline kernel? Thanks, Christian [1] https://forum.hyperion-entertainment.com/viewtopic.php?p=58643#p58643 [2] https://github.com/chzigotzky/kernels/bl