Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:52 PM, Christoph Hellwig wrote: > On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote: >>> - if (lim->zoned) >>> + if (sdkp->device->type == TYPE_ZBC) >> >> Nit: use sd_is_zoned() here ? > > Yes. > >>> - if (!sd_is_zoned(sdkp)) >>> + if (!sd_is_zoned(sdkp)) { >>> +

Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:54 PM, Christoph Hellwig wrote: > On Tue, Jun 11, 2024 at 07:52:39AM +0200, Christoph Hellwig wrote: >>> Maybe we should clear the other zone related limits here ? If the drive is >>> reformatted/converted from SMR to CMR (FORMAT WITH PRESET), the other zone >>> limits may be set alrea

Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > virtblk_update_cache_mode boils down to a single call to > blk_queue_write_cache. Remove it in preparation for moving the cache > control flags into the queue_limits. > > Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal -- Damien Le

Re: [PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move setting the cache control flags in nbd in preparation for moving > these flags into the queue_limits structure. > > Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research

Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > blkfront always had a robust negotiation protocol for detecting a write > cache. Stop simply disabling cache flushes when they fail as that is > a grave error. > > Signed-off-by: Christoph Hellwig Looks good to me but maybe mention that removal of

Re: [PATCH 11/26] block: freeze the queue in queue_attr_store

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > queue_attr_store updates attributes used to control generating I/O, and > can cause malformed bios if changed with I/O in flight. Freeze the queue > in common code instead of adding it to almost every attribute. > > Signed-off-by: Christoph Hellwig

Re: [PATCH 12/26] block: remove blk_flush_policy

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Fold blk_flush_policy into the only caller to prepare for pending changes > to it. > > Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research

Re: [PATCH 13/26] block: move cache control settings out of queue->flags

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the cache control settings into the queue_limits so that they > can be set atomically and all I/O is frozen when changing the > flags. ...so that they can be set atomically with the device queue frozen when changing the flags. may be better. >

Re: [PATCH] watchdog/core: Fix AA deadlock due to watchdog holding cpu_hotplug_lock and wait for wq

2024-06-11 Thread kernel test robot
try/entry_64.S:257) [ 87.535111][T9] The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20240611/202406111537.dd9d27e9-...@intel.com -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

Re: [PATCH 14/26] block: move the nonrot flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the norot flag into the queue_limits feature field so that it can be s/norot/nonrot > set atomically and all I/O is frozen when changing the flag. and... -> with the queue frozen when... ? > > Use the chance to switch to defaulting to non-rot

Re: [PATCH 15/26] block: move the add_random flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the add_random flag into the queue_limits feature field so that it > can be set atomically and all I/O is frozen when changing the flag. Same remark as the previous patches for the end of this sentence.c > > Note that this also removes code fro

Re: [PATCH 16/26] block: move the io_stat flag setting to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the io_stat flag into the queue_limits feature field so that it > can be set atomically and all I/O is frozen when changing the flag. Why a feature ? It seems more appropriate for io_stat to be a flag rather than a feature as that is a block laye

Re: [PATCH 17/26] block: move the stable_write flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the io_stat flag into the queue_limits feature field so that it can s/io_stat/stable_write > be set atomically and all I/O is frozen when changing the flag. > > The flag is now inherited by blk_stack_limits, which greatly simplifies > the code

Re: [PATCH 18/26] block: move the synchronous flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the synchronous flag into the queue_limits feature field so that it > can be set atomically and all I/O is frozen when changing the flag. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western

Re: [PATCH 03/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: __loop_clr_fd wants to clear all settings on the device. Prepare for moving more settings into the block limits by open coding loop_reconfigure_limits. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 10 +- 1 file changed, 9 ins

Re: [PATCH 04/26] loop: always update discard settings in loop_reconfigure_limits

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: Simplify loop_reconfigure_limits by always updating the discard limits. This adds a little more work to loop_set_block_size, but doesn't change the outcome as the discard flag won't change. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c |

Re: [PATCH 19/26] block: move the nowait flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the nowait flag into the queue_limits feature field so that it > can be set atomically and all I/O is frozen when changing the flag. > > Stacking drivers are simplified in that they now can simply set the > flag, and blk_stack_limits will clear i

Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: The LOOP_CONFIGURE path automatically upgrades the block size to that of the underlying file for O_DIRECT file descriptors, but the LOOP_SET_BLOCK_SIZE path does not. Fix this by lifting the code to pick the block size into common code. Signed-off-by:

Re: [PATCH 20/26] block: move the dax flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the dax flag into the queue_limits feature field so that it > can be set atomically and all I/O is frozen when changing the flag. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital

Re: [PATCH 06/26] loop: also use the default block size from an underlying block device

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: Fix the code in loop_reconfigure_limits to pick a default block size for O_DIRECT file descriptors to also work when the loop device sits on top of a block device and not just on a regular file on a block device based file system. Signed-off-by: Christo

Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: Move a bit of code that sets up the zone flag and the write granularity into sd_zbc_read_zones to be with the rest of the zoned limits. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 21 + drivers/scsi/sd_zbc.c | 13

Re: [PATCH 01/26] sd: fix sd_is_zoned

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: Since commit 7437bb73f087 ("block: remove support for the host aware zone model"), only ZBC devices expose a zoned access model. sd_is_zoned is used to check for that and thus return false for host aware devices. Fixes: 7437bb73f087 ("block: remove sup

Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: This prepares for moving the rotational flag into the queue_limits and also fixes it for the case where the loop device is backed by a block device. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 23 --- 1 file chang

Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: virtblk_update_cache_mode boils down to a single call to blk_queue_write_cache. Remove it in preparation for moving the cache control flags into the queue_limits. Signed-off-by: Christoph Hellwig --- drivers/block/virtio_blk.c | 13 +++-- 1

Re: [PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: Move setting the cache control flags in nbd in preparation for moving these flags into the queue_limits structure. Signed-off-by: Christoph Hellwig --- drivers/block/nbd.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) Re

Re: [PATCH 21/26] block: move the poll flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the poll flag into the queue_limits feature field so that it > can be set atomically and all I/O is frozen when changing the flag. > > Stacking drivers are simplified in that they now can simply set the > flag, and blk_stack_limits will clear it

Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: blkfront always had a robust negotiation protocol for detecting a write cache. Stop simply disabling cache flushes when they fail as that is a grave error. Signed-off-by: Christoph Hellwig --- drivers/block/xen-blkfront.c | 29 +-

Re: [PATCH 11/26] block: freeze the queue in queue_attr_store

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: queue_attr_store updates attributes used to control generating I/O, and can cause malformed bios if changed with I/O in flight. Freeze the queue in common code instead of adding it to almost every attribute. Signed-off-by: Christoph Hellwig --- bloc

Re: [PATCH 22/26] block: move the zoned flag into the feature field

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the boolean zoned field into the flags field to reclaim a little > bit of space. Nit: flags -> feature flags > > Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research

Re: [PATCH 12/26] block: remove blk_flush_policy

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: Fold blk_flush_policy into the only caller to prepare for pending changes to it. Signed-off-by: Christoph Hellwig --- block/blk-flush.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) Reviewed-by: Hannes R

Re: [PATCH 23/26] block: move the zone_resetall flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the zone_resetall flag into the queue_limits feature field so that > it can be set atomically and all I/O is frozen when changing the flag. > > Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Re

Re: [PATCH 24/26] block: move the pci_p2pdma flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the pci_p2pdma flag into the queue_limits feature field so that it > can be set atomically and all I/O is frozen when changing the flag. > > Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Resea

Re: [PATCH 25/26] block: move the skip_tagset_quiesce flag to queue_limits

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the skip_tagset_quiesce flag into the queue_limits feature field so > that it can be set atomically and all I/O is frozen when changing the > flag. > > Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal -- Damien Le Moal Western Di

Re: [PATCH 26/26] block: move the bounce flag into the feature field

2024-06-11 Thread Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote: > Move the bounce field into the flags field to reclaim a little bit of s/flags/feature > space. > > Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research

Re: [PATCH 1/2] dt-bindings: Drop Li Yang as maintainer for all bindings

2024-06-11 Thread Krzysztof Kozlowski
On 04/06/2024 16:22, Michael Walle wrote: > Remove Li Yang from all device tree bindings because mails to this > address are bouncing. > > Commit fbdd90334a62 ("MAINTAINERS: Drop Li Yang as their email address > stopped working") already removed the entry from the MAINTAINERS but > didn't address

Re: [RFC PATCH 2/2] dt-bindings: memory: fsl: replace maintainer

2024-06-11 Thread Krzysztof Kozlowski
On 04/06/2024 16:22, Michael Walle wrote: > Li Yang's mail address is bouncing, replace it with Shawn Guo's one. > > Signed-off-by: Michael Walle > --- > This is marked as an RFC because it is more of a question for Shawn if > he is willing to take over the maintainership. > --- I suppose this c

Re: [PATCH 3/6] mips: defconfig: drop RT_GROUP_SCHED=y from generic/db1xxx/eyeq5

2024-06-11 Thread Thomas Bogendoerfer
On Thu, May 30, 2024 at 07:19:51PM +0800, Celeste Liu wrote: > For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it > needs an RT budget assigned, otherwise the processes in it will not be able to > get RT at all. The problem with RT group scheduling is that it requires the

Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

2024-06-11 Thread Oscar Salvador
On Mon, Jun 10, 2024 at 07:54:47AM +0200, Christophe Leroy wrote: > On powerpc 8xx, when a page is 8M size, the information is in the PMD > entry. So allow architectures to provide __pte_leaf_size() instead of > pte_leaf_size() and provide the PMD entry to that function. > > When __pte_leaf_size()

Re: [PATCH 13/26] block: move cache control settings out of queue->flags

2024-06-11 Thread Hannes Reinecke
On 6/11/24 07:19, Christoph Hellwig wrote: Move the cache control settings into the queue_limits so that they can be set atomically and all I/O is frozen when changing the flags. Add new features and flags field for the driver set flags, and internal (usually sysfs-controlled) flags in the block

Re: [Patch v2 1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs

2024-06-11 Thread Krzysztof Kozlowski
On 11/06/2024 11:47, Piotr Wojtaszczyk wrote: > This driver was ported from an old version in linux 2.6.27 and adjusted > for the new ASoC framework and DMA API. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v2: > - Coding Style cleanup > - Use dev_err_probe() for error handling in pro

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Krzysztof Kozlowski
On 11/06/2024 11:47, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk > --- > + > +maintainers: > + - Piotr Wojtaszczyk > + > +properties: > + compatible: > +enum: > + - nxp,lpc3220-i2s > + > + reg: > +maxItems: 1 > +

Re: [Patch v2 1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs

2024-06-11 Thread Mark Brown
On Tue, Jun 11, 2024 at 11:47:51AM +0200, Piotr Wojtaszczyk wrote: > arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 4 + > arch/arm/mach-lpc32xx/phy3250.c| 60 These architecture changes are separate and should at least be separate commits, copied to the architecture maintainers. > +FR

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Mark Brown
On Tue, Jun 11, 2024 at 11:47:52AM +0200, Piotr Wojtaszczyk wrote: > Changes for v2: > - Added maintainers field > - Dropped clock-names > - Dropped unused unneded interrupts field > +required: > + - compatible > + - reg > + - clocks > + - clock-names Some of the dropping of clock-names was

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Krzysztof Kozlowski
On 11/06/2024 11:47, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v2: > - Added maintainers field > - Dropped clock-names > - Dropped unused unneded interrupts field Does the device has interrupts or not? This s

Re: [PATCH 01/26] sd: fix sd_is_zoned

2024-06-11 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Rob Herring (Arm)
On Tue, 11 Jun 2024 11:47:52 +0200, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v2: > - Added maintainers field > - Dropped clock-names > - Dropped unused unneded interrupts field > > .../bindings/sound/nxp,

Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode

2024-06-11 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

[Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Piotr Wojtaszczyk
Add nxp,lpc3220-i2s DT binding documentation. Signed-off-by: Piotr Wojtaszczyk --- Changes for v2: - Added maintainers field - Dropped clock-names - Dropped unused unneded interrupts field .../bindings/sound/nxp,lpc3220-i2s.yaml | 47 +++ 1 file changed, 47 insertions(+)

[Patch v2 1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs

2024-06-11 Thread Piotr Wojtaszczyk
This driver was ported from an old version in linux 2.6.27 and adjusted for the new ASoC framework and DMA API. Signed-off-by: Piotr Wojtaszczyk --- Changes for v2: - Coding Style cleanup - Use dev_err_probe() for error handling in probe function - Removed unneded err_clk_disable label - Removed

[PATCH v3 0/6] powerpc: pSeries: vfio: iommu: Re-enable support for SPAPR TCE VFIO

2024-06-11 Thread Shivaprasad G Bhat
The patches reimplement the iommu table_group_ops for pSeries for VFIO SPAPR TCE sub-driver thereby bringing consistency with PowerNV implementation and getting rid of limitations/bugs which were emanating from these differences on the earlier approach on pSeries. Structure of the patchset: --

[PATCH v3 1/6] powerpc/iommu: Move pSeries specific functions to pseries/iommu.c

2024-06-11 Thread Shivaprasad G Bhat
The PowerNV specific table_group_ops are defined in powernv/pci-ioda.c. The pSeries specific table_group_ops are sitting in the generic powerpc file. Move it to where it actually belong(pseries/iommu.c). Only code movement, no functional changes intended. Signed-off-by: Shivaprasad G Bhat --- a

[PATCH v3 2/6] powerpc/pseries/iommu: Fix the VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl output

2024-06-11 Thread Shivaprasad G Bhat
The ioctl VFIO_IOMMU_SPAPR_TCE_GET_INFO is not reporting the actuals on the platform as not all the details are correctly collected during the platform probe/scan into the iommu_table_group. Collect the information during the device setup time as the DMA window property is already looked up on par

[PATCH v3 3/6] powerpc/pseries/iommu: Use the iommu table[0] for IOV VF's DDW

2024-06-11 Thread Shivaprasad G Bhat
This patch basically brings consistency with PowerNV approach to use the first freely available iommu table when the default window is removed. The pSeries iommu code convention has been that the table[0] is for the default 32 bit DMA window and the table[1] is for the 64 bit DDW. With VFs having

[PATCH v3 4/6] vfio/spapr: Always clear TCEs before unsetting the window

2024-06-11 Thread Shivaprasad G Bhat
The PAPR expects the TCE table to have no entries at the time of unset window(i.e. remove-pe). The TCE clear right now is done before freeing the iommu table. On pSeries, the unset window makes those entries inaccessible to the OS and the H_PUT/GET calls fail on them with H_CONSTRAINED. On PowerNV

[PATCH v3 5/6] powerpc/iommu: Move dev_has_iommu_table() to iommu.c

2024-06-11 Thread Shivaprasad G Bhat
Move function dev_has_iommu_table() to powerpc/kernel/iommu.c as it is going to be used by machine specific iommu code as well in subsequent patches. Signed-off-by: Shivaprasad G Bhat --- arch/powerpc/include/asm/iommu.h |1 + arch/powerpc/kernel/eeh.c| 16 arch/po

[PATCH v3 6/6] powerpc/iommu: Reimplement the iommu_table_group_ops for pSeries

2024-06-11 Thread Shivaprasad G Bhat
PPC64 IOMMU API defines iommu_table_group_ops which handles DMA windows for PEs, their ownership transfer, create/set/unset the TCE tables for the Dynamic DMA wundows(DDW). VFIOS uses these APIs for support on POWER. The commit 9d67c9433509 ("powerpc/iommu: Add "borrowing" iommu_table_group_ops")

Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

2024-06-11 Thread Peter Xu
Oscar, On Tue, Jun 11, 2024 at 11:34:23AM +0200, Oscar Salvador wrote: > Which means that they would be caught in the following code: > > ptl = pmd_huge_lock(pmd, vma); > if (ptl) { > - 8MB hugepages will be handled here > smaps_pmd_entry(pmd, addr, w

Re: [RFC PATCH v2 2/5] powerpc/ftrace: Remove pointer to struct module from dyn_arch_ftrace

2024-06-11 Thread Naveen N Rao
On Mon, Jun 10, 2024 at 04:03:56PM GMT, Steven Rostedt wrote: > On Mon, 10 Jun 2024 14:08:15 +0530 > Naveen N Rao wrote: > > > Pointer to struct module is only relevant for ftrace records belonging > > to kernel modules. Having this field in dyn_arch_ftrace wastes memory > > for all ftrace record

Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

2024-06-11 Thread LEROY Christophe
Le 11/06/2024 à 11:34, Oscar Salvador a écrit : > [Vous ne recevez pas souvent de courriers de osalva...@suse.de. D?couvrez > pourquoi ceci est important ? https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 10, 2024 at 07:54:47AM +0200, Christophe Leroy wrote: >> On powerpc 8xx, wh

Re: [RFC PATCH v2 3/5] powerpc/ftrace: Unify 32-bit and 64-bit ftrace entry code

2024-06-11 Thread Naveen N Rao
On Mon, Jun 10, 2024 at 04:06:32PM GMT, Steven Rostedt wrote: > On Mon, 10 Jun 2024 14:08:16 +0530 > Naveen N Rao wrote: > > > On 32-bit powerpc, gcc generates a three instruction sequence for > > function profiling: > > mflrr0 > > stw r0, 4(r1) > > bl _mcount > > > > On

Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

2024-06-11 Thread Oscar Salvador
On Tue, Jun 11, 2024 at 10:17:30AM -0400, Peter Xu wrote: > Oscar, > > On Tue, Jun 11, 2024 at 11:34:23AM +0200, Oscar Salvador wrote: > > Which means that they would be caught in the following code: > > > > ptl = pmd_huge_lock(pmd, vma); > > if (ptl) { > > - 8MB hugep

Re: [RFC PATCH v2 3/5] powerpc/ftrace: Unify 32-bit and 64-bit ftrace entry code

2024-06-11 Thread Steven Rostedt
On Tue, 11 Jun 2024 20:17:19 +0530 Naveen N Rao wrote: > > I know it's very unlikely, but in theory, I think the race exists. > > I *think* you are assuming that we will be patching back the 'stw' Yes, that was what I was assuming :-p > instruction here? So, there could be an issue if a cpu

Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

2024-06-11 Thread Peter Xu
On Tue, Jun 11, 2024 at 05:08:45PM +0200, Oscar Salvador wrote: > The problem is that we do not have spare bits for 8xx to mark these ptes > as cont-ptes or mark them pte as 8MB, so I do not see a clear path on how > we could remove huge_ptep_get for 8xx. Right, I remember I thought about this too

Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

2024-06-11 Thread Oscar Salvador
On Tue, Jun 11, 2024 at 11:20:01AM -0400, Peter Xu wrote: > On Tue, Jun 11, 2024 at 05:08:45PM +0200, Oscar Salvador wrote: > > The problem is that we do not have spare bits for 8xx to mark these ptes > > as cont-ptes or mark them pte as 8MB, so I do not see a clear path on how > > we could remove

Re: [PATCH V3 11/14] tools/perf: Add support to use libcapstone in powerpc

2024-06-11 Thread Adrian Hunter
On 10/06/24 15:20, Athira Rajeev wrote: > > >> On 3 Jun 2024, at 10:28 PM, Adrian Hunter wrote: >> >> On 3/06/24 19:30, Ian Rogers wrote: >>> On Fri, May 31, 2024 at 11:10 PM Athira Rajeev >>> wrote: Now perf uses the capstone library to disassemble the instructions in x86. capst

Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

2024-06-11 Thread LEROY Christophe
Le 11/06/2024 à 17:08, Oscar Salvador a écrit : > [Vous ne recevez pas souvent de courriers de osalva...@suse.de. D?couvrez > pourquoi ceci est important ? https://aka.ms/LearnAboutSenderIdentification ] > > On Tue, Jun 11, 2024 at 10:17:30AM -0400, Peter Xu wrote: >> Oscar, >> >> On Tue, Jun 1

Re: [RFC PATCH v2 4/5] kbuild: Add generic hook for architectures to use before the final vmlinux link

2024-06-11 Thread Naveen N Rao
On Tue, Jun 11, 2024 at 06:51:51AM GMT, Masahiro Yamada wrote: > On Tue, Jun 11, 2024 at 2:20 AM Naveen N Rao wrote: > > > > On Mon, Jun 10, 2024 at 06:14:51PM GMT, Masahiro Yamada wrote: > > > On Mon, Jun 10, 2024 at 5:39 PM Naveen N Rao wrote: > > > > > > > > On powerpc, we would like to be abl

Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

2024-06-11 Thread LEROY Christophe
Le 11/06/2024 à 18:10, Oscar Salvador a écrit : > [Vous ne recevez pas souvent de courriers de osalva...@suse.de. D?couvrez > pourquoi ceci est important ? https://aka.ms/LearnAboutSenderIdentification ] > > On Tue, Jun 11, 2024 at 11:20:01AM -0400, Peter Xu wrote: >> On Tue, Jun 11, 2024 at 05

Re: [PATCH 03/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: __loop_clr_fd wants to clear all settings on the device. Prepare for moving more settings into the block limits by open coding loop_reconfigure_limits. If Damien's comment is addressed, feel free to add: Reviewed-by: Bart Van Assche

Re: [PATCH 01/26] sd: fix sd_is_zoned

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: Since commit 7437bb73f087 ("block: remove support for the host aware zone model"), only ZBC devices expose a zoned access model. sd_is_zoned is used to check for that and thus return false for host aware devices. Reviewed-by: Bart Van Assche

Re: [PATCH 04/26] loop: always update discard settings in loop_reconfigure_limits

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: Simplify loop_reconfigure_limits by always updating the discard limits. This adds a little more work to loop_set_block_size, but doesn't change the outcome as the discard flag won't change. Reviewed-by: Bart Van Assche

Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: The LOOP_CONFIGURE path automatically upgrades the block size to that of the underlying file for O_DIRECT file descriptors, but the LOOP_SET_BLOCK_SIZE path does not. Fix this by lifting the code to pick the block size into common code. Reviewed-by

Re: [PATCH 06/26] loop: also use the default block size from an underlying block device

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: Fix the code in loop_reconfigure_limits to pick a default block size for O_DIRECT file descriptors to also work when the loop device sits on top of a block device and not just on a regular file on a block device based file system. Reviewed-by: Bart

Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: This prepares for moving the rotational flag into the queue_limits and also fixes it for the case where the loop device is backed by a block device. Reviewed-by: Bart Van Assche

Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: virtblk_update_cache_mode boils down to a single call to blk_queue_write_cache. Remove it in preparation for moving the cache control flags into the queue_limits. Reviewed-by: Bart Van Assche

Re: [PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: Move setting the cache control flags in nbd in preparation for moving these flags into the queue_limits structure. Reviewed-by: Bart Van Assche

Re: [PATCH 11/26] block: freeze the queue in queue_attr_store

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: queue_attr_store updates attributes used to control generating I/O, and can cause malformed bios if changed with I/O in flight. Freeze the queue in common code instead of adding it to almost every attribute. Reviewed-by: Bart Van Assche

Re: [PATCH 12/26] block: remove blk_flush_policy

2024-06-11 Thread Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote: Fold blk_flush_policy into the only caller to prepare for pending changes to it. Reviewed-by: Bart Van Assche

Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

2024-06-11 Thread Peter Xu
On Tue, Jun 11, 2024 at 07:00:14PM +, LEROY Christophe wrote: > But what about something like > > static inline pte_t pmd_pte(pmd_t pmd) > { > return *(pte_t *)pmd_page_vaddr(pmd); > } > > Would it do the trick ? > > Of course it would require to carefully make sure all accesses are do

Re: [PATCH 2/5] PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers

2024-06-11 Thread Bjorn Helgaas
On Thu, Jun 06, 2024 at 12:56:35PM +0530, Manivannan Sadhasivam wrote: > As like the 'epc_init' event, that is used to signal the EPF drivers about > the EPC initialization, let's introduce 'epc_deinit' event that is used to > signal EPC deinitialization. > > The EPC deinitialization applies only

Re: [PATCH v2 0/6] KVM: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load()

2024-06-11 Thread Sean Christopherson
On Tue, 21 May 2024 18:40:07 -0700, Sean Christopherson wrote: > Drop kvm_arch_sched_in() and instead add and use kvm_vcpu.scheduled_out > to communicate to kvm_arch_vcpu_load() that the vCPU is being scheduling > back in. > > While fiddling with an idea for optimizing state management on AMD CPUs

Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode

2024-06-11 Thread Stefan Hajnoczi
On Tue, Jun 11, 2024 at 07:19:08AM +0200, Christoph Hellwig wrote: > virtblk_update_cache_mode boils down to a single call to > blk_queue_write_cache. Remove it in preparation for moving the cache > control flags into the queue_limits. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/

Re: [PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size

2024-06-11 Thread Josef Bacik
On Tue, Jun 11, 2024 at 07:19:09AM +0200, Christoph Hellwig wrote: > Move setting the cache control flags in nbd in preparation for moving > these flags into the queue_limits structure. > > Signed-off-by: Christoph Hellwig Reviewed-by: Josef Bacik Thanks, Josef

Re: [PATCH 2/5] PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers

2024-06-11 Thread Manivannan Sadhasivam
On Tue, Jun 11, 2024 at 05:06:40PM -0500, Bjorn Helgaas wrote: > On Thu, Jun 06, 2024 at 12:56:35PM +0530, Manivannan Sadhasivam wrote: > > As like the 'epc_init' event, that is used to signal the EPF drivers about > > the EPC initialization, let's introduce 'epc_deinit' event that is used to > > s

[kvm-unit-tests PATCH] build: retain intermediate .aux.o targets

2024-06-11 Thread Nicholas Piggin
arm, powerpc, riscv, build .aux.o targets with implicit pattern rules in dependency chains that cause them to be made as intermediate files, which get removed when make finishes. This results in unnecessary partial rebuilds. If make is run again, this time the .aux.o targets are not intermediate, p

Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics

2024-06-11 Thread Christoph Hellwig
On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote: > > - if (!sd_is_zoned(sdkp)) > > + if (!sd_is_zoned(sdkp)) { > > + lim->zoned = false; > > Maybe we should clear the other zone related limits here ? If the drive is > reformatted/converted from SMR to CMR (FORMAT WITH

Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail

2024-06-11 Thread Christoph Hellwig
On Tue, Jun 11, 2024 at 04:30:39PM +0900, Damien Le Moal wrote: > On 6/11/24 2:19 PM, Christoph Hellwig wrote: > > blkfront always had a robust negotiation protocol for detecting a write > > cache. Stop simply disabling cache flushes when they fail as that is > > a grave error. > > > > Signed-off

Re: [PATCH 13/26] block: move cache control settings out of queue->flags

2024-06-11 Thread Christoph Hellwig
A friendly reminder that I've skipped over the full quote. Please properly quote mails if you want your replies to be seen.

Re: [PATCH 13/26] block: move cache control settings out of queue->flags

2024-06-11 Thread Christoph Hellwig
On Tue, Jun 11, 2024 at 04:55:04PM +0900, Damien Le Moal wrote: > On 6/11/24 2:19 PM, Christoph Hellwig wrote: > > Move the cache control settings into the queue_limits so that they > > can be set atomically and all I/O is frozen when changing the > > flags. > > ...so that they can be set atomical

Re: [PATCH 16/26] block: move the io_stat flag setting to queue_limits

2024-06-11 Thread Christoph Hellwig
On Tue, Jun 11, 2024 at 05:09:45PM +0900, Damien Le Moal wrote: > On 6/11/24 2:19 PM, Christoph Hellwig wrote: > > Move the io_stat flag into the queue_limits feature field so that it > > can be set atomically and all I/O is frozen when changing the flag. > > Why a feature ? It seems more appropri

Re: [PATCH 19/26] block: move the nowait flag to queue_limits

2024-06-11 Thread Christoph Hellwig
On Tue, Jun 11, 2024 at 05:16:37PM +0900, Damien Le Moal wrote: > > @@ -1825,9 +1815,7 @@ int dm_table_set_restrictions(struct dm_table *t, > > struct request_queue *q, > > int r; > > > > if (dm_table_supports_nowait(t)) > > - blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q); > > - e

Re: [PATCH 21/26] block: move the poll flag to queue_limits

2024-06-11 Thread Christoph Hellwig
On Tue, Jun 11, 2024 at 05:21:07PM +0900, Damien Le Moal wrote: > Kind of the same remark as for io_stat about this not really being a device > feature. But I guess seeing "features" as a queue feature rather than just a > device feature makes it OK to have poll (and io_stat) as a feature rather th

[kvm-unit-tests PATCH v10 00/15] powerpc improvements

2024-06-11 Thread Nicholas Piggin
Tree here https://gitlab.com/npiggin/kvm-unit-tests/-/tree/powerpc Since v9: - Rebase after a good chunk of patches were merged. - Review from Thomas: - TCG/KVM host query is moved to the start of the series. - Changelog for atomics test. - Dropped spinlock patch change for now. - Fixed t

[kvm-unit-tests PATCH v10 01/15] powerpc: Add facility to query TCG or KVM host

2024-06-11 Thread Nicholas Piggin
Use device tree properties to determine whether KVM or TCG is in use. Logically these are not the inverse of one another, because KVM can run on a TCG processor (if TCG is emulating HV mode, or it is using the nested hypervisor APIs in pseries / spapr). And kvm-unit-tests can run on that KVM. Thi

[kvm-unit-tests PATCH v10 02/15] powerpc: Add atomics tests

2024-06-11 Thread Nicholas Piggin
Add some tests for larx/stcx. operations for certain edge cases including migration, as well as some simple performance tests. Signed-off-by: Nicholas Piggin --- powerpc/Makefile.common | 1 + powerpc/atomics.c | 386 powerpc/unittests.cfg | 10

[kvm-unit-tests PATCH v10 03/15] powerpc: Add timebase tests

2024-06-11 Thread Nicholas Piggin
This has a known failure on QEMU TCG machines where the decrementer interrupt is not lowered when the DEC wraps from -ve to +ve. Signed-off-by: Nicholas Piggin --- lib/powerpc/asm/reg.h | 1 + powerpc/Makefile.common | 1 + powerpc/timebase.c | 350

[kvm-unit-tests PATCH v10 04/15] powerpc: Add MMU support

2024-06-11 Thread Nicholas Piggin
Add support for radix MMU, 4kB and 64kB pages. This also adds MMU interrupt test cases, and runs the interrupts test entirely with MMU enabled if it is available (aside from machine check tests). Acked-by: Andrew Jones (configure changes) Signed-off-by: Nicholas Piggin --- configure

[kvm-unit-tests PATCH v10 05/15] common/sieve: Support machines without MMU

2024-06-11 Thread Nicholas Piggin
Not all powerpc CPUs provide MMU support. Define vm_available() that is true by default but archs can override it. Use this to run VM tests. Reviewed-by: Thomas Huth Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- common/sieve.c | 14 -- lib/ppc64/asm/mmu.h | 1 -

[kvm-unit-tests PATCH v10 06/15] powerpc: Add sieve.c common test

2024-06-11 Thread Nicholas Piggin
Now that sieve copes with lack of MMU support, it can be run by powerpc. Reviewed-by: Thomas Huth Signed-off-by: Nicholas Piggin --- powerpc/Makefile.common | 1 + powerpc/sieve.c | 1 + powerpc/unittests.cfg | 3 +++ 3 files changed, 5 insertions(+) create mode 12 powerpc/sieve.

[kvm-unit-tests PATCH v10 07/15] powerpc: add usermode support

2024-06-11 Thread Nicholas Piggin
The biggest difficulty for user mode is MMU support. Otherwise it is a simple matter of setting and clearing MSR[PR] with rfid and sc respectively. Some common harness operations will fail in usermode, so some workarounds are reqiured (e.g., puts() can't be used directly). A usermode privileged i

  1   2   >