Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Cancel pending HDEC exception

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone. Was this regression ever resolved? Doesn't look like it, but maybe I just missed something. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Every

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

On Thu, Apr 4, 2024 at 8:07 AM Jiri Slaby wrote: > On 04. 04. 24, 0:29, Andy Shevchenko wrote: > >> Cc: Benjamin Herrenschmidt > >> Cc: Michael Ellerman > >> Cc: Nicholas Piggin > >> Cc: Christophe Leroy > >> Cc: "Aneesh Kumar K.V" > >> Cc: "Naveen N. Rao" > >> Cc: linux-m...@lists.linux-m6

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote: > On Thu, 4 Apr 2024, Andy Shevchenko wrote: ... > > > Cc: Benjamin Herrenschmidt > > > Cc: Michael Ellerman > > > Cc: Nicholas Piggin > > > Cc: Christophe Leroy > > > Cc: "Aneesh Kumar K.V" > > > Cc: "Naveen N. Rao" > > > Cc: linux-m...@lis

Re: [PATCH v2 1/2] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

On Wed, Apr 03, 2024 at 01:02:05PM +0300, Ilpo Järvinen wrote: > pcie_read_tlp_log() handles only 4 TLP Header Log DWORDs but TLP Prefix > Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present. > > Generalize pcie_read_tlp_log() and struct pcie_tlp_log to handle also > TLP Prefix Log. The

Re: [PATCH v2 1/2] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

On Thu, 4 Apr 2024, Lukas Wunner wrote: > On Wed, Apr 03, 2024 at 01:02:05PM +0300, Ilpo Järvinen wrote: > > pcie_read_tlp_log() handles only 4 TLP Header Log DWORDs but TLP Prefix > > Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present. > > > > Generalize pcie_read_tlp_log() and struct

Re: [PATCH v4 05/13] mm/arch: Provide pud_pfn() fallback

On Wed, Apr 03, 2024 at 02:25:20PM -0400, Peter Xu wrote: > > I'd say the BUILD_BUG has done it's job and found an issue, fix it by > > not defining pud_leaf? I don't see any calls to pud_leaf in loongarch > > at least > > Yes, that sounds better too to me, however it means we may also risk other

Re: [RFC PATCH 1/8] mm: Provide pagesize to pmd_populate()

On Wed, Apr 03, 2024 at 06:24:38PM +, Christophe Leroy wrote: > > If it is a software walker there might be value in just aligning to > > the contig pte scheme in all levels and forgetting about the variable > > size page table levels. That quarter page stuff is a PITA to manage > > the memory

Re: [PATCH v4 05/13] mm/arch: Provide pud_pfn() fallback

On Thu, Apr 04, 2024 at 08:24:04AM -0300, Jason Gunthorpe wrote: > On Wed, Apr 03, 2024 at 02:25:20PM -0400, Peter Xu wrote: > > > > I'd say the BUILD_BUG has done it's job and found an issue, fix it by > > > not defining pud_leaf? I don't see any calls to pud_leaf in loongarch > > > at least > >

Re: [PATCH v3] scsi: sg: Avoid race in error handling & drop bogus warn

On 4/1/24 12:10, Alexander Wetzel wrote: commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race") introduced an incorrect WARN_ON_ONCE() and missed a sequence where sg_device_destroy() was used after scsi_device_put(). sg_device_destroy() is accessing the parent scsi_device request_queue

Re: [FSL P50x0] Kernel 6.9-rc1 compiling issue

Hi Christian, hi Hari, Le 04/04/2024 à 19:44, Christian Zigotzky a écrit : > Shall we use CONFIG_CRASH_DUMP to get int crashing_cpu = -1;? > > Further information: > https://lists.ozlabs.org/pipermail/linuxppc-dev/2024-March/269985.html >

[PATCH] selftests/powerpc/papr-vpd: Fix missing variable initialization

From: Nathan Lynch The "close handle without consuming VPD" testcase has inconsistent results because it fails to initialize the location code object it passes to ioctl() to create a VPD handle. Initialize the location code to the empty string as intended. Signed-off-by: Nathan Lynch --- tools

Re: [FSL P50x0] Kernel 6.9-rc1 compiling issue

Shall we use CONFIG_CRASH_DUMP to get int crashing_cpu = -1;? Further information: https://lists.ozlabs.org/pipermail/linuxppc-dev/2024-March/269985.html — Christian

Re: [PATCH v3 00/12] mm/gup: Unify hugetlb, part 2

On Tue, Mar 26, 2024 at 11:02:52AM -0300, Jason Gunthorpe wrote: > The more I look at this the more I think we need to get to Matthew's > idea of having some kind of generic page table API that is not tightly > tied to level. Replacing the hugetlb trick of 'everything is a PTE' > with 5 special cas

Re: [PATCH] selftests/powerpc/papr-vpd: Fix missing variable initialization

Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > The "close handle without consuming VPD" testcase has inconsistent > results because it fails to initialize the location code object it > passes to ioctl() to create a VPD handle. Initialize the location code > to the empty string as inte

[PATCH v2] selftests/powerpc/papr-vpd: Fix missing variable initialization

Reported-by: Geetika Moolchandani Fixes: 9118c5d32bdd ("powerpc/selftests: Add test for papr-vpd") --- Changes in v2: - Add Fixes: and Reported-by: tags. - Link to v1: https://lore.kernel.org/r/20240404-papr-vpd-test-uninit-lc-v1-1-04cc22d7f...@linux.ibm.com --- tools/testing/selfte

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

On Thu, 4 Apr 2024, Andy Shevchenko wrote: > > > > > --- > > > (here is a good location for Cc:) > > > > Documentation/process/submitting-patches.rst indicats that it should > > be above the "---" separator together with Acked-by etc. Has this > > convention changed recently? > > I see, I wi

Re: [PATCH v3] scsi: sg: Avoid race in error handling & drop bogus warn

Alexander, > commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race") > introduced an incorrect WARN_ON_ONCE() and missed a sequence where > sg_device_destroy() was used after scsi_device_put(). Applied to 6.9/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

The mitigation was intended to stop the irq completely. That may be better than a hard lock-up but it turns out that you get a crash anyway if you're using pmac_zilog as a serial console: ttyPZ0: pmz: rx irq flood ! BUG: spinlock recursion on CPU#0, swapper/0 That's because the pr_err() call in p

Re: [PATCH v1 1/1] powerpc/52xx: Replace of_gpio.h by proper one

Andy Shevchenko writes: > On Wed, Mar 13, 2024 at 03:56:45PM +0200, Andy Shevchenko wrote: >> of_gpio.h is deprecated and subject to remove. >> The driver doesn't use it directly, replace it >> with what is really being used. > > Any comments on this? No comment :) I'll take it for 6.10, or do y

[powerpc:fixes-test] BUILD SUCCESS 69630926011c1f7170a465b7b5c228deb66e9372

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git fixes-test branch HEAD: 69630926011c1f7170a465b7b5c228deb66e9372 powerpc/crypto/chacha-p10: Fix failure on non Power10 elapsed time: 731m configs tested: 132 configs skipped: 155 The following configs have been bui

[powerpc:next] BUILD SUCCESS bfe51886ca544956eb4ff924d1937ac01d0ca9c8

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next branch HEAD: bfe51886ca544956eb4ff924d1937ac01d0ca9c8 powerpc: Fix PS3 allmodconfig warning elapsed time: 733m configs tested: 139 configs skipped: 157 The following configs have been built successfully. More

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

Andy Shevchenko writes: > On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote: >> On Thu, 4 Apr 2024, Andy Shevchenko wrote: > >> > > Cc: Benjamin Herrenschmidt >> > > Cc: Michael Ellerman >> > > Cc: Nicholas Piggin >> > > Cc: Christophe Leroy >> > > Cc: "Aneesh Kumar K.V" >> > > Cc: "Naveen N.

Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

Finn Thain writes: > The mitigation was intended to stop the irq completely. That may be > better than a hard lock-up but it turns out that you get a crash anyway > if you're using pmac_zilog as a serial console: > > ttyPZ0: pmz: rx irq flood ! > BUG: spinlock recursion on CPU#0, swapper/0 > > Tha

Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Cancel pending HDEC exception

"Linux regression tracking (Thorsten Leemhuis)" writes: > Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting > for once, to make this easily accessible to everyone. > > Was this regression ever resolved? Doesn't look like it, but maybe I > just missed something. I'm not sure ho

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

On Fri, 5 Apr 2024, Michael Ellerman wrote: > >> > > --- > >> > (here is a good location for Cc:) > >> > >> Documentation/process/submitting-patches.rst indicats that it should > >> be above the "---" separator together with Acked-by etc. Has this > >> convention changed recently? > > The doc

Re: [kvm-unit-tests PATCH v7 07/35] common: add memory dirtying vs migration test

On Fri Mar 29, 2024 at 3:37 AM AEST, Thomas Huth wrote: > On 19/03/2024 08.58, Nicholas Piggin wrote: > > This test stores to a bunch of pages and verifies previous stores, > > while being continually migrated. Default runtime is 5 seconds. > > > > Add this test to ppc64 and s390x builds. This can

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

On Fri, Apr 5, 2024 at 1:15 AM Finn Thain wrote: > On Thu, 4 Apr 2024, Andy Shevchenko wrote: > > > > > > --- > > > > (here is a good location for Cc:) > > > > > > Documentation/process/submitting-patches.rst indicats that it should > > > be above the "---" separator together with Acked-by etc. Ha

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

On Fri, Apr 5, 2024 at 6:06 AM Michael Ellerman wrote: > Andy Shevchenko writes: > > On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote: > >> On Thu, 4 Apr 2024, Andy Shevchenko wrote: > > > >> > > Cc: Benjamin Herrenschmidt > >> > > Cc: Michael Ellerman > >> > > Cc: Nicholas Piggin > >> > > Cc:

Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Cancel pending HDEC exception

On 05.04.24 05:20, Michael Ellerman wrote: > "Linux regression tracking (Thorsten Leemhuis)" > writes: >> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting >> for once, to make this easily accessible to everyone. >> >> Was this regression ever resolved? Doesn't look like it, bu

[PATCH] usb: gadget: fsl: Initialize udc before using it

fsl_ep_queue() is only called by usb_ep_queue() (as ep->ops->queue()). So _ep isn't NULL. As ep->ops->queue = fsl_ep_queue, the ep was initialized by struct_ep_setup() and so ep->udc isn't NULL either. Drop the check for _ep being NULL and assign udc earlier to prevent following an uninitialized