Re: [PATCH] drivers/ps3: select VIDEO to provide cmdline functions

2024-02-07 Thread Thomas Zimmermann
Hi Am 07.02.24 um 04:37 schrieb Randy Dunlap: When VIDEO is not set, there is a build error. Fix that by selecting VIDEO for PS3_PS3AV. ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! Fixes: dae7fbf43fd0 ("driver/ps3: Include for mode parsing") Thanks for the fix.

[PATCH] powerpc/cputable: Add missing PPC_FEATURE_BOOKE on PPC64 Book-E

2024-02-07 Thread David Engraf
Commit e320a76db4b0 ("powerpc/cputable: Split cpu_specs[] out of cputable.h") moved the cpu_specs to separate header files. Previously PPC_FEATURE_BOOKE was enabled by CONFIG_PPC_BOOK3E_64. The definition in cpu_specs_e500mc.h for PPC64 no longer enables PPC_FEATURE_BOOKE. This breaks user space r

Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing

2024-02-07 Thread Ilpo Järvinen
Adding Cc Quigshun which I ended up forgotting despite thinking it at one point. -- i. On Tue, 6 Feb 2024, Ilpo Järvinen wrote: > This series consolidates AER & DPC TLP Log handling code. Helpers are > added for reading and printing the TLP Log and the format is made to > include E-E Prefixes

[PATCH v11 1/5] uaccess: add generic fallback version of copy_mc_to_user()

2024-02-07 Thread Tong Tiangen
x86/powerpc has it's implementation of copy_mc_to_user(), we add generic fallback in include/linux/uaccess.h prepare for other architechures to enable CONFIG_ARCH_HAS_COPY_MC. Signed-off-by: Tong Tiangen Acked-by: Michael Ellerman --- arch/powerpc/include/asm/uaccess.h | 1 + arch/x86/include/a

[PATCH v11 2/5] arm64: add support for ARCH_HAS_COPY_MC

2024-02-07 Thread Tong Tiangen
For the arm64 kernel, when it processes hardware memory errors for synchronize notifications(do_sea()), if the errors is consumed within the kernel, the current processing is panic. However, it is not optimal. Take copy_from/to_user for example, If ld* triggers a memory error, even in kernel mode,

[PATCH v11 3/5] mm/hwpoison: return -EFAULT when copy fail in copy_mc_[user]_highpage()

2024-02-07 Thread Tong Tiangen
If hardware errors are encountered during page copying, returning the bytes not copied is not meaningful, and the caller cannot do any processing on the remaining data. Returning -EFAULT is more reasonable, which represents a hardware error encountered during the copying. Signed-off-by: Tong Tiang

[PATCH v11 0/5]arm64: add ARCH_HAS_COPY_MC support

2024-02-07 Thread Tong Tiangen
With the increase of memory capacity and density, the probability of memory error also increases. The increasing size and density of server RAM in data centers and clouds have shown increased uncorrectable memory errors. Currently, more and more scenarios that can tolerate memory errors???such as

[PATCH v11 4/5] arm64: support copy_mc_[user]_highpage()

2024-02-07 Thread Tong Tiangen
Currently, many scenarios that can tolerate memory errors when copying page have been supported in the kernel[1~5], all of which are implemented by copy_mc_[user]_highpage(). arm64 should also support this mechanism. Due to mte, arm64 needs to have its own copy_mc_[user]_highpage() architecture im

[PATCH v11 5/5] arm64: send SIGBUS to user process for SEA exception

2024-02-07 Thread Tong Tiangen
For SEA exception, kernel require take some action to recover from memory error, such as isolate poison page adn kill failure thread, which are done in memory_failure(). During the test, the failure thread cannot be killed due to this issue[1], Here, I temporarily workaround this issue by sending

[powerpc:fixes-test] BUILD SUCCESS 1c57b9f63ab34f01b8c73731cc0efacb5a9a2f16

2024-02-07 Thread kernel test robot
-20240207 gcc arc randconfig-002-20240207 gcc arm allmodconfig gcc arm allnoconfig clang arm allyesconfig gcc arm aspeed_g5_defconfig gcc arm

[powerpc:merge] BUILD SUCCESS 4ef8376c466ae8b03e632dd8eca1e44315f7dd61

2024-02-07 Thread kernel test robot
randconfig-001-20240207 gcc arc randconfig-002-20240207 gcc arm allmodconfig gcc arm allnoconfig clang arm allyesconfig gcc arm aspeed_g5_defconfig

Re: [PATCH 5/5] sched/vtime: do not include header

2024-02-07 Thread Alexander Gordeev
On Wed, Feb 07, 2024 at 12:30:08AM +0100, Frederic Weisbecker wrote: > Reviewed-by: Frederic Weisbecker Thank you for the review, Frederic! The Heiko comment is valid and I would add this chunk in v2: --- a/arch/powerpc/include/asm/Kbuild +++ b/arch/powerpc/include/asm/Kbuild @@ -6,5 +6,4 @@ ge

Re: [PATCH 4/5] s390/irq,nmi: do not include header

2024-02-07 Thread Alexander Gordeev
On Mon, Jan 29, 2024 at 10:51:44AM +0100, Heiko Carstens wrote: > It is confusing when the patch subject is "do not include.." and all > what this patch is doing is to add two includes. I see what this is > doing: getting rid of the implicit include of asm/vtime.h most likely > via linux/hardirq.h,

Re: [PATCH 5/5] sched/vtime: do not include header

2024-02-07 Thread Frederic Weisbecker
Le Wed, Feb 07, 2024 at 03:12:57PM +0100, Alexander Gordeev a écrit : > On Wed, Feb 07, 2024 at 12:30:08AM +0100, Frederic Weisbecker wrote: > > Reviewed-by: Frederic Weisbecker > > Thank you for the review, Frederic! > > The Heiko comment is valid and I would add this chunk in v2: > > --- a/ar

[PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

2024-02-07 Thread Randy Dunlap
When VIDEO is not set, there is a build error. Fix that by selecting VIDEO for PS3_PS3AV. ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! Fixes: dae7fbf43fd0 ("driver/ps3: Include for mode parsing") Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video=

Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

2024-02-07 Thread Thomas Zimmermann
Am 07.02.24 um 17:13 schrieb Randy Dunlap: When VIDEO is not set, there is a build error. Fix that by selecting VIDEO for PS3_PS3AV. ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! Fixes: dae7fbf43fd0 ("driver/ps3: Include for mode parsing") Fixes: a3b6792e990d ("

Re: [PATCH 1/2] powerpc/pseries: Add a clear modifier to ibm,pa/pi-features parser

2024-02-07 Thread Vaibhav Jain
Nicholas Piggin writes: > When a new ibm,pa/pi-features bit is introduced that is intended to > apply to existing systems and features, it may have an "inverted" > meaning (i.e., bit clear => feature available; bit set => unavailable). > Depending on the nature of the feature, this may give the b

Re: [PATCH 2/2] powerpc/pseries: Set CPU_FTR_DBELL according to ibm,pi-features

2024-02-07 Thread Vaibhav Jain
Nicholas Piggin writes: > PAPR will define a new ibm,pi-features bit which says that doorbells > should not be used even on architectures where they exist. This could be > because they are emulated and slower than using the interrupt controller > directly for IPIs. > > Wire this bit into the pi-f

Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal()

2024-02-07 Thread Anthony Krowiak
For vfio_ap_ops.c Reviewed-by: Anthony Krowiak On 2/6/24 2:44 PM, Stefan Hajnoczi wrote: vhost and VIRTIO-related parts: Reviewed-by: Stefan Hajnoczi On Wed, 22 Nov 2023 at 07:50, Christian Brauner wrote: Ever since the evenfd type was introduced back in 2007 in commit e1ad7468c77d ("sign

Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal()

2024-02-07 Thread Paolo Bonzini
On Wed, Nov 22, 2023 at 1:49 PM Christian Brauner wrote: > > Ever since the evenfd type was introduced back in 2007 in commit > e1ad7468c77d ("signal/timer/event: eventfd core") the eventfd_signal() > function only ever passed 1 as a value for @n. There's no point in > keeping that additional argu

Re: [PATCH] powerpc/pseries/iommu: DLPAR ADD of pci device doesn't completely initialize pci_controller structure

2024-02-07 Thread Gaurav Batra
Hello All, There is still some issue even after applying the patch. This is not a complete fix. I am working on V3 of the patch. Please do not merge this patch upstream. Thanks, Gaurav On 1/10/24 4:53 PM, Gaurav Batra wrote: When a PCI device is Dynamically added, LPAR OOPS with NULL point

Re: [PATCH v3 01/15] arm64/mm: Make set_ptes() robust when OAs cross 48-bit boundary

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:35PM +0100, David Hildenbrand wrote: > From: Ryan Roberts > > Since the high bits [51:48] of an OA are not stored contiguously in the > PTE, there is a theoretical bug in set_ptes(), which just adds PAGE_SIZE > to the pte to get the pte with the next pfn. This works

Re: [PATCH v3 02/15] arm/pgtable: define PFN_PTE_SHIFT

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:36PM +0100, David Hildenbrand wrote: > We want to make use of pte_next_pfn() outside of set_ptes(). Let's > simply define PFN_PTE_SHIFT, required by pte_next_pfn(). > > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > arch/arm/include/asm

Re: [PATCH v3 03/15] nios2/pgtable: define PFN_PTE_SHIFT

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:37PM +0100, David Hildenbrand wrote: > We want to make use of pte_next_pfn() outside of set_ptes(). Let's > simply define PFN_PTE_SHIFT, required by pte_next_pfn(). > > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > arch/nios2/include/a

Re: [PATCH v3 04/15] powerpc/pgtable: define PFN_PTE_SHIFT

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:38PM +0100, David Hildenbrand wrote: > We want to make use of pte_next_pfn() outside of set_ptes(). Let's > simply define PFN_PTE_SHIFT, required by pte_next_pfn(). > > Reviewed-by: Christophe Leroy > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM

Re: [PATCH v3 05/15] riscv/pgtable: define PFN_PTE_SHIFT

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:39PM +0100, David Hildenbrand wrote: > We want to make use of pte_next_pfn() outside of set_ptes(). Let's > simply define PFN_PTE_SHIFT, required by pte_next_pfn(). > > Reviewed-by: Alexandre Ghiti > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM)

Re: [PATCH v3 06/15] s390/pgtable: define PFN_PTE_SHIFT

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:40PM +0100, David Hildenbrand wrote: > We want to make use of pte_next_pfn() outside of set_ptes(). Let's > simply define PFN_PTE_SHIFT, required by pte_next_pfn(). > > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > arch/s390/include/as

Re: [PATCH v3 07/15] sparc/pgtable: define PFN_PTE_SHIFT

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:41PM +0100, David Hildenbrand wrote: > We want to make use of pte_next_pfn() outside of set_ptes(). Let's > simply define PFN_PTE_SHIFT, required by pte_next_pfn(). > > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > arch/sparc/include/a

Re: [PATCH v3 08/15] mm/pgtable: make pte_next_pfn() independent of set_ptes()

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:42PM +0100, David Hildenbrand wrote: > Let's provide pte_next_pfn(), independently of set_ptes(). This allows for > using the generic pte_next_pfn() version in some arch-specific set_ptes() > implementations, and prepares for reusing pte_next_pfn() in other context. >

Re: [PATCH v3 09/15] arm/mm: use pte_next_pfn() in set_ptes()

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:43PM +0100, David Hildenbrand wrote: > Let's use our handy helper now that it's available on all archs. > > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > arch/arm/mm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [PATCH v3 10/15] powerpc/mm: use pte_next_pfn() in set_ptes()

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:44PM +0100, David Hildenbrand wrote: > Let's use our handy new helper. Note that the implementation is slightly > different, but shouldn't really make a difference in practice. > > Reviewed-by: Christophe Leroy > Signed-off-by: David Hildenbrand Reviewed-by: Mike R

Re: [PATCH v3 12/15] mm/memory: pass PTE to copy_present_pte()

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:46PM +0100, David Hildenbrand wrote: > We already read it, let's just forward it. > > This patch is based on work by Ryan Roberts. > > Reviewed-by: Ryan Roberts > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > mm/memory.c | 7 +++

Re: [PATCH v3 11/15] mm/memory: factor out copying the actual PTE in copy_present_pte()

2024-02-07 Thread Mike Rapoport
On Mon, Jan 29, 2024 at 01:46:45PM +0100, David Hildenbrand wrote: > Let's prepare for further changes. > > Reviewed-by: Ryan Roberts > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > mm/memory.c | 63 - > 1 file c