Re: [PATCH linux-next v3 10/14] sh, crash: wrap crash dumping code into crash related ifdefs

2024-01-24 Thread John Paul Adrian Glaubitz
Hello Baoquan, On Wed, 2024-01-24 at 13:12 +0800, Baoquan He wrote: > Now crash codes under kernel/ folder has been split out from kexec > code, crash dumping can be separated from kexec reboot in config > items on SuperH with some adjustments. > > wrap up crash dumping codes with CONFIG_CRASH_DU

[PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver

2024-01-24 Thread Kunwu Chan
This part was commented from commit 2f4cf5e42d13 ("Add book3s.c") in about 14 years before. If there are no plans to enable this part code in the future, we can remove this dead code. Signed-off-by: Kunwu Chan --- arch/powerpc/kvm/book3s.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ar

[PATCH v2] powerpc/6xx: set High BAT Enable flag on G2_LE cores

2024-01-24 Thread Matthias Schiffer
MMU_FTR_USE_HIGH_BATS is set for G2_LE cores and derivatives like e300cX, but the high BATs need to be enabled in HID2 to work. Add register definitions and add the needed setup to __setup_cpu_603. This fixes boot on CPUs like the MPC5200B with STRICT_KERNEL_RWX enabled on systems where the flag h

[PATCH] powerpc: rename SPRN_HID2 define to SPRN_HID2_750FX

2024-01-24 Thread Matthias Schiffer
This register number is hardware-specific, rename it for clarity. FIXME comments are added in a few places where it seems like the wrong register is used. As I can't test this, only the rename is done with no functional change. Signed-off-by: Matthias Schiffer --- arch/powerpc/include/asm/reg.h

Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver

2024-01-24 Thread Christophe Leroy
Le 24/01/2024 à 10:36, Kunwu Chan a écrit : > This part was commented from commit 2f4cf5e42d13 ("Add book3s.c") > in about 14 years before. > If there are no plans to enable this part code in the future, > we can remove this dead code. > > Signed-off-by: Kunwu Chan > --- > arch/powerpc/kvm/bo

Re: [PATCH linux-next v3 10/14] sh, crash: wrap crash dumping code into crash related ifdefs

2024-01-24 Thread Baoquan He
On 01/24/24 at 09:13am, John Paul Adrian Glaubitz wrote: > Hello Baoquan, > > On Wed, 2024-01-24 at 13:12 +0800, Baoquan He wrote: > > Now crash codes under kernel/ folder has been split out from kexec > > code, crash dumping can be separated from kexec reboot in config > > items on SuperH with so

Re: [PATCH 1/4] net: wan: Add support for QMC HDLC

2024-01-24 Thread Herve Codina
Hi Vadim, On Wed, 24 Jan 2024 10:03:45 + Vadim Fedorenko wrote: [...] > > +static void qmc_hcld_recv_complete(void *context, size_t length, unsigned > > int flags) > > +{ > > + struct qmc_hdlc_desc *desc = context; > > + struct net_device *netdev = desc->netdev; > > + struct qmc_hdlc

Re: [PATCH 3/4] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support

2024-01-24 Thread Herve Codina
Hi Vadim, On Wed, 24 Jan 2024 10:10:46 + Vadim Fedorenko wrote: [...] > > +static int qmc_hdlc_xlate_slot_map(struct qmc_hdlc *qmc_hdlc, > > + u32 slot_map, struct qmc_chan_ts_info > > *ts_info) > > +{ > > + u64 ts_mask_avail; > > + unsigned int bit; > > +

Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver

2024-01-24 Thread Markus Elfring
> If there are no plans to enable this part code in the future, Will the word combination “code part” become preferred for a subsequent change description? > we can remove this dead code. And omit another blank line accordingly? Regards, Markus

Re: [PATCH v2] NUMA: Early use of cpu_to_node() returns 0 instead of the correct node id

2024-01-24 Thread Yury Norov
On Wed, Jan 24, 2024 at 09:19:00AM -0800, Lameter, Christopher wrote: > On Tue, 23 Jan 2024, Huang Shijie wrote: > > > During the kernel booting, the generic cpu_to_node() is called too early in > > arm64, powerpc and riscv when CONFIG_NUMA is enabled. > > > > For arm64/powerpc/riscv, there are a

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-24 Thread Yosry Ahmed
On Mon, Jan 22, 2024 at 12:49 PM Yosry Ahmed wrote: > > On Sun, Jan 21, 2024 at 11:42 PM Christoph Hellwig wrote: > > > > On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote: > > > Well, better compression ratios for one :) > > > > > > I think a long time ago there were complaints that zs

ps3_gelic_net.c issue (linux kernel 6.8-rc1)

2024-01-24 Thread sambat goson
Hi, I've just test it and find below code not proper in function "gelic_descr_prepare_rx", line 398. it causes error as my attached file. descr->skb = netdev_alloc_skb(*card->netdev, rx_skb_size); if (!descr->skb) { descr->hw_regs.payload.dev_addr = 0; /* tell DMAC don't touch memory */ return -EN

Re: [PATCH 1/4] net: wan: Add support for QMC HDLC

2024-01-24 Thread Vadim Fedorenko
On 23/01/2024 16:49, Herve Codina wrote: The QMC HDLC driver provides support for HDLC using the QMC (QUICC Multichannel Controller) to transfer the HDLC data. Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy Acked-by: Jakub Kicinski --- drivers/net/wan/Kconfig| 12 + dri

Re: [PATCH 3/4] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support

2024-01-24 Thread Vadim Fedorenko
On 23/01/2024 16:49, Herve Codina wrote: QMC channels support runtime timeslots changes but nothing is done at the QMC HDLC driver to handle these changes. Use existing IFACE ioctl in order to configure the timeslots to use. Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy Acked-by:

Re: [PATCH 3/4] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support

2024-01-24 Thread Vadim Fedorenko
On 24/01/2024 15:26, Herve Codina wrote: Hi Vadim, On Wed, 24 Jan 2024 10:10:46 + Vadim Fedorenko wrote: [...] +static int qmc_hdlc_xlate_slot_map(struct qmc_hdlc *qmc_hdlc, + u32 slot_map, struct qmc_chan_ts_info *ts_info) +{ + u64 ts_mask_avail; +

Re: [PATCH v2] NUMA: Early use of cpu_to_node() returns 0 instead of the correct node id

2024-01-24 Thread Lameter, Christopher
On Tue, 23 Jan 2024, Huang Shijie wrote: During the kernel booting, the generic cpu_to_node() is called too early in arm64, powerpc and riscv when CONFIG_NUMA is enabled. For arm64/powerpc/riscv, there are at least four places in the common code where the generic cpu_to_node() is called before

RE: [PATCH linux-next v3 06/14] x86, crash: wrap crash dumping code into crash related ifdefs

2024-01-24 Thread Michael Kelley
From: Baoquan He Sent: Tuesday, January 23, 2024 9:13 PM > > Now crash codes under kernel/ folder has been split out from kexec > code, crash dumping can be separated from kexec reboot in config > items on x86 with some adjustments. > > Here, also change some ifdefs or IS_ENABLED() check to mor

Re: [PATCH v2] NUMA: Early use of cpu_to_node() returns 0 instead of the correct node id

2024-01-24 Thread Shijie Huang
在 2024/1/25 1:19, Lameter, Christopher 写道: On Tue, 23 Jan 2024, Huang Shijie wrote: During the kernel booting, the generic cpu_to_node() is called too early in arm64, powerpc and riscv when CONFIG_NUMA is enabled. For arm64/powerpc/riscv, there are at least four places in the common code

[PATCH] powerpc/iommu: Code cleanup for cell/iommu.c

2024-01-24 Thread Kunwu Chan
This part was commented from commit 165785e5c0be ("[POWERPC] Cell iommu support") in about 17 years before. If there are no plans to enable this part code in the future, we can remove this dead code. Signed-off-by: Kunwu Chan --- arch/powerpc/platforms/cell/iommu.c | 16 1 file

Re: [PATCH linux-next v3 06/14] x86, crash: wrap crash dumping code into crash related ifdefs

2024-01-24 Thread Baoquan He
On 01/24/24 at 11:02pm, Michael Kelley wrote: > > diff --git a/arch/x86/kernel/cpu/mshyperv.c > > b/arch/x86/kernel/cpu/mshyperv.c > > index 01fa06dd06b6..f8163a59026b 100644 > > --- a/arch/x86/kernel/cpu/mshyperv.c > > +++ b/arch/x86/kernel/cpu/mshyperv.c > > @@ -210,6 +210,7 @@ static void hv_mac

RE: [PATCH linux-next v3 06/14] x86, crash: wrap crash dumping code into crash related ifdefs

2024-01-24 Thread Michael Kelley
From: Baoquan He Sent: Wednesday, January 24, 2024 8:10 PM > > On 01/24/24 at 11:02pm, Michael Kelley wrote: > > > diff --git a/arch/x86/kernel/cpu/mshyperv.c > > > b/arch/x86/kernel/cpu/mshyperv.c > > > index 01fa06dd06b6..f8163a59026b 100644 > > > --- a/arch/x86/kernel/cpu/mshyperv.c > > > +++

Re: ps3_gelic_net.c issue (linux kernel 6.8-rc1)

2024-01-24 Thread Christophe Leroy
Hi, Le 24/01/2024 à 09:41, sambat goson a écrit : > > Hi, > I've just test it and find below code not proper in function > "gelic_descr_prepare_rx", line 398. > it causes error as my attached file. > > descr->skb = netdev_alloc_skb(*card->netdev, rx_skb_size); > if (!descr->skb) { > descr

Re: [PATCH] powerpc/iommu: Code cleanup for cell/iommu.c

2024-01-24 Thread Christophe Leroy
Le 25/01/2024 à 03:46, Kunwu Chan a écrit : > This part was commented from commit 165785e5c0be ("[POWERPC] Cell > iommu support") in about 17 years before. > > If there are no plans to enable this part code in the future, > we can remove this dead code. > > Signed-off-by: Kunwu Chan > --- >

Re: ps3_gelic_net.c issue (linux kernel 6.8-rc1)

2024-01-24 Thread Geoff Levand
Hi, On 1/25/24 15:46, Christophe Leroy wrote: > Hi, > > Le 24/01/2024 à 09:41, sambat goson a écrit : >> >> Hi, >> I've just test it and find below code not proper in function >> "gelic_descr_prepare_rx", line 398. >> it causes error as my attached file. >> >> descr->skb = netdev_alloc_skb

Re: [PATCH v2] NUMA: Early use of cpu_to_node() returns 0 instead of the correct node id

2024-01-24 Thread Mike Rapoport
On Wed, Jan 24, 2024 at 09:19:00AM -0800, Lameter, Christopher wrote: > On Tue, 23 Jan 2024, Huang Shijie wrote: > > > During the kernel booting, the generic cpu_to_node() is called too early in > > arm64, powerpc and riscv when CONFIG_NUMA is enabled. > > > > For arm64/powerpc/riscv, there are a