Re: [PATCH v4 2/5] RISC-V: Add SBI debug console helper routines

2023-11-20 Thread Andrew Jones
On Sat, Nov 18, 2023 at 09:08:56AM +0530, Anup Patel wrote: > Let us provide SBI debug console helper routines which can be > shared by serial/earlycon-riscv-sbi.c and hvc/hvc_riscv_sbi.c. > > Signed-off-by: Anup Patel > --- > arch/riscv/include/asm/sbi.h | 5 + > arch/riscv/kernel/sbi.c

Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing

2023-11-20 Thread Christoph Hellwig
On Wed, Nov 15, 2023 at 08:29:02PM -0500, Peter Xu wrote: > Hugepd format is only used in PowerPC with hugetlbfs. In commit > a6e79df92e4a ("mm/gup: disallow FOLL_LONGTERM GUP-fast writing to > file-backed mappings"), we added a check to fail gup-fast if there's > potential risk of violating GUP o

Re: [PATCH v9 10/15] media: uapi: Add V4L2_CTRL_TYPE_FIXED_POINT

2023-11-20 Thread Shengjiu Wang
On Fri, Nov 17, 2023 at 8:07 PM Hans Verkuil wrote: > > Here is an RFC patch adding support for 'fraction_bits'. It's lacking > documentation, but it can be used for testing. > > It was rather a pain logging fixed point number in a reasonable format, > but I think it is OK. > > In userspace (where

Re: [PATCH] ASoC: fsl_mqs: Remove duplicate linux/of.h header

2023-11-20 Thread Shengjiu Wang
On Sun, Nov 19, 2023 at 6:45 PM Lucas Tanure wrote: > > Remove linux/of.h as is included more than once. > Reported by make includecheck. > > Signed-off-by: Lucas Tanure Acked-by: Shengjiu Wang best regards Wang shengjiu > --- > sound/soc/fsl/fsl_mqs.c | 1 - > 1 file changed, 1 deletion(-) >

[PATCH] ASoC: fsl_sai: Fix no frame sync clock issue on i.MX8MP

2023-11-20 Thread Shengjiu Wang
On i.MX8MP, when the TERE and FSD_MSTR enabled before configuring the word width, there will be no frame sync clock issue, because old word width impact the generation of frame sync. TERE enabled earlier only for i.MX8MP case for the hardware limitation, So need to disable FSD_MSTR before configur

[PATCH v4 0/4] KVM: selftests: add powerpc support

2023-11-20 Thread Nicholas Piggin
This series adds initial KVM selftests support for powerpc (64-bit, BookS, radix MMU). Since v3: https://lore.kernel.org/linuxppc-dev/20230608032425.59796-1-npig...@gmail.com/ - Rebased to upstream (on top of Sean's ucall and guest assert rework). - Drop powerpc specific tests for now, concentra

[PATCH v4 1/4] KVM: selftests: Move pgd_created check into virt_pgd_alloc

2023-11-20 Thread Nicholas Piggin
virt_arch_pgd_alloc all do the same test and set of pgd_created. Move this into common code. Signed-off-by: Nicholas Piggin --- tools/testing/selftests/kvm/include/kvm_util_base.h | 5 + tools/testing/selftests/kvm/lib/aarch64/processor.c | 4 tools/testing/selftests/kvm/lib/riscv/proce

[PATCH v4 2/4] KVM: selftests: Add aligned guest physical page allocator

2023-11-20 Thread Nicholas Piggin
powerpc will require this to allocate MMU tables in guest memory that are larger than guest base page size. Signed-off-by: Nicholas Piggin --- .../selftests/kvm/include/kvm_util_base.h | 2 + tools/testing/selftests/kvm/lib/kvm_util.c| 44 --- 2 files changed, 29 inserti

[PATCH v4 3/4] KVM: PPC: selftests: add support for powerpc

2023-11-20 Thread Nicholas Piggin
Implement KVM selftests support for powerpc (Book3S-64). ucalls are implemented with an unsuppored PAPR hcall number which will always cause KVM to exit to userspace. Virtual memory is implemented for the radix MMU, and only a base page size is supported (both 4K and 64K). Guest interrupts are t

[PATCH v4 4/4] KVM: PPC: selftests: powerpc enable kvm_create_max_vcpus test

2023-11-20 Thread Nicholas Piggin
powerpc's maximum permitted vCPU ID depends on the VM's SMT mode, and the maximum reported by KVM_CAP_MAX_VCPU_ID exceeds a simple non-SMT VM's limit. The powerpc KVM selftest port uses non-SMT VMs, so add a workaround to the kvm_create_max_vcpus test case to limit vCPU IDs to KVM_CAP_MAX_VCPUS on

Re: [PATCH v9 00/27] Add support for QMC HDLC, framer infrastructure and PEF2256 framer

2023-11-20 Thread Mark Brown
On Fri, Nov 17, 2023 at 04:47:46PM -0800, Jakub Kicinski wrote: > On Wed, 15 Nov 2023 15:39:36 +0100 Herve Codina wrote: > >- Removed Patches 6, 7 and 8 (patches applied) > > > >- Patches 7, 20, 21, 23 (patches 10, 23, 24, 26 in v8) > > Add 'Acked-by: Jakub Kicinski ' > I thought som

Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags

2023-11-20 Thread Mark Brown
On Wed, Nov 08, 2023 at 05:08:01PM -0800, Anish Moorthy wrote: > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > __x86_64__, while the usages introduced here aren't. > > Should > > On Sun, Nov 5, 2023 at 8:35 

Re: [RFC - is this a bug?] powerpc/lib/sstep: Asking for some light on this, please. :)

2023-11-20 Thread Naveen N Rao
On Fri, Nov 17, 2023 at 12:36:01PM -0600, Gustavo A. R. Silva wrote: > Hi all, > > I'm trying to fix the following -Wstringop-overflow warnings, and I'd like > to get your feedback on this, please: > > In function 'do_byte_reverse', > inlined from 'do_vec_store' at > /home/gus/linux/arch/pow

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Nicholas Piggin
Yeah, awesome. On Mon Nov 20, 2023 at 5:10 PM AEST, Michael Ellerman wrote: > Hi Timothy, > > Great work debugging this. I think your fix is good, but I want to understand > it > a bit more to make sure I can explain why we haven't seen it outside of > io-uring. Analysis seems right to me. Pro

Re: [RFC - is this a bug?] powerpc/lib/sstep: Asking for some light on this, please. :)

2023-11-20 Thread Gustavo A. R. Silva
On 11/20/23 08:25, Naveen N Rao wrote: On Fri, Nov 17, 2023 at 12:36:01PM -0600, Gustavo A. R. Silva wrote: Hi all, I'm trying to fix the following -Wstringop-overflow warnings, and I'd like to get your feedback on this, please: In function 'do_byte_reverse', inlined from 'do_vec_store

Re: [RFC - is this a bug?] powerpc/lib/sstep: Asking for some light on this, please. :)

2023-11-20 Thread Naveen N Rao
On Mon, Nov 20, 2023 at 08:33:45AM -0600, Gustavo A. R. Silva wrote: > > > On 11/20/23 08:25, Naveen N Rao wrote: > > On Fri, Nov 17, 2023 at 12:36:01PM -0600, Gustavo A. R. Silva wrote: > > > Hi all, > > > > > > I'm trying to fix the following -Wstringop-overflow warnings, and I'd like > > > to

Re: [PATCH] ASoC: fsl_sai: Fix no frame sync clock issue on i.MX8MP

2023-11-20 Thread Mark Brown
On Mon, 20 Nov 2023 18:05:35 +0800, Shengjiu Wang wrote: > On i.MX8MP, when the TERE and FSD_MSTR enabled before configuring > the word width, there will be no frame sync clock issue, because > old word width impact the generation of frame sync. > > TERE enabled earlier only for i.MX8MP case for t

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Timothy Pearson
- Original Message - > From: "Michael Ellerman" > To: "Timothy Pearson" , "Jens Axboe" > , "regressions" > , "npiggin" , "christophe > leroy" , > "linuxppc-dev" > Sent: Monday, November 20, 2023 1:10:06 AM > Subject: Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec >

Re: [PATCH] ASoC: fsl_mqs: Remove duplicate linux/of.h header

2023-11-20 Thread Mark Brown
On Sun, 19 Nov 2023 10:45:14 +, Lucas Tanure wrote: > Remove linux/of.h as is included more than once. > Reported by make includecheck. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_mqs: Remove duplicate linux/of.h hea

Re: [RFC - is this a bug?] powerpc/lib/sstep: Asking for some light on this, please. :)

2023-11-20 Thread Gustavo A. R. Silva
On 11/20/23 09:21, Naveen N Rao wrote: On Mon, Nov 20, 2023 at 08:33:45AM -0600, Gustavo A. R. Silva wrote: On 11/20/23 08:25, Naveen N Rao wrote: On Fri, Nov 17, 2023 at 12:36:01PM -0600, Gustavo A. R. Silva wrote: Hi all, I'm trying to fix the following -Wstringop-overflow warnings, an

Re: [PATCH v4 01/13] powerpc/rtas: Add for_each_rtas_function() iterator

2023-11-20 Thread IBM
Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > Add a convenience macro for iterating over every element of the > internal function table and convert the one site that can use it. An > additional user of the macro is anticipated in changes to follow. > Reviewed-by: Aneesh Kumar K.V (

Re: [PATCH v4 02/13] powerpc/rtas: Fall back to linear search on failed token->function lookup

2023-11-20 Thread IBM
Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > Enabling any of the powerpc:rtas_* tracepoints at boot is likely to > result in an oops on RTAS platforms. For example, booting a QEMU > pseries model with 'trace_event=powerpc:rtas_input' in the command > line leads to: > > BUG: Kerne

Re: [PATCH v4 03/13] powerpc/rtas: Add function return status constants

2023-11-20 Thread IBM
Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > Not all of the generic RTAS function statuses specified in PAPR have > symbolic constants and descriptions in rtas.h. Fix this, providing a > little more background, slightly updating the existing wording, and > improving the formatting.

Re: [PATCH v4 04/13] powerpc/rtas: Factor out function descriptor lookup

2023-11-20 Thread IBM
Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > Move the function descriptor table lookup out of rtas_function_token() > into a separate routine for use in new code to follow. No functional > change. > Reviewed-by: Aneesh Kumar K.V (IBM) > Signed-off-by: Nathan Lynch > --- > arch

Re: [PATCH v4 05/13] powerpc/rtas: Facilitate high-level call sequences

2023-11-20 Thread IBM
Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > On RTAS platforms there is a general restriction that the OS must not > enter RTAS on more than one CPU at a time. This low-level > serialization requirement is satisfied by holding a spin > lock (rtas_lock) across most RTAS function inv

Re: [PATCH v4 06/13] powerpc/rtas: Serialize firmware activation sequences

2023-11-20 Thread IBM
Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > Use the function lock API to prevent interleaving call sequences of > the ibm,activate-firmware RTAS function, which typically requires > multiple calls to complete the update. While the spec does not > specifically prohibit interleaved

Re: [PATCH v4 07/13] powerpc/rtas: Warn if per-function lock isn't held

2023-11-20 Thread IBM
Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > If the function descriptor has a populated lock member, then callers > are required to hold it across calls. Now that the firmware activation > sequence is appropriately guarded, we can warn when the requirement > isn't satisfied. > > __

[PATCH 2/5] usb: gadget: fsl_udc: Convert to platform remove callback returning void

2023-11-20 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve h

[PATCH 0/5] usb: gadget: udc: Convert to platform remove callback returning void

2023-11-20 Thread Uwe Kleine-König
Hello, this patch set converts the platform drivers below drivers/usb/gadget to use .remove_new. These drivers all have an error path if the driver is still in use. Returning there early leaks resources, but fixing this isn't trivial, so I just added an error message. The patches don't make a diff

Re: [PATCH v4 2/2] ASoC: imx-rpmsg: Force codec power on in low power audio mode

2023-11-20 Thread Mark Brown
On Mon, Oct 23, 2023 at 10:07:18AM +0800, Chancel Liu wrote: > Low power audio mode requires binding codec still power on while Acore > enters into suspend so Mcore can continue playback music. > > ASoC machine driver acquires DAPM endpoints through reading > "ignore-suspend-widgets" property from

[PATCH] powerpc: add crtsavres.o to always-y instead of extra-y

2023-11-20 Thread Masahiro Yamada
crtsavres.o is linked to modules. However, as explained in commit d0e628cd817f ("kbuild: doc: clarify the difference between extra-y and always-y"), 'make modules' does not build extra-y. For example, the following command fails: $ make ARCH=powerpc LLVM=1 KBUILD_MODPOST_WARN=1 mrproper ps3_def

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Michael Ellerman
Timothy Pearson writes: > - Original Message - >> From: "Michael Ellerman" ... >> >> But we now have a new path, because io-uring can call copy_process() via >> create_io_thread() from the signal handling path. That's OK if the signal is >> handled as we return from a syscall, but it's n

Potential config regression after 89cde455 ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec")

2023-11-20 Thread Ignat Korchagin
Good day! We have recently started to evaluate Linux 6.6 and noticed that we cannot disable CONFIG_KEXEC anymore, but keep CONFIG_CRASH_DUMP enabled. It seems to be related to commit 89cde455 ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec"), where a CONFIG_KEXEC dependency

Re: [RFC - is this a bug?] powerpc/lib/sstep: Asking for some light on this, please. :)

2023-11-20 Thread Michael Ellerman
"Gustavo A. R. Silva" writes: > On 11/20/23 09:21, Naveen N Rao wrote: >> On Mon, Nov 20, 2023 at 08:33:45AM -0600, Gustavo A. R. Silva wrote: >>> On 11/20/23 08:25, Naveen N Rao wrote: On Fri, Nov 17, 2023 at 12:36:01PM -0600, Gustavo A. R. Silva wrote: > Hi all, > > I'm trying t

[PATCH] powerpc/lib: Avoid array bounds warnings in vec ops

2023-11-20 Thread Michael Ellerman
Building with GCC 13 (which has -array-bounds enabled) there are several warnings in sstep.c along the lines of: In function ‘do_byte_reverse’, inlined from ‘do_vec_load’ at arch/powerpc/lib/sstep.c:691:3, inlined from ‘emulate_loadstore’ at arch/powerpc/lib/sstep.c:3439:9: arch/po

Re: [PATCH] powerpc/lib: Avoid array bounds warnings in vec ops

2023-11-20 Thread Gustavo A. R. Silva
On 11/20/23 17:54, Michael Ellerman wrote: Building with GCC 13 (which has -array-bounds enabled) there are several warnings in sstep.c along the lines of: In function ‘do_byte_reverse’, inlined from ‘do_vec_load’ at arch/powerpc/lib/sstep.c:691:3, inlined from ‘emulate_loads

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Nicholas Piggin
On Tue Nov 21, 2023 at 2:45 AM AEST, Timothy Pearson wrote: > > > - Original Message - > > From: "Michael Ellerman" > > To: "Timothy Pearson" , "Jens Axboe" > > , "regressions" > > , "npiggin" , "christophe > > leroy" , > > "linuxppc-dev" > > Sent: Monday, November 20, 2023 1:10:06 AM >

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Nicholas Piggin
On Tue Nov 21, 2023 at 9:39 AM AEST, Michael Ellerman wrote: > Timothy Pearson writes: > > - Original Message - > >> From: "Michael Ellerman" > ... > >> > >> But we now have a new path, because io-uring can call copy_process() via > >> create_io_thread() from the signal handling path. Th

Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y

2023-11-20 Thread Nicholas Piggin
On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote: > crtsavres.o is linked to modules. However, as explained in commit > d0e628cd817f ("kbuild: doc: clarify the difference between extra-y > and always-y"), 'make modules' does not build extra-y. > > For example, the following command fails:

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Timothy Pearson
- Original Message - > From: "Michael Ellerman" > To: "Timothy Pearson" > Cc: "Jens Axboe" , "regressions" > , "npiggin" , > "christophe leroy" , "linuxppc-dev" > > Sent: Monday, November 20, 2023 5:39:52 PM > Subject: Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec

Re: Potential config regression after 89cde455 ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec")

2023-11-20 Thread Michael Ellerman
Ignat Korchagin writes: > Good day! > > We have recently started to evaluate Linux 6.6 and noticed that we > cannot disable CONFIG_KEXEC anymore, but keep CONFIG_CRASH_DUMP > enabled. It seems to be related to commit 89cde455 ("kexec: > consolidate kexec and crash options into kernel/Kconfig.kexec

Re: Potential config regression after 89cde455 ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec")

2023-11-20 Thread Baoquan He
Eric DeVolder's Oracle mail address is not available anymore, add his current mail address he told me. On 11/20/23 at 10:52pm, Ignat Korchagin wrote: > Good day! > > We have recently started to evaluate Linux 6.6 and noticed that we > cannot disable CONFIG_KEXEC anymore, but keep CONFIG_CRASH_DU

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Timothy Pearson
- Original Message - > From: "Michael Ellerman" > To: "Timothy Pearson" > Cc: "Jens Axboe" , "regressions" > , "npiggin" , > "christophe leroy" , "linuxppc-dev" > > Sent: Monday, November 20, 2023 5:39:52 PM > Subject: Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec >

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Timothy Pearson
- Original Message - > From: "Timothy Pearson" > To: "Michael Ellerman" > Cc: "Jens Axboe" , "regressions" > , "npiggin" , > "christophe leroy" , "linuxppc-dev" > > Sent: Monday, November 20, 2023 10:10:32 PM > Subject: Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec

[PATCH v5 2/2] ASoC: imx-rpmsg: Force codec power on in low power audio mode

2023-11-20 Thread Chancel Liu
Low power audio mode requires binding codec still power on while Acore enters into suspend so Mcore can continue playback music. ASoC machine driver acquires DAPM endpoints through reading "ignore-suspend-widgets" property from DT and then forces the path between these endpoints ignoring suspend.

[PATCH v5 1/2] ASoC: dt-bindings: sound-card-common: List sound widgets ignoring system suspend

2023-11-20 Thread Chancel Liu
Add a property to list audio sound widgets which are marked ignoring system suspend. Paths between these endpoints are still active over suspend of the main application processor that the current operating system is running. Signed-off-by: Chancel Liu --- .../devicetree/bindings/sound/sound-card

Re: [PATCH v9 00/27] Add support for QMC HDLC, framer infrastructure and PEF2256 framer

2023-11-20 Thread Herve Codina
Hi Mark, Jakub, Qiang, Li, On Mon, 20 Nov 2023 13:30:08 + Mark Brown wrote: > On Fri, Nov 17, 2023 at 04:47:46PM -0800, Jakub Kicinski wrote: > > On Wed, 15 Nov 2023 15:39:36 +0100 Herve Codina wrote: > > >- Removed Patches 6, 7 and 8 (patches applied) > > > > > >- Patches 7, 20,

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Nicholas Piggin
On Tue Nov 21, 2023 at 2:10 PM AEST, Timothy Pearson wrote: > - Original Message - > > From: "Michael Ellerman" > > To: "Timothy Pearson" > > Cc: "Jens Axboe" , "regressions" > > , "npiggin" , > > "christophe leroy" , "linuxppc-dev" > > > > Sent: Monday, November 20, 2023 5:39:52 PM >

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-20 Thread Nicholas Piggin
On Tue Nov 21, 2023 at 11:23 AM AEST, Timothy Pearson wrote: > > > - Original Message - > > From: "Michael Ellerman" > > To: "Timothy Pearson" > > Cc: "Jens Axboe" , "regressions" > > , "npiggin" , > > "christophe leroy" , "linuxppc-dev" > > > > Sent: Monday, November 20, 2023 5:39:52