Re: [PATCH v2 01/28] soc: fsl: cpm1: tsa: Fix __iomem addresses declaration

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:01, Herve Codina a écrit : > Running sparse (make C=1) on tsa.c raises a lot of warning such as: >--- 8< --- >warning: incorrect type in assignment (different address spaces) > expected void *[noderef] si_regs > got void [noderef] __iomem * >--- 8< --- >

Re: [PATCH v2 02/28] soc: fsl: cpm1: qmc: Fix __iomem addresses declaration

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:01, Herve Codina a écrit : > Running sparse (make C=1) on qmc.c raises a lot of warning such as: >... >warning: incorrect type in assignment (different address spaces) > expected struct cpm_buf_desc [usertype] *[noderef] __iomem bd > got struct cpm_buf_desc

Re: [PATCH v2 03/28] soc: fsl: cpm1: qmc: Fix rx channel reset

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:01, Herve Codina a écrit : > The qmc_chan_reset_rx() set the is_rx_stopped flag. This leads to an > inconsistent state in the following sequence. > qmc_chan_stop() > qmc_chan_reset() > Indeed, after the qmc_chan_reset() call, the channel must still be > stopped. Only

Re: [PATCH v2 04/28] soc: fsl: cpm1: qmc: Extend the API to provide Rx status

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > In HDLC mode, some status flags related to the data read transfer can be > set by the hardware and need to be known by a QMC consumer for further > analysis. > > Extend the API in order to provide these transfer status flags at the > read complete(

Re: [PATCH v7 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter

2023-08-08 Thread David Hildenbrand
On 08.08.23 08:29, Aneesh Kumar K V wrote: On 8/8/23 12:05 AM, David Hildenbrand wrote: On 07.08.23 14:41, David Hildenbrand wrote: On 07.08.23 14:27, Michal Hocko wrote: On Sat 05-08-23 19:54:23, Aneesh Kumar K V wrote: [...] Do you see a need for firmware-managed memory to be hotplugged in

Re: [PATCH v2 06/28] net: wan: Add support for QMC HDLC

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The QMC HDLC driver provides support for HDLC using the QMC (QUICC > Multichannel Controller) to transfer the HDLC data. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/

Re: [PATCH v2 08/28] soc: fsl: cpm1: qmc: Introduce available timeslots masks

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > Available timeslots masks define timeslots available for the related > channel. These timeslots are defined by the QMC binding. > > Timeslots used are initialized to available timeslots but can be a > subset of available timeslots. > This prepares

Re: [PATCH v2 09/28] soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa*

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > qmc_setup_tsa* are called once at initialisation. > They initialize the QMC TSA table. > In order to introduce setup function later on for dynamic timeslots > management, rename the function to avoid later confusion. > > Signed-off-by: Herve Codina

Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > Introduce the qmc_chan_setup_tsa* functions to setup entries related > to the given channel. > Use them during QMC channels setup. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > drivers/soc/fsl/qe/qmc.c | 161 ++

Re: [PATCH v2 11/28] soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans()

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The newly introduced qmc_chan_setup_tsa* functions check that the > channel entries are not already used. > These checks are also performed by qmc_check_chans() and are no more > needed. > > Remove them from qmc_check_chans(). > > Signed-off-by: H

Re: [PATCH v2 12/28] soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans()

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The timeslots checked in qmc_check_chans() are the timeslots used. > With the introduction of the available timeslots, the used timeslots > are a subset of the available timeslots. The timeslots checked during > the qmc_check_chans() call should be

Re: [PATCH v2 13/28] soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > In order to allow runtime timeslot route changes, disabling channel TSA > entries needs to be supported. > > Add support for this new feature. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > drivers/soc/fsl/qe/qmc.c | 2

Re: [PATCH v2 14/28] soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The Tx and Rx entries for a given channel are set in one function. > > In order to modify Rx entries and Tx entries independently of one other, > split this function in one for the Rx part and one for the Tx part. > > Signed-off-by: Herve Codina

Re: [PATCH v2 15/28] soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > In order to support runtime timeslot route changes, some operations will > be different according the routing table used (common Rx and Tx table or > one table for Rx and one for Tx). > > The is_tsa_64rxtx flag is introduced to avoid extra computat

Re: [PATCH v2 16/28] soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop()

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > In order to support runtime timeslot route changes, enable the > channel timeslot entries at channel start() and disable them at > channel stop(). > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > drivers/soc/fsl/qe/qmc.c

Re: [PATCH v2 17/28] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan()

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > Timeslots setting is done at channel start() and stop(). > There is no more need to do that during setup_chan(). > > Simply remove timeslot setting from setup_chan(). > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > driv

Re: [PATCH v2 18/28] soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > Introduce qmc_chan_{get,set}_ts_info() function to allow timeslots > modification at runtime. > > The modification is provided using qmc_chan_set_ts_info() and will be > applied on next qmc_chan_start(). > qmc_chan_set_ts_info() must be called with

Re: [PATCH v2 19/28] wan: qmc_hdlc: Add runtime timeslots changes support

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > QMC channels support runtime timeslots changes but nothing is done at > the QMC HDLC driver to handle these changes. > > Use existing IFACE ioctl in order to configure the timeslots to use. > > Signed-off-by: Herve Codina Reviewed-by: Christophe

Re: [PATCH v2 20/28] net: wan: Add framer framework support

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > A framer is a component in charge of an E1/T1 line interface. > Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 > frames. It also provides information related to the E1/T1 line. > > The framer framework provides a set of APIs f

Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The loop searching for a matching device based on its compatible > string is aborted when a matching disabled device is found. > This abort avoid to add devices as soon as one disabled device > is found. s/avoid/prevents/ > > Continue searching f

Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required interfacing between an analog E1/T1/J1 line and the > digital PCM system highway/H.100 bus. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Ler

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required interfacing between an analog E1/T1/J1 line and the > digital PCM system highway/H.100 bus. > > This pinmux support handles the pin muxing part (pins RP(

Re: [PATCH v2 25/28] MAINTAINERS: Add the Lantiq PEF2256 driver entry

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > After contributing the driver, add myself as the maintainer for the > Lantiq PEF2256 driver. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a

Re: [PATCH v2 26/28] ASoC: codecs: Add support for the framer codec

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The framer codec interracts with a framer. > It allows to use some of the framer timeslots as audio channels to > transport audio data over the framer E1/T1/J1 lines. > It also reports line carrier detection events through the ALSA jack > detection

Re: [PATCH v2 28/28] net: wan: fsl_qmc_hdlc: Add framer support

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > Add framer support in the fsl_qmc_hdlc driver in order to be able to > signal carrier changes to the network stack based on the framer status > Also use this framer to provide information related to the E1/T1 line > interface on IF_GET_IFACE and con

Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting

2023-08-08 Thread Herve Codina
On Tue, 8 Aug 2023 08:13:27 + Christophe Leroy wrote: > Le 26/07/2023 à 17:02, Herve Codina a écrit : > > The loop searching for a matching device based on its compatible > > string is aborted when a matching disabled device is found. > > This abort avoid to add devices as soon as one disable

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-08 Thread Linus Walleij
On Mon, Aug 7, 2023 at 3:10 PM Mark Brown wrote: > On Mon, Aug 07, 2023 at 03:05:15PM +0200, Linus Walleij wrote: > > On Wed, Jul 26, 2023 at 5:04 PM Herve Codina > > wrote: > > > > +#include "linux/bitfield.h" > > > Really? I don't think there is such a file there. > > > Do you mean and does t

Re: [PATCH v2 26/28] ASoC: codecs: Add support for the framer codec

2023-08-08 Thread Herve Codina
On Tue, 8 Aug 2023 08:26:16 + Christophe Leroy wrote: > Le 26/07/2023 à 17:02, Herve Codina a écrit : > > The framer codec interracts with a framer. > > It allows to use some of the framer timeslots as audio channels to > > transport audio data over the framer E1/T1/J1 lines. > > It also repo

[PATCH v8 0/6] Add support for memmap on memory feature on ppc64

2023-08-08 Thread Aneesh Kumar K.V
This patch series update memmap on memory feature to fall back to memmap allocation outside the memory block if the alignment rules are not met. This makes the feature more useful on architectures like ppc64 where alignment rules are different with 64K page size. This patch series is dependent on

[PATCH v8 1/6] mm/memory_hotplug: Simplify ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE kconfig

2023-08-08 Thread Aneesh Kumar K.V
Instead of adding menu entry with all supported architectures, add mm/Kconfig variable and select the same from supported architectures. No functional change in this patch. Acked-by: Michal Hocko Acked-by: David Hildenbrand Signed-off-by: Aneesh Kumar K.V --- arch/arm64/Kconfig | 4 +--- arch

[PATCH v8 2/6] mm/memory_hotplug: Allow memmap on memory hotplug request to fallback

2023-08-08 Thread Aneesh Kumar K.V
If not supported, fallback to not using memap on memmory. This avoids the need for callers to do the fallback. Acked-by: Michal Hocko Acked-by: David Hildenbrand Signed-off-by: Aneesh Kumar K.V --- drivers/acpi/acpi_memhotplug.c | 3 +-- include/linux/memory_hotplug.h | 3 ++- mm/memory_hotp

[PATCH v8 3/6] mm/memory_hotplug: Allow architecture to override memmap on memory support check

2023-08-08 Thread Aneesh Kumar K.V
Some architectures would want different restrictions. Hence add an architecture-specific override. The PMD_SIZE check is moved there. Acked-by: Michal Hocko Acked-by: David Hildenbrand Signed-off-by: Aneesh Kumar K.V --- mm/memory_hotplug.c | 24 1 file changed, 20 in

[PATCH v8 4/6] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks

2023-08-08 Thread Aneesh Kumar K.V
Currently, memmap_on_memory feature is only supported with memory block sizes that result in vmemmap pages covering full page blocks. This is because memory onlining/offlining code requires applicable ranges to be pageblock-aligned, for example, to set the migratetypes properly. This patch helps t

[PATCH v8 6/6] mm/memory_hotplug: Embed vmem_altmap details in memory block

2023-08-08 Thread Aneesh Kumar K.V
With memmap on memory, some architecture needs more details w.r.t altmap such as base_pfn, end_pfn, etc to unmap vmemmap memory. Instead of computing them again when we remove a memory block, embed vmem_altmap details in struct memory_block if we are using memmap on memory block feature. Acked-by:

[PATCH v8 5/6] powerpc/book3s64/memhotplug: Enable memmap on memory for radix

2023-08-08 Thread Aneesh Kumar K.V
Radix vmemmap mapping can map things correctly at the PMD level or PTE level based on different device boundary checks. Hence we skip the restrictions w.r.t vmemmap size to be multiple of PMD_SIZE. This also makes the feature widely useful because to use PMD_SIZE vmemmap area we require a memory bl

[PATCH -next] net/ps3_gelic_net: Use ether_addr_to_u64() to convert ethernet address

2023-08-08 Thread Li Zetao
Use ether_addr_to_u64() to convert an Ethernet address into a u64 value, instead of directly calculating, as this is exactly what this function does. Signed-off-by: Li Zetao --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

Re: [PATCH v2 1/2] PCI: Add pci_find_next_dvsec_capability to find next Designated VSEC

2023-08-08 Thread Bjorn Helgaas
Don't re-post just for this, but if you do repost, add "()" after the function name in the subject line, as you did for the 2/2 patch. On Tue, Aug 08, 2023 at 12:08:57PM +0800, Xiongfeng Wang wrote: > Some devices may have several DVSEC (Designated Vendor-Specific Extended > Capability) entries wi

Re: [PATCH v2] powerpc: Use shared font data

2023-08-08 Thread Randy Dunlap
Hi-- On 8/6/23 18:07, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > PowerPC has a 'btext' font used for the console which is almost identical > to the shared font_sun8x16, so use it rather than duplicating the data. > > They were actually identical until about a decade ago when

Re: [PATCH v2] powerpc: Use shared font data

2023-08-08 Thread Dr. David Alan Gilbert
* Randy Dunlap (rdun...@infradead.org) wrote: > Hi-- > > On 8/6/23 18:07, li...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > PowerPC has a 'btext' font used for the console which is almost identical > > to the shared font_sun8x16, so use it rather than duplicating the data. > >

Re: [PATCH -next] net/ps3_gelic_net: Use ether_addr_to_u64() to convert ethernet address

2023-08-08 Thread Geoff Levand
Hi, On 8/8/23 04:40, Li Zetao wrote: > Use ether_addr_to_u64() to convert an Ethernet address into a u64 value, > instead of directly calculating, as this is exactly what > this function does. > > Signed-off-by: Li Zetao > --- > drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +--- > 1 fil

Re: [PATCH v2] powerpc: Use shared font data

2023-08-08 Thread Randy Dunlap
On 8/8/23 10:28, Dr. David Alan Gilbert wrote: > * Randy Dunlap (rdun...@infradead.org) wrote: >> Hi-- >> >> On 8/6/23 18:07, li...@treblig.org wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> PowerPC has a 'btext' font used for the console which is almost identical >>> to the shared font_sun8

Re: [PATCH -next] ASoC: imx-audio-rpmsg: Remove redundant initialization owner in imx_audio_rpmsg_driver

2023-08-08 Thread Mark Brown
On Tue, 08 Aug 2023 10:17:28 +0800, Li Zetao wrote: > The module_rpmsg_driver() will set "THIS_MODULE" to driver.owner when > register a rpmsg_driver driver, so it is redundant initialization to set > driver.owner in the statement. Remove it for clean code. > > Applied to https://git.kernel.

Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-08-08 Thread Sean Christopherson
On Mon, Aug 07, 2023, Ackerley Tng wrote: > I’d like to propose an alternative to the refcounting approach between > the gmem file and associated kvm, where we think of KVM’s memslots as > users of the gmem file. > > Instead of having the gmem file pin the VM (i.e. take a refcount on > kvm), we co

Re: [PATCH net-next v2 00/10] net: fs_enet: Driver cleanup

2023-08-08 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 4 Aug 2023 15:30:10 +0200 you wrote: > Over the years, platform and driver initialisation have evolved into > more generic ways, and driver or platform specific stuff has gone > away, leaving stale objects b

Re: [PATCH v2] powerpc: Use shared font data

2023-08-08 Thread Dr. David Alan Gilbert
* Randy Dunlap (rdun...@infradead.org) wrote: > > > On 8/8/23 10:28, Dr. David Alan Gilbert wrote: > > * Randy Dunlap (rdun...@infradead.org) wrote: > >> Hi-- > >> > >> On 8/6/23 18:07, li...@treblig.org wrote: > >>> From: "Dr. David Alan Gilbert" > >>> > >>> PowerPC has a 'btext' font used for

Re: [PATCH v6 2/3] PCI/AER: Disable AER interrupt on suspend

2023-08-08 Thread Kai-Heng Feng
On Fri, Jul 21, 2023 at 11:58 AM Kai-Heng Feng wrote: > > On Tue, Jul 18, 2023 at 7:17 PM Bjorn Helgaas wrote: > > > > [+cc Rafael] > > > > On Fri, May 12, 2023 at 08:00:13AM +0800, Kai-Heng Feng wrote: > > > PCIe services that share an IRQ with PME, such as AER or DPC, may cause a > > > spurious