[PATCH 0/3] fbdev: Set missing owner fields in fb_ops

2023-04-24 Thread Thomas Zimmermann
Set the owner field of various drivers' fb_ops instance. The setting is required by fbcon, which acquires a reference on the fbdev driver's module. Otherwise, users could attempt to unload the module while it's still in use. Thomas Zimmermann (3): fbdev/68328fb: Init owner field of struct fb_ops

[PATCH 2/3] fbdev/ps3fb: Init owner field of struct fb_ops

2023-04-24 Thread Thomas Zimmermann
Initialize the owner field of struct fb_ops. Required to prevent module unloading while the driver is in use. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/ps3fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/ps3fb.c b/drivers/video/fbdev/ps3fb.c index 2fe08

[PATCH 3/3] fbdev/vfb: Init owner field of struct fb_ops

2023-04-24 Thread Thomas Zimmermann
Initialize the owner field of struct fb_ops. Required to prevent module unloading while the driver is in use. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vfb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/vfb.c b/drivers/video/fbdev/vfb.c index 680c88267ef

[PATCH 1/3] fbdev/68328fb: Init owner field of struct fb_ops

2023-04-24 Thread Thomas Zimmermann
Initialize the owner field of struct fb_ops. Required to prevent module unloading while the driver is in use. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/68328fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/68328fb.c b/drivers/video/fbdev/68328fb.c index

Re: [PATCH 0/3] fbdev: Set missing owner fields in fb_ops

2023-04-24 Thread Helge Deller
On 4/24/23 10:58, Thomas Zimmermann wrote: Set the owner field of various drivers' fb_ops instance. The setting is required by fbcon, which acquires a reference on the fbdev driver's module. Otherwise, users could attempt to unload the module while it's still in use. Thomas Zimmermann (3): fb

In-flight collision: DRM_AMD_DC_DCN renaming

2023-04-24 Thread Lukas Bulwahn
Dear Michael, dear Harry, dear Alex, The commit 4652ae7a51b7 ("drm/amd/display: Rename DCN config to FP") renames config DRM_AMD_DC_DCN to config DRM_AMD_DC_FP. The concurrent commit 78f0929884d4 ("powerpc/64: Always build with 128-bit long double") overrides the renaming change for the select in

Re: [PATCH v10 2/5] powerpc/crash: introduce a new config option CRASH_HOTPLUG

2023-04-24 Thread Laurent Dufour
On 23/04/2023 12:52:10, Sourabh Jain wrote: > Due to CPU/Memory hot plug/unplug or online/offline events the system > resources changes. A similar change should reflect in the loaded kdump > kernel kexec segments that describes the state of the CPU and memory of > the running kernel. > > If the kd

Re: [PATCH v10 3/5] powerpc/crash: add crash CPU hotplug support

2023-04-24 Thread Laurent Dufour
On 23/04/2023 12:52:11, Sourabh Jain wrote: > Introduce powerpc crash hotplug handler to update the necessary kexec > segments in the kernel on CPU/Memory hotplug events. Currently, these > updates are done by monitoring CPU/Memory hotplug events in userspace. > > A common crash hotplug handler is

Re: [PATCH v10 5/5] powerpc/kexec: add crash memory hotplug support

2023-04-24 Thread Laurent Dufour
On 23/04/2023 12:52:13, Sourabh Jain wrote: > Extend PowerPC arch crash hotplug handler to support memory hotplug > events. Since elfcorehdr is used to exchange the memory info between the > kernels hence it needs to be recreated to reflect the changes due to > memory hotplug events. > > The way m

Re: [PATCH v10 4/5] crash: forward memory_notify args to arch crash hotplug handler

2023-04-24 Thread Laurent Dufour
On 23/04/2023 12:52:12, Sourabh Jain wrote: > On PowePC memblock regions are used to prepare elfcorehdr which > describes the memory regions of the running kernel to the kdump kernel. > Since the notifier used for the memory hotplug crash handler gets > initiated before the update of the memblock r

Re: In-flight collision: DRM_AMD_DC_DCN renaming

2023-04-24 Thread Michael Ellerman
Hi Lukas, Lukas Bulwahn writes: > Dear Michael, dear Harry, dear Alex, > > The commit 4652ae7a51b7 ("drm/amd/display: Rename DCN config to FP") > renames config DRM_AMD_DC_DCN to config DRM_AMD_DC_FP. The concurrent > commit 78f0929884d4 ("powerpc/64: Always build with 128-bit long > double") ove

Re: [PATCH] powerpc/bpf: populate extable entries only during the last pass

2023-04-24 Thread Naveen N. Rao
Hari Bathini wrote: Hello Christophe, Thanks for the review. On 07/04/23 11:31 am, Christophe Leroy wrote: Le 06/04/2023 à 09:35, Hari Bathini a écrit : Since commit 85e031154c7c ("powerpc/bpf: Perform complete extra passes to update addresses"), two additional passes are performed to avoid

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-24 Thread Michael Ellerman
Hi Boqun, Thanks for debugging this ... Boqun Feng writes: > On Sat, Apr 22, 2023 at 09:28:39PM +0200, Joel Fernandes wrote: >> On Sat, Apr 22, 2023 at 2:47 PM Zhouyi Zhou wrote: >> > >> > Dear PowerPC and RCU developers: >> > During the RCU torture test on mainline (on the VM of Opensource Lab

Re: [PATCH v10 0/5] PowerPC: In-kernel handling of CPU/Memory hotplug/online/offline events for kdump kernel

2023-04-24 Thread Eric DeVolder
On 4/23/23 05:52, Sourabh Jain wrote: The Problem: Post CPU/Memory hot plug/unplug and online/offline events the kernel holds stale information about the system. Dump collection with stale kdump kernel might end up in dump capture failure or an inaccurate dump collection. Existi

Re: [PATCH v10 4/5] crash: forward memory_notify args to arch crash hotplug handler

2023-04-24 Thread Eric DeVolder
On 4/23/23 05:52, Sourabh Jain wrote: On PowePC memblock regions are used to prepare elfcorehdr which s/PowePC/PowerPC/ describes the memory regions of the running kernel to the kdump kernel. Since the notifier used for the memory hotplug crash handler gets initiated before the update of th

Re: [PATCH v10 2/5] powerpc/crash: introduce a new config option CRASH_HOTPLUG

2023-04-24 Thread Sourabh Jain
On 24/04/23 15:27, Laurent Dufour wrote: On 23/04/2023 12:52:10, Sourabh Jain wrote: Due to CPU/Memory hot plug/unplug or online/offline events the system resources changes. A similar change should reflect in the loaded kdump kernel kexec segments that describes the state of the CPU and memory

Re: [PATCH v10 0/5] PowerPC: In-kernel handling of CPU/Memory hotplug/online/offline events for kdump kernel

2023-04-24 Thread Sourabh Jain
On 24/04/23 19:35, Eric DeVolder wrote: On 4/23/23 05:52, Sourabh Jain wrote: The Problem: Post CPU/Memory hot plug/unplug and online/offline events the kernel holds stale information about the system. Dump collection with stale kdump kernel might end up in dump capture failure

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-24 Thread Segher Boessenkool
Hi! On Mon, Apr 24, 2023 at 11:14:00PM +1000, Michael Ellerman wrote: > Boqun Feng writes: > > On Sat, Apr 22, 2023 at 09:28:39PM +0200, Joel Fernandes wrote: > >> On Sat, Apr 22, 2023 at 2:47 PM Zhouyi Zhou wrote: > >> > by debugging, I see the r10 is assigned with r13 on c0226eb4, > >>

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-24 Thread Boqun Feng
On Mon, Apr 24, 2023 at 10:13:51AM -0500, Segher Boessenkool wrote: > Hi! > > On Mon, Apr 24, 2023 at 11:14:00PM +1000, Michael Ellerman wrote: > > Boqun Feng writes: > > > On Sat, Apr 22, 2023 at 09:28:39PM +0200, Joel Fernandes wrote: > > >> On Sat, Apr 22, 2023 at 2:47 PM Zhouyi Zhou wrote: >

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-24 Thread Segher Boessenkool
On Mon, Apr 24, 2023 at 08:28:55AM -0700, Boqun Feng wrote: > On Mon, Apr 24, 2023 at 10:13:51AM -0500, Segher Boessenkool wrote: > > At what points can r13 change? Only when some particular functions are > > called? > > r13 is the local paca: > > register struct paca_struct *local_paca as

[PATCH 0/5] crypto: Accelerated Chacha20/Poly1305 implementation

2023-04-24 Thread Danny Tsen
This patch series provide an accelerated/optimized Chacha20 and Poly1305 implementation for Power10 or later CPU (ppc64le). This module implements algorithm specified in RFC7539. The implementation provides 3.5X better performance than the baseline for Chacha20 and Poly1305 individually and 1.5X

[PATCH 1/5] An optimized Chacha20 implementation with 8-way unrolling for ppc64le.

2023-04-24 Thread Danny Tsen
Improve overall performance of chacha20 encrypt and decrypt operations for Power10 or later CPU. Signed-off-by: Danny Tsen --- arch/powerpc/crypto/chacha-p10le-8x.S | 842 ++ 1 file changed, 842 insertions(+) create mode 100644 arch/powerpc/crypto/chacha-p10le-8x.S diff

[PATCH 3/5] An optimized Poly1305 implementation with 4-way unrolling for ppc64le.

2023-04-24 Thread Danny Tsen
Improve overall performance of Poly1305 for Power10 or later CPU. Signed-off-by: Danny Tsen --- arch/powerpc/crypto/poly1305-p10le_64.S | 1075 +++ 1 file changed, 1075 insertions(+) create mode 100644 arch/powerpc/crypto/poly1305-p10le_64.S diff --git a/arch/powerpc/crypto

[PATCH 2/5] Glue code for optmized Chacha20 implementation for ppc64le.

2023-04-24 Thread Danny Tsen
Signed-off-by: Danny Tsen --- arch/powerpc/crypto/chacha-p10-glue.c | 223 ++ 1 file changed, 223 insertions(+) create mode 100644 arch/powerpc/crypto/chacha-p10-glue.c diff --git a/arch/powerpc/crypto/chacha-p10-glue.c b/arch/powerpc/crypto/chacha-p10-glue.c new file m

[PATCH 4/5] Glue code for optmized Poly1305 implementation for ppc64le.

2023-04-24 Thread Danny Tsen
Signed-off-by: Danny Tsen --- arch/powerpc/crypto/poly1305-p10-glue.c | 186 1 file changed, 186 insertions(+) create mode 100644 arch/powerpc/crypto/poly1305-p10-glue.c diff --git a/arch/powerpc/crypto/poly1305-p10-glue.c b/arch/powerpc/crypto/poly1305-p10-glue.c new

[PATCH 5/5] Update Kconfig and Makefile.

2023-04-24 Thread Danny Tsen
Defined CRYPTO_CHACHA20_P10 and CRYPTO POLY1305_P10 in Kconfig to support optimized implementation for Power10 and later CPU. Added new module driver chacha-p10-crypto and poly1305-p10-crypto. Signed-off-by: Danny Tsen --- arch/powerpc/crypto/Kconfig | 26 ++ arch/power

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-24 Thread Joel Fernandes
This is amazing debugging Boqun, like a boss! One comment below: > > > Or something simple I haven't thought of? :) > > > > At what points can r13 change? Only when some particular functions are > > called? > > > > r13 is the local paca: > > register struct paca_struct *local_paca asm("r1

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-24 Thread Boqun Feng
On Mon, Apr 24, 2023 at 12:29:00PM -0500, Segher Boessenkool wrote: > On Mon, Apr 24, 2023 at 08:28:55AM -0700, Boqun Feng wrote: > > On Mon, Apr 24, 2023 at 10:13:51AM -0500, Segher Boessenkool wrote: > > > At what points can r13 change? Only when some particular functions are > > > called? > >

RE: [PATCH 1/5] An optimized Chacha20 implementation with 8-way unrolling for ppc64le.

2023-04-24 Thread Elliott, Robert (Servers)
> +# Copyright 2023- IBM Inc. All rights reserved I don't think any such entity exists - you probably mean IBM Corporation.

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-24 Thread Michael Ellerman
Zhouyi Zhou writes: > Dear PowerPC and RCU developers: > During the RCU torture test on mainline (on the VM of Opensource Lab > of Oregon State University), SRCU-P failed with __stack_chk_fail: ... > by debugging, I see the r10 is assigned with r13 on c0226eb4, > but if there is a context-

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-24 Thread Zhouyi Zhou
On Tue, Apr 25, 2023 at 6:07 AM Michael Ellerman wrote: > > Zhouyi Zhou writes: > > Dear PowerPC and RCU developers: > > During the RCU torture test on mainline (on the VM of Opensource Lab > > of Oregon State University), SRCU-P failed with __stack_chk_fail: > ... > > by debugging, I see the r10

Re: [PATCH 1/5] An optimized Chacha20 implementation with 8-way unrolling for ppc64le.

2023-04-24 Thread Danny Tsen
This is recommended template to use for IBM copyright. Thanks. -Danny On 4/24/23 3:40 PM, Elliott, Robert (Servers) wrote: +# Copyright 2023- IBM Inc. All rights reserved I don't think any such entity exists - you probably mean IBM Corporation.

Re: [PATCH v4 2/3] PCI/AER: Disable AER interrupt on suspend

2023-04-24 Thread Sathyanarayanan Kuppuswamy
On 4/23/23 10:52 PM, Kai-Heng Feng wrote: > PCIe service that shares IRQ with PME may cause spurious wakeup on > system suspend. > > PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states > that TLP and DLLP transmission is disabled for a Link in L2/L3 Ready > (D3hot), L2 (D3cold

Re: [PATCH 2/5] Glue code for optmized Chacha20 implementation for ppc64le.

2023-04-24 Thread Herbert Xu
On Mon, Apr 24, 2023 at 02:47:23PM -0400, Danny Tsen wrote: > > +static int __init chacha_p10_init(void) > +{ > + static_branch_enable(&have_p10); > + > + return IS_REACHABLE(CONFIG_CRYPTO_SKCIPHER) ? > + crypto_register_skciphers(algs, ARRAY_SIZE(algs)) : 0; What is this for?

Re: [PATCH 2/5] Glue code for optmized Chacha20 implementation for ppc64le.

2023-04-24 Thread Herbert Xu
On Tue, Apr 25, 2023 at 01:37:22PM +0800, Herbert Xu wrote: > On Mon, Apr 24, 2023 at 02:47:23PM -0400, Danny Tsen wrote: > > > > +static int __init chacha_p10_init(void) > > +{ > > + static_branch_enable(&have_p10); > > + > > + return IS_REACHABLE(CONFIG_CRYPTO_SKCIPHER) ? > > + cryp

Re: [PATCH 2/5] Glue code for optmized Chacha20 implementation for ppc64le.

2023-04-24 Thread Herbert Xu
On Mon, Apr 24, 2023 at 02:47:23PM -0400, Danny Tsen wrote: > > +static int chacha_p10_stream_xor(struct skcipher_request *req, > + const struct chacha_ctx *ctx, const u8 *iv) > +{ > + struct skcipher_walk walk; > + u32 state[16]; > + int err; > + > + er

Re: [PATCH 4/5] Glue code for optmized Poly1305 implementation for ppc64le.

2023-04-24 Thread Herbert Xu
On Mon, Apr 24, 2023 at 02:47:25PM -0400, Danny Tsen wrote: > > + if (likely(srclen >= POLY1305_BLOCK_SIZE)) { > + bytes = round_down(srclen, POLY1305_BLOCK_SIZE); > + used = crypto_poly1305_setdctxkey(dctx, src, bytes); > + if (likely(used)) { > +

Re: [PATCH 5/5] Update Kconfig and Makefile.

2023-04-24 Thread Herbert Xu
On Mon, Apr 24, 2023 at 02:47:26PM -0400, Danny Tsen wrote: > > +config CRYPTO_CHACHA20_P10 > + tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)" > + depends on PPC64 && CPU_LITTLE_ENDIAN > + select CRYPTO_SKCIPHER I thought your IS_REACHABLE test was so that you could

Re: [PATCH v4 2/3] PCI/AER: Disable AER interrupt on suspend

2023-04-24 Thread Kai-Heng Feng
On Tue, Apr 25, 2023 at 7:47 AM Sathyanarayanan Kuppuswamy wrote: > > > > On 4/23/23 10:52 PM, Kai-Heng Feng wrote: > > PCIe service that shares IRQ with PME may cause spurious wakeup on > > system suspend. > > > > PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states > > that TLP a

Re: [PATCH v4 2/3] PCI/AER: Disable AER interrupt on suspend

2023-04-24 Thread Sathyanarayanan Kuppuswamy
Hi, On 4/24/23 10:55 PM, Kai-Heng Feng wrote: > On Tue, Apr 25, 2023 at 7:47 AM Sathyanarayanan Kuppuswamy > wrote: >> >> >> >> On 4/23/23 10:52 PM, Kai-Heng Feng wrote: >>> PCIe service that shares IRQ with PME may cause spurious wakeup on >>> system suspend. >>> >>> PCIe Base Spec 5.0, section

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-24 Thread Zhouyi Zhou
hi On Tue, Apr 25, 2023 at 6:07 AM Michael Ellerman wrote: > > Zhouyi Zhou writes: > > Dear PowerPC and RCU developers: > > During the RCU torture test on mainline (on the VM of Opensource Lab > > of Oregon State University), SRCU-P failed with __stack_chk_fail: > ... > > by debugging, I see the