Re: [PATCH] driver core: fix up some missing class.devnode() conversions.

2022-11-29 Thread Greg Kroah-Hartman
On Tue, Nov 29, 2022 at 06:33:04AM +, Christophe Leroy wrote: > > > Le 28/11/2022 à 18:35, Greg Kroah-Hartman a écrit : > > In commit ff62b8e6588f ("driver core: make struct class.devnode() take a > > const *") the ->devnode callback changed the pointer to be const, but a > > few instances of

[syzbot] WARNING in btrfs_free_reserved_data_space_noquota

2022-11-29 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b7b275e60bcd Linux 6.1-rc7 git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=158a7b7388 kernel config: https://syzkaller.appspot.com/x/.config?x=2325e409a9a893e1 dashboard link: https://syzkaller.app

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-29 Thread David Hildenbrand
On 28.11.22 23:59, Andrew Morton wrote: On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand wrote: Less chances of things going wrong that way. Just mention in the v2 cover letter that the first patch was added to make it easy to backport that fix without being hampered by merge conflicts if

Re: [PATCH] driver core: fix up some missing class.devnode() conversions.

2022-11-29 Thread Christophe Leroy
Le 29/11/2022 à 09:27, Greg Kroah-Hartman a écrit : > On Tue, Nov 29, 2022 at 06:33:04AM +, Christophe Leroy wrote: >> >> >> Le 28/11/2022 à 18:35, Greg Kroah-Hartman a écrit : >>> In commit ff62b8e6588f ("driver core: make struct class.devnode() take a >>> const *") the ->devnode callback ch

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-29 Thread Hans Verkuil
On 29/11/2022 09:48, David Hildenbrand wrote: > On 28.11.22 23:59, Andrew Morton wrote: >> On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand >> wrote: >> Less chances of things going wrong that way. Just mention in the v2 cover letter that the first patch was added to make

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-29 Thread David Hildenbrand
On 29.11.22 10:08, Hans Verkuil wrote: On 29/11/2022 09:48, David Hildenbrand wrote: On 28.11.22 23:59, Andrew Morton wrote: On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand wrote: Less chances of things going wrong that way. Just mention in the v2 cover letter that the first patch was

Re: [PATCH 1/3] firmware_loader: remove #include

2022-11-29 Thread Masahiro Yamada
On Tue, Nov 29, 2022 at 10:18 AM Russ Weight wrote: > > > > On 11/25/22 21:09, Thomas Weißschuh wrote: > > utsrelease.h is potentially generated on each build. > > By removing this unused include we can get rid of some spurious > > recompilations. > Reviewed-by: Russ Weight > > Signed-off-by: Tho

Re: [PATCH 3/3] init/version.c: remove #include

2022-11-29 Thread Masahiro Yamada
On Sun, Nov 27, 2022 at 7:18 AM Masahiro Yamada wrote: > > On Sat, Nov 26, 2022 at 2:10 PM Thomas Weißschuh wrote: > > > > Commit 2df8220cc511 ("kbuild: build init/built-in.a just once") moved > > the usage of the define UTS_VERSION to the file version-timestamp.c. > > With s/UTS_VERSION/UTS_RELE

Re: [PATCH 2/3] powerpc/book3e: remove #include

2022-11-29 Thread Masahiro Yamada
On Mon, Nov 28, 2022 at 7:59 AM Michael Ellerman wrote: > > Thomas Weißschuh writes: > > On 2022-11-26 07:36+, Christophe Leroy wrote: > >> Le 26/11/2022 à 06:10, Thomas Weißschuh a écrit : > >>> Commit 7ad4bd887d27 ("powerpc/book3e: get rid of #include > >>> ") > >>> removed the usage of th

Re: [PATCH v4 2/7] powerpc/64: Add interrupt register sanitisation macros

2022-11-29 Thread Nicholas Piggin
On Tue Nov 29, 2022 at 2:43 PM AEST, Rohan McLure wrote: > Include in asm/ppc_asm.h macros to be used in multiple successive > patches to implement zeroising architected registers in interrupt > handlers. Registers will be sanitised in this fashion in future patches > to reduce the speculation infl

Re: [PATCH v4 3/7] powerpc/64: Sanitise common exit code for interrupts

2022-11-29 Thread Nicholas Piggin
On Tue Nov 29, 2022 at 2:43 PM AEST, Rohan McLure wrote: > Interrupt code is shared between Book3E/S 64-bit systems for interrupt > handlers. Ensure that exit code correctly restores non-volatile gprs on > each system when CONFIG_INTERRUPT_SANITIZE_REGISTERS is enabled. > > Also introduce macros fo

Re: [PATCH v4 4/7] powerpc/64s: IOption for MSR stored in r12

2022-11-29 Thread Nicholas Piggin
On Tue Nov 29, 2022 at 2:43 PM AEST, Rohan McLure wrote: > Interrupt handlers in asm/exceptions-64s.S contain a great deal of common > code produced by the GEN_COMMON macros. Currently, at the exit point of > the macro, r12 will contain the contents of the MSR. A future patch will > cause these mac

Re: [PATCH v4 5/7] powerpc/64s: Zeroise gprs on interrupt routine entry on Book3S

2022-11-29 Thread Nicholas Piggin
On Tue Nov 29, 2022 at 2:43 PM AEST, Rohan McLure wrote: > Zeroise user state in gprs (assign to zero) to reduce the influence of user > registers on speculation within kernel syscall handlers. Clears occur > at the very beginning of the sc and scv 0 interrupt handlers, with > restores occurring fo

Re: [PATCH v4 7/7] powerpc/64: Sanitise user registers on interrupt in pseries, POWERNV

2022-11-29 Thread Nicholas Piggin
On Tue Nov 29, 2022 at 2:43 PM AEST, Rohan McLure wrote: > Cause pseries and POWERNV platforms to default to zeroising all potentially > user-defined registers when entering the kernel by means of any interrupt > source, reducing user-influence of the kernel and the likelihood or > producing specul

Re: [RFC PATCH 03/13] powerpc/dexcr: Handle hashchk exception

2022-11-29 Thread Nicholas Piggin
On Mon Nov 28, 2022 at 12:44 PM AEST, Benjamin Gray wrote: > Recognise and pass the appropriate signal to the user program when a > hashchk instruction triggers. This is independent of allowing > configuration of DEXCR[NPHIE], as a hypervisor can enforce this aspect > regardless of the kernel. > >

Re: [PATCH v2] powerpc/hv-gpci: Fix hv_gpci event list

2022-11-29 Thread kajoljain
On 11/24/22 17:18, Michael Ellerman wrote: > Kajol Jain writes: >> Based on getPerfCountInfo v1.018 documentation, some of the >> hv_gpci events got deprecated for platforms firmware that > ^ ^ > were platform > >> supports count

Re: [PATCH v7 0/2] arm64: support batched/deferred tlb shootdown during page reclamation

2022-11-29 Thread Yicong Yang
a gentle ping... Hi Andrew, Will and Catalin, is it ok to pick this series? Thanks. On 2022/11/17 16:26, Yicong Yang wrote: > From: Yicong Yang > > Though ARM64 has the hardware to do tlb shootdown, the hardware > broadcasting is not free. > A simplest micro benchmark shows even on snapdragon

Re: linux-next: build warnings after merge of the powerpc-objtool tree

2022-11-29 Thread Sathvika Vasireddy
Hi all, On 25/11/22 09:00, Stephen Rothwell wrote: Hi all, After merging the powerpc-objtool tree, today's linux-next build (powerpc pseries_le_defconfig) produced these warnings: arch/powerpc/kernel/head_64.o: warning: objtool: end_first_256B(): can't find starting instruction arch/powerpc/k

Re: linux-next: build warnings after merge of the powerpc-objtool tree

2022-11-29 Thread Christophe Leroy
Le 29/11/2022 à 16:13, Sathvika Vasireddy a écrit : > Hi all, > > On 25/11/22 09:00, Stephen Rothwell wrote: >> Hi all, >> >> After merging the powerpc-objtool tree, today's linux-next build (powerpc >> pseries_le_defconfig) produced these warnings: >> >> arch/powerpc/kernel/head_64.o: warning:

Re: [PATCH 10/13] powerpc/rtas: improve function information lookups

2022-11-29 Thread Nathan Lynch
Andrew Donnellan writes: > On Mon, 2022-11-28 at 18:08 -0600, Nathan Lynch wrote: >> Andrew Donnellan writes: >> > On Fri, 2022-11-18 at 09:07 -0600, Nathan Lynch wrote: >> > > Convert rtas_token() to use a lockless binary search on the >> > > function table. Fall back to the old behavior for loo

Re: [PATCH 03/13] powerpc/rtas: avoid device tree lookups in rtas_os_term()

2022-11-29 Thread Nathan Lynch
"Nicholas Piggin" writes: > On Tue Nov 29, 2022 at 4:26 AM AEST, Nathan Lynch wrote: >> "Nicholas Piggin" writes: >> > On Sat Nov 19, 2022 at 1:07 AM AEST, Nathan Lynch wrote: >> >> rtas_os_term() is called during panic. Its behavior depends on a >> >> couple of conditions in the /rtas node of th

Re: [PATCH] powerpc: dts: turris1x.dts: Add channel labels for temperature sensor

2022-11-29 Thread Pali Rohár
On Tuesday 29 November 2022 12:18:28 Michael Ellerman wrote: > Pali Rohár writes: > > Michael, could you take this patch? > > Yep. > > With these dts patches it always helps if you tell me that it passes the > DT schema checks, so that I don't get yelled at by the DT people :) Mostly dt schemas

Re: [PATCH 13/13] powerpc/rtas: place tracepoints in do_enter_rtas()

2022-11-29 Thread Nathan Lynch
Michael Ellerman writes: > Nathan Lynch writes: >> "Nicholas Piggin" writes: >>> On Sat Nov 19, 2022 at 1:07 AM AEST, Nathan Lynch wrote: Call the just-added rtas tracepoints in do_enter_rtas(), taking care to avoid function name lookups in the CPU offline path. Signed-off-by

Re: [RFC PATCH 03/13] powerpc/dexcr: Handle hashchk exception

2022-11-29 Thread Benjamin Gray
On Tue, 2022-11-29 at 20:39 +1000, Nicholas Piggin wrote: > On Mon Nov 28, 2022 at 12:44 PM AEST, Benjamin Gray wrote: > > Recognise and pass the appropriate signal to the user program when > > a > > hashchk instruction triggers. This is independent of allowing > > configuration of DEXCR[NPHIE], as

Re: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring

2022-11-29 Thread Stefano Stabellini
On Tue, 29 Nov 2022, Roger Pau Monne wrote: > The hvc machinery registers both a console and a tty device based on > the hv ops provided by the specific implementation. Those two > interfaces however have different locks, and there's no single locks > that's shared between the tty and the console

Re: [PATCH] hvc/xen: lock console list traversal

2022-11-29 Thread Stefano Stabellini
On Tue, 29 Nov 2022, Roger Pau Monne wrote: > The currently lockless access to the xen console list in > vtermno_to_xencons() is incorrect, as additions and removals from the > list can happen anytime, and as such the traversal of the list to get > the private console data for a given termno needs

Re: [PATCH v7 1/2] mm/tlbbatch: Introduce arch_tlbbatch_should_defer()

2022-11-29 Thread Andrew Morton
On Thu, 17 Nov 2022 16:26:47 +0800 Yicong Yang wrote: > From: Anshuman Khandual > > The entire scheme of deferred TLB flush in reclaim path rests on the > fact that the cost to refill TLB entries is less than flushing out > individual entries by sending IPI to remote CPUs. But architecture > ca

[PATCH v3 0/3] sed-opal: keyrings, discovery, revert, key store

2022-11-29 Thread gjoyce
From: Greg Joyce TCG SED Opal is a specification from The Trusted Computing Group that allows self encrypting storage devices (SED) to be locked at power on and require an authentication key to unlock the drive. The current SED Opal implementation in the block driver requires that authentication

[PATCH v3 1/3] block: sed-opal: Implement IOC_OPAL_DISCOVERY

2022-11-29 Thread gjoyce
From: Greg Joyce Add IOC_OPAL_DISCOVERY ioctl to return raw discovery data to a SED Opal application. This allows the application to display drive capabilities and state. Signed-off-by: Greg Joyce Reviewed-by: Christoph Hellwig Reviewed-by: Jonathan Derrick --- block/sed-opal.c

[PATCH v3 2/3] block: sed-opal: Implement IOC_OPAL_REVERT_LSP

2022-11-29 Thread gjoyce
From: Greg Joyce This is used in conjunction with IOC_OPAL_REVERT_TPR to return a drive to Original Factory State without erasing the data. If IOC_OPAL_REVERT_LSP is called with opal_revert_lsp.options bit OPAL_PRESERVE set prior to calling IOC_OPAL_REVERT_TPR, the drive global locking range will

[PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-11-29 Thread gjoyce
From: Greg Joyce Extend the SED block driver so it can alternatively obtain a key from a sed-opal kernel keyring. The SED ioctls will indicate the source of the key, either directly in the ioctl data or from the keyring. This allows the use of SED commands in scripts such as udev scripts so that

[linux-next:master] BUILD REGRESSION 13ee7ef407cfcf63f4f047460ac5bb6ba5a3447d

2022-11-29 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 13ee7ef407cfcf63f4f047460ac5bb6ba5a3447d Add linux-next specific files for 20221129 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211041320.coq8eelj-...@intel.com https

Re: [PATCH v7 1/2] mm/tlbbatch: Introduce arch_tlbbatch_should_defer()

2022-11-29 Thread Yicong Yang
On 2022/11/30 7:23, Andrew Morton wrote: > On Thu, 17 Nov 2022 16:26:47 +0800 Yicong Yang wrote: > >> From: Anshuman Khandual >> >> The entire scheme of deferred TLB flush in reclaim path rests on the >> fact that the cost to refill TLB entries is less than flushing out >> individual entries by

Re: [PATCH 3/6] powerpc/pseries: Return -EIO instead of -EINTR for H_ABORTED error

2022-11-29 Thread Andrew Donnellan
On Sun, 2022-11-06 at 15:58 -0500, Nayna Jain wrote: > Some commands for eg. "cat" might continue to retry on encountering > EINTR. This is not expected for original error code H_ABORTED. > > Map H_ABORTED to more relevant Linux error code EIO. > > Fixes: 2454a7af0f2a ("powerpc/pseries: define dr

Re: [PATCH v7 1/2] mm/tlbbatch: Introduce arch_tlbbatch_should_defer()

2022-11-29 Thread Anshuman Khandual
On 11/30/22 07:53, Yicong Yang wrote: > On 2022/11/30 7:23, Andrew Morton wrote: >> On Thu, 17 Nov 2022 16:26:47 +0800 Yicong Yang wrote: >> >>> From: Anshuman Khandual >>> >>> The entire scheme of deferred TLB flush in reclaim path rests on the >>> fact that the cost to refill TLB entries is

[PATCH] hvc/xen: prevent concurrent accesses to the shared ring

2022-11-29 Thread Roger Pau Monne
The hvc machinery registers both a console and a tty device based on the hv ops provided by the specific implementation. Those two interfaces however have different locks, and there's no single locks that's shared between the tty and the console implementations, hence the driver needs to protect i

[PATCH] hvc/xen: lock console list traversal

2022-11-29 Thread Roger Pau Monne
The currently lockless access to the xen console list in vtermno_to_xencons() is incorrect, as additions and removals from the list can happen anytime, and as such the traversal of the list to get the private console data for a given termno needs to happen with the lock held. Note users that modif

Re: [PATCH v3 1/3] block: sed-opal: Implement IOC_OPAL_DISCOVERY

2022-11-29 Thread Hannes Reinecke
On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: From: Greg Joyce Add IOC_OPAL_DISCOVERY ioctl to return raw discovery data to a SED Opal application. This allows the application to display drive capabilities and state. Signed-off-by: Greg Joyce Reviewed-by: Christoph Hellwig Reviewed-by:

Re: [PATCH v3 2/3] block: sed-opal: Implement IOC_OPAL_REVERT_LSP

2022-11-29 Thread Hannes Reinecke
On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: From: Greg Joyce This is used in conjunction with IOC_OPAL_REVERT_TPR to return a drive to Original Factory State without erasing the data. If IOC_OPAL_REVERT_LSP is called with opal_revert_lsp.options bit OPAL_PRESERVE set prior to calling IO

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-11-29 Thread Hannes Reinecke
On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: From: Greg Joyce Extend the SED block driver so it can alternatively obtain a key from a sed-opal kernel keyring. The SED ioctls will indicate the source of the key, either directly in the ioctl data or from the keyring. This allows the use o

Re: [PATCH 13/13] powerpc/rtas: place tracepoints in do_enter_rtas()

2022-11-29 Thread Michael Ellerman
Nathan Lynch writes: > Michael Ellerman writes: >> Nathan Lynch writes: >>> "Nicholas Piggin" writes: On Sat Nov 19, 2022 at 1:07 AM AEST, Nathan Lynch wrote: > Call the just-added rtas tracepoints in do_enter_rtas(), taking care > to avoid function name lookups in the CPU offline