Re: [PATCH v3] i2c/pasemi: PASemi I2C controller IRQ enablement

2022-10-08 Thread Sven Peter
Hi, > On 7. Oct 2022, at 02:43, Arminder Singh wrote: > > This patch adds IRQ support to the PASemi I2C controller driver to > increase the performace of I2C transactions on platforms with PASemi I2C > controllers. While primarily intended for Apple silicon platforms, this > patch should als

Re: [PATCH v4 2/6] treewide: use prandom_u32_max() when possible

2022-10-08 Thread Julia Lawall
> >> @minus_one@ > >> expression FULL; > >> @@ > >> > >> - (get_random_int() & ((FULL) - 1) > >> + prandom_u32_max(FULL) > > > >Ahh, well, okay, this is the example I mentioned above. Only works if > >FULL is saturated. Any clever way to get coccinelle to prove that? Can > >it look at the value of

Re: [PATCH v4 2/6] treewide: use prandom_u32_max() when possible

2022-10-08 Thread Andy Shevchenko
On Fri, Oct 07, 2022 at 08:50:43PM -0700, Kees Cook wrote: > On October 7, 2022 7:21:28 PM PDT, "Jason A. Donenfeld" > wrote: > >On Fri, Oct 07, 2022 at 03:47:44PM -0700, Kees Cook wrote: > >> On Fri, Oct 07, 2022 at 12:01:03PM -0600, Jason A. Donenfeld wrote: ... > >> These are more fun, but C

Re: [RFC PATCH 4/5] irq_work: Trace calls to arch_irq_work_raise()

2022-10-08 Thread Steven Rostedt
On Fri, 7 Oct 2022 16:45:32 +0100 Valentin Schneider wrote: > } > > +static inline void irq_work_raise(void) > +{ > + if (arch_irq_work_has_interrupt()) > + trace_ipi_send_cpu(_RET_IP_, smp_processor_id()); To save on the branch, let's make the above: if (trace_ipi_se

Re: [RFC PATCH 0/5] Generic IPI sending tracepoint

2022-10-08 Thread Steven Rostedt
On Fri, 7 Oct 2022 17:01:33 -0300 Marcelo Tosatti wrote: > > As for the targeted CPUs, the existing tracepoint does export them, albeit > > in > > cpumask form, which is quite inconvenient from a tooling perspective. For > > instance, as far as I'm aware, it's not possible to do event filtering

Re: [PATCH] soc: fsl: qe: Add check for ioremap

2022-10-08 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jiasheng-Jiang/soc-fsl-qe-Add-check-for-ioremap/20221008-104034 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next confi

Re: [PATCH v5 0/7] treewide cleanup of random integer usage

2022-10-08 Thread Greg Kroah-Hartman
On Fri, Oct 07, 2022 at 11:53:52PM -0600, Jason A. Donenfeld wrote: > Changes v4->v5: > - Coccinelle is now used for as much mechanical aspects as possible, > with mechanical parts split off from non-mechanical parts. This should > drastically reduce the amount of code that needs to be reviewed

Re: [PATCH v5 0/7] treewide cleanup of random integer usage

2022-10-08 Thread Yury Norov
On Fri, Oct 07, 2022 at 11:53:52PM -0600, Jason A. Donenfeld wrote: > Changes v4->v5: > - Coccinelle is now used for as much mechanical aspects as possible, > with mechanical parts split off from non-mechanical parts. This should > drastically reduce the amount of code that needs to be reviewed

RE: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-08 Thread David Laight
From: Jason A. Donenfeld > Sent: 07 October 2022 18:56 ... > > Given these kinds of less mechanical changes, it may make sense to split > > these from the "trivial" conversions in a treewide patch. The chance of > > needing a revert from the simple 1:1 conversions is much lower than the > > need to

RE: [PATCH v4 2/6] treewide: use prandom_u32_max() when possible

2022-10-08 Thread David Laight
From: Jason A. Donenfeld > Sent: 07 October 2022 19:01 > > Rather than incurring a division or requesting too many random bytes for > the given range, use the prandom_u32_max() function, which only takes > the minimum required bytes from the RNG and avoids divisions. > ... > --- a/lib/cmdline_kun

RE: [PATCH v4 4/6] treewide: use get_random_u32() when possible

2022-10-08 Thread David Laight
From: Jason A. Donenfeld > Sent: 07 October 2022 19:01 > > The prandom_u32() function has been a deprecated inline wrapper around > get_random_u32() for several releases now, and compiles down to the > exact same code. Replace the deprecated wrapper with a direct call to > the real function. The s

Re: [PATCH v4 2/6] treewide: use prandom_u32_max() when possible

2022-10-08 Thread Jason A. Donenfeld
On Sat, Oct 08, 2022 at 10:08:03PM +, David Laight wrote: > From: Jason A. Donenfeld > > Sent: 07 October 2022 19:01 > > > > Rather than incurring a division or requesting too many random bytes for > > the given range, use the prandom_u32_max() function, which only takes > > the minimum requir

Re: [PATCH v4 4/6] treewide: use get_random_u32() when possible

2022-10-08 Thread Jason A. Donenfeld
On Sat, Oct 08, 2022 at 10:18:45PM +, David Laight wrote: > From: Jason A. Donenfeld > > Sent: 07 October 2022 19:01 > > > > The prandom_u32() function has been a deprecated inline wrapper around > > get_random_u32() for several releases now, and compiles down to the > > exact same code. Repla

[powerpc:next] BUILD SUCCESS 376b3275c19f83d373e841e9af2d7658693190b9

2022-10-08 Thread kernel test robot
randconfig-r043-20221008 powerpc ep8248e_defconfig arm badge4_defconfig sh r7780mp_defconfig arc randconfig-r043-20221003 mips db1xxx_defconfig arcvdk_hs38_defconfig alpha

Re: [PATCH v4 4/6] treewide: use get_random_u32() when possible

2022-10-08 Thread Jason A. Donenfeld
On Sat, Oct 8, 2022 at 4:37 PM Jason A. Donenfeld wrote: > > On Sat, Oct 08, 2022 at 10:18:45PM +, David Laight wrote: > > From: Jason A. Donenfeld > > > Sent: 07 October 2022 19:01 > > > > > > The prandom_u32() function has been a deprecated inline wrapper around > > > get_random_u32() for se

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-08 Thread Jason A. Donenfeld
On Sat, Oct 08, 2022 at 09:53:33PM +, David Laight wrote: > From: Jason A. Donenfeld > > Sent: 07 October 2022 18:56 > ... > > > Given these kinds of less mechanical changes, it may make sense to split > > > these from the "trivial" conversions in a treewide patch. The chance of > > > needing a

Re: [PATCH v5 0/7] treewide cleanup of random integer usage

2022-10-08 Thread Kees Cook
On Fri, Oct 07, 2022 at 11:53:52PM -0600, Jason A. Donenfeld wrote: > This is a five part treewide cleanup of random integer handling. The > rules for random integers are: Reviewing the delta between of my .cocci rules and your v5, everything matches, except for get_random_int() conversions for fi

Re: [PATCH v3 2/7] ASoC: imx-audio-rpmsg: Create rpmsg channel for MICFIL

2022-10-08 Thread Shengjiu Wang
On Fri, Sep 30, 2022 at 2:46 PM Chancel Liu wrote: > Rpmsg channel for MICFIL can also be created through rpmsg name service > announcement. If this driver is probed, Cortex-A can access MICFIL > which is actually controlled by Cortex-M through rpmsg channel for > MICFIL. This driver also helps r

Re: [PATCH v3 3/7] ASoC: imx-pcm-rpmsg: Register different platform drivers

2022-10-08 Thread Shengjiu Wang
On Fri, Sep 30, 2022 at 2:46 PM Chancel Liu wrote: > This patch can register different ASoC platform drivers if there are > several rpmsg channels. Thus sound cards based on different rpmsg > channels can link to their respective platform drivers. Besides, the > name of driver is equal to the nam

Re: [PATCH v3 4/7] ASoC: imx-pcm-rpmsg: Multi-channel support for sound card based on rpmsg

2022-10-08 Thread Shengjiu Wang
On Fri, Sep 30, 2022 at 2:46 PM Chancel Liu wrote: > Some sound card based on rpmsg may support multi-channel. The number of > channels can be sent to Cortex-M in rpmsg for process. > > Signed-off-by: Chancel Liu > Acked-by: Shengjiu Wang Best regards Wang Shengjiu > --- > sound/soc/fsl/imx

Re: [PATCH v3 5/7] ASoC: fsl_rpmsg: Register different ASoC machine devices

2022-10-08 Thread Shengjiu Wang
On Fri, Sep 30, 2022 at 2:46 PM Chancel Liu wrote: > This driver helps register ASoC machine device thus use of > PLATFORM_DEVID_AUTO macro in API can automatically create device for > each sound card based on rpmsg. > > Signed-off-by: Chancel Liu > Acked-by: Shengjiu Wang Best regards Wang S

Re: [PATCH v3 6/7] ASoC: fsl_rpmsg: Multi-channel support in CPU DAI driver

2022-10-08 Thread Shengjiu Wang
On Fri, Sep 30, 2022 at 2:46 PM Chancel Liu wrote: > Some sound card based on rpmsg may support multi-channel. This patch > expands the maximum channels to 32. > > Signed-off-by: Chancel Liu > Acked-by: Shengjiu Wang Best regards Wang Shengjiu > --- > sound/soc/fsl/fsl_rpmsg.c | 4 ++-- > 1

Re: [PATCH v3 7/7] ASoC: imx-rpmsg: Assign platform driver used by machine driver to link with

2022-10-08 Thread Shengjiu Wang
On Fri, Sep 30, 2022 at 2:46 PM Chancel Liu wrote: > Each ASoC platform driver is named by rpmsg channel. ASoC machine > driver can parse "fsl,rpmsg-channel-name" property to figure out which > ASoC platform driver it should link with. > > Signed-off-by: Chancel Liu > Acked-by: Shengjiu Wang