At 2022-09-05 11:25:38, "Michael Ellerman" wrote:
>Liang He writes:
>> We should call of_node_put() for the reference 'tsi' returned by
>> of_get_parent() which will increase the refcount.
>>
>> Signed-off-by: Liang He
>> ---
>> changelog:
>>
>> v2: use more conservative way to call of_node
On 03.09.22 09:07, Christophe Leroy wrote:
+Resending with valid powerpc list address
Le 02/09/2022 à 20:52, David Hildenbrand a écrit :
Adding Christophe on Cc:
Christophe do you know if is_hugepd is true for all hugetlb entries, not
just hugepd?
is_hugepd() is true if and only if the direc
The page table fragment allocator is a simple per-mm slab allocator.
It can be quite wasteful of space for small processes, as well as being
expensive to initialise. It does not do well at NUMA awareness.
This is a quick hack at addressing some of those problems, but it's not
complete. It doesn't
Le 05/09/2022 à 10:37, David Hildenbrand a écrit :
> On 03.09.22 09:07, Christophe Leroy wrote:
>> +Resending with valid powerpc list address
>>
>> Le 02/09/2022 à 20:52, David Hildenbrand a écrit :
>> Adding Christophe on Cc:
>>
>> Christophe do you know if is_hugepd is true for all
update_mmu_cache() voids when hash page tables are not used.
On PPC32 that means when MMU_FTR_HPTE_TABLE is not defined.
On PPC64 that means when RADIX is enabled.
Rename core part of update_mmu_cache() as __update_mmu_cache()
and include the initial verification in an inlined caller.
Signed-off-
On 05.09.22 11:33, Christophe Leroy wrote:
Le 05/09/2022 à 10:37, David Hildenbrand a écrit :
On 03.09.22 09:07, Christophe Leroy wrote:
+Resending with valid powerpc list address
Le 02/09/2022 à 20:52, David Hildenbrand a écrit :
Adding Christophe on Cc:
Christophe do you know if is_hugep
Christophe Leroy wrote:
Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit :
objtool is throwing *unannotated intra-function call* warnings in
.c files with a few instructions that are marked unreachable. The
problem comes from the annotate_unreachable() macro that is
called by unreachable(). T
https://bugzilla.kernel.org/show_bug.cgi?id=216427
Erhard F. (erhar...@mailbox.org) changed:
What|Removed |Added
Summary|OF fails to handle some PCI |[bisected] OF fails to
https://bugzilla.kernel.org/show_bug.cgi?id=216427
--- Comment #3 from Erhard F. (erhar...@mailbox.org) ---
Created attachment 301744
--> https://bugzilla.kernel.org/attachment.cgi?id=301744&action=edit
bisect.log
--
You may reply to this email to add a comment.
You are receiving this mail be
Christophe Leroy wrote:
Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit :
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 4c466acdc70d..dc05cd23c233 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -237,6 +237,7 @@ config PPC
select HAVE_MOD_ARCH_SPECIF
On Mon, Sep 05, 2022 at 10:24:40AM +0530, Athira Rajeev wrote:
> The affinity code in "affinity_set" function access array
> named "sched_cpus". The size for this array is allocated in
> affinity_setup function which is nothing but value from
> get_cpu_set_size. This is used to contain the cpumask
Segher Boessenkool wrote:
On Wed, Aug 31, 2022 at 12:50:07PM +, Christophe Leroy wrote:
Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit :
> + opcode = insn >> 26;
> +
> + switch (opcode) {
> + case 18: /* bl */
case 18 is more than 'bl', it includes also 'b'.
In both cases, the calcula
Peter Zijlstra wrote:
On Mon, Aug 29, 2022 at 11:22:12AM +0530, Sathvika Vasireddy wrote:
With objtool enabled, below warnings are seen when trying to build:
drivers/crypto/vmx/aesp8-ppc.o: warning: objtool: aes_p8_set_encrypt_key+0x44:
unannotated intra-function call
drivers/crypto/vmx/aesp8
Peter Zijlstra wrote:
On Mon, Aug 29, 2022 at 11:22:18AM +0530, Sathvika Vasireddy wrote:
Architectures can select HAVE_NOP_MCOUNT if they choose
to nop out mcount call sites. If that config option is
selected, then --mnop is passed as an option to objtool,
along with --mcount.
Also, make sure
On Mon, Aug 29, 2022 at 11:22:10AM +0530, Sathvika Vasireddy wrote:
> objtool does not add STT_NOTYPE symbols with size 0 to the
I suspect we can fix that once:
https://lkml.kernel.org/r/20220902130949.789826...@infradead.org
lands.
> On 05-Sep-2022, at 3:30 PM, Jiri Olsa wrote:
>
> On Mon, Sep 05, 2022 at 10:24:40AM +0530, Athira Rajeev wrote:
>> The affinity code in "affinity_set" function access array
>> named "sched_cpus". The size for this array is allocated in
>> affinity_setup function which is nothing but value fr
On Mon, Aug 29, 2022 at 11:22:09AM +0530, Sathvika Vasireddy wrote:
> Powerpc instructions must be word-aligned. Currently,
> there is an alignment of 16 bytes (by default), and it is
> much more than what is required for powerpc (4 bytes).
>
> The default expansion of __ALIGN() macro is:
> #defin
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller :
On Fri, 2 Sep 2022 17:57:22 -0400 you wrote:
> This series contains several cleanup patches for dpaa/fman. While they
> are intended to prepare for a phylink conversion, they stand on their
> own. This series was
The cpu mask init code in "record__mmap_cpu_mask_init"
function access "bits" array part of "struct mmap_cpu_mask".
The size of this array is the value from cpu__max_cpu().cpu.
This array is used to contain the cpumask value for each
cpu. While setting bit for each cpu, it calls "set_bit" function
The affinity code in "affinity_set" function access array
named "sched_cpus". The size for this array is allocated in
affinity_setup function which is nothing but value from
get_cpu_set_size. This is used to contain the cpumask value
for each cpu. While setting bit for each cpu, it calls
"set_bit"
Le 05/09/2022 à 11:46, David Hildenbrand a écrit :
> On 05.09.22 11:33, Christophe Leroy wrote:
>>
>>
>> Le 05/09/2022 à 10:37, David Hildenbrand a écrit :
>>> On 03.09.22 09:07, Christophe Leroy wrote:
+Resending with valid powerpc list address
Le 02/09/2022 à 20:52, David Hildenb
Yes I think the assumption is correct for user pages hence for GUP.
By the way the discussion started with PTDUMP. For PTDUMP we need huge
page directories to be taken into account. And for anything that
involves kernel pages like VMAP or VMALLOC.
Yes, makes perfect sense to me now that you exp
https://bugzilla.kernel.org/show_bug.cgi?id=216368
--- Comment #6 from David Sterba (dste...@suse.com) ---
(In reply to Christophe Leroy from comment #3)
> This happens when you get an IRQ while being deep into BTRFS handling it
> seems.
>
> It should be investigated with BTRFS team why the calls
Le 05/09/2022 à 10:50, Nicholas Piggin a écrit :
> The page table fragment allocator is a simple per-mm slab allocator.
> It can be quite wasteful of space for small processes, as well as being
> expensive to initialise. It does not do well at NUMA awareness.
>
> This is a quick hack at address
On Mon, Sep 05, 2022 at 11:32:48AM -0700, Suren Baghdasaryan wrote:
> On Mon, Sep 5, 2022 at 5:32 AM 'Michal Hocko' via kernel-team
> wrote:
> >
> > Unless I am missing something, this is not based on the Maple tree
> > rewrite, right? Does the change in the data structure makes any
> > difference
Hi!
On Mon, Sep 05, 2022 at 04:15:07PM +0530, Naveen N. Rao wrote:
> Segher Boessenkool wrote:
> >>> + if ((insn & 3) == 1) {
> >>> + *type = INSN_CALL;
> >>> + *immediate = insn & 0x3fc;
> >>> + if (*immediate & 0x200)
> >>> +
Currently in pas_pci_init() a reference to the root node is leaked due
to a missing of_node_put(). Instead just use of_root directly.
Note that converting to of_find_compatible_node(NULL, ...) would
not be entirely equivalent, because that would check the compatible
property of the root node, wher
On Thu, 2022-09-01 at 07:01 +, Christophe Leroy wrote:
>
>
> Le 01/09/2022 à 07:58, Benjamin Gray a écrit :
> > From: Russell Currey
> >
> > powerpc allocates a text poke area of one page that is used by
> > patch_instruction() to modify read-only text when STRICT_KERNEL_RWX
> > is enabled.
> On 05-Sep-2022, at 12:08 PM, Ganesh Goudar wrote:
>
> Part of machine check error handling is done in realmode,
> As of now instrumentation is not possible for any code that
> runs in realmode.
> When MCE is injected on KASAN enabled kernel, crash is
> observed, Hence force inline or mark no
> @@ -9752,10 +9889,13 @@ void perf_tp_event(u16 event_type, u64 count, void
> *record, int entry_size,
> struct trace_entry *entry = record;
>
> rcu_read_lock();
> - ctx = rcu_dereference(task->perf_event_ctxp[perf_sw_context]);
> + ctx = rcu_
Since last posting I've added more debugging and done some test code
that tires to irritate this on hardware (e.g., put DEC into the
MUST_HARD_MASK category, set_dec(1) in the hash fault handler, run
with perf, etc), and also trigger interrupts at various points stepping
through in the simulator.
If a synchronous interrupt (e.g., hash fault) is taken inside an
irqs-disabled region which has MSR[EE]=1, then an asynchronous interrupt
that is PACA_IRQ_MUST_HARD_MASK (e.g., PMI) is taken inside the
synchronous interrupt handler, then the synchronous interrupt will
return with MSR[EE]=1 and the
When irqs are soft-disabled, MSR[EE] is volatile and can change from
1 to 0 asynchronously (if a PACA_IRQ_MUST_HARD_MASK interrupt hits).
So it can not be used to check hard IRQ enabled status, except to
confirm it is disabled.
ppc64_runlatch_o* functions use MSR this way to decide whether to
re-e
Prior changes eliminated cases of masked PACA_IRQ_MUST_HARD_MASK
interrupts that re-fire due to MSR[EE] being enabled while they are
pending. Add a debug check in the masked interrupt handler to catch
if this occurs.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/kernel/exceptions-64s.S | 10 ++
Le 06/09/2022 à 03:03, Michael Ellerman a écrit :
> Currently in pas_pci_init() a reference to the root node is leaked due
> to a missing of_node_put(). Instead just use of_root directly.
>
> Note that converting to of_find_compatible_node(NULL, ...) would
> not be entirely equivalent, because t
Le 05/09/2022 à 22:43, Segher Boessenkool a écrit :
> Hi!
>
> On Mon, Sep 05, 2022 at 04:15:07PM +0530, Naveen N. Rao wrote:
>> Segher Boessenkool wrote:
> + if ((insn & 3) == 1) {
> + *type = INSN_CALL;
> + *immediate = insn & 0x3fc;
>
36 matches
Mail list logo