Re: [PATCH linux-next] power:pkeys: fix bugon.cocci warnings

2022-05-07 Thread Christophe Leroy
Le 02/05/2022 à 15:24, Michael Ellerman a écrit : > CGEL writes: >> From: Jing Yangyang >> >> Use BUG_ON instead of a if condition followed by BUG. >> >> ./arch/powerpc/include/asm/book3s/64/pkeys.h:21:2-5:WARNING >> Use BUG_ON instead of if condition followed by BUG. >> ./arch/powerpc/include/

Re: request_module DoS

2022-05-07 Thread Christophe Leroy
+ linuxppc list Le 07/05/2022 à 05:08, Herbert Xu a écrit : > Hi: > > There are some code paths in the kernel where you can reliably > trigger a request_module of a non-existant module. For example, > if you attempt to load a non-existent crypto algorithm, or create > a socket of a non-existent

Re: request_module DoS

2022-05-07 Thread Luis Chamberlain
On Sat, May 07, 2022 at 07:10:23AM +, Christophe Leroy wrote: > > There are some code paths in the kernel where you can reliably > > trigger a request_module of a non-existant module. For example, > > if you attempt to load a non-existent crypto algorithm, or create > > a socket of a non-exist

Re: [PATCH v6 00/23] Rust support

2022-05-07 Thread Kees Cook
On Sat, May 07, 2022 at 07:23:58AM +0200, Miguel Ojeda wrote: > ## Patch series status > > The Rust support is still to be considered experimental. However, > support is good enough that kernel developers can start working on the > Rust abstractions for subsystems and write drivers and other modul

Re: [PATCH linux-next] power:pkeys: fix bugon.cocci warnings

2022-05-07 Thread Arnd Bergmann
On Sat, May 7, 2022 at 9:04 AM Christophe Leroy wrote: > Le 02/05/2022 à 15:24, Michael Ellerman a écrit : > > CGEL writes: > >> From: Jing Yangyang > >> > >> Use BUG_ON instead of a if condition followed by BUG. > >> > >> ./arch/powerpc/include/asm/book3s/64/pkeys.h:21:2-5:WARNING > >> Use BUG_

Re: [PATCH 2/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when migration

2022-05-07 Thread Mike Kravetz
On 5/5/22 20:39, Baolin Wang wrote: > > On 5/6/2022 7:53 AM, Mike Kravetz wrote: >> On 4/29/22 01:14, Baolin Wang wrote: >>> On some architectures (like ARM64), it can support CONT-PTE/PMD size >>> hugetlb, which means it can support not only PMD/PUD size hugetlb: >>> 2M and 1G, but also CONT-PTE/

[PATCH v2 2/4] powerpc/mpc5xxx: Switch mpc5xxx_get_bus_frequency() to use fwnode

2022-05-07 Thread Andy Shevchenko
Switch mpc5xxx_get_bus_frequency() to use fwnode in order to help cleaning up other parts of the kernel from OF specific code. No functional change intended. Signed-off-by: Andy Shevchenko Acked-by: Chris Packham # for i2c-mpc Acked-by: Wolfram Sang # for the I2C part Acked-by: Mark Brown Ack

[PATCH v2 3/4] powerpc/52xx: Get rid of of_node assignment

2022-05-07 Thread Andy Shevchenko
Let GPIO library assign of_node from the parent device. This allows to move GPIO library and drivers to use fwnode APIs instead of being stuck with OF-only interfaces. Signed-off-by: Andy Shevchenko --- v2: no changes arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 18 -- 1 file chan

[PATCH v2 1/4] powerpc/52xx: Remove dead code, i.e. mpc52xx_get_xtal_freq()

2022-05-07 Thread Andy Shevchenko
It seems mpc52xx_get_xtal_freq() is not used anywhere. Remove dead code. Signed-off-by: Andy Shevchenko Reviewed-by: Wolfram Sang --- v2: collected tags arch/powerpc/include/asm/mpc52xx.h | 1 - arch/powerpc/platforms/52xx/mpc52xx_common.c | 37 2 files changed,

[PATCH v2 4/4] powerpc/52xx: Convert to use fwnode API

2022-05-07 Thread Andy Shevchenko
We may convert the GPT driver to use fwnode API for the sake of consistency of the used APIs inside the driver. Signed-off-by: Andy Shevchenko --- v2: no changes arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 47 +++ 1 file changed, 22 insertions(+), 25 deletions(-) diff --git

Re: [PATCH v2 21/25] powerpc/ftrace: Don't use copy_from_kernel_nofault() in module_trampoline_target()

2022-05-07 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Christophe-Leroy/powerpc-ftrace-optimisation-and-cleanup-and-more-v2/20220507-145034 base: https://git.kernel.org/pub

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-07 Thread Arnd Bergmann
On Sat, May 7, 2022 at 2:01 AM Finn Thain wrote: > On Fri, 6 May 2022, Niklas Schnelle wrote: > > On Fri, 2022-05-06 at 19:12 +1000, Finn Thain wrote: > > > On Thu, 5 May 2022, Bjorn Helgaas wrote: > > > > > > > > I mooted a s390 inb() implementation like "return ~0" because that's > > > > what ha

Re: [PATCH v6 00/23] Rust support

2022-05-07 Thread Miguel Ojeda
Hi David, On Sat, May 7, 2022 at 11:29 AM David Gow wrote: > > It's great to see some KUnit support here! Thanks! > It's also possible to run these tests using the KUnit wrapper tool with: > $ ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_RUST=y > --make_options LLVM=1 --arch x86_64 '

Re: request_module DoS

2022-05-07 Thread Luis Chamberlain
On Sat, May 07, 2022 at 01:02:20AM -0700, Luis Chamberlain wrote: > You can try to reproduce by using adding a new test type for crypto-aegis256 > on lib/test_kmod.c. These tests however can try something similar but other > modules. > > /tools/testing/selftests/kmod/kmod.sh -t 0008 > /tools/testi

[PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message

2022-05-07 Thread Pieterjan Camerlynck
In commit ("ASoC: fsl_sai: add sai master mode support") the loop was changed to start iterating from 1 instead of 0. The error message however was not updated, reporting the wrong clock to the user. Signed-off-by: Pieterjan Camerlynck --- sound/soc/fsl/fsl_sai.c | 2 +- 1 file changed, 1 inser

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-07 Thread Finn Thain
Hi Arnd, On Sat, 7 May 2022, Arnd Bergmann wrote: > On Sat, May 7, 2022 at 2:01 AM Finn Thain wrote: > > On Fri, 6 May 2022, Niklas Schnelle wrote: > > > On Fri, 2022-05-06 at 19:12 +1000, Finn Thain wrote: > > > > On Thu, 5 May 2022, Bjorn Helgaas wrote: > > > > > > > > > > I mooted a s390 in

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-07 Thread Finn Thain
On Sun, 8 May 2022, I wrote: > > That suggests to me that we need a "bool CONFIG_WARINGS_INTO_ERRORS" to > control -Werror, which could be disabled for .config files (like make > allmodconfig) where it is not helping. > I just noticed that we already have CONFIG_WERROR. So perhaps something

[PATCH] KVM: PPC: Book3S HV: Fix typo in a comment

2022-05-07 Thread Jason Wang
The double `the' in the comment in line 212 is repeated. Remove one of them from the comment. Signed-off-by: Jason Wang --- arch/powerpc/kvm/book3s_xive_native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_xive_native.c b/arch/powerpc/kvm/book3s_x