Re: Build regressions/improvements in v5.17-rc7

2022-03-28 Thread Christophe Leroy
Le 07/03/2022 à 10:56, Geert Uytterhoeven a écrit : > On Mon, Mar 7, 2022 at 10:21 AM Geert Uytterhoeven > wrote: >> JFYI, when comparing v5.17-rc7[1] to v5.17-rc6[3], the summaries are: >>- build errors: +4/-1 > > >+ error: arch/powerpc/kvm/book3s_64_entry.o: relocation truncated to

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.18-1 tag

2022-03-28 Thread Michael Ellerman
Linus Torvalds writes: > On Fri, Mar 25, 2022 at 3:25 AM Michael Ellerman wrote: >> >> Livepatch support for 32-bit is probably the standout new feature, otherwise >> mostly just >> lots of bits and pieces all over the board. > > Heh. I would have expected 32-bit ppc to be entirely legacy by now

[PATCH] sched: topology: add input parameter for sched_domain_flags_f()

2022-03-28 Thread Qing Wang
From: Wang Qing sched_domain_flags_f() are statically set now, but actually, we can get a lot of necessary information based on the cpu_map. e.g. we can know whether its cache is shared. Allows custom extension without affecting current. Signed-off-by: Wang Qing --- arch/powerpc/kernel/smp.c

Re: [PATCH] livepatch: Remove klp_arch_set_pc() and asm/livepatch.h

2022-03-28 Thread Peter Zijlstra
On Mon, Mar 28, 2022 at 08:26:48AM +0200, Christophe Leroy wrote: > All three versions of klp_arch_set_pc() do exactly the same: they > call ftrace_instruction_pointer_set(). > > Call ftrace_instruction_pointer_set() directly and remove > klp_arch_set_pc(). > > As klp_arch_set_pc() was the only t

Re: [PATCH v4 1/2] Revert "powerpc: Set max_mapnr correctly"

2022-03-28 Thread Michael Ellerman
Kefeng Wang writes: > Hi maintainers, > > I saw the patches has been reviewed[1], could they be merged? Maybe I'm just misreading the change log, but it seems wrong that we need to add extra checks. pfn_valid() shouldn't return true for vmalloc addresses in the first place, shouldn't we fix that

Re: [PATCH 21/22] rtw89: Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Larry Finger writes: > On 3/26/22 11:59, Benjamin Stürz wrote: >> This replaces comments with C99's designated >> initializers because the kernel supports them now. >> >> Signed-off-by: Benjamin Stürz >> --- >> drivers/net/wireless/realtek/rtw89/coex.c | 40 +++ >> 1 file

Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Benjamin Stürz writes: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things the wrong way. I'm sorry for that. Just

Re: [PATCH v4 1/2] Revert "powerpc: Set max_mapnr correctly"

2022-03-28 Thread Christophe Leroy
Le 28/03/2022 à 12:37, Michael Ellerman a écrit : > Kefeng Wang writes: >> Hi maintainers, >> >> I saw the patches has been reviewed[1], could they be merged? > > Maybe I'm just misreading the change log, but it seems wrong that we > need to add extra checks. pfn_valid() shouldn't return true f

Re: [PATCH] sched: topology: add input parameter for sched_domain_flags_f()

2022-03-28 Thread Srikar Dronamraju
* Qing Wang [2022-03-28 02:53:37]: > From: Wang Qing > > sched_domain_flags_f() are statically set now, but actually, we can get a > lot of necessary information based on the cpu_map. e.g. we can know whether > its cache is shared. > > Allows custom extension without affecting current. > can

Re: [PATCH] sched: topology: add input parameter for sched_domain_flags_f()

2022-03-28 Thread Peter Zijlstra
On Mon, Mar 28, 2022 at 02:53:37AM -0700, Qing Wang wrote: > From: Wang Qing > > sched_domain_flags_f() are statically set now, but actually, we can get a > lot of necessary information based on the cpu_map. e.g. we can know whether > its cache is shared. > > Allows custom extension without affe

[PATCH] sched: topology: add input parameter for sched_domain_flags_f()

2022-03-28 Thread 王擎
>> From: Wang Qing >> >> sched_domain_flags_f() are statically set now, but actually, we can get a >> lot of necessary information based on the cpu_map. e.g. we can know whether >> its cache is shared. >> >> Allows custom extension without affecting current. > >This all still makes absolutely n

Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Benjamin Stürz writes: > On 28.03.22 11:33, Kalle Valo wrote: >> Benjamin Stürz writes: >> >>> This patch series replaces comments with C99's designated initializers >>> in a few places. It also adds some enum initializers. This is my first >>> time contributing to the Linux kernel, therefore I

Re: [PATCH v1 1/1] powerpc/83xx/mpc8349emitx: Get rid of of_node assignment

2022-03-28 Thread Linus Walleij
On Wed, Mar 23, 2022 at 6:43 PM Andy Shevchenko wrote: > Let GPIO library to assign of_node from the parent device. > This allows to move GPIO library and drivers to use fwnode > APIs instead of being stuck with OF-only interfaces. > > Signed-off-by: Andy Shevchenko That's a nice patch. Reviewe

Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

2022-03-28 Thread Segher Boessenkool
On Sat, Mar 26, 2022 at 08:23:31PM +0100, Arnd Bergmann wrote: > On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz wrote: > > > > This replaces comments with C99's designated > > initializers because the kernel supports them now. > > The change looks fine, but the comment looks misplaced, as enum in

Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Daniel Thompson
On Sun, Mar 27, 2022 at 02:46:00PM +0200, Benjamin Stürz wrote: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things t

Re: [PATCH v4 1/2] Revert "powerpc: Set max_mapnr correctly"

2022-03-28 Thread Christophe Leroy
Hi, Le 26/03/2022 à 08:55, Kefeng Wang a écrit : > Hi maintainers, > > I saw the patches has been reviewed[1], could they be merged? Thinking about it once more, I think the patches should go in reverse order. Patch 2 should go first and patch 1 should go after. Otherwise, once patch 1 is appl

Re: [PATCH 1/2] powerpc: Reject probes on instructions that can't be single stepped

2022-03-28 Thread Naveen N. Rao
Michael Ellerman wrote: Murilo Opsfelder Araújo writes: On 3/23/22 08:51, Naveen N. Rao wrote: +static inline bool can_single_step(u32 inst) +{ + switch (inst >> 26) { Can't ppc_inst_primary_opcode() be used instead? I didn't want to add a dependency on inst.h. But I guess I can very

Re: [PATCH 1/2] powerpc: Reject probes on instructions that can't be single stepped

2022-03-28 Thread Christophe Leroy
Le 28/03/2022 à 19:20, Naveen N. Rao a écrit : > Michael Ellerman wrote: >> Murilo Opsfelder Araújo writes: >>> On 3/23/22 08:51, Naveen N. Rao wrote: +static inline bool can_single_step(u32 inst) +{ +    switch (inst >> 26) { >>> >>> Can't ppc_inst_primary_opcode() be used instea

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-28 Thread Josh Poimboeuf
On Sun, Mar 27, 2022 at 09:09:20AM +, Christophe Leroy wrote: > Second point is the endianess and 32/64 selection, especially when > crossbuilding. There is already some stuff regarding endianess based on > bswap_if_needed() but that's based on constant selection at build time > and I couldn

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-28 Thread Peter Zijlstra
On Mon, Mar 28, 2022 at 12:59:20PM -0700, Josh Poimboeuf wrote: > I'm not making any major changes to the code, just shuffling things > around to make the interface more modular. I hope to have something > soon (this week). Peter recently added a big feature (Intel IBT) which > is already in -ne

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-28 Thread Peter Zijlstra
+arm64 people... On Mon, Mar 28, 2022 at 10:14:38PM +0200, Peter Zijlstra wrote: > On Mon, Mar 28, 2022 at 12:59:20PM -0700, Josh Poimboeuf wrote: > > > I'm not making any major changes to the code, just shuffling things > > around to make the interface more modular. I hope to have something >

Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Jakub Kicinski
On Mon, 28 Mar 2022 13:51:42 +0200 Benjamin Stürz wrote: > > Just a small tip: If you are new, start with something small and learn > > from that. Don't do a controversial big patchset spanning multiple > > subsystems, that's the hard way to learn things. First submit one patch > > at a time to one

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-28 Thread Josh Poimboeuf
On Mon, Mar 28, 2022 at 10:14:38PM +0200, Peter Zijlstra wrote: > > FWIW, there have been some objtool patches for arm64 stack validation, > > but the arm64 maintainers have been hesitant to get on board with > > objtool, as it brings a certain maintenance burden. Especially for the > > full stack

Re: [PATCH 20/22] wireless: Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Benjamin Stürz wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. > > Signed-off-by: Benjamin Stürz The title prefix should be "ray_cs: ". Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/202

RE: [PATCH 21/22] rtw89: Replace comments with C99 initializers

2022-03-28 Thread David Laight
From: Kalle Valo > Sent: 28 March 2022 10:29 > > Larry Finger writes: > > > On 3/26/22 11:59, Benjamin Stürz wrote: > >> This replaces comments with C99's designated > >> initializers because the kernel supports them now. > >> > >> Signed-off-by: Benjamin Stürz > >> --- > >> drivers/net/wirel

Re: [PATCH 05/22] acpica: Replace comments with C99 initializers

2022-03-28 Thread Rafael J. Wysocki
On Sat, Mar 26, 2022 at 6:09 PM Benjamin Stürz wrote: > > This replaces comments with C99's designated > initializers because the kernel supports them now. However, note that all of the ACPICA material should be submitted to the upstream ACPICA project via https://github.com/acpica/acpica Also p

Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

2022-03-28 Thread Daniel Thompson
On Sat, Mar 26, 2022 at 05:58:48PM +0100, Benjamin Stürz wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. This commit description seems wrong to me. This patch doesn't include use C99 designated initializers (or AFAICT any other language fe

Re: [PATCH 02/22] s3c: Replace comments with C99 initializers

2022-03-28 Thread Daniel Thompson
On Sat, Mar 26, 2022 at 05:58:49PM +0100, Benjamin Stürz wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. I'm a bit puzzled by "because the kernel supports them now". Designated initializers are not purely a C99 feature... it is also a GNU

Re: [PATCH 19/22] wnc36xx: Replace comments with C99 initializers

2022-03-28 Thread Jeff Johnson
On 3/26/2022 9:59 AM, Benjamin Stürz wrote: This replaces comments with C99's designated initializers because the kernel supports them now. Signed-off-by: Benjamin Stürz --- drivers/net/wireless/ath/wcn36xx/main.c | 122 1 file changed, 61 insertions(+), 61 deletions

[PATCH] KVM: PPC: Book3S HV: Fix vcore_blocked tracepoint

2022-03-28 Thread Fabiano Rosas
We removed most of the vcore logic from the P9 path but there's still a tracepoint that tried to dereference vc->runner. Fixes: ecb6a7207f92 ("KVM: PPC: Book3S HV P9: Remove most of the vcore logic") Signed-off-by: Fabiano Rosas --- arch/powerpc/kvm/book3s_hv.c | 8 arch/powerpc/kvm/tra

Re: [PATCH] recordmcount: Support empty section from recent binutils

2022-03-28 Thread Joel Stanley
On Mon, 29 Nov 2021 at 22:43, Christophe Leroy wrote: > > > > Le 29/11/2021 à 18:43, Steven Rostedt a écrit : > > On Fri, 26 Nov 2021 08:43:23 + > > LEROY Christophe wrote: > > > >> Le 24/11/2021 à 15:43, Christophe Leroy a écrit : > >>> Looks like recent binutils (2.36 and over ?) may empty

Re: [PATCH 04/22] x86: Replace comments with C99 initializers

2022-03-28 Thread Thomas Gleixner
Benjamin, On Sat, Mar 26 2022 at 17:58, Benjamin Stürz wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. the kernel has used designated array initializers for a very long time simply because the kernel did not use pure C89 but C89 with GNU