Re: [PATCH v1 4/7] arm64/pgtable: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE

2022-03-18 Thread David Hildenbrand
On 17.03.22 18:58, Catalin Marinas wrote: > On Thu, Mar 17, 2022 at 11:04:18AM +0100, David Hildenbrand wrote: >> On 16.03.22 19:27, Catalin Marinas wrote: >>> On Tue, Mar 15, 2022 at 03:18:34PM +0100, David Hildenbrand wrote: @@ -909,12 +925,13 @@ static inline pmd_t pmdp_establish(struct >>

Re: [PATCH v1 4/7] arm64/pgtable: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE

2022-03-18 Thread Catalin Marinas
On Fri, Mar 18, 2022 at 10:59:10AM +0100, David Hildenbrand wrote: > diff --git a/arch/arm64/include/asm/pgtable-prot.h > b/arch/arm64/include/asm/pgtable-prot.h > index b1e1b74d993c..fd6ddf14c190 100644 > --- a/arch/arm64/include/asm/pgtable-prot.h > +++ b/arch/arm64/include/asm/pgtable-prot.h >

[PATCH 1/2] drivers/nvdimm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-18 Thread Kajol Jain
The following build failure occures when CONFIG_PERF_EVENTS is not set as generic pmu functions are not visible in that scenario. |-- s390-randconfig-r044-20220313 | |-- nd_perf.c:(.text):undefined-reference-to-perf_pmu_migrate_context | |-- nd_perf.c:(.text):undefined-reference-to-perf_pmu_re

[PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-18 Thread Kajol Jain
The following build failure occures when CONFIG_PERF_EVENTS is not set as generic pmu functions are not visible in that scenario. arch/powerpc/platforms/pseries/papr_scm.c:372:35: error: ‘struct perf_event’ has no member named ‘attr’ p->nvdimm_events_map[event->attr.config],

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-18 Thread Peter Zijlstra
On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: > This patch adds powerpc specific functions required for > 'objtool mcount' to work, and enables mcount for ppc. I would love to see more objtool enablement for Power :-) > diff --git a/tools/objtool/arch/powerpc/include/arch/e

Re: [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()

2022-03-18 Thread Stefan Berger
On 3/18/22 02:02, Xiu Jianfeng wrote: Currently it returns zero when CRQ response timed out, it should return an error code instead. Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding") Signed-off-by: Xiu Jianfeng Reviewed-by: Stefan Berger --- drivers/ch

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-18 Thread Christophe Leroy
Hi, Le 18/03/2022 à 13:26, Peter Zijlstra a écrit : > On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: >> This patch adds powerpc specific functions required for >> 'objtool mcount' to work, and enables mcount for ppc. > > I would love to see more objtool enablement for Power :

Re: [PATCH v1 4/7] arm64/pgtable: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE

2022-03-18 Thread David Hildenbrand
On 18.03.22 12:33, Catalin Marinas wrote: > On Fri, Mar 18, 2022 at 10:59:10AM +0100, David Hildenbrand wrote: >> diff --git a/arch/arm64/include/asm/pgtable-prot.h >> b/arch/arm64/include/asm/pgtable-prot.h >> index b1e1b74d993c..fd6ddf14c190 100644 >> --- a/arch/arm64/include/asm/pgtable-prot.h

Re: [PATCH] macintosh: windfarm: Use NULL to compare with pointer-typed value rather than 0

2022-03-18 Thread Christophe Leroy
Le 13/11/2020 à 08:33, Xu Wang a écrit : Compare pointer-typed values to NULL rather than 0. Signed-off-by: Xu Wang If we are going to change that, let's do it right at once Checkpatch says: CHECK: Comparison to NULL could be written "!hdr" #25: FILE: drivers/macintosh/windfarm_pm121.c:6

Re: [PATCH v1 1/2] static_call: Properly initialise DEFINE_STATIC_CALL_RET0()

2022-03-18 Thread Peter Zijlstra
Thanks!

Re: [PATCH v2] static_call: Don't make __static_call_return0 static

2022-03-18 Thread Peter Zijlstra
On Mon, Mar 14, 2022 at 12:49:36PM +0100, Christophe Leroy wrote: > System.map shows that vmlinux contains several instances of > __static_call_return0(): > > c0004fc0 t __static_call_return0 > c0011518 t __static_call_return0 > c00d8160 t __static_call_return0 > > arch_static_c

Re: False positive kmemleak report for dtb properties names on powerpc

2022-03-18 Thread Ariel Marcovitch
Pinging again :) On 25/02/2022 0:27, Ariel Marcovitch wrote: Ping :) On 18/02/2022 21:45, Ariel Marcovitch wrote: Hello! I was running a powerpc 32bit kernel (built using qemu_ppc_mpc8544ds_defconfig buildroot config, with enabling DEBUGFS+KMEMLEAK+HIGHMEM in the kernel config) on qemu and

Re: [PATCH v1] PCI/AER: Handle Multi UnCorrectable/Correctable errors properly

2022-03-18 Thread Sathyanarayanan Kuppuswamy
On 3/17/22 3:59 PM, Bjorn Helgaas wrote: Thanks for the additional details! After this patch, I guess aer_irq() still reads 0x2 (PCI_ERR_ROOT_MULTI_COR_RCV), but now it writes 0x2 back which clears PCI_ERR_ROOT_MULTI_COR_RCV. In addition, aer_irq() will continue on to read PCI_ERR_ROOT_ERR_S

[PATCH] ASoC: fsl-asoc-card: Fix jack_event() always return 0

2022-03-18 Thread Meng Tang
Today, hp_jack_event and mic_jack_event always return 0. However, snd_soc_dapm_disable_pin and snd_soc_dapm_enable_pin may return a non-zero value, this will cause the user who calling hp_jack_event and mic_jack_event don't know whether the operation was really successfully. This patch corrects th

[RFC PATCH 0/3] objtool: Add mcount sub-command

2022-03-18 Thread Sathvika Vasireddy
This patchset adds support to implement 'objtool mcount' command. Right now, objtool is built if CONFIG_STACK_VALIDATION is enabled. And, '__mcount_loc' section is generated by objtool when --mcount option is passed to check sub-command. For architectures to be able to generate '__mcount_loc' s

[RFC PATCH 1/3] objtool: Move common code to utils.c

2022-03-18 Thread Sathvika Vasireddy
This patch moves common code to utils.c file. Code from this file will be reused across check.c and mcount.c (will be introduced in the coming patches). Also, ensure that this change works well with existing commands. Signed-off-by: Sathvika Vasireddy --- tools/objtool/Build |

[RFC PATCH 2/3] objtool: Enable and implement 'mcount' subcommand

2022-03-18 Thread Sathvika Vasireddy
This patch adds 'mcount' as a subcommand to objtool, and enables the same for x86. objtool is built if CONFIG_FTRACE_MCOUNT_USE_OBJTOOL is selected. Additionally, architectures can select HAVE_NOP_MCOUNT if they choose to nop out mcount call sites. If that config option is selected, then --mnop is

[RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-18 Thread Sathvika Vasireddy
This patch adds powerpc specific functions required for 'objtool mcount' to work, and enables mcount for ppc. Signed-off-by: Sathvika Vasireddy --- arch/powerpc/Kconfig | 1 + tools/objtool/Makefile| 4 ++ tools/objtool/arch/powerpc/Build

Re: [PATCH v1 0/7] mm: COW fixes part 3: reliable GUP R/W FOLL_GET of anonymous pages

2022-03-18 Thread Jason Gunthorpe
On Tue, Mar 15, 2022 at 03:18:30PM +0100, David Hildenbrand wrote: > This is just the natural follow-up of part 2, that will also further > reduce "wrong COW" on the swapin path, for example, when we cannot remove > a page from the swapcache due to concurrent writeback, or if we have two > threads

Re: [RFC PATCH 0/3] objtool: Add mcount sub-command

2022-03-18 Thread Josh Poimboeuf
On Fri, Mar 18, 2022 at 04:21:37PM +0530, Sathvika Vasireddy wrote: > This patchset adds support to implement 'objtool mcount' command. > > Right now, objtool is built if CONFIG_STACK_VALIDATION is enabled. > And, '__mcount_loc' section is generated by objtool when --mcount > option is passed to

[powerpc:next] BUILD SUCCESS 35de589cb8793573ed56a915af9cb4b5f15ad7d7

2022-03-18 Thread kernel test robot
mac_defconfig shhp6xx_defconfig arm randconfig-c002-20220318 arm randconfig-c002-20220317 ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k

[powerpc:merge] BUILD SUCCESS 7e726dd53fdd381a1a2b2dcd7766c66a9684241f

2022-03-18 Thread kernel test robot
ig powerpc pasemi_defconfig shtitan_defconfig arm randconfig-c002-20220318 arm randconfig-c002-20220317 ia64defconfig ia64 allmodconfig ia64 allyesc

[PATCH] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled

2022-03-18 Thread Finn Thain
drivers/macintosh/via-pmu-event.o: In function `via_pmu_event': via-pmu-event.c:(.text+0x44): undefined reference to `input_event' via-pmu-event.c:(.text+0x68): undefined reference to `input_event' via-pmu-event.c:(.text+0x94): undefined reference to `input_event' via-pmu-event.c:(.text+0xb8): unde

Re: [PATCH] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled

2022-03-18 Thread Randy Dunlap
On 3/18/22 21:18, Finn Thain wrote: > drivers/macintosh/via-pmu-event.o: In function `via_pmu_event': > via-pmu-event.c:(.text+0x44): undefined reference to `input_event' > via-pmu-event.c:(.text+0x68): undefined reference to `input_event' > via-pmu-event.c:(.text+0x94): undefined reference to `

Re: [PATCH] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled

2022-03-18 Thread Finn Thain
On Fri, 18 Mar 2022, Randy Dunlap wrote: > > Hi Finn, > It builds without those reported errors, but I do see these warnings > since the robot-supplied .config file has: > # CONFIG_PROC_FS is not set > > > CC drivers/macintosh/via-pmu.o > ../drivers/macintosh/via-pmu.c:897:12: warning: '