Re: rcutorture’s init segfaults in ppc64le VM

2022-02-08 Thread Michael Ellerman
Paul Menzel writes: > Dear Linux folks, Hi Paul, > On the POWER8 server IBM S822LC running Ubuntu 21.10, building Linux > 5.17-rc2+ with rcutorture tests I'm not sure if that's the host kernel version or the version you're using of rcutorture? Can you tell us the sha1 of your host kernel and o

Re: [PATCHv2] selftests/powerpc/copyloops: Add memmove_64 test

2022-02-08 Thread Michael Ellerman
Ritesh Harjani writes: > Found this, while checking my older emails. Sorry about not checking on this > before. Have addressed the review comments here [1] > > This still applies cleanly on 5.17-rc3 and passes. > > riteshh-> ./copyloops/memmove_64 > test: memmove > tags: git_version:v5.17-rc3-1-g8

Re: rcutorture’s init segfaults in ppc64le VM

2022-02-08 Thread Paul Menzel
Dear Michael, Thank you for looking into this. Am 08.02.22 um 11:09 schrieb Michael Ellerman: Paul Menzel writes: […] On the POWER8 server IBM S822LC running Ubuntu 21.10, building Linux 5.17-rc2+ with rcutorture tests I'm not sure if that's the host kernel version or the version you're

Re: rcutorture’s init segfaults in ppc64le VM

2022-02-08 Thread Paul Menzel
[Correct sha1 for test for 2022.02.01-21.52.37] Am 08.02.22 um 13:12 schrieb Paul Menzel: Dear Michael, Thank you for looking into this. Am 08.02.22 um 11:09 schrieb Michael Ellerman: Paul Menzel writes: […] On the POWER8 server IBM S822LC running Ubuntu 21.10, building Linux 5.17-rc2+

Re: ppc64le: `NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #20!!!` when turning off SMT

2022-02-08 Thread Frederic Weisbecker
On Tue, Feb 08, 2022 at 08:32:37AM +0100, Paul Menzel wrote: > Dear Linux folks, > > > On the POWER8 server IBM S822LC running Ubuntu 21.10, Linux 5.17-rc1+ built > with > > $ grep HZ /boot/config-5.17.0-rc1+ > CONFIG_NO_HZ_COMMON=y > # CONFIG_HZ_PERIODIC is not set > CONFIG_NO_H

Re: ppc64le: `NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #20!!!` when turning off SMT

2022-02-08 Thread Paul A. Clarke
On Tue, Feb 08, 2022 at 02:17:03PM +0100, Frederic Weisbecker wrote: > On Tue, Feb 08, 2022 at 08:32:37AM +0100, Paul Menzel wrote: > > once warned about a NOHZ tick-stop error, when I executed `sudo > > /usr/sbin/ppc64_cpu --smt=off` (so that KVM would work). > > I see, so I assume this sets some

[PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Paul Menzel
Buidling `raid6test` on Ubuntu 21.10 (ppc64le) with GNU Make 4.3 shows the errors below: $ cd lib/raid6/test/ $ make :1:1: error: stray ‘\’ in program :1:2: error: stray ‘#’ in program :1:11: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘<’ token cp -f ..

[PATCH v2 2/2] lib/raid6: Include for `VPERMXOR`

2022-02-08 Thread Paul Menzel
On Ubuntu 21.10 (ppc64le) building `raid6test` with gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0 fails with the error below. gcc -I.. -I ../../../include -g -O2 -I../../../arch/powerpc/include -DCONFIG_ALTIVEC -c -o vpermxor1.o vpermxor1.c vpermxor1.c: In function ‘raid6_vperm

Re: [PATCH v2 1/4] powerpc/pseries/vas: Define global hv_cop_caps struct

2022-02-08 Thread Nathan Lynch
Haren Myneni writes: > The coprocessor capabilities struct is used to get default and > QoS capabilities from the hypervisor during init, DLPAR event and > migration. So instead of allocating this struct for each event, > define global struct and reuse it, especially eliminate memory > allocation

Re: [PATCH v2 1/4] powerpc/pseries/vas: Define global hv_cop_caps struct

2022-02-08 Thread Haren Myneni
On Tue, 2022-02-08 at 09:48 -0600, Nathan Lynch wrote: > Haren Myneni writes: > > The coprocessor capabilities struct is used to get default and > > QoS capabilities from the hypervisor during init, DLPAR event and > > migration. So instead of allocating this struct for each event, > > define glob

[PATCH v2] include: linux: Reorganize timekeeping and ktime headers

2022-02-08 Thread Carlos Bilbao
The timekeeping subsystem could use some reorganization. Reorganize and separate the headers by making ktime.h take care of the ktime_get() family of functions, and reserve timekeeping.h for the actual timekeeping. This also helps to avoid implicit function errors and strengthens the header depend

Re: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Song Liu
On Tue, Feb 8, 2022 at 7:22 AM Paul Menzel wrote: > > Buidling `raid6test` on Ubuntu 21.10 (ppc64le) with GNU Make 4.3 shows the > errors below: > > $ cd lib/raid6/test/ > $ make > :1:1: error: stray ‘\’ in program > :1:2: error: stray ‘#’ in program > :1:11: error: expected ‘=

Re: [PATCH v3 4/6] modules: Add CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC

2022-02-08 Thread Michal Suchánek
Hello, On Thu, Feb 03, 2022 at 11:51:05AM -0800, Luis Chamberlain wrote: > On Thu, Feb 03, 2022 at 07:05:13AM +, Christophe Leroy wrote: > > Le 03/02/2022 à 01:01, Luis Chamberlain a écrit : > > > On Sat, Jan 29, 2022 at 05:02:09PM +, Christophe Leroy wrote: > > >> diff --git a/kernel/modu

Re: [PATCH] powerpc/pseries: make pseries_devicetree_update() static

2022-02-08 Thread Tyrel Datwyler
On 2/7/22 2:12 PM, Nathan Lynch wrote: > pseries_devicetree_update() has only one call site, in the same file in > which it is defined. Make it static. > > Signed-off-by: Nathan Lynch > --- Reviewed-by: Tyrel Datwyler

Re: BUG: Kernel NULL pointer dereference on write at 0x00000000 (rtmsg_ifinfo_build_skb)

2022-02-08 Thread Zhouyi Zhou
Hi Paul Below are my preliminary test results tested on PPC VM supplied by Open source lab of Oregon State University, thank you for your support! [Preliminary test results on ppc64le virtual guest] 1. Conclusion Some other kernel configuration besides RCU may lead to "BUG: Kernel NULL pointer d

Re: [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Wols Lists
On 26/01/2022 11:41, Paul Menzel wrote: So, do the same as commit 9564a8cf422d (Kbuild: fix # escaping in .cmd files for future Make) and commit 929bef467771 (bpf: Use $(pound) instead of \# in Makefiles) and define and use a `$(pound)` variable. Ouch! In the English (as opposed to American) s

Re: [PATCH v2] include: linux: Reorganize timekeeping and ktime headers

2022-02-08 Thread kernel test robot
Hi Carlos, Thank you for the patch! Yet something to improve: [auto build test ERROR on geert-m68k/for-next] [also build test ERROR on tip/timers/core tip/x86/core linus/master v5.17-rc3] [cannot apply to next-20220208] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Wols Lists
On 08/02/2022 15:21, Paul Menzel wrote: So, do the same as commit 9564a8cf422d ("Kbuild: fix # escaping in .cmd files for future Make") and commit 929bef467771 ("bpf: Use $(pound) instead of \# in Makefiles") and define and use a `$(pound)` variable. As commented elsewhere, for the sake of us E

Re: [PATCH v2] include: linux: Reorganize timekeeping and ktime headers

2022-02-08 Thread kernel test robot
Hi Carlos, Thank you for the patch! Yet something to improve: [auto build test ERROR on geert-m68k/for-next] [also build test ERROR on tip/timers/core tip/x86/core linus/master v5.17-rc3] [cannot apply to next-20220208] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-08 Thread Nayna
On 2/2/22 03:25, Greg KH wrote: On Wed, Feb 02, 2022 at 08:04:01AM +, Matthew Garrett wrote: On Wed, Feb 02, 2022 at 08:22:03AM +0100, Ard Biesheuvel wrote: On Wed, 2 Feb 2022 at 08:10, Matthew Garrett wrote: Which other examples are you thinking of? I think this conversation may have a

[PATCH] scsi: ibmvfc: replace snprintf with sysfs_emit

2022-02-08 Thread davidcomponentone
From: Yang Guang coccinelle report: ./drivers/scsi/ibmvscsi/ibmvfc.c:3453:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/ibmvscsi/ibmvfc.c:3416:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/ibmvscsi/ibmvfc.c:3436:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/ibmvscsi/ibm

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-08 Thread Nayna
On 2/2/22 03:25, Greg KH wrote: On Wed, Feb 02, 2022 at 08:04:01AM +, Matthew Garrett wrote: On Wed, Feb 02, 2022 at 08:22:03AM +0100, Ard Biesheuvel wrote: On Wed, 2 Feb 2022 at 08:10, Matthew Garrett wrote: Which other examples are you thinking of? I think this conversation may have ac

Re: [PATCH] scsi: ibmvfc: replace snprintf with sysfs_emit

2022-02-08 Thread Joe Perches
On Wed, 2022-02-09 at 08:43 +0800, davidcomponent...@gmail.com wrote: > From: Yang Guang [] > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c [] > @@ -3403,7 +3403,7 @@ static ssize_t ibmvfc_show_host_partition_name(struct > device *dev, > struct Scsi_Host *shos

Re: [PATCH] scsi: ibmvfc: replace snprintf with sysfs_emit

2022-02-08 Thread Damien Le Moal
On 2/9/22 09:43, davidcomponent...@gmail.com wrote: > From: Yang Guang > > coccinelle report: > ./drivers/scsi/ibmvscsi/ibmvfc.c:3453:8-16: > WARNING: use scnprintf or sprintf > ./drivers/scsi/ibmvscsi/ibmvfc.c:3416:8-16: > WARNING: use scnprintf or sprintf > ./drivers/scsi/ibmvscsi/ibmvfc.c:3436

[PATCH] oc: fsl: dpio: Make use of the helper macro LIST_HEAD()

2022-02-08 Thread Cai Huoqing
Replace "struct list_head head = LIST_HEAD_INIT(head)" with "LIST_HEAD(head)" to simplify the code. Signed-off-by: Cai Huoqing --- drivers/soc/fsl/dpio/dpio-service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/dpio/dpio-service.c b/drivers/soc/fsl/dpio/d

[PATCH] ocxl: Make use of the helper macro LIST_HEAD()

2022-02-08 Thread Cai Huoqing
Replace "struct list_head head = LIST_HEAD_INIT(head)" with "LIST_HEAD(head)" to simplify the code. Signed-off-by: Cai Huoqing --- drivers/misc/ocxl/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c index ab039c115381..

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-08 Thread Michael Ellerman
Michal Suchanek writes: > Copy the code from s390x > > Both powerpc and s390x use appended signature format (as opposed to EFI > based patforms using PE format). > > Signed-off-by: Michal Suchanek > --- > v3: - Philipp Rudo : Update the comit message with > explanation why the s390 code is

Re: [PATCH v5 0/6] KEXEC_SIG with appended signature

2022-02-08 Thread Michael Ellerman
Luis Chamberlain writes: > On Tue, Jan 11, 2022 at 12:37:42PM +0100, Michal Suchanek wrote: >> Hello, >> >> This is a refresh of the KEXEC_SIG series. >> >> This adds KEXEC_SIG support on powerpc and deduplicates the code dealing >> with appended signatures in the kernel. >> >> powerpc supports

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-08 Thread Paul Menzel
Dear Michal, Thank you for the patch. Am 11.01.22 um 12:37 schrieb Michal Suchanek: Could you please remove the dot/period at the end of the git commit message summary? Copy the code from s390x Both powerpc and s390x use appended signature format (as opposed to EFI based patforms using P

[PATCH v3 2/5] Partially revert "KVM: Pass kvm_init()'s opaque param to additional arch funcs"

2022-02-08 Thread Chao Gao
This partially reverts commit b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs") remove opaque from kvm_arch_check_processor_compat because no one uses this opaque now. Address conflicts for ARM (due to file movement) and manually handle RISC-V which comes after the commi

Re: [PATCH] ocxl: Make use of the helper macro LIST_HEAD()

2022-02-08 Thread Andrew Donnellan
On 9/2/22 14:24, Cai Huoqing wrote: Replace "struct list_head head = LIST_HEAD_INIT(head)" with "LIST_HEAD(head)" to simplify the code. Signed-off-by: Cai Huoqing LGTM Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Austra