Re: Build regressions/improvements in v5.16-rc1

2021-11-17 Thread Geert Uytterhoeven
Hi Nick, On Wed, Nov 17, 2021 at 3:20 AM Nick Terrell wrote: > > On Nov 16, 2021, at 6:05 PM, Randy Dunlap wrote: > > On 11/16/21 5:59 PM, Nick Terrell wrote: > >> I’ll send the PR to Linus tomorrow. I’ve been informed that it > >> isn't strictly necessary to send the patches to the mailing list

Re: [PATCH kernel 0/4] Fixes for powerpc/pseries/iommu: Make use of DDW for indirect mapping

2021-11-17 Thread Frederic Barrat
On 02/11/2021 03:43, Michael Ellerman wrote: On Thu, 21 Oct 2021 00:23:11 +1100, Alexey Kardashevskiy wrote: Found some issues on SRIOV enabled PHYP. It probably should be one patch, or not? Please comment. Thanks. [...] Patches 2-4 applied to powerpc/fixes. Any reason why patch 1 wa

Re: [PATCH] powerpc/pseries: delete scanlog

2021-11-17 Thread Michael Ellerman
Nathan Lynch writes: > Nathan Lynch writes: >> Remove the pseries scanlog driver. >> >> This code supports functions from Power4-era servers that are not present >> on targets currently supported by arch/powerpc. System manuals from this >> time have this description: >> >> Scan Dump data is a

Re: [PATCH kernel 0/4] Fixes for powerpc/pseries/iommu: Make use of DDW for indirect mapping

2021-11-17 Thread Frederic Barrat
On 17/11/2021 11:19, Frederic Barrat wrote: On 02/11/2021 03:43, Michael Ellerman wrote: On Thu, 21 Oct 2021 00:23:11 +1100, Alexey Kardashevskiy wrote: Found some issues on SRIOV enabled PHYP. It probably should be one patch, or not? Please comment. Thanks. [...] Patches 2-4 applied

Re: Build regressions/improvements in v5.16-rc1

2021-11-17 Thread Helge Deller
On 11/17/21 03:19, Nick Terrell wrote: > > >> On Nov 16, 2021, at 6:05 PM, Randy Dunlap wrote: >> >> On 11/16/21 5:59 PM, Nick Terrell wrote: On Nov 15, 2021, at 8:44 AM, Helge Deller wrote: On 11/15/21 17:12, Geert Uytterhoeven wrote: > On Mon, Nov 15, 2021 at 4:54 PM Geert Uy

Re: [PATCH kernel 0/3] powerpc/pseries/ddw: Fixes for persistent memory case

2021-11-17 Thread Michael Ellerman
On Mon, 8 Nov 2021 15:03:16 +1100, Alexey Kardashevskiy wrote: > This is based on sha1 > f855455dee0b Michael Ellerman "Automatic merge of 'next' into merge > (2021-11-05 22:19)". > > Please comment. Thanks. > > > > [...] Applied to powerpc/fixes. [1/3] powerpc/pseries/ddw: Revert "Extend up

Re: [PATCH] powerpc/8xx: Fix pinned TLBs with CONFIG_STRICT_KERNEL_RWX

2021-11-17 Thread Michael Ellerman
On Mon, 15 Nov 2021 09:08:36 +0100, Christophe Leroy wrote: > As spotted and explained in commit c12ab8dbc492 ("powerpc/8xx: Fix > Oops with STRICT_KERNEL_RWX without DEBUG_RODATA_TEST"), the selection > of STRICT_KERNEL_RWX without selecting DEBUG_RODATA_TEST has spotted > the lack of the DIRTY bi

Re: [PATCH] powerpc/book3e: Fix TLBCAM preset at boot

2021-11-17 Thread Michael Ellerman
On Mon, 15 Nov 2021 10:05:32 +0100, Christophe Leroy wrote: > Commit 52bda69ae8b5 ("powerpc/fsl_booke: Tell map_mem_in_cams() if > init is done") was supposed to just add an additional parameter to > map_mem_in_cams() and always set it to 'true' at that time. > > But a few call sites were messed u

Re: [PATCH] powerpc/signal32: Fix sigset_t copy

2021-11-17 Thread Michael Ellerman
On Mon, 15 Nov 2021 09:52:55 +0100, Christophe Leroy wrote: > The conversion from __copy_from_user() to __get_user() by > commit d3ccc9781560 ("powerpc/signal: Use __get_user() to copy > sigset_t") introduced a regression in __get_user_sigset() for > powerpc/32. The bug was subsequently moved into

Re: [PATCH] powerpc: clean vdso32 and vdso64 directories

2021-11-17 Thread Michael Ellerman
On Wed, 10 Nov 2021 03:50:15 +0900, Masahiro Yamada wrote: > Since commit bce74491c300 ("powerpc/vdso: fix unnecessary rebuilds of > vgettimeofday.o"), "make ARCH=powerpc clean" does not clean up the > arch/powerpc/kernel/{vdso32,vdso64} directories. > > Use the subdir- trick to let "make clean" d

Re: [PATCH] KVM: PPC: Book3S HV: Use GLOBAL_TOC for kvmppc_h_set_dabr/xdabr()

2021-11-17 Thread Michael Ellerman
On Fri, 24 Sep 2021 01:10:31 +1000, Michael Ellerman wrote: > kvmppc_h_set_dabr(), and kvmppc_h_set_xdabr() which jumps into > it, need to use _GLOBAL_TOC to setup the kernel TOC pointer, because > kvmppc_h_set_dabr() uses LOAD_REG_ADDR() to load dawr_force_enable. > > When called from hcall_try_r

Re: [PATCH v2 1/2] powerpc/pseries: rename numa_dist_table to form2_distances

2021-11-17 Thread Michael Ellerman
On Tue, 9 Nov 2021 16:48:59 +1000, Nicholas Piggin wrote: > The name of the local variable holding the "form2" property address > conflicts with the numa_distance_table global. > > This patch does 's/numa_dist_table/form2_distances/g' over the function, > which also renames numa_dist_table_length

Re: [PATCH] powerpc/83xx/mpc8349emitx: Drop unused variable

2021-11-17 Thread Michael Ellerman
On Wed, 10 Nov 2021 12:07:39 +0100, Uwe Kleine-König wrote: > Commit 5d354dc35ebb ("powerpc/83xx/mpc8349emitx: Make > mcu_gpiochip_remove() return void") removed the usage of the variable > ret, but failed to remove the variable itself, resulting in: > > arch/powerpc/platforms/83xx/mcu_mpc83

powerpc: pervasive.c:: error: unannotated fall-through between switch labels

2021-11-17 Thread Naresh Kamboju
Regression found on ppc clang-nightly build. Following build warnings / errors reported on linux next 2027. metadata: git_describe: next-2027 git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next git_short_log: fd96a4057bd0 (\"Add linux-next specific file

Re: [PATCH kernel 0/4] Fixes for powerpc/pseries/iommu: Make use of DDW for indirect mapping

2021-11-17 Thread Michael Ellerman
Frederic Barrat writes: > On 02/11/2021 03:43, Michael Ellerman wrote: >> On Thu, 21 Oct 2021 00:23:11 +1100, Alexey Kardashevskiy wrote: >>> Found some issues on SRIOV enabled PHYP. >>> It probably should be one patch, or not? >>> >>> Please comment. Thanks. >>> >>> [...] >> >> Patches 2-4 appli

Re: [PATCH] powerpc/pseries: delete scanlog

2021-11-17 Thread Nathan Lynch
Michael Ellerman writes: > Nathan Lynch writes: >> Nathan Lynch writes: >>> Remove the pseries scanlog driver. >>> >>> This code supports functions from Power4-era servers that are not present >>> on targets currently supported by arch/powerpc. System manuals from this >>> time have this descri

Re: [PATCH] powerpc: clean vdso32 and vdso64 directories

2021-11-17 Thread Masahiro Yamada
On Wed, Nov 17, 2021 at 12:38 AM Christophe Leroy wrote: > > Hi Masahiro, > > Le 09/11/2021 à 19:50, Masahiro Yamada a écrit : > > Since commit bce74491c300 ("powerpc/vdso: fix unnecessary rebuilds of > > vgettimeofday.o"), "make ARCH=powerpc clean" does not clean up the > > arch/powerpc/kernel/{v

[PATCH v3 10/12] KVM: x86/xen: Maintain valid mapping of Xen shared_info page

2021-11-17 Thread David Woodhouse
From: David Woodhouse Use the newly reinstated gfn_to_pfn_cache to maintain a kernel mapping of the Xen shared_info page so that it can be accessed in atomic context. Signed-off-by: David Woodhouse --- arch/x86/include/asm/kvm_host.h | 2 +- arch/x86/kvm/xen.c | 25 ++

[PATCH v3 01/12] KVM: Introduce CONFIG_HAVE_KVM_DIRTY_RING

2021-11-17 Thread David Woodhouse
From: David Woodhouse I'd like to make the build include dirty_ring.c based on whether the arch wants it or not. That's a whole lot simpler if there's a config symbol instead of doing it implicitly on KVM_DIRTY_LOG_PAGE_OFFSET being set to something non-zero. Signed-off-by: David Woodhouse ---

[PATCH v3 05/12] KVM: RISC-V: Use Makefile.kvm for common files

2021-11-17 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- arch/riscv/kvm/Makefile | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/riscv/kvm/Makefile b/arch/riscv/kvm/Makefile index 30cdd1df0098..300590225348 100644 --- a/arch/riscv/kvm/Makefile +++ b/arch/riscv/kvm/

[PATCH v3 12/12] KVM: x86: First attempt at converting nested virtual APIC page to gpc

2021-11-17 Thread David Woodhouse
From: David Woodhouse This is what evolved during the discussion at https://lore.kernel.org/kvm/960e233f-ec0b-4fb5-ba2e-c8d2ccb38...@infradead.org/T/#m11d75fcfe2da357ec1dabba0d0e3abb91fd13665 As discussed, an alternative approach might be to augment kvm_arch_memslots_updated() to raise KVM_REQ_G

[PATCH v3 06/12] KVM: powerpc: Use Makefile.kvm for common files

2021-11-17 Thread David Woodhouse
From: David Woodhouse It's all fairly baroque but in the end, I don't think there's any reason for $(KVM)/irqchip.o to have been handled differently, as they all end up in $(kvm-y) in the end anyway, regardless of whether they get there via $(common-objs-y) and the CPU-specific object lists. Sig

[PATCH v3 02/12] KVM: Add Makefile.kvm for common files, use it for x86

2021-11-17 Thread David Woodhouse
From: David Woodhouse Splitting kvm_main.c out into smaller and better-organized files is slightly non-trivial when it involves editing a bunch of per-arch KVM makefiles. Provide virt/kvm/Makefile.kvm for them to include. Signed-off-by: David Woodhouse --- arch/x86/kvm/Makefile | 7 +-- v

[PATCH v3 03/12] KVM: s390: Use Makefile.kvm for common files

2021-11-17 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Christian Borntraeger --- arch/s390/kvm/Makefile | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile index b3aaadc60ead..e4f50453cf7f 100644 --- a/arch/s390/k

[PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot()

2021-11-17 Thread David Woodhouse
From: David Woodhouse The kvm_dirty_ring_get() function uses kvm_get_running_vcpu() to work out which dirty ring to use, but there are some use cases where that doesn't work. There's one in setting the Xen shared info page, introduced in commit 629b5348841a ("KVM: x86/xen: update wallclock regio

[PATCH v3 04/12] KVM: mips: Use Makefile.kvm for common files

2021-11-17 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- arch/mips/kvm/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/mips/kvm/Makefile b/arch/mips/kvm/Makefile index d3710959da55..21ff75bcdbc4 100644 --- a/arch/mips/kvm/Makefile +++ b/arch/mips/kvm/Makefile

[PATCH v3 07/12] KVM: arm64: Use Makefile.kvm for common files

2021-11-17 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- arch/arm64/kvm/Makefile | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/kvm/Makefile b/arch/arm64/kvm/Makefile index 989bb5dad2c8..04a53f71a6b6 100644 --- a/arch/arm64/kvm/Makefile +++ b/arch/arm64/kvm

[PATCH v3 00/12] KVM: x86/xen: Add in-kernel Xen event channel delivery

2021-11-17 Thread David Woodhouse
Event channels, yeah. That really is where I started. It was all so simple in Joao and Ankur's original version at https://www.spinics.net/lists/kvm/msg182556.html — just a handful of simple test_and_set_bit() calls on the mapped page. When I posted v1 I didn't quite understand how steal time an

[PATCH v3 09/12] KVM: Reinstate gfn_to_pfn_cache with invalidation support

2021-11-17 Thread David Woodhouse
From: David Woodhouse This can be used in two modes. There is an atomic mode where the cached mapping is accessed while holding the rwlock, and a mode where the physical address is used by a vCPU in guest mode. For the latter case, an invalidation will wake the vCPU with the new KVM_REQ_GPC_INVA

[PATCH v3 11/12] KVM: x86/xen: Add KVM_IRQ_ROUTING_XEN_EVTCHN and event channel delivery

2021-11-17 Thread David Woodhouse
From: David Woodhouse This adds basic support for delivering 2 level event channels to a guest. Initially, it only supports delivery via the IRQ routing table, triggered by an eventfd. In order to do so, it has a kvm_xen_set_evtchn_fast() function which will use the pre-mapped shared_info page i

Re: [PATCH v3 07/12] KVM: arm64: Use Makefile.kvm for common files

2021-11-17 Thread Marc Zyngier
On Wed, 17 Nov 2021 17:39:58 +, David Woodhouse wrote: > > From: David Woodhouse > > Signed-off-by: David Woodhouse > --- > arch/arm64/kvm/Makefile | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/Makefile b/arch/arm64/kvm/Makefile > index 989

Re: [PATCH v3 02/12] KVM: Add Makefile.kvm for common files, use it for x86

2021-11-17 Thread Marc Zyngier
On Wed, 17 Nov 2021 17:39:53 +, David Woodhouse wrote: > > From: David Woodhouse > > Splitting kvm_main.c out into smaller and better-organized files is > slightly non-trivial when it involves editing a bunch of per-arch > KVM makefiles. Provide virt/kvm/Makefile.kvm for them to include. >

Re: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot()

2021-11-17 Thread Marc Zyngier
On Wed, 17 Nov 2021 17:39:59 +, David Woodhouse wrote: > > From: David Woodhouse > > The kvm_dirty_ring_get() function uses kvm_get_running_vcpu() to work out > which dirty ring to use, but there are some use cases where that doesn't > work. > > There's one in setting the Xen shared info p

Re: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot()

2021-11-17 Thread David Woodhouse
On 17 November 2021 18:13:37 GMT, Marc Zyngier wrote: >On Wed, 17 Nov 2021 17:39:59 +, >David Woodhouse wrote: >> >> From: David Woodhouse >> >> The kvm_dirty_ring_get() function uses kvm_get_running_vcpu() to work out >> which dirty ring to use, but there are some use cases where that

Re: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot()

2021-11-17 Thread David Woodhouse
On Wed, 2021-11-17 at 18:13 +, Marc Zyngier wrote: > What's the base for this series? This patch fails to compile for me > (at least on arm64), and the following patch doesn't apply on -rc1. It's on top of kvm/master, and it's also at https://git.infradead.org/users/dwmw2/linux.git/shortlog/re

Re: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot()

2021-11-17 Thread David Woodhouse
> From: David Woodhouse > > The kvm_dirty_ring_get() function uses kvm_get_running_vcpu() to work out > which dirty ring to use, but there are some use cases where that doesn't > work. > > There's one in setting the Xen shared info page, introduced in commit > 629b5348841a ("KVM: x86/xen: updat

Re: [PATCH v3 06/12] KVM: powerpc: Use Makefile.kvm for common files

2021-11-17 Thread Michael Ellerman
David Woodhouse writes: > From: David Woodhouse > > It's all fairly baroque but in the end, I don't think there's any reason > for $(KVM)/irqchip.o to have been handled differently, as they all end > up in $(kvm-y) in the end anyway, regardless of whether they get there > via $(common-objs-y) and

Re: [PATCH v3 01/25] PCI: Add PCI_ERROR_RESPONSE and it's related definitions

2021-11-17 Thread Bjorn Helgaas
On Thu, Oct 21, 2021 at 08:37:26PM +0530, Naveen Naidu wrote: > An MMIO read from a PCI device that doesn't exist or doesn't respond > causes a PCI error. There's no real data to return to satisfy the > CPU read, so most hardware fabricates ~0 data. > > Add a PCI_ERROR_RESPONSE definition for tha

Re: [PATCH] powerpc/pseries: delete scanlog

2021-11-17 Thread Michael Ellerman
Nathan Lynch writes: > Michael Ellerman writes: >> Nathan Lynch writes: >>> Nathan Lynch writes: Remove the pseries scanlog driver. This code supports functions from Power4-era servers that are not present on targets currently supported by arch/powerpc. System manuals from t

[powerpc:fixes-test] BUILD SUCCESS 8e80a73fa9a7747e3e8255cb149c543aabf65a24

2021-11-17 Thread kernel test robot
allmodconfig i386 randconfig-c001-2027 powerpc randconfig-c003-2027 shecovec24-romimage_defconfig m68k multi_defconfig powerpc mpc85xx_cds_defconfig arm jornada720_defconfig sh

[powerpc:next-test] BUILD SUCCESS 5d12a44d97850aacfc86a4817ca304fc33876476

2021-11-17 Thread kernel test robot
allmodconfig i386 randconfig-c001-2027 powerpc randconfig-c003-2027 shecovec24-romimage_defconfig m68k multi_defconfig powerpc mpc85xx_cds_defconfig arm jornada720_defconfig sh

[PATCH] powerpc/microwatt: Make microwatt_get_random_darn() static

2021-11-17 Thread Michael Ellerman
Make microwatt_get_random_darn() static, because it can be. Reported-by: kernel test robot Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/microwatt/rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Report: https://lore.kernel.org/lkml/20220545.dtew8ptr-...@intel.com/

Re: [RESEND PATCH v2 1/3] fixup mmu_features immediately after getting cpu pa features.

2021-11-17 Thread Sourabh Jain
Hi MPE, Any comments or suggestion on list patch series? Thanks, Sourabh Jain On 18/10/21 14:14, Sourabh Jain wrote: From: Mahesh Salgaonkar On system with radix support available, early_radix_enabled() starts returning true for a small window (until mmu_early_init_devtree() is called) even