Re: [PATCH] powerpc/64s: Default to 64K pages for 64 bit book3s

2021-10-14 Thread LEROY Christophe
Le 14/10/2021 à 01:31, Joel Stanley a écrit : > For 64-bit book3s the default should be 64K as that's what modern CPUs > are designed for. > > The following defconfigs already set CONFIG_PPC_64K_PAGES: > > cell_defconfig > pasemi_defconfig > powernv_defconfig > ppc64_defconfig > pseri

Re: [PATCH] powerpc/64s: Default to 64K pages for 64 bit book3s

2021-10-14 Thread Joel Stanley
On Thu, 14 Oct 2021 at 07:03, LEROY Christophe wrote: > > > > Le 14/10/2021 à 01:31, Joel Stanley a écrit : > > For 64-bit book3s the default should be 64K as that's what modern CPUs > > are designed for. > > > > The following defconfigs already set CONFIG_PPC_64K_PAGES: > > > > cell_defconfig >

Re: [PATCH v1 04/10] asm-generic: Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR to define associated stubs

2021-10-14 Thread Christophe Leroy
Le 13/10/2021 à 09:00, Kees Cook a écrit : On Mon, Oct 11, 2021 at 05:25:31PM +0200, Christophe Leroy wrote: Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR instead of 'dereference_function_descriptor' to know whether arch has function descriptors. Signed-off-by: Christophe Leroy I'd mention th

[PATCH] powerpc/pseries/iommu: Add of_node_put() before break

2021-10-14 Thread Wan Jiabing
Fix following coccicheck warning: ./arch/powerpc/platforms/pseries/iommu.c:924:1-28: WARNING: Function for_each_node_with_property should have of_node_put() before break Early exits from for_each_node_with_property should decrement the node reference counter. Signed-off-by: Wan Jiabing --- arc

RE: [RESEND PATCH v4 0/8] bpf powerpc: Add BPF_PROBE_MEM support in powerpc JIT compiler

2021-10-14 Thread David Laight
From: Hari Bathini > Sent: 12 October 2021 13:31 > > Patch #1 & #2 are simple cleanup patches. Patch #3 refactors JIT > compiler code with the aim to simplify adding BPF_PROBE_MEM support. > Patch #4 introduces PPC_RAW_BRANCH() macro instead of open coding > branch instruction. Patch #5 & #7 add

Re: [RESEND PATCH v4 0/8] bpf powerpc: Add BPF_PROBE_MEM support in powerpc JIT compiler

2021-10-14 Thread Christophe Leroy
Le 14/10/2021 à 10:15, David Laight a écrit : From: Hari Bathini Sent: 12 October 2021 13:31 Patch #1 & #2 are simple cleanup patches. Patch #3 refactors JIT compiler code with the aim to simplify adding BPF_PROBE_MEM support. Patch #4 introduces PPC_RAW_BRANCH() macro instead of open coding

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-14 Thread Xianting Tian
在 2021/10/10 下午1:33, Greg KH 写道: On Sat, Oct 09, 2021 at 11:45:23PM +0800, Xianting Tian wrote: 在 2021/10/9 下午7:58, Greg KH 写道: Did you look at the placement using pahole as to how this structure now looks? thanks for all your commnts. for this one, do you mean I need to remove the blank lin

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-14 Thread Greg KH
On Thu, Oct 14, 2021 at 04:34:59PM +0800, Xianting Tian wrote: > > 在 2021/10/10 下午1:33, Greg KH 写道: > > On Sat, Oct 09, 2021 at 11:45:23PM +0800, Xianting Tian wrote: > > > 在 2021/10/9 下午7:58, Greg KH 写道: > > > > Did you look at the placement using pahole as to how this structure now > > > > looks

Re: linux-next: build warnings in Linus' tree

2021-10-14 Thread Arnd Bergmann
On Thu, Oct 14, 2021 at 12:12 AM Anatolij Gustschin wrote: > On Tue, 12 Oct 2021 16:39:56 +0200 > Arnd Bergmann a...@arndb.de wrote: > ... > >Grant Likely was the original maintainer for MPC52xx until 2011, > >Anatolij Gustschin is still listed as maintainer since then but hasn't > >been active in

Re: [PATCH v2] powerpc/s64: Clarify that radix lacks DEBUG_PAGEALLOC

2021-10-14 Thread Christophe Leroy
Le 13/10/2021 à 23:34, Joel Stanley a écrit : The page_alloc.c code will call into __kernel_map_pages when DEBUG_PAGEALLOC is configured and enabled. As the implementation assumes hash, this should crash spectacularly if not for a bit of luck in __kernel_map_pages. In this function linear_map

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-14 Thread Xianting Tian
在 2021/10/14 下午4:41, Greg KH 写道: On Thu, Oct 14, 2021 at 04:34:59PM +0800, Xianting Tian wrote: 在 2021/10/10 下午1:33, Greg KH 写道: On Sat, Oct 09, 2021 at 11:45:23PM +0800, Xianting Tian wrote: 在 2021/10/9 下午7:58, Greg KH 写道: Did you look at the placement using pahole as to how this structure

Re: [PATCH v3 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock()

2021-10-14 Thread Miroslav Benes
> diff --git a/kernel/livepatch/patch.c b/kernel/livepatch/patch.c > index e8029ae..b8d75fb 100644 > --- a/kernel/livepatch/patch.c > +++ b/kernel/livepatch/patch.c > @@ -49,14 +49,16 @@ static void notrace klp_ftrace_handler(unsigned long ip, > > ops = container_of(fops, struct klp_ops, fop

Re: [PATCH v3 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock()

2021-10-14 Thread 王贇
On 2021/10/14 下午5:13, Miroslav Benes wrote: >> diff --git a/kernel/livepatch/patch.c b/kernel/livepatch/patch.c >> index e8029ae..b8d75fb 100644 >> --- a/kernel/livepatch/patch.c >> +++ b/kernel/livepatch/patch.c >> @@ -49,14 +49,16 @@ static void notrace klp_ftrace_handler(unsigned long ip, >>

[PATCH] dmaengine: bestcomm: fix system boot lockups

2021-10-14 Thread Anatolij Gustschin
memset() and memcpy() on an MMIO region like here results in a lockup at startup on mpc5200 platform (since this first happens during probing of the ATA and Ethernet drivers). Use memset_io() and memcpy_toio() instead. Fixes: 2f9ea1bde0d1 ("bestcomm: core bestcomm support for Freescale MPC5200") C

RE: [RESEND PATCH v4 0/8] bpf powerpc: Add BPF_PROBE_MEM support in powerpc JIT compiler

2021-10-14 Thread David Laight
From: Christophe Leroy > Sent: 14 October 2021 09:34 > > Le 14/10/2021 à 10:15, David Laight a écrit : > > From: Hari Bathini > >> Sent: 12 October 2021 13:31 > >> > >> Patch #1 & #2 are simple cleanup patches. Patch #3 refactors JIT > >> compiler code with the aim to simplify adding BPF_PROBE_MEM

Re: [PATCH] powerpc/dcr: Use cmplwi instead of 3-argument cmpli

2021-10-14 Thread Segher Boessenkool
Hi! On Thu, Oct 14, 2021 at 01:44:24PM +1100, Michael Ellerman wrote: > In dcr-low.S we use cmpli with three arguments, instead of four > arguments as defined in the ISA: > > cmpli cr0,r3,1024 > > This appears to be a PPC440-ism, looking at the "PPC440x5 CPU Core > User’s Manual" it show

[PATCH] powerpc/mpc512x: dts: fix PSC node warnings

2021-10-14 Thread Anatolij Gustschin
Fix build warnings like: mpc5121.dtsi:397.13-406.5: Warning (spi_bus_bridge): /soc@8000/psc@11400: node name for SPI buses should be 'spi' mpc5121.dtsi:409.13-418.5: Warning (spi_bus_bridge): /soc@8000/psc@11500: node name for SPI buses should be 'spi' mpc5121.dtsi:457.13-466.5: Warning (

Re: linux-next: build warnings in Linus' tree

2021-10-14 Thread Anatolij Gustschin
On Thu, 14 Oct 2021 10:44:46 +0200 Arnd Bergmann a...@arndb.de wrote: >On Thu, Oct 14, 2021 at 12:12 AM Anatolij Gustschin wrote: >> On Tue, 12 Oct 2021 16:39:56 +0200 >> Arnd Bergmann a...@arndb.de wrote: >> ... >> >Grant Likely was the original maintainer for MPC52xx until 2011, >> >Anatolij

Re: [RFC PATCH] powerpc: dts: Remove MPC5xxx platforms

2021-10-14 Thread Anatolij Gustschin
On Wed, 13 Oct 2021 17:38:08 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: >Hi Rob, > >On Tue, 12 Oct 2021 10:34:56 -0500 Rob Herring wrote: >> >> The mpc5xxx platforms have had dts warnings for some time which no one >> seems to care to fix, so let's just remove the dts files. >> >> Accor

Re: [PATCH] powerpc/mpc512x: dts: fix PSC node warnings

2021-10-14 Thread Rob Herring
On Thu, Oct 14, 2021 at 6:31 AM Anatolij Gustschin wrote: > > Fix build warnings like: > mpc5121.dtsi:397.13-406.5: Warning (spi_bus_bridge): /soc@8000/psc@11400: > node name for SPI buses should be 'spi' > mpc5121.dtsi:409.13-418.5: Warning (spi_bus_bridge): /soc@8000/psc@11500: > node

Re: [PATCH 1/5] dt-bindings: memory: fsl: convert ifc binding to yaml schema

2021-10-14 Thread Rob Herring
On Mon, Oct 4, 2021 at 4:31 AM Krzysztof Kozlowski wrote: > > On 01/10/2021 18:17, Li Yang wrote: > > On Fri, Oct 1, 2021 at 5:01 AM Krzysztof Kozlowski > > wrote: > >> > > (...) > > >>> + > >>> + interrupts: > >>> +minItems: 1 > >>> +maxItems: 2 > >>> +description: | > >>> + IF

Re: [PATCH v3 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock()

2021-10-14 Thread Steven Rostedt
On Thu, 14 Oct 2021 11:13:13 +0200 (CEST) Miroslav Benes wrote: > for the livepatch part of the patch. > > I would also ask you not to submit new versions so often, so that the > other reviewers have time to actually review the patch set. > > Quoting from Documentation/process/submitting-patch

Re: [PATCH] powerpc/pseries/iommu: Add of_node_put() before break

2021-10-14 Thread Leonardo Brás
Hello Wan, thank you for this patch. On Thu, 2021-10-14 at 03:56 -0400, Wan Jiabing wrote: > Fix following coccicheck warning: > > ./arch/powerpc/platforms/pseries/iommu.c:924:1-28: WARNING: Function > for_each_node_with_property should have of_node_put() before break > > Early exits from for_e

Re: [PATCH v3 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock()

2021-10-14 Thread Petr Mladek
On Wed 2021-10-13 16:51:46, 王贇 wrote: > As the documentation explained, ftrace_test_recursion_trylock() > and ftrace_test_recursion_unlock() were supposed to disable and > enable preemption properly, however currently this work is done > outside of the function, which could be missing by mistake. >

Re: [PATCH v2] scsi: ibmvscsi: Use dma_alloc_noncoherent() instead of get_zeroed_page/dma_map_single()

2021-10-14 Thread Nathan Lynch
Cai Huoqing writes: > @@ -331,18 +329,12 @@ static int ibmvscsi_init_crq_queue(struct crq_queue > *queue, > int retrc; > struct vio_dev *vdev = to_vio_dev(hostdata->dev); > > - queue->msgs = (struct viosrp_crq *)get_zeroed_page(GFP_KERNEL); > - > - if (!queue->msgs) > -

Re: [PATCH v2 01/13] powerpc: Move 'struct ppc64_opd_entry' back into asm/elf.h

2021-10-14 Thread Daniel Axtens
Hi Christophe, > 'struct ppc64_opd_entry' doesn't belong to uapi/asm/elf.h > > It was initially in module_64.c and commit 2d291e902791 ("Fix compile > failure with non modular builds") moved it into asm/elf.h > > But it was by mistake added outside of __KERNEL__ section, > therefore commit c3617f7

Re: [PATCH v2 00/13] Fix LKDTM for PPC64/IA64/PARISC

2021-10-14 Thread Daniel Axtens
Christophe Leroy writes: > PPC64/IA64/PARISC have function descriptors. LKDTM doesn't work > on those three architectures because LKDTM messes up function > descriptors with functions. Just to nitpick, it's powerpc 64-bit using the ELFv1 ABI. [1] The ELFv2 ABI [2] doesn't use function descripto

Re: [PATCH v2 02/13] powerpc: Rename 'funcaddr' to 'addr' in 'struct ppc64_opd_entry'

2021-10-14 Thread Daniel Axtens
Christophe Leroy writes: > There are three architectures with function descriptors, try to > have common names for the address they contain in order to > refactor some functions into generic functions later. > > powerpc has 'funcaddr' > ia64 has 'ip' > parisc has 'addr' > > Vote for 'addr' and up

Re: [PATCH v2] scsi: ibmvscsi: Use dma_alloc_noncoherent() instead of get_zeroed_page/dma_map_single()

2021-10-14 Thread Tyrel Datwyler
On 10/11/21 8:23 PM, Cai Huoqing wrote: > Replacing get_zeroed_page/free_page/dma_map_single/dma_unmap_single() > with dma_alloc_noncoherent/dma_free_noncoherent() helps to reduce > code size, and simplify the code, and the hardware can keeep DMA > coherent itsel Not sure why the switch from cohere

Re: [PATCH] powerpc/dcr: Use cmplwi instead of 3-argument cmpli

2021-10-14 Thread Nick Desaulniers
On Wed, Oct 13, 2021 at 7:44 PM Michael Ellerman wrote: > > In dcr-low.S we use cmpli with three arguments, instead of four > arguments as defined in the ISA: > > cmpli cr0,r3,1024 > > This appears to be a PPC440-ism, looking at the "PPC440x5 CPU Core > User’s Manual" it shows cmpli havi

Re: [PATCH v2 03/13] powerpc: Remove func_descr_t

2021-10-14 Thread Daniel Axtens
Christophe Leroy writes: > 'func_descr_t' is redundant with 'struct ppc64_opd_entry' So, if I understand the overall direction of the series, you're consolidating powerpc around one single type for function descriptors, and then you're creating a generic typedef so that generic code can always d

[PATCH v2] powerpc/mpc512x: dts: fix PSC node warnings

2021-10-14 Thread Anatolij Gustschin
Rework PSC node description to fix build warnings like: mpc5121.dtsi:397.13-406.5: Warning (spi_bus_bridge): /soc@8000/psc@11400: node name for SPI buses should be 'spi' mpc5121.dtsi:409.13-418.5: Warning (spi_bus_bridge): /soc@8000/psc@11500: node name for SPI buses should be 'spi' mpc51

Re: [PATCH] powerpc/mpc512x: dts: fix PSC node warnings

2021-10-14 Thread Anatolij Gustschin
On Thu, 14 Oct 2021 07:33:26 -0500 Rob Herring robh...@kernel.org wrote: ... >> +++ b/arch/powerpc/boot/dts/ac14xx.dts >> @@ -301,13 +301,21 @@ >> fsl,tx-fifo-size = <512>; >> }; >> >> + /delete-node/ psc@11400; >> + /delete-node/

Re: [PATCH] ibmvscsi: use GFP_KERNEL with dma_alloc_coherent in initialize_event_pool

2021-10-14 Thread Tyrel Datwyler
Just stumbled upon this trivial little patch that looks to have gotten lost in the shuffle. Seems it even got a reviewed-by from Brian [1]. So, uh I guess after almost 3 years...ping? -Tyrel [1] https://yhbt.net/lore/all/fd33df0e-012b-e437-c6e9-29cd08838...@linux.vnet.ibm.com/ On 01/09/2019 08:

[PATCH v2] powerpc/64s: Default to 64K pages for 64 bit book3s

2021-10-14 Thread Joel Stanley
For 64-bit book3s the default should be 64K as that's what modern CPUs are designed for. The following defconfigs already set CONFIG_PPC_64K_PAGES: cell_defconfig pasemi_defconfig powernv_defconfig ppc64_defconfig pseries_defconfig skiroot_defconfig The have the option removed from the def

Re: [PATCH v2] KVM: PPC: Defer vtime accounting 'til after IRQ handling

2021-10-14 Thread Nicholas Piggin
Excerpts from Laurent Vivier's message of October 13, 2021 7:30 pm: > On 13/10/2021 01:18, Michael Ellerman wrote: >> Laurent Vivier writes: >>> Commit 112665286d08 moved guest_exit() in the interrupt protected >>> area to avoid wrong context warning (or worse), but the tick counter >>> cannot be

[powerpc:fixes-test] BUILD SUCCESS 6f779e1d359b8d5801f677c1d49dcfa10bf95674

2021-10-14 Thread kernel test robot
have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig i386 randconfig-c001-20211014 arm

[PATCH v11 1/3] tty: hvc: use correct dma alignment size

2021-10-14 Thread Xianting Tian
Use L1_CACHE_BYTES as the dma alignment size, use 'sizeof(long)' as dma alignment is wrong. Signed-off-by: Xianting Tian Signed-off-by: Shile Zhang --- drivers/tty/hvc/hvc_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/h

[PATCH v11 0/3] make hvc pass dma capable memory to its backend

2021-10-14 Thread Xianting Tian
Dear all, This patch series make hvc framework pass DMA capable memory to put_chars() of hvc backend(eg, virtio-console), and revert commit c4baad5029 ("virtio-console: avoid DMA from stack”) V1 virtio-console: avoid DMA from vmalloc area https://lkml.org/lkml/2021/7/27/494 For v1 patch, Arnd Be

[PATCH v11 3/3] virtio-console: remove unnecessary kmemdup()

2021-10-14 Thread Xianting Tian
This revert commit c4baad5029 ("virtio-console: avoid DMA from stack") hvc framework will never pass stack memory to the put_chars() function, So the calling of kmemdup() is unnecessary, we can remove it. Signed-off-by: Xianting Tian Reviewed-by: Shile Zhang --- drivers/char/virtio_console.c |

[PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-14 Thread Xianting Tian
As well known, hvc backend can register its opertions to hvc backend. the operations contain put_chars(), get_chars() and so on. Some hvc backend may do dma in its operations. eg, put_chars() of virtio-console. But in the code of hvc framework, it may pass DMA incapable memory to put_chars() under

[powerpc:merge] BUILD SUCCESS 38947529bb05bbb8acfb2fe0ff96c2f1bc3f2c96

2021-10-14 Thread kernel test robot
config arm allmodconfig i386 randconfig-c001-20211012 i386 randconfig-c001-20211011 i386 randconfig-c001-20211014 mips tb0219_defconfig armmvebu_v7_defconfig xtensa audio_kc705_defc

Re: [PATCH v3 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock()

2021-10-14 Thread 王贇
On 2021/10/14 下午11:14, Petr Mladek wrote: [snip] >> -return trace_test_and_set_recursion(ip, parent_ip, TRACE_FTRACE_START, >> TRACE_FTRACE_MAX); >> +int bit; >> + >> +bit = trace_test_and_set_recursion(ip, parent_ip, TRACE_FTRACE_START, >> TRACE_FTRACE_MAX); >> +/* >> + *

Re: [PATCH v3 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock()

2021-10-14 Thread Steven Rostedt
On Thu, 14 Oct 2021 17:14:07 +0200 Petr Mladek wrote: > /** >* ftrace_test_recursion_trylock - tests for recursion in same context >* >* Use this for ftrace callbacks. This will detect if the function >* tracing recursed in the same context (normal vs interrupt), >* >* R

[powerpc:next-test] BUILD SUCCESS 3091f5fc5f1df7741ddf326561384e0997eca2a1

2021-10-14 Thread kernel test robot
randconfig-c001-20211014 mips loongson1b_defconfig armmmp2_defconfig mips rb532_defconfig arm exynos_defconfig shedosk7705_defconfig arm

Re: [PATCH] ibmvscsi: use GFP_KERNEL with dma_alloc_coherent in initialize_event_pool

2021-10-14 Thread Michael Ellerman
Tyrel Datwyler writes: > Just stumbled upon this trivial little patch that looks to have gotten lost in > the shuffle. Seems it even got a reviewed-by from Brian [1]. > > So, uh I guess after almost 3 years...ping? It's marked "Changes Requested" here: https://patchwork.kernel.org/project/lin

Re: [PATCH v3 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock()

2021-10-14 Thread 王贇
On 2021/10/15 上午11:13, 王贇 wrote: [snip] >> # define do_ftrace_record_recursion(ip, pip)do { } while (0) >> #endif >> >> +/* >> + * trace_test_and_set_recursion() is called on several layers >> + * of the ftrace code when handling the same ftrace entry. >> + * These calls might be nes

[PATCH][next] powerpc/vas: Fix potential NULL pointer dereference

2021-10-14 Thread Gustavo A. R. Silva
(!ptr && !ptr->foo) strikes again. :) The expression (!ptr && !ptr->foo) is bogus and in case ptr is NULL, it leads to a NULL pointer dereference: ptr->foo. Fix this by converting && to || This issue was detected with the help of Coccinelle, and audited and fixed manually. Fixes: 1a0d0d5ed5e3 (

Re: [PATCH v2 02/13] powerpc: Rename 'funcaddr' to 'addr' in 'struct ppc64_opd_entry'

2021-10-14 Thread Christophe Leroy
Le 14/10/2021 à 23:45, Daniel Axtens a écrit : Christophe Leroy writes: There are three architectures with function descriptors, try to have common names for the address they contain in order to refactor some functions into generic functions later. powerpc has 'funcaddr' ia64 has 'ip' pari

Re: [PATCH v2 03/13] powerpc: Remove func_descr_t

2021-10-14 Thread Christophe Leroy
Le 15/10/2021 à 00:17, Daniel Axtens a écrit : Christophe Leroy writes: 'func_descr_t' is redundant with 'struct ppc64_opd_entry' So, if I understand the overall direction of the series, you're consolidating powerpc around one single type for function descriptors, and then you're creating

[powerpc:next] BUILD SUCCESS 8f6aca0e0f26eaaee670cd27896993a45cdc8f9e

2021-10-14 Thread kernel test robot
allmodconfig i386 randconfig-c001-20211014 mips loongson1b_defconfig armmmp2_defconfig mips rb532_defconfig arm exynos_defconfig sh

Re: [PATCH v2 01/13] powerpc: Move 'struct ppc64_opd_entry' back into asm/elf.h

2021-10-14 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of October 14, 2021 3:49 pm: > 'struct ppc64_opd_entry' doesn't belong to uapi/asm/elf.h > > It was initially in module_64.c and commit 2d291e902791 ("Fix compile > failure with non modular builds") moved it into asm/elf.h > > But it was by mistake added o

Re: [PATCH v2 02/13] powerpc: Rename 'funcaddr' to 'addr' in 'struct ppc64_opd_entry'

2021-10-14 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of October 14, 2021 3:49 pm: > There are three architectures with function descriptors, try to > have common names for the address they contain in order to > refactor some functions into generic functions later. > > powerpc has 'funcaddr' > ia64 has 'ip' >

Re: [PATCH v2 03/13] powerpc: Remove func_descr_t

2021-10-14 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of October 15, 2021 3:19 pm: > > > Le 15/10/2021 à 00:17, Daniel Axtens a écrit : >> Christophe Leroy writes: >> >>> 'func_descr_t' is redundant with 'struct ppc64_opd_entry' >> >> So, if I understand the overall direction of the series, you're >> conso

Re: [PATCH v2 06/13] asm-generic: Use HAVE_FUNCTION_DESCRIPTORS to define associated stubs

2021-10-14 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of October 14, 2021 3:49 pm: > Replace HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR by > HAVE_FUNCTION_DESCRIPTORS and use it instead of > 'dereference_function_descriptor' macro to know > whether an arch has function descriptors. > > To limit churn in one of the f

Re: [PATCH v2 06/13] asm-generic: Use HAVE_FUNCTION_DESCRIPTORS to define associated stubs

2021-10-14 Thread Christophe Leroy
Le 15/10/2021 à 08:16, Nicholas Piggin a écrit : Excerpts from Christophe Leroy's message of October 14, 2021 3:49 pm: Replace HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR by HAVE_FUNCTION_DESCRIPTORS and use it instead of 'dereference_function_descriptor' macro to know whether an arch has function d

[PATCH] macintosh: ams: replace snprintf in show functions with sysfs_emit

2021-10-14 Thread Qing Wang
show() must not use snprintf() when formatting the value to be returned to user space. Fix the following coccicheck warning: drivers/macintosh/ams/ams-core.c:53: WARNING: use scnprintf or sprintf. Use sysfs_emit instead of scnprintf or sprintf makes more sense. Signed-off-by: Qing Wang --- dri