Re: [PATCH] powerpc/64s: Fix hash fault to use TRAP accessor

2021-03-30 Thread Michael Ellerman
On Tue, 16 Mar 2021 20:52:05 +1000, Nicholas Piggin wrote: > Hash faults use the trap vector to decide whether this is an > instruction or data fault. This should use the TRAP accessor > rather than open access regs->trap. > > This won't cause a problem at the moment because 64s only uses > trap f

Re: [PATCH v5] powerpc/uprobes: Validation for prefixed instruction

2021-03-30 Thread Michael Ellerman
On Thu, 11 Mar 2021 14:45:38 +0530, Ravi Bangoria wrote: > As per ISA 3.1, prefixed instruction should not cross 64-byte > boundary. So don't allow Uprobe on such prefixed instruction. > > There are two ways probed instruction is changed in mapped pages. > First, when Uprobe is activated, it searc

Re: [PATCH] arch: powerpc: kernel: Change droping to dropping in the file traps.c

2021-03-30 Thread Michael Ellerman
On Wed, 24 Feb 2021 13:25:47 +0530, Bhaskar Chowdhury wrote: > s/droping/dropping/ Applied to powerpc/next. [1/1] arch: powerpc: kernel: Change droping to dropping in the file traps.c https://git.kernel.org/powerpc/c/5c4a4802b9ac8c1acdf2250fad3f8f2d6254f9c7 cheers

Re: [PATCH] powerpc: kernel: Trivial spelling fixes throughout the file head_fsl_booke.S

2021-03-30 Thread Michael Ellerman
On Mon, 15 Mar 2021 03:34:36 +0530, Bhaskar Chowdhury wrote: > Trivial spelling fixes throughout the file. Applied to powerpc/next. [1/1] powerpc: kernel: Trivial spelling fixes throughout the file head_fsl_booke.S https://git.kernel.org/powerpc/c/f239873fcd953557ba9a9781d10ca95c0594e2b3

Re: [PATCH] powerpc: kernel: Trivial typo fix in the file kgdb.c

2021-03-30 Thread Michael Ellerman
On Wed, 17 Mar 2021 14:34:13 +0530, Bhaskar Chowdhury wrote: > s/procesing/processing/ Applied to powerpc/next. [1/1] powerpc: kernel: Trivial typo fix in the file kgdb.c https://git.kernel.org/powerpc/c/89f7d2927ae16ea470d29234447763826e40c6cf cheers

Re: [PATCH] powerpc: mm: book3s64: Fix a typo in the file mmu_context.c

2021-03-30 Thread Michael Ellerman
On Fri, 12 Mar 2021 16:55:37 +0530, Bhaskar Chowdhury wrote: > s/detalis/details/ Applied to powerpc/next. [1/1] powerpc: mm: book3s64: Fix a typo in the file mmu_context.c https://git.kernel.org/powerpc/c/7a7d744ffe87ae10ab98004d1a6ca1f691af58e1 cheers

Re: [PATCH] powerpc/xive: use true and false for bool variable

2021-03-30 Thread Michael Ellerman
On Mon, 15 Mar 2021 15:24:56 +0800, Yang Li wrote: > fixed the following coccicheck: > ./arch/powerpc/sysdev/xive/spapr.c:552:8-9: WARNING: return of 0/1 in > function 'xive_spapr_match' with return type bool Applied to powerpc/next. [1/1] powerpc/xive: use true and false for bool variable

Re: [PATCH] cxl: Fix couple of spellings

2021-03-30 Thread Michael Ellerman
On Mon, 22 Mar 2021 08:03:07 +0530, Bhaskar Chowdhury wrote: > s/filesytem/filesystem/ > s/symantics/semantics/ Applied to powerpc/next. [1/1] cxl: Fix couple of spellings https://git.kernel.org/powerpc/c/e23ecdf9fd87c547a3ac55bcebaf7df28df2fab0 cheers

Re: [PATCH v4 01/46] KVM: PPC: Book3S HV: Nested move LPCR sanitising to sanitise_hv_regs

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:20AM +1000, Nicholas Piggin wrote: > This will get a bit more complicated in future patches. Move it > into the helper function. This does change L1-visible behaviour, because now the L1 hypervisor can see the LPCR bits that L0 is using, whereas previously it couldn't

Re: [PATCH v4 02/46] KVM: PPC: Book3S HV: Add a function to filter guest LPCR bits

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:21AM +1000, Nicholas Piggin wrote: > Guest LPCR depends on hardware type, and future changes will add > restrictions based on errata and guest MMU mode. Move this logic > to a common function and use it for the cases where the guest > wants to update its LPCR (or the L

Re: [PATCH v4 03/46] KVM: PPC: Book3S HV: Disallow LPCR[AIL] to be set to 1 or 2

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:22AM +1000, Nicholas Piggin wrote: > These are already disallowed by H_SET_MODE from the guest, also disallow > these by updating LPCR directly. > > AIL modes can affect the host interrupt behaviour while the guest LPCR > value is set, so filter it here too. > > Sugg

Re: [PATCH v4 04/46] KVM: PPC: Book3S HV: Prevent radix guests from setting LPCR[TC]

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:23AM +1000, Nicholas Piggin wrote: > This bit only applies to hash partitions. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/kvm/book3s_hv.c| 6 ++ > arch/powerpc/kvm/book3s_hv_nested.c | 3 +-- > 2 files changed, 7 insertions(+), 2 deletions(-

Re: [PATCH] powerpc/pseries: Only register vio drivers if vio bus exists

2021-03-30 Thread Michael Ellerman
Paul Menzel writes: > Am 16.03.21 um 02:09 schrieb Michael Ellerman: >> The vio bus is a fake bus, which we use on pseries LPARs (guests) to >> discover devices provided by the hypervisor. There's no need or sense >> in creating the vio bus on bare metal systems. >> >> Which is why commit 4336b93

Re: [PATCH v4 06/46] KVM: PPC: Book3S HV: remove unused kvmppc_h_protect argument

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:25AM +1000, Nicholas Piggin wrote: > The va argument is not used in the function or set by its asm caller, > so remove it to be safe. > > Reviewed-by: Daniel Axtens > Signed-off-by: Nicholas Piggin Acked-by: Paul Mackerras

Re: [PATCH v4 05/46] KVM: PPC: Book3S HV: Remove redundant mtspr PSPB

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:24AM +1000, Nicholas Piggin wrote: > This SPR is set to 0 twice when exiting the guest. > > Suggested-by: Fabiano Rosas > Reviewed-by: Daniel Axtens > Signed-off-by: Nicholas Piggin Acked-by: Paul Mackerras

Re: [PATCH v4 07/46] KVM: PPC: Book3S HV: Fix CONFIG_SPAPR_TCE_IOMMU=n default hcalls

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:26AM +1000, Nicholas Piggin wrote: > This config option causes the warning in init_default_hcalls to fire > because the TCE handlers are in the default hcall list but not > implemented. > > Reviewed-by: Daniel Axtens > Signed-off-by: Nicholas Piggin Acked-by: Paul

Re: [PATCH v4 08/46] powerpc/64s: Remove KVM handler support from CBE_RAS interrupts

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:27AM +1000, Nicholas Piggin wrote: > Cell does not support KVM. > > Reviewed-by: Fabiano Rosas > Signed-off-by: Nicholas Piggin Acked-by: Paul Mackerras

Re: [PATCH v4 09/46] powerpc/64s: remove KVM SKIP test from instruction breakpoint handler

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:28AM +1000, Nicholas Piggin wrote: > The code being executed in KVM_GUEST_MODE_SKIP is hypervisor code with > MSR[IR]=0, so the faults of concern are the d-side ones caused by access > to guest context by the hypervisor. > > Instruction breakpoint interrupts are not a

Re: [PATCH v4 10/46] KVM: PPC: Book3S HV: Ensure MSR[ME] is always set in guest MSR

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:29AM +1000, Nicholas Piggin wrote: > Rather than add the ME bit to the MSR at guest entry, make it clear > that the hypervisor does not allow the guest to clear the bit. > > The ME set is kept in guest entry for now, but a future patch will > warn if it's not present.

Re: [PATCH v4 11/46] KVM: PPC: Book3S HV: Ensure MSR[HV] is always clear in guest MSR

2021-03-30 Thread Paul Mackerras
On Tue, Mar 23, 2021 at 11:02:30AM +1000, Nicholas Piggin wrote: > Rather than clear the HV bit from the MSR at guest entry, make it clear > that the hypervisor does not allow the guest to set the bit. > > The HV clear is kept in guest entry for now, but a future patch will > warn if it's not pres

<    1   2