[PATCH for 5.10] powerpc/32: Preserve cr1 in exception prolog stack check to fix build error

2021-02-12 Thread Christophe Leroy
This is backport of 3642eb21256a ("powerpc/32: Preserve cr1 in exception prolog stack check to fix build error") for kernel 5.10 It fixes the build failure on v5.10 reported by kernel test robot and by David Michael. This fix is not in Linux tree yet, it is in next branch in powerpc tree. (cherr

Re: linux-next: manual merge of the spi tree with the powerpc tree

2021-02-12 Thread Mark Brown
On Fri, Feb 12, 2021 at 03:31:42PM +1100, Stephen Rothwell wrote: > BTW Mark: the author's address in 258ea99fe25a uses a non existent domain :-( Ugh, I think that's something gone wrong with b4 :( A bit late now to try to fix it up. signature.asc Description: PGP signature

Re: [PATCH v17 02/10] of: Add a common kexec FDT setup function

2021-02-12 Thread Rob Herring
On Thu, Feb 11, 2021 at 7:17 PM Lakshmi Ramasubramanian wrote: > > On 2/11/21 5:09 PM, Thiago Jung Bauermann wrote: > > > > There's actually a complication that I just noticed and needs to be > > addressed. More below. > > > > <...> > > >> + > >> +/* > >> + * of_kexec_alloc_and_setup_fdt - Alloc a

Re: [PATCH 2/2] powerpc/uaccess: Move might_fault() into user_access_begin()

2021-02-12 Thread Christophe Leroy
Le 08/02/2021 à 14:57, Michael Ellerman a écrit : We have a might_fault() check in __unsafe_put_user_goto(), but that is dangerous as it potentially calls lots of code while user access is enabled. It also triggers the check Alexey added to the irq restore path to catch cases like that: W

[PATCH] powerpc/pseries: Don't enforce MSI affinity with kdump

2021-02-12 Thread Greg Kurz
Depending on the number of online CPUs in the original kernel, it is likely for CPU #0 to be offline in a kdump kernel. The associated IRQs in the affinity mappings provided by irq_create_affinity_masks() are thus not started by irq_startup(), as per-design with managed IRQs. This can be a problem

Re: [PATCH] powerpc/pseries: Don't enforce MSI affinity with kdump

2021-02-12 Thread Laurent Vivier
On 12/02/2021 17:41, Greg Kurz wrote: > Depending on the number of online CPUs in the original kernel, it is > likely for CPU #0 to be offline in a kdump kernel. The associated IRQs > in the affinity mappings provided by irq_create_affinity_masks() are > thus not started by irq_startup(), as per-de

Re: [PATCH v17 02/10] of: Add a common kexec FDT setup function

2021-02-12 Thread Lakshmi Ramasubramanian
On 2/12/21 6:38 AM, Rob Herring wrote: On Thu, Feb 11, 2021 at 7:17 PM Lakshmi Ramasubramanian wrote: On 2/11/21 5:09 PM, Thiago Jung Bauermann wrote: There's actually a complication that I just noticed and needs to be addressed. More below. <...> + +/* + * of_kexec_alloc_and_setup_fdt

Re: [PATCH] powerpc/pseries: Don't enforce MSI affinity with kdump

2021-02-12 Thread Cédric Le Goater
On 2/12/21 5:41 PM, Greg Kurz wrote: > Depending on the number of online CPUs in the original kernel, it is > likely for CPU #0 to be offline in a kdump kernel. The associated IRQs > in the affinity mappings provided by irq_create_affinity_masks() are > thus not started by irq_startup(), as per-des

Re: [PATCH v17 02/10] of: Add a common kexec FDT setup function

2021-02-12 Thread Rob Herring
On Fri, Feb 12, 2021 at 11:19 AM Lakshmi Ramasubramanian wrote: > > On 2/12/21 6:38 AM, Rob Herring wrote: > > On Thu, Feb 11, 2021 at 7:17 PM Lakshmi Ramasubramanian > > wrote: > >> > >> On 2/11/21 5:09 PM, Thiago Jung Bauermann wrote: > >>> > >>> There's actually a complication that I just noti

Re: [PATCH v17 02/10] of: Add a common kexec FDT setup function

2021-02-12 Thread Lakshmi Ramasubramanian
On 2/12/21 10:24 AM, Rob Herring wrote: On Fri, Feb 12, 2021 at 11:19 AM Lakshmi Ramasubramanian wrote: On 2/12/21 6:38 AM, Rob Herring wrote: On Thu, Feb 11, 2021 at 7:17 PM Lakshmi Ramasubramanian wrote: On 2/11/21 5:09 PM, Thiago Jung Bauermann wrote: There's actually a complication t

Re: [PATCH v17 02/10] of: Add a common kexec FDT setup function

2021-02-12 Thread Thiago Jung Bauermann
Lakshmi Ramasubramanian writes: > On 2/12/21 10:24 AM, Rob Herring wrote: >> On Fri, Feb 12, 2021 at 11:19 AM Lakshmi Ramasubramanian >> wrote: >>> >>> On 2/12/21 6:38 AM, Rob Herring wrote: On Thu, Feb 11, 2021 at 7:17 PM Lakshmi Ramasubramanian wrote: > > On 2/11/21 5:09 P

Re: [RFC PATCH 2/9] KVM: PPC: Book3S 64: Move GUEST_MODE_SKIP test into KVM

2021-02-12 Thread Fabiano Rosas
Nicholas Piggin writes: > Move the GUEST_MODE_SKIP logic into KVM code. This is quite a KVM > internal detail that has no real need to be in common handlers. LGTM, > > (XXX: Need to confirm CBE handlers etc) Do these interrupts exist only in Cell? I see that they set HSRRs and MSR_HV, but CPU_

Re: [RFC PATCH 3/9] KVM: PPC: Book3S 64: add hcall interrupt handler

2021-02-12 Thread Fabiano Rosas
Nicholas Piggin writes: > Add a separate hcall entry point. This can be used to deal with the > different calling convention. > > Signed-off-by: Nicholas Piggin Reviewed-by: Fabiano Rosas > --- > arch/powerpc/kernel/exceptions-64s.S | 4 ++-- > arch/powerpc/kvm/book3s_64_entry.S | 4 >

Re: [PATCH] powerpc/pseries: Don't enforce MSI affinity with kdump

2021-02-12 Thread kernel test robot
Hi Greg, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on linus/master v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as docu

Re: [PATCH v5 07/10] powerpc/signal64: Replace restore_sigcontext() w/ unsafe_restore_sigcontext()

2021-02-12 Thread Daniel Axtens
Hi Chris, > Previously restore_sigcontext() performed a costly KUAP switch on every > uaccess operation. These repeated uaccess switches cause a significant > drop in signal handling performance. > > Rewrite restore_sigcontext() to assume that a userspace read access > window is open. Replace all

Re: [PATCH v5 10/10] powerpc/signal64: Use __get_user() to copy sigset_t

2021-02-12 Thread Daniel Axtens
"Christopher M. Riedl" writes: > Usually sigset_t is exactly 8B which is a "trivial" size and does not > warrant using __copy_from_user(). Use __get_user() directly in > anticipation of future work to remove the trivial size optimizations > from __copy_from_user(). Calling __get_user() also resul

Re: linux-next: manual merge of the spi tree with the powerpc tree

2021-02-12 Thread Stephen Rothwell
Hi Mark, On Fri, 12 Feb 2021 12:27:59 + Mark Brown wrote: > > On Fri, Feb 12, 2021 at 03:31:42PM +1100, Stephen Rothwell wrote: > > > BTW Mark: the author's address in 258ea99fe25a uses a non existent domain > > :-( > > Ugh, I think that's something gone wrong with b4 :( A bit late now