Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()

On 14/11/2019 14.57, Timur Tabi wrote: > On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes > wrote: >> >> - if (*iprop) >> - qe_port->port.uartclk = *iprop; >> + if (val) >> + qe_port->port.uartclk = val; >> else { >> /* >>

Re: [PATCH v4 07/47] soc: fsl: qe: qe.c: guard use of pvr_version_is() with CONFIG_PPC32

On 15/11/2019 05.50, Timur Tabi wrote: > On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes > wrote: >> >> +static bool qe_general4_errata(void) >> +{ >> +#ifdef CONFIG_PPC32 >> + return pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x); >> +#endif >> + return false; >> +} >> +

[PATCH 3/6] powerpc/fsl_booke/64: implement KASLR for fsl_booke64

The implementation for Freescale BookE64 is similar as BookE32. One difference is that Freescale BookE64 set up a TLB mapping of 1G during booting. Another difference is that ppc64 needs the kernel to be 64K-aligned. So we can randomize the kernel in this 1G mapping and make it 64K-aligned. This ca

[PATCH 1/6] powerpc/fsl_booke/kaslr: refactor kaslr_legal_offset() and kaslr_early_init()

Some code refactor in kaslr_legal_offset() and kaslr_early_init(). No functional change. This is a preparation for KASLR fsl_booke64. Signed-off-by: Jason Yan Cc: Scott Wood Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nichola

[PATCH 2/6] powerpc/fsl_booke/64: introduce reloc_kernel_entry() helper

Like the 32bit code, we introduce reloc_kernel_entry() helper to prepare for the KASLR 64bit version. And move the C declaration of this function out of CONFIG_PPC32 and use long instead of int for the parameter 'addr'. Signed-off-by: Jason Yan Cc: Scott Wood Cc: Diana Craciun Cc: Michael Eller

[PATCH 0/6] implement KASLR for powerpc/fsl_booke/64

This is a try to implement KASLR for Freescale BookE64 which is based on my earlier implementation for Freescale BookE32: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=131718 The implementation for Freescale BookE64 is similar as BookE32. One difference is that Freescale BookE64 s

[PATCH 5/6] powerpc/fsl_booke/64: clear the original kernel if randomized

The original kernel still exists in the memory, clear it now. Signed-off-by: Jason Yan Cc: Scott Wood Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook --- arch/powerpc/mm/nohash/kaslr_booke.c | 4 +

[PATCH 4/6] powerpc/fsl_booke/64: do not clear the BSS for the second pass

The BSS section has already cleared out in the first pass. No need to clear it again. This can save some time when booting with KASLR enabled. Signed-off-by: Jason Yan Cc: Scott Wood Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc

[PATCH 6/6] powerpc/fsl_booke/kaslr: rename kaslr-booke32.rst to kaslr-booke.rst and add 64bit part

Now we support both 32 and 64 bit KASLR for fsl booke. Add document for 64 bit part and rename kaslr-booke32.rst to kaslr-booke.rst. Signed-off-by: Jason Yan Cc: Scott Wood Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas

Re: WARN_ONCE does not warn once

On Fri, Nov 15, 2019 at 09:44:34AM +0100, Michal Suchánek wrote: > On Fri, Nov 15, 2019 at 03:43:24PM +1100, Michael Ellerman wrote: > > Michal Suchánek writes: > > > On Thu, Nov 14, 2019 at 05:46:55PM +0100, Michal Suchánek wrote: > > >> Hello, > > >> > > >> on powernv with 5.3.8 kernel I get fl

Re: [-merge] BUG followed by oops running ndctl tests

Sachin Sant writes: > Following Oops is seen on latest (commit 3b4852888d) powerpc merge branch > code while running ndctl (test_namespace) tests > > 85c5b0984e was good. The obvious change is: 076265907cf9 ("powerpc: Chunk calls to flush_dcache_range in arch_*_memory") Though not obvious why

Re: [PATCH v2 0/2] mm: remove the memory isolate notifier

On 14.11.19 14:19, David Hildenbrand wrote: > This is the MM part of > https://lkml.org/lkml/2019/10/31/487 > > "We can get rid of the memory isolate notifier by switching to balloon > compaction in powerpc's CMM (Collaborative Memory Management). The memory > isolate notifier was only neces

Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops

> test_bit() is an atomic bitop. I assume it was meant to be in > instrumented-atomic.h? Hmm, interesting. I was tricked by the generic version doing just a simple read, with only a volatile attribute to ensure the read occurs more-or-less as written: /** * test_bit - Determine whether a bit is

Re: [PATCH] rtc: fsl-ftm-alarm: remove select FSL_RCPM and default y from Kconfig

On 08/11/2019 16:40:56-0600, Li Yang wrote: > The Flextimer alarm is primarily used as a wakeup source for system > power management. But it shouldn't select the power management driver > as they don't really have dependency of each other. > > Also remove the default y as it is not a critical fea

Re: [PATCH v3 36/36] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE

Hi Rasmus, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.4-rc7 next-20191114] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' o

Re: [PATCH v4 0/5] Early node associativity

Hi Michael, > Nathan Lynch writes: > > Srikar Dronamraju writes: > >> Abdul reported a warning on a shared lpar. > >> "WARNING: workqueue cpumask: online intersect > possible intersect". > >> This is because per node workqueue possible mask is set very early in the > >> boot process even before

Re: [PATCH v2] powerpc/smp: Use nid as fallback for package_id

Hey Michael, * Srikar Dronamraju [2019-08-22 20:08:53]: > Package_id is to find out all cores that are part of the same chip. On > PowerNV machines, package_id defaults to chip_id. However ibm,chip_id > property is not present in device-tree of PowerVM Lpars. Hence lscpu > output shows one core

Re: [PATCH v3 36/36] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE

On 15/11/2019 14.31, kbuild test robot wrote: > Hi Rasmus, > > Thank you for the patch! Perhaps something to improve: Hello kbuild Thanks for your reports, but this has already been fixed. Is there some way to indicate to the kbuild bot that it should stop using resources on a specific patch set

Re: [PATCH v5 09/24] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM

On Thu, Nov 14, 2019 at 09:53:25PM -0800, John Hubbard wrote: > As it says in the updated comment in gup.c: current FOLL_LONGTERM > behavior is incompatible with FAULT_FLAG_ALLOW_RETRY because of the > FS DAX check requirement on vmas. > > However, the corresponding restriction in get_user_pages_r

Re: [PATCH v5 12/24] IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP

On Thu, Nov 14, 2019 at 09:53:28PM -0800, John Hubbard wrote: > Convert infiniband to use the new pin_user_pages*() calls. > > Also, revert earlier changes to Infiniband ODP that had it using > put_user_page(). ODP is "Case 3" in > Documentation/core-api/pin_user_pages.rst, which is to say, normal

Re: [PATCH v10 1/8] mm: ksm: Export ksm_madvise()

On Thu, Nov 07, 2019 at 04:45:35PM +1100, Paul Mackerras wrote: > On Wed, Nov 06, 2019 at 12:15:42PM +0530, Bharata B Rao wrote: > > On Wed, Nov 06, 2019 at 03:33:29PM +1100, Paul Mackerras wrote: > > > On Mon, Nov 04, 2019 at 09:47:53AM +0530, Bharata B Rao wrote: > > > > KVM PPC module needs ksm_

Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32

On 11/14/19 11:44 PM, Li Yang wrote: Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? I think it is because the QE Ethernet was never integrated in any non-PowerPC SoC and most likely will not be in the future. We probably can make it compile for other architectur

Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32

On 11/15/19 1:54 AM, Rasmus Villemoes wrote: "Also, the QE Ethernet has never been integrated on any non-PowerPC SoC and most likely will not be in the future." That works for me, thanks.

Re: [PATCH v4 45/47] net/wan/fsl_ucc_hdlc: reject muram offsets above 64K

On 11/15/19 1:44 AM, Rasmus Villemoes wrote: I can change it, sure, but it's a matter of taste. To me the above asks "does the value change when it is truncated to a u16" which makes perfect sense when the value is next used with iowrite16be(). Using a comparison to U16_MAX takes more brain cycle

Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()

On 11/15/19 2:01 AM, Rasmus Villemoes wrote: That would be a separate patch, this patch is only concerned with eliminating the implicit assumption of the host being big-endian. And there's already been some pushback to adding arch-specific ifdefs (which I agree with, but as I responded there see

Re: [PATCH v11 1/4] kasan: support backing vmalloc space with real shadow memory

248896][T1] 2 locks held by swapper/0/1: [   32.253580][T1]  #0: 880d6160 (pcpu_alloc_mutex){+.+.}, at: pcpu_alloc+0x707/0xbe0 [   32.262305][T1]  #1: 88105558 (vmap_area_lock){+.+.}, at: pcpu_get_vm_areas+0xc4f/0x1e60 [   32.271919][T1] CPU: 4 PID: 1 Comm: swapper/0 Tainted:

Re: [PATCH v5 09/24] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM

On Thu, Nov 14, 2019 at 09:53:25PM -0800, John Hubbard wrote: > As it says in the updated comment in gup.c: current FOLL_LONGTERM > behavior is incompatible with FAULT_FLAG_ALLOW_RETRY because of the > FS DAX check requirement on vmas. > > However, the corresponding restriction in get_user_pages_r

[PATCH] powerpc/xive: Drop extern qualifiers from header function prototypes

As reported by ./scripts/checkpatch.pl --strict: CHECK: extern prototypes should be avoided in .h files Signed-off-by: Greg Kurz --- arch/powerpc/include/asm/xive.h | 92 --- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/arch/powerpc/inclu

Re: generic DMA bypass flag

On 14/11/2019 7:41 am, Christoph Hellwig wrote: On Wed, Nov 13, 2019 at 02:45:15PM +, Robin Murphy wrote: In all honesty, this seems silly. If we can set a per-device flag to say "oh, bypass these ops and use some other ops instead", then we can just as easily simply give the device the appr

Re: [-merge] BUG followed by oops running ndctl tests

On 11/15/19 11:36 AM, Sachin Sant wrote: Following Oops is seen on latest (commit 3b4852888d) powerpc merge branch code while running ndctl (test_namespace) tests 85c5b0984e was good. Are the namespace size created with size that is multiple of 16M size? Wondering whether this is related t

powerpc ftrace broken due to "manual merge of the ftrace tree with the arm64 tree"

# echo function >/sys/kernel/debug/tracing/current_tracer It hangs forever with today's linux-next on powerpc. Reverted the conflict fix [1] as below fixes the issue. [1] https://lore.kernel.org/linux-next/20191115135357.10386...@canb.auug.org.au/ diff --git a/include/asm-generic/vmlinux.lds.h b

[v3 0/2] Enable IOMMU support for pseries Secure VMs

This patch series enables IOMMU support for pseries Secure VMs. Tested using QEMU command line option: "-device virtio-scsi-pci,id=scsi0,bus=pci.0,addr=0x4, iommu_platform=on,disable-modern=off,disable-legacy=on" and "-device virtio-blk-pci,scsi=off,bus=pci.0, addr=0x5,drive=

[v3 1/2] powerpc/pseries/iommu: Share the per-cpu TCE page with the hypervisor.

H_PUT_TCE_INDIRECT hcall uses a page filled with TCE entries, as one of its parameters. One page is dedicated per cpu, for the lifetime of the kernel for this purpose. On secure VMs, contents of this page, when accessed by the hypervisor, retrieves encrypted TCE entries. Hypervisor needs to know t

[v3 2/2] powerpc/pseries/iommu: Use dma_iommu_ops for Secure VMs aswell.

Commit edea902c1c1e ("powerpc/pseries/iommu: Don't use dma_iommu_ops on secure guests") disabled dma_iommu_ops path, for secure VMs. The rationale for disabling the dma_iommu_ops path, was to use the dma_direct path, since it had inbuilt support for bounce-buffering through SWIOTLB.

Re: powerpc ftrace broken due to "manual merge of the ftrace tree with the arm64 tree"

On Fri, 15 Nov 2019 15:28:52 -0500 Qian Cai wrote: > # echo function >/sys/kernel/debug/tracing/current_tracer > > It hangs forever with today's linux-next on powerpc. Reverted the conflict fix > [1] as below fixes the issue. > > [1] > https://lore.kernel.org/linux-next/20191115135357.10386...

Re: powerpc ftrace broken due to "manual merge of the ftrace tree with the arm64 tree"

On Fri, 2019-11-15 at 16:02 -0500, Steven Rostedt wrote: > On Fri, 15 Nov 2019 15:28:52 -0500 > Qian Cai wrote: > > > # echo function >/sys/kernel/debug/tracing/current_tracer > > > > It hangs forever with today's linux-next on powerpc. Reverted the conflict > > fix > > [1] as below fixes the i

HPT allocation failures on POWER8 KVM hosts

Hi Aneesh, We're running a lot of KVM virtual machines on POWER8 hosts and sometimes new VMs can't be started because there are no contiguous regions for HPT because of CMA region fragmentation. The issue is covered in the LWN article: https://lwn.net/Articles/684611/ The article points that you

Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()

On Fri, 2019-11-15 at 08:35 -0600, Timur Tabi wrote: > On 11/15/19 2:01 AM, Rasmus Villemoes wrote: > > That would be a separate patch, this patch is only concerned with > > eliminating the implicit assumption of the host being big-endian. And > > there's already been some pushback to adding arch-s

[PATCH v16 00/12] open: introduce openat2(2) syscall

This patchset is being developed here: Patch changelog: v16: * Update based on review by Al Viro: * Handle magic-link related errors from with nd_jump_link() and drop LOOKUP_MAGICLINK_JUMPED. * Drop the slash-skipping logic f

[PATCH v16 01/12] nsfs: clean-up ns_get_path() signature to return int

ns_get_path() and ns_get_path_cb() only ever return either NULL or an ERR_PTR. It is far more idiomatic to simply return an integer, and it makes all of the callers of ns_get_path() more straightforward to read. Fixes: e149ed2b805f ("take the targets of /proc/*/ns/* symlinks to separate fs") Signe

[PATCH v16 02/12] namei: allow nd_jump_link() to produce errors

In preparation for LOOKUP_NO_MAGICLINKS, it's necessary to add the ability for nd_jump_link() to return an error which the corresponding get_link() caller must propogate back up to the VFS. Suggested-by: Al Viro Signed-off-by: Aleksa Sarai --- fs/namei.c | 3 ++- fs/proc/ba

[PATCH v16 03/12] namei: allow set_root() to produce errors

For LOOKUP_BENEATH and LOOKUP_IN_ROOT it is necessary to ensure that set_root() is never called, and thus (for hardening purposes) it should return an error rather than permit a breakout from the root. In addition, move all of the repetitive set_root() calls to nd_jump_root(). Signed-off-by: Aleks

[PATCH v16 04/12] namei: LOOKUP_NO_SYMLINKS: block symlink resolution

/* Background. */ Userspace cannot easily resolve a path without resolving symlinks, and would have to manually resolve each path component with O_PATH and O_NOFOLLOW. This is clearly inefficient, and can be fairly easy to screw up (resulting in possible security bugs). Linus has mentioned that Git

[PATCH v16 05/12] namei: LOOKUP_NO_MAGICLINKS: block magic-link resolution

/* Background. */ There has always been a special class of symlink-like objects in procfs (and a few other pseudo-filesystems) which allow for non-lexical resolution of paths using nd_jump_link(). These "magic-links" do not follow traditional mount namespace boundaries, and have been used consisten

[PATCH v16 06/12] namei: LOOKUP_NO_XDEV: block mountpoint crossing

/* Background. */ The need to contain path operations within a mountpoint has been a long-standing usecase that userspace has historically implemented manually with liberal usage of stat(). find, rsync, tar and many other programs implement these semantics -- but it'd be much simpler to have a fool

[PATCH v16 07/12] namei: LOOKUP_BENEATH: O_BENEATH-like scoped resolution

/* Background. */ There are many circumstances when userspace wants to resolve a path and ensure that it doesn't go outside of a particular root directory during resolution. Obvious examples include archive extraction tools, as well as other security-conscious userspace programs. FreeBSD spun out O

[PATCH v16 08/12] namei: LOOKUP_IN_ROOT: chroot-like scoped resolution

/* Background. */ Container runtimes or other administrative management processes will often interact with root filesystems while in the host mount namespace, because the cost of doing a chroot(2) on every operation is too prohibitive (especially in Go, which cannot safely use vfork). However, a ma

[PATCH v16 09/12] namei: LOOKUP_{IN_ROOT, BENEATH}: permit limited ".." resolution

Allow LOOKUP_BENEATH and LOOKUP_IN_ROOT to safely permit ".." resolution (in the case of LOOKUP_BENEATH the resolution will still fail if ".." resolution would resolve a path outside of the root -- while LOOKUP_IN_ROOT will chroot(2)-style scope it). Magic-link jumps are still disallowed entirely[*

[PATCH v16 10/12] open: introduce openat2(2) syscall

/* Background. */ For a very long time, extending openat(2) with new features has been incredibly frustrating. This stems from the fact that openat(2) is possibly the most famous counter-example to the mantra "don't silently accept garbage from userspace" -- it doesn't check whether unknown flags a

[PATCH v16 11/12] selftests: add openat2(2) selftests

Test all of the various openat2(2) flags. A small stress-test of a symlink-rename attack is included to show that the protections against ".."-based attacks are sufficient. The main things these self-tests are enforcing are: * The struct+usize ABI for openat2(2) and copy_struct_from_user() to

[PATCH v16 12/12] Documentation: path-lookup: include new LOOKUP flags

Now that we have new LOOKUP flags, we should document them in the relevant path-walking documentation. And now that we've settled on a common name for nd_jump_link() style symlinks ("magic links"), use that term where magic-link semantics are described. Signed-off-by: Aleksa Sarai --- Documentat

Re: [PATCH v16 02/12] namei: allow nd_jump_link() to produce errors

On Sat, Nov 16, 2019 at 11:27:52AM +1100, Aleksa Sarai wrote: > + error = nd_jump_link(&path); > + if (error) > + path_put(&path); > + error = nd_jump_link(&ns_path); > + if (error) > + path_put(&ns_path); > + error = nd_jump_link(&path); > + if (er

Re: [PATCH v16 06/12] namei: LOOKUP_NO_XDEV: block mountpoint crossing

On Sat, Nov 16, 2019 at 11:27:56AM +1100, Aleksa Sarai wrote: > @@ -1383,6 +1398,8 @@ static int follow_dotdot_rcu(struct nameidata *nd) > return -ECHILD; > if (&mparent->mnt == nd->path.mnt) > break; > +

Re: [PATCH v16 09/12] namei: LOOKUP_{IN_ROOT,BENEATH}: permit limited ".." resolution

On Sat, Nov 16, 2019 at 11:27:59AM +1100, Aleksa Sarai wrote: > + if (unlikely(nd->flags & LOOKUP_IS_SCOPED)) { > + bool m_retry = read_seqretry(&mount_lock, nd->m_seq); > + bool r_retry = read_seqretry(&rename_lock, nd->r_seq); > + > +

Re: generic DMA bypass flag

On Fri, Nov 15, 2019 at 06:12:48PM +, Robin Murphy wrote: > And is that any different from where you would choose to "just" set a > generic bypass flag? Same spots, as intel-iommu moves from the identify to a dma domain when setting a 32-bit mask. But that means once a 32-bit mask is set we

[Bug 205201] Booting halts if Dawicontrol DC-2976 UW SCSI board installed, unless RAM size limited to 3500M

https://bugzilla.kernel.org/show_bug.cgi?id=205201 --- Comment #15 from Christian Zigotzky (chzigot...@xenosoft.de) --- FYI: Souce files of the Dawicontrol DC 2976 UW SCSI board (PCI): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/scsi/sym53c8xx_2?h=v5.4-rc7 /*

[PATCH] powerpc/pseries: remove variable 'status' set but not used

Fixes gcc '-Wunused-but-set-variable' warning: arch/powerpc/platforms/pseries/ras.c: In function ras_epow_interrupt: arch/powerpc/platforms/pseries/ras.c:319:6: warning: variable status set but not used [-Wunused-but-set-variable] Signed-off-by: Chen Wandun --- arch/powerpc/platforms/pseries/r

Bug 205201 - Booting halts if Dawicontrol DC-2976 UW SCSI board installed, unless RAM size limited to 3500M

FYI: Source files of the Dawicontrol DC 2976 UW SCSI board (PCI): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/scsi/sym53c8xx_2?h=v5.4-rc7 /* * DMA addressing mode. * * 0 : 32 bit addressing for all chips. * 1 : 40 bit addressing when supported by chip.