Re: [RFC PATCH 00/10] implement KASLR for powerpc/fsl_booke/32

2019-07-25 Thread Jason Yan
Hi all, any comments? On 2019/7/17 16:06, Jason Yan wrote: This series implements KASLR for powerpc/fsl_booke/32, as a security feature that deters exploit attempts relying on knowledge of the location of kernel internals. Since CONFIG_RELOCATABLE has already supported, what we need to do is m

[PATCH] hwrng: Use device-managed registration API

2019-07-25 Thread Chuhong Yuan
Use devm_hwrng_register to simplify the implementation. Manual unregistration and some remove functions can be removed now. Signed-off-by: Chuhong Yuan --- drivers/char/hw_random/atmel-rng.c | 3 +-- drivers/char/hw_random/cavium-rng-vf.c | 11 +-- drivers/char/hw_random/exynos-trng

Re: [PATCH] hwrng: Use device-managed registration API

2019-07-25 Thread Łukasz Stelmach
It was <2019-07-25 czw 10:01>, when Chuhong Yuan wrote: > Use devm_hwrng_register to simplify the implementation. > Manual unregistration and some remove functions can be > removed now. > > Signed-off-by: Chuhong Yuan > --- > drivers/char/hw_random/atmel-rng.c | 3 +-- > drivers/char/hw_rand

Re: [PATCH v2] powerpc: slightly improve cache helpers

2019-07-25 Thread Segher Boessenkool
On Tue, Jul 23, 2019 at 09:21:53AM +1000, Michael Ellerman wrote: > Segher Boessenkool writes: > >> can use both RA and RB to compute the address, rather than us forcing RA > >> to 0. > >> > >> But at least with my compiler here (GCC 8 vintage) I don't actually see > >> GCC ever using both GPRs e

Re: [alsa-devel] [PATCH 08/10] ASoC: dt-bindings: Document fcomb_mode property

2019-07-25 Thread Nicolin Chen
On Thu, Jul 25, 2019 at 09:02:22AM +0300, Daniel Baluta wrote: > On Thu, Jul 25, 2019 at 2:22 AM Nicolin Chen wrote: > > > > On Mon, Jul 22, 2019 at 03:48:31PM +0300, Daniel Baluta wrote: > > > This allows combining multiple-data-line FIFOs into a > > > single-data-line FIFO. > > > > > > Signed-of

Re: [RFC PATCH 00/10] implement KASLR for powerpc/fsl_booke/32

2019-07-25 Thread Kees Cook
On Thu, Jul 25, 2019 at 03:16:28PM +0800, Jason Yan wrote: > Hi all, any comments? I'm a fan of it, but I don't know ppc internals well enough to sanely review the code. :) Some comments below on design... > > > On 2019/7/17 16:06, Jason Yan wrote: > > This series implements KASLR for powerpc/f

Freeze on ppc32 MPC8248 board with 5.2 kernel

2019-07-25 Thread Doug Crawford
We have a ppc32 MPC8248 board that is working perfectly with the 4.19 kernel. We have noticed two issues with the 5.2 kernel: 1) If the new CONFIG_PPC_KUAP (kernel userspace access protection) is enabled the kernel freezes right after initializing all the drivers and just before starting /sbin/ini

[PATCH v3 0/2] Memory unplug fixes for radix guests

2019-07-25 Thread Bharata B Rao
A couple of fixes to memory unplug on radix guests. 1/2 was being posted individually earlier and 2/2 is included with it in this series. 1/2 v2 was last posted at https://lists.ozlabs.org/pipermail/linuxppc-dev/2019-July/193668.html Bharata B Rao (2): powerpc/mm/radix: Fix PTE/PMD fragment co

[PATCH v3 2/2] powerpc/mm/radix: Free PUD table when freeing pagetable

2019-07-25 Thread Bharata B Rao
remove_pagetable() isn't freeing PUD table. This causes memory leak during memory unplug. Fix this. Signed-off-by: Bharata B Rao --- arch/powerpc/mm/book3s64/radix_pgtable.c | 16 1 file changed, 16 insertions(+) diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/pow

[PATCH v3 1/2] powerpc/mm/radix: Fix PTE/PMD fragment count for early page table mappings

2019-07-25 Thread Bharata B Rao
We can hit the following BUG_ONs during memory unplug kernel BUG at arch/powerpc/mm/pgtable-frag.c:113! remove_pagetable+0x594/0x6a0 (unreliable) remove_pagetable+0x94/0x6a0 vmemmap_free+0x394/0x410 sparse_remove_one_section+0x26c/0x2e8 __remove_pages+0x428/0x540 arch_remove_memory+0xd0/0x1