Re: [PATCH v2] powerpc: slightly improve cache helpers

2019-07-21 Thread Nathan Chancellor
On Fri, Jul 19, 2019 at 09:04:55AM -0700, Nathan Chancellor wrote: > On Fri, Jul 19, 2019 at 10:23:03AM -0500, Segher Boessenkool wrote: > > On Thu, Jul 18, 2019 at 08:24:56PM -0700, Nathan Chancellor wrote: > > > On Mon, Jul 08, 2019 at 11:49:52PM -0700, Nathan Chancellor wrote: > > > > On Tue, Ju

Re: [PATCH v2] powerpc: slightly improve cache helpers

2019-07-21 Thread Segher Boessenkool
On Sun, Jul 21, 2019 at 12:58:46AM -0700, Nathan Chancellor wrote: > I have attached the disassembly of arch/powerpc/kernel/mem.o with > clear_page (working) and broken_clear_page (broken), along with the side > by side diff. My assembly knowledge is fairly limited as it stands and > it is certainl

Re: [PATCH] powerpc: Test broken dcbz

2019-07-21 Thread kbuild test robot
Hi Nathan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc1 next-20190719] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nat

Re: [PATCH v2] powerpc: slightly improve cache helpers

2019-07-21 Thread Nathan Chancellor
Hi Segher, On Sun, Jul 21, 2019 at 01:01:50PM -0500, Segher Boessenkool wrote: > On Sun, Jul 21, 2019 at 12:58:46AM -0700, Nathan Chancellor wrote: > > I have attached the disassembly of arch/powerpc/kernel/mem.o with > > clear_page (working) and broken_clear_page (broken), along with the side > >

Re: [PATCH v2] PCI: rpaphp: Avoid a sometimes-uninitialized warning

2019-07-21 Thread Nathan Chancellor
On Mon, Jun 03, 2019 at 03:11:58PM -0700, Nathan Chancellor wrote: > When building with -Wsometimes-uninitialized, clang warns: > > drivers/pci/hotplug/rpaphp_core.c:243:14: warning: variable 'fndit' is > used uninitialized whenever 'for' loop exits because its condition is > false [-Wsometimes-un

Re: [PATCH] powerpc/xive: Fix loop exit-condition in xive_find_target_in_mask()

2019-07-21 Thread Michael Ellerman
On Wed, 2019-07-17 at 10:35:24 UTC, "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > xive_find_target_in_mask() has the following for(;;) loop which has a > bug when @first == cpumask_first(@mask) and condition 1 fails to hold > for every CPU in @mask. In this case we loop forever in th

Re: [PATCH] powerpc/dma: Fix invalid DMA mmap behavior

2019-07-21 Thread Michael Ellerman
On Wed, 2019-07-17 at 23:54:37 UTC, Shawn Anastasio wrote: > The refactor of powerpc DMA functions in commit cc17d780 > ("powerpc/dma: remove dma_nommu_mmap_coherent") incorrectly > changes the way DMA mappings are handled on powerpc. > Since this change, all mapped pages are marked as cache-in

Re: [PATCH] powerpc/tm: Fix oops on sigreturn on systems without TM

2019-07-21 Thread Michael Ellerman
On Fri, 2019-07-19 at 05:05:02 UTC, Michael Neuling wrote: > On systems like P9 powernv where we have no TM (or P8 booted with > ppc_tm=off), userspace can construct a signal context which still has > the MSR TS bits set. The kernel tries to restore this context which > results in the following cra

Re: Re: Crash in kvmppc_xive_release()

2019-07-21 Thread Michael Ellerman
On Thu, 2019-07-18 at 21:51:54 UTC, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= wrote: > On 18/07/2019 15:14, Cédric Le Goater wrote: ... > > Here is a fix. Could you give it a try on your system ? > > Thanks, > > C. > > >From b6f728ca19a9540c8bf4f5a56991c4e3dab4cf56 Mon Sep 17 00:00:00 2001 > From: =?

Re: [PATCH] powerpc/tm: Fix oops on sigreturn on systems without TM

2019-07-21 Thread Michael Ellerman
On Fri, 2019-07-19 at 05:05:02 UTC, Michael Neuling wrote: > On systems like P9 powernv where we have no TM (or P8 booted with > ppc_tm=off), userspace can construct a signal context which still has > the MSR TS bits set. The kernel tries to restore this context which > results in the following cra

Re: [PATCH] powerpc/tm: Fix oops on sigreturn on systems without TM

2019-07-21 Thread Michael Ellerman
Michael Ellerman writes: > On Fri, 2019-07-19 at 05:05:02 UTC, Michael Neuling wrote: >> On systems like P9 powernv where we have no TM (or P8 booted with >> ppc_tm=off), userspace can construct a signal context which still has >> the MSR TS bits set. The kernel tries to restore this context which

Re: [PATCH v2] PCI: rpaphp: Avoid a sometimes-uninitialized warning

2019-07-21 Thread Michael Ellerman
Nathan Chancellor writes: > On Mon, Jun 03, 2019 at 03:11:58PM -0700, Nathan Chancellor wrote: >> When building with -Wsometimes-uninitialized, clang warns: >> >> drivers/pci/hotplug/rpaphp_core.c:243:14: warning: variable 'fndit' is >> used uninitialized whenever 'for' loop exits because its con

Re: [PATCH v2] powerpc: slightly improve cache helpers

2019-07-21 Thread Segher Boessenkool
On Sun, Jul 21, 2019 at 07:41:40PM -0700, Nathan Chancellor wrote: > Hi Segher, > > On Sun, Jul 21, 2019 at 01:01:50PM -0500, Segher Boessenkool wrote: > > On Sun, Jul 21, 2019 at 12:58:46AM -0700, Nathan Chancellor wrote: > > > 017c clear_user_page: > > > 17c: 94 21 ff f0