Re: [PATCH] powerpc/mm/32s: only use MMU to mark initmem NX if STRICT_KERNEL_RWX

2019-06-16 Thread christophe leroy
Le 15/06/2019 à 16:36, Andreas Schwab a écrit : On Jun 15 2019, Christophe Leroy wrote: Andreas Schwab a écrit : If STRICT_KERNEL_RWX is disabled, never use the MMU to mark initmen nonexecutable. I dont understand, can you elaborate ? It breaks suspend. Ok, but we need to explain w

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

2019-06-16 Thread christophe leroy
Le 15/06/2019 à 13:23, Andreas Schwab a écrit : This breaks suspend (or resume) on the iBook G4. no_console_suspend doesn't give any clues, the display just stays dark. After a quick look at the suspend functions, I have the feeling that those functions only store and restore BATs 0 to 3.

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

2019-06-16 Thread christophe leroy
Le 15/06/2019 à 14:28, Andreas Schwab a écrit : On Feb 21 2019, Christophe Leroy wrote: diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c index a000768a5cc9..6e56a6240bfa 100644 --- a/arch/powerpc/mm/pgtable_32.c +++ b/arch/powerpc/mm/pgtable_32.c @@ -353,7 +353,10 @@

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

2019-06-16 Thread Andreas Schwab
On Jun 16 2019, christophe leroy wrote: > Le 15/06/2019 à 14:28, Andreas Schwab a écrit : >> On Feb 21 2019, Christophe Leroy wrote: >> >>> diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c >>> index a000768a5cc9..6e56a6240bfa 100644 >>> --- a/arch/powerpc/mm/pgtable_32.c

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

2019-06-16 Thread Andreas Schwab
On Jun 16 2019, christophe leroy wrote: > If any of registers IBATs 4 to 7 are used Nope. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

2019-06-16 Thread Andreas Schwab
On Jun 16 2019, christophe leroy wrote: > If any of registers IBATs 4 to 7 are used, could you adjust > CONFIG_ETEXT_SHIFT so that only IBATs 0 to 3 be used, and check if > suspend/resume works when IBATs 4 to 7 are not used ? I forgot to remove my patch. With only 0-3 used, suspend/resume work

Re: [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU

2019-06-16 Thread Michael Ellerman
On Tue, 2019-06-11 at 15:47:20 UTC, Christophe Leroy wrote: > The patch referenced below moved the loading of segment registers > out of load_up_mmu() in order to do it earlier in the boot sequence. > However, the secondary CPU still needs it to be done when loading up > the MMU. > > Reported-by:

Re: [PATCH] powerpc/32: fix build failure on book3e with KVM

2019-06-16 Thread Michael Ellerman
On Thu, 2019-05-23 at 08:39:27 UTC, Christophe Leroy wrote: > Build failure was introduced by the commit identified below, > due to missed macro expension leading to wrong called function's name. > > arch/powerpc/kernel/head_fsl_booke.o: In function `SystemCall': > arch/powerpc/kernel/head_fsl_boo

Re: [PATCH] powerpc/booke: fix fast syscall entry on SMP

2019-06-16 Thread Michael Ellerman
On Thu, 2019-06-13 at 13:52:30 UTC, Christophe Leroy wrote: > Use r10 instead of r9 to calculate CPU offset as r9 contains > the value from SRR1 which is used later. > > Fixes: 1a4b739bbb4f ("powerpc/32: implement fast entry for syscalls on BOOKE") > Signed-off-by: Christophe Leroy Applied to po

Re: [PATCH v3 1/3] powerpc/powernv: Add OPAL API interface to get secureboot state

2019-06-16 Thread Daniel Axtens
Hi Nayna, >> I guess I also somewhat object to calling it a 'backend' if we're using >> it as a version scheme. I think the skiboot storage backends are true >> backends - they provide different implementations of the same >> functionality with the same API, but this seems like you're using it to

Re: [PATCH 0/1] PPC32: fix ptrace() access to FPU registers

2019-06-16 Thread Daniel Axtens
Radu Rendec writes: > Hi Everyone, > > I'm following up on the ptrace() problem that I reported a few days ago. > I believe my version of the code handles all cases correctly. While the > problem essentially boils down to dividing the fpidx by 2 on PPC32, it > becomes tricky when the same code mu

Re: [PATCH v3 4/9] KVM: PPC: Ultravisor: Add generic ultravisor call handler

2019-06-16 Thread Paul Mackerras
On Thu, Jun 06, 2019 at 02:36:09PM -0300, Claudio Carvalho wrote: > From: Ram Pai > > Add the ucall() function, which can be used to make ultravisor calls > with varied number of in and out arguments. Ultravisor calls can be made > from the host or guests. > > This copies the implementation of p

Re: [PATCH 0/1] PPC32: fix ptrace() access to FPU registers

2019-06-16 Thread Radu Rendec
On Mon, 2019-06-17 at 11:19 +1000, Daniel Axtens wrote: > Radu Rendec < > radu.ren...@gmail.com > > writes: > > > Hi Everyone, > > > > I'm following up on the ptrace() problem that I reported a few days ago. > > I believe my version of the code handles all cases correctly. While the > > problem e

Re: [RFC PATCH v4 6/6] kvmppc: Support reset of secure guest

2019-06-16 Thread Paul Mackerras
On Tue, May 28, 2019 at 12:19:33PM +0530, Bharata B Rao wrote: > Add support for reset of secure guest via a new ioctl KVM_PPC_SVM_OFF. > This ioctl will be issued by QEMU during reset and in this ioctl, > we ask UV to terminate the guest via UV_SVM_TERMINATE ucall, > reinitialize guest's partition

[PATCH] ocxl: Allow contexts to be attached with a NULL mm

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva If an OpenCAPI context is to be used directly by a kernel driver, there may not be a suitable mm to use. The patch makes the mm parameter to ocxl_context_attach optional. Signed-off-by: Alastair D'Silva --- drivers/misc/ocxl/context.c | 9 ++--- drivers/misc/ocxl/l

Re: [PATCH v4 1/6] kvmppc: HMM backend driver to manage pages of secure guest

2019-06-16 Thread Paul Mackerras
On Tue, May 28, 2019 at 12:19:28PM +0530, Bharata B Rao wrote: > HMM driver for KVM PPC to manage page transitions of > secure guest via H_SVM_PAGE_IN and H_SVM_PAGE_OUT hcalls. > > H_SVM_PAGE_IN: Move the content of a normal page to secure page > H_SVM_PAGE_OUT: Move the content of a secure page

Re: [PATCH v4 3/6] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls

2019-06-16 Thread Paul Mackerras
On Tue, May 28, 2019 at 12:19:30PM +0530, Bharata B Rao wrote: > H_SVM_INIT_START: Initiate securing a VM > H_SVM_INIT_DONE: Conclude securing a VM > > As part of H_SVM_INIT_START register all existing memslots with the UV. > H_SVM_INIT_DONE call by UV informs HV that transition of the guest > to

Re: [PATCH v4 4/6] kvmppc: Handle memory plug/unplug to secure VM

2019-06-16 Thread Paul Mackerras
On Tue, May 28, 2019 at 12:19:31PM +0530, Bharata B Rao wrote: > Register the new memslot with UV during plug and unregister > the memslot during unplug. > > Signed-off-by: Bharata B Rao Acked-by: Paul Mackerras

[PATCH] powerpc/32s: fix suspend/resume when IBATs 4-7 are used

2019-06-16 Thread Christophe Leroy
Previously, only IBAT1 and IBAT2 were used to map kernel linear mem. Since commit 63b2bc619565 ("powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX"), we may have all 8 BATs used for mapping kernel text. But the suspend/restore functions only save/restore BATs 0 to 3, and clears BATs 4 to 7. Make susp

Re: [PATCH v2] KVM: PPC: Report single stepping capability

2019-06-16 Thread Paul Mackerras
On Wed, May 29, 2019 at 07:22:19PM -0300, Fabiano Rosas wrote: > When calling the KVM_SET_GUEST_DEBUG ioctl, userspace might request > the next instruction to be single stepped via the > KVM_GUESTDBG_SINGLESTEP control bit of the kvm_guest_debug structure. > > We currently don't have support for g

Re: remove dead powernv code v2

2019-06-16 Thread Christoph Hellwig
ping? On Thu, May 23, 2019 at 09:49:20AM +0200, Christoph Hellwig wrote: > Hi all, > > the powerpc powernv port has a fairly large chunk of code that never > had any upstream user. We generally strive to not keep dead code > around, and this was affirmed at least years Maintainer summit. > > Ch