Re: [PATCH RFC v3 18/18] powerpc: KASAN for 64bit Book3E

2019-03-13 Thread Christophe Leroy
Why does snowpatch reports not being able to apply it to any branch ? I built the serie on top of merge branch, but it also cleanly applies on next branch. Could it be because the begining of the series is names 'v10' while the end of it is 'RFC v3' as it comes from Daniel's RFC v2 ? Christ

Re: [PATCH v2] powerpc/mm: move warning from resize_hpt_for_hotplug()

2019-03-13 Thread Laurent Vivier
On 13/03/2019 07:03, Christophe Leroy wrote: > > > Le 08/03/2019 à 11:54, Laurent Vivier a écrit : >> resize_hpt_for_hotplug() reports a warning when it cannot >> resize the hash page table ("Unable to resize hash page >> table to target order") but in some cases it's not a problem >> and can mak

Re: [PATCH v2 15/16] KVM: introduce a KVM_DESTROY_DEVICE ioctl

2019-03-13 Thread Cédric Le Goater
On 2/25/19 5:15 AM, David Gibson wrote: > On Fri, Feb 22, 2019 at 12:28:39PM +0100, Cédric Le Goater wrote: >> The 'destroy' method is currently used to destroy all devices when the >> VM is destroyed after the vCPUs have been freed. >> >> This new KVM ioctl exposes the same KVM device method. It a

Re: [PATCH v5 02/10] powerpc/powernv/idle: Restore AMR/UAMOR/AMOR after idle

2019-03-13 Thread Akshay Adiga
On Fri, Mar 08, 2019 at 12:16:11PM +1100, Michael Ellerman wrote: > In order to implement KUAP (Kernel Userspace Access Protection) on > Power9 we will be using the AMR, and therefore indirectly the > UAMOR/AMOR. > > So save/restore these regs in the idle code. > > Signed-off-by: Michael Ellerman

Re: [PATCH v2 16/16] KVM: PPC: Book3S HV: XIVE: clear the vCPU interrupt presenters

2019-03-13 Thread Cédric Le Goater
On 2/25/19 5:18 AM, David Gibson wrote: > On Fri, Feb 22, 2019 at 12:28:40PM +0100, Cédric Le Goater wrote: >> When the VM boots, the CAS negotiation process determines which >> interrupt mode to use and invokes a machine reset. At that time, the >> previous KVM interrupt device is 'destroyed' befo

Re: [PATCH v2] powerpc/mm: move warning from resize_hpt_for_hotplug()

2019-03-13 Thread Christophe Leroy
Le 13/03/2019 à 09:01, Laurent Vivier a écrit : On 13/03/2019 07:03, Christophe Leroy wrote: Le 08/03/2019 à 11:54, Laurent Vivier a écrit : resize_hpt_for_hotplug() reports a warning when it cannot resize the hash page table ("Unable to resize hash page table to target order") but in some

Re: [PATCH RFC v3 18/18] powerpc: KASAN for 64bit Book3E

2019-03-13 Thread Christophe Leroy
Any, the build is clean, see http://kisskb.ellerman.id.au/kisskb/head/3e97aba429c769bd99ccd8d6f16eda98f7d378a7/ Only s390 defconfig and powerpc randconfig failed for unrelated reasons. Christophe Le 13/03/2019 à 08:02, Christophe Leroy a écrit : Why does snowpatch reports not being able to ap

Re: [PATCH 4/5] ocxl: Remove superfluous 'extern' from headers

2019-03-13 Thread Greg Kurz
On Wed, 13 Mar 2019 15:07:00 +1100 "Alastair D'Silva" wrote: > From: Alastair D'Silva > > The 'extern' keyword adds no value here. > > Signed-off-by: Alastair D'Silva > --- Reviewed-by: Greg Kurz > drivers/misc/ocxl/ocxl_internal.h | 54 +++ > include/misc/ocxl

Re: [PATCH v2 06/16] KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration

2019-03-13 Thread Cédric Le Goater
On 3/13/19 5:03 AM, David Gibson wrote: > On Tue, Mar 12, 2019 at 06:00:38PM +0100, Cédric Le Goater wrote: >> On 2/25/19 3:39 AM, David Gibson wrote: >>> On Fri, Feb 22, 2019 at 12:28:30PM +0100, Cédric Le Goater wrote: These controls will be used by the H_INT_SET_QUEUE_CONFIG and H_INT_

Re: [PATCH v2] powerpc/mm: move warning from resize_hpt_for_hotplug()

2019-03-13 Thread Laurent Vivier
On 13/03/2019 09:28, Christophe Leroy wrote: > > > Le 13/03/2019 à 09:01, Laurent Vivier a écrit : >> On 13/03/2019 07:03, Christophe Leroy wrote: >>> >>> >>> Le 08/03/2019 à 11:54, Laurent Vivier a écrit : resize_hpt_for_hotplug() reports a warning when it cannot resize the hash page t

Re: [PATCH 1/1] arch/powerpc: Rework local_paca to avoid LTO warnings

2019-03-13 Thread Christophe Leroy
Hello, Le 13/03/2019 à 04:42, Alastair D'Silva a écrit : From: Alastair D'Silva When building an LTO kernel, the existing code generates warnings: ./arch/powerpc/include/asm/paca.h:37:30: warning: register of ‘local_paca’ used for multiple global register variables register

Re: [PATCH v2] powerpc/mm: move warning from resize_hpt_for_hotplug()

2019-03-13 Thread Christophe Leroy
Le 13/03/2019 à 09:50, Laurent Vivier a écrit : On 13/03/2019 09:28, Christophe Leroy wrote: Le 13/03/2019 à 09:01, Laurent Vivier a écrit : On 13/03/2019 07:03, Christophe Leroy wrote: Le 08/03/2019 à 11:54, Laurent Vivier a écrit : resize_hpt_for_hotplug() reports a warning when it c

Re: [PATCH 5/5] ocxl: Remove some unused exported symbols

2019-03-13 Thread Greg Kurz
On Wed, 13 Mar 2019 15:07:01 +1100 "Alastair D'Silva" wrote: > From: Alastair D'Silva > > Remove some unused exported symbols. > > Signed-off-by: Alastair D'Silva > --- > drivers/misc/ocxl/config.c| 2 -- > drivers/misc/ocxl/ocxl_internal.h | 23 +++ > include/mi

Re: [PATCH v2 06/16] KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration

2019-03-13 Thread Cédric Le Goater
On 2/26/19 6:24 AM, Paul Mackerras wrote: > On Fri, Feb 22, 2019 at 12:28:30PM +0100, Cédric Le Goater wrote: >> These controls will be used by the H_INT_SET_QUEUE_CONFIG and >> H_INT_GET_QUEUE_CONFIG hcalls from QEMU. They will also be used to >> restore the configuration of the XIVE EQs in the KV

Re: [PATCH v2] fs/dax: deposit pagetable even when installing zero page

2019-03-13 Thread Jan Kara
On Wed 13-03-19 10:17:17, Aneesh Kumar K.V wrote: > > Hi Dan/Andrew/Jan, > > "Aneesh Kumar K.V" writes: > > > Architectures like ppc64 use the deposited page table to store hardware > > page table slot information. Make sure we deposit a page table when > > using zero page at the pmd level for

[PATCH v3] powerpc/mm: move warning from resize_hpt_for_hotplug()

2019-03-13 Thread Laurent Vivier
resize_hpt_for_hotplug() reports a warning when it cannot resize the hash page table ("Unable to resize hash page table to target order") but in some cases it's not a problem and can make user thinks something has not worked properly. This patch moves the warning to arch_remove_memory() to only re

Re: [PATCH v2 03/16] KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE

2019-03-13 Thread Cédric Le Goater
On 2/25/19 5:35 AM, Paul Mackerras wrote: > On Fri, Feb 22, 2019 at 12:28:27PM +0100, Cédric Le Goater wrote: >> The user interface exposes a new capability to let QEMU connect the >> vCPU to the XIVE KVM device if required. The capability is only >> advertised on a PowerNV Hypervisor as support fo

Re: [PATCH 2/5] ocxl: Clean up printf formats

2019-03-13 Thread Greg Kurz
On Wed, 13 Mar 2019 15:06:58 +1100 "Alastair D'Silva" wrote: > From: Alastair D'Silva > > Use %# instead of using a literal '0x' > > Signed-off-by: Alastair D'Silva > --- Reviewed-by: Greg Kurz > drivers/misc/ocxl/config.c | 6 +++--- > drivers/misc/ocxl/context.c | 2 +- > drivers/mis

Re: [PATCH v2 09/16] KVM: PPC: Book3S HV: XIVE: add a control to dirty the XIVE EQ pages

2019-03-13 Thread Cédric Le Goater
On 2/25/19 3:53 AM, David Gibson wrote: > On Fri, Feb 22, 2019 at 12:28:33PM +0100, Cédric Le Goater wrote: >> When migration of a VM is initiated, a first copy of the RAM is >> transferred to the destination before the VM is stopped, but there is >> no guarantee that the EQ pages in which the even

BUG: p8_aes_ctr randomly returns wrong results

2019-03-13 Thread Ondrej Mosnáček
Hi, FYI, the p8_aes_ctr crypto driver (drivers/crypto/vmx/aes_ctr.c) seems to be seriously broken. When I do repeated encryption using libkcapi multiple times in a row, I sometimes get a wrong result. This happens more often with long messages (e.g. at 16 KiB it already happens very frequently).

Re: BUG: p8_aes_ctr randomly returns wrong results

2019-03-13 Thread Ondrej Mosnáček
st 13. 3. 2019 o 13:37 Ondrej Mosnáček napísal(a): > Hi, > > FYI, the p8_aes_ctr crypto driver (drivers/crypto/vmx/aes_ctr.c) seems > to be seriously broken. When I do repeated encryption using libkcapi > multiple times in a row, I sometimes get a wrong result. This happens > more often with long

[PATCH] powerpc/vdso64: Fix CLOCK_MONOTONIC inconsistencies across Y2038

2019-03-13 Thread Michael Ellerman
Jakub Drnec reported: Setting the realtime clock can sometimes make the monotonic clock go back by over a hundred years. Decreasing the realtime clock across the y2k38 threshold is one reliable way to reproduce. Allegedly this can also happen just by running ntpd, I have not managed to re

Re: [PATCH v2 10/16] KVM: PPC: Book3S HV: XIVE: add get/set accessors for the VP XIVE state

2019-03-13 Thread Cédric Le Goater
On 2/25/19 4:31 AM, David Gibson wrote: > On Fri, Feb 22, 2019 at 12:28:34PM +0100, Cédric Le Goater wrote: >> At a VCPU level, the state of the thread interrupt management >> registers needs to be collected. These registers are cached under the >> 'xive_saved_state.w01' field of the VCPU when the

Re: [PATCH] powerpc/vdso64: Fix CLOCK_MONOTONIC inconsistencies across Y2038

2019-03-13 Thread Arnd Bergmann
On Wed, Mar 13, 2019 at 2:14 PM Michael Ellerman wrote: > That causes CLOCK_MONOTONIC to jump ahead by ~4 billion seconds which > it is not meant to do. Worse, if the time is then set back before the > Y2038 boundary CLOCK_MONOTONIC will jump backward. > > We can fix it simply by storing the full

Re: bpf jit PPC64 (BE) test_verifier PTR_TO_STACK store/load failure

2019-03-13 Thread Naveen N. Rao
Hi, Yauheni Kaliuta wrote: Hi! I found a failure: ``` # ./test_verifier 722 #722/u PTR_TO_STACK store/load FAIL retval -1 != -87117812 0: (bf) r1 = r10 1: (07) r1 += -10 2: (7a) *(u64 *)(r1 +2) = -87117812 3: (79) r0 = *(u64 *)(r1 +2) 4: (95) exit processed 5 insns (limit 131072), stack dept

[PATCH v2] kmemleak: skip scanning holes in the .bss section

2019-03-13 Thread Qian Cai
The commit 2d4f567103ff ("KVM: PPC: Introduce kvm_tmp framework") adds kvm_tmp[] into the .bss section and then free the rest of unused spaces back to the page allocator. kernel_init kvm_guest_init kvm_free_tmp free_reserved_area free_unref_page free_unref_page_prepar

Re: [PATCH v2] fs/dax: deposit pagetable even when installing zero page

2019-03-13 Thread Dan Williams
On Wed, Mar 13, 2019 at 2:58 AM Jan Kara wrote: > > On Wed 13-03-19 10:17:17, Aneesh Kumar K.V wrote: > > > > Hi Dan/Andrew/Jan, > > > > "Aneesh Kumar K.V" writes: > > > > > Architectures like ppc64 use the deposited page table to store hardware > > > page table slot information. Make sure we dep

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-13 Thread Dan Williams
On Wed, Mar 6, 2019 at 1:18 AM Aneesh Kumar K.V wrote: > > Dan Williams writes: > > > On Thu, Feb 28, 2019 at 1:40 AM Oliver wrote: > >> > >> On Thu, Feb 28, 2019 at 7:35 PM Aneesh Kumar K.V > >> wrote: > >> > > >> > Add a flag to indicate the ability to do huge page dax mapping. On > >> > arc

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-13 Thread Dan Williams
On Wed, Mar 6, 2019 at 4:46 AM Aneesh Kumar K.V wrote: > > On 3/6/19 5:14 PM, Michal Suchánek wrote: > > On Wed, 06 Mar 2019 14:47:33 +0530 > > "Aneesh Kumar K.V" wrote: > > > >> Dan Williams writes: > >> > >>> On Thu, Feb 28, 2019 at 1:40 AM Oliver wrote: > > On Thu, Feb 28, 2019 at

Re: [PATCH v6 0/4] Fix free/allocation of runtime gigantic pages

2019-03-13 Thread Dave Hansen
On 3/7/19 5:20 AM, Alexandre Ghiti wrote: > This series fixes sh and sparc that did not advertise their gigantic page > support and then were not able to allocate and free those pages at runtime. > It renames MEMORY_ISOLATION && COMPACTION || CMA condition into the more > accurate CONTIG_ALLOC, sin

Re: [PATCH v6 0/4] Fix free/allocation of runtime gigantic pages

2019-03-13 Thread Alexandre Ghiti
On 03/13/2019 05:41 PM, Dave Hansen wrote: On 3/7/19 5:20 AM, Alexandre Ghiti wrote: This series fixes sh and sparc that did not advertise their gigantic page support and then were not able to allocate and free those pages at runtime. It renames MEMORY_ISOLATION && COMPACTION || CMA condition in

Re: [PATCH 1/7] ocxl: Provide global MMIO accessors for external drivers

2019-03-13 Thread Frederic Barrat
Hi Alastair, I only realize now that this patch looks a bit out of place and would fit better later in the series: it assumes an external driver can get an ocxl_afu handle, which can only happen after patch 5. And since I'm nitpicking, the year at the top of the new mmio file could be adjust

Re: [PATCH 2/7] ocxl: Allow external drivers to use OpenCAPI contexts

2019-03-13 Thread Frederic Barrat
Le 13/03/2019 à 05:15, Alastair D'Silva a écrit : From: Alastair D'Silva Most OpenCAPI operations require a valid context, so exposing these functions to external drivers is necessary. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz --- Patch could also be moved later in the seri

Re: [PATCH v3] powerpc/mm: move warning from resize_hpt_for_hotplug()

2019-03-13 Thread Christophe Leroy
Le 13/03/2019 à 11:25, Laurent Vivier a écrit : resize_hpt_for_hotplug() reports a warning when it cannot resize the hash page table ("Unable to resize hash page table to target order") but in some cases it's not a problem and can make user thinks something has not worked properly. This patch

[PATCH v2] powerpc/64s: Remove 'dummy_copy_buffer'

2019-03-13 Thread Mathieu Malaterre
In commit 2bf1071a8d50 ("powerpc/64s: Remove POWER9 DD1 support") the function __switch_to remove usage for 'dummy_copy_buffer'. Since it is not used anywhere else, remove it completely. This remove the following warning: arch/powerpc/kernel/process.c:1156:17: error: 'dummy_copy_buffer' defined

Re: [PATCH] powerpc: sstep: Mark variable `rc` as unused in function 'analyse_instr'

2019-03-13 Thread Mathieu Malaterre
On Tue, Mar 12, 2019 at 10:26 PM Christophe Leroy wrote: > > > > Le 12/03/2019 à 22:12, Mathieu Malaterre a écrit : > > On Tue, Mar 12, 2019 at 9:56 PM Christophe Leroy > > wrote: > >> > >> > >> > >> Le 12/03/2019 à 21:20, Mathieu Malaterre a écrit : > >>> Add gcc attribute unused for `rc` variab

Re: [PATCH] powerpc: Make some functions static

2019-03-13 Thread Mathieu Malaterre
On Tue, Mar 12, 2019 at 10:14 PM Christophe Leroy wrote: > > > > Le 12/03/2019 à 21:31, Mathieu Malaterre a écrit : > > In commit cb9e4d10c448 ("[POWERPC] Add support for 750CL Holly board") > > new functions were added. Since these functions can be made static, > > make it so. While doing so, it

Re: [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG

2019-03-13 Thread Mathieu Malaterre
On Sat, Feb 16, 2019 at 3:26 AM Masahiro Yamada wrote: > > On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre wrote: > > > > On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada > > wrote: > > > > > > I often test all Kconfig commands for all architectures. To ease my > > > workflow, I want 'make def

bpf jit PPC64 (BE) test_verifier PTR_TO_STACK store/load failure

2019-03-13 Thread Yauheni Kaliuta
Hi! I found a failure: ``` # ./test_verifier 722 #722/u PTR_TO_STACK store/load FAIL retval -1 != -87117812 0: (bf) r1 = r10 1: (07) r1 += -10 2: (7a) *(u64 *)(r1 +2) = -87117812 3: (79) r0 = *(u64 *)(r1 +2) 4: (95) exit processed 5 insns (limit 131072), stack depth 8 #722/p PTR_TO_STACK store/l

Re: bpf jit PPC64 (BE) test_verifier PTR_TO_STACK store/load failure

2019-03-13 Thread Segher Boessenkool
Hi! On Wed, Mar 13, 2019 at 12:54:16PM +0200, Yauheni Kaliuta wrote: > This is because of the handling of the +2 offset. The low two bits of instructions with primary opcodes 58 and 62 are part of the opcode, not the offset. These instructions can not have offsets with the low two bits non-zero.

Re: [PATCH 1/1] arch/powerpc: Rework local_paca to avoid LTO warnings

2019-03-13 Thread Daniel Axtens
"Alastair D'Silva" writes: > From: Alastair D'Silva > > When building an LTO kernel, the existing code generates warnings: > ./arch/powerpc/include/asm/paca.h:37:30: warning: register of > ‘local_paca’ used for multiple global register variables > register struct paca_struct *lo

Re: [PATCH 1/1] arch/powerpc: Rework local_paca to avoid LTO warnings

2019-03-13 Thread Andrew Donnellan
On 14/3/19 10:54 am, Daniel Axtens wrote: +static inline struct paca_struct *get_paca_no_preempt_check(void) +{ + register struct paca_struct *paca asm("r13"); + return paca; +} Isn't the convention to have the { on the same line as the function, or am I horrible mis-remembering thi

Re: BUG: p8_aes_ctr randomly returns wrong results

2019-03-13 Thread Daniel Axtens
Hi Ondrej, I can confirm this on a ppc64le VM, at least as far back as 4.18, and am investigating. Thanks for the reproducer. Regards, Daniel

Re: [PATCH 1/1] arch/powerpc: Rework local_paca to avoid LTO warnings

2019-03-13 Thread Alastair D'Silva
On Wed, 2019-03-13 at 10:06 +0100, Christophe Leroy wrote: > Hello, Thanks for reviewing :) > > Le 13/03/2019 à 04:42, Alastair D'Silva a écrit : > > From: Alastair D'Silva > > > > When building an LTO kernel, the existing code generates warnings: > > ./arch/powerpc/include/asm/paca.h:37:3

Re: [PATCH 5/5] ocxl: Remove some unused exported symbols

2019-03-13 Thread Alastair D'Silva
On Wed, 2019-03-13 at 10:10 +0100, Greg Kurz wrote: > On Wed, 13 Mar 2019 15:07:01 +1100 > "Alastair D'Silva" wrote: > > > From: Alastair D'Silva > > > > Remove some unused exported symbols. > > > > Signed-off-by: Alastair D'Silva > > --- > > drivers/misc/ocxl/config.c| 2 -- > > dr

Re: [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG

2019-03-13 Thread Michael Ellerman
Mathieu Malaterre writes: > On Sat, Feb 16, 2019 at 3:26 AM Masahiro Yamada > wrote: >> >> On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre wrote: >> > >> > On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada >> > wrote: >> > > >> > > I often test all Kconfig commands for all architectures. To ea

[PATCH v2] arch/powerpc: Rework local_paca to avoid LTO warnings

2019-03-13 Thread Alastair D'Silva
From: Alastair D'Silva When building an LTO kernel, the existing code generates warnings: ./arch/powerpc/include/asm/paca.h:37:30: warning: register of ‘local_paca’ used for multiple global register variables register struct paca_struct *local_paca asm("r13");

Re: [PATCH v6 4/4] hugetlb: allow to free gigantic pages regardless of the configuration

2019-03-13 Thread Michael Ellerman
[ Cc += Aneesh ] Alexandre Ghiti writes: > diff --git a/arch/powerpc/include/asm/book3s/64/hugetlb.h > b/arch/powerpc/include/asm/book3s/64/hugetlb.h > index 5b0177733994..d04a0bcc2f1c 100644 > --- a/arch/powerpc/include/asm/book3s/64/hugetlb.h > +++ b/arch/powerpc/include/asm/book3s/64/hugetlb.

Re: [PATCH v2 09/16] KVM: PPC: Book3S HV: XIVE: add a control to dirty the XIVE EQ pages

2019-03-13 Thread David Gibson
On Wed, Mar 13, 2019 at 12:48:57PM +0100, Cédric Le Goater wrote: > On 2/25/19 3:53 AM, David Gibson wrote: > > On Fri, Feb 22, 2019 at 12:28:33PM +0100, Cédric Le Goater wrote: > >> When migration of a VM is initiated, a first copy of the RAM is > >> transferred to the destination before the VM is

Re: [PATCH v2 06/16] KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration

2019-03-13 Thread David Gibson
On Wed, Mar 13, 2019 at 10:40:19AM +0100, Cédric Le Goater wrote: > On 2/26/19 6:24 AM, Paul Mackerras wrote: > > On Fri, Feb 22, 2019 at 12:28:30PM +0100, Cédric Le Goater wrote: > >> These controls will be used by the H_INT_SET_QUEUE_CONFIG and > >> H_INT_GET_QUEUE_CONFIG hcalls from QEMU. They w

Re: [PATCH v2 16/16] KVM: PPC: Book3S HV: XIVE: clear the vCPU interrupt presenters

2019-03-13 Thread David Gibson
On Wed, Mar 13, 2019 at 09:17:17AM +0100, Cédric Le Goater wrote: > On 2/25/19 5:18 AM, David Gibson wrote: > > On Fri, Feb 22, 2019 at 12:28:40PM +0100, Cédric Le Goater wrote: > >> When the VM boots, the CAS negotiation process determines which > >> interrupt mode to use and invokes a machine res

Re: [PATCH v2 04/16] KVM: PPC: Book3S HV: XIVE: add a control to initialize a source

2019-03-13 Thread David Gibson
On Tue, Mar 12, 2019 at 04:19:35PM +0100, Cédric Le Goater wrote: > On 2/25/19 3:10 AM, David Gibson wrote: > > On Fri, Feb 22, 2019 at 12:28:28PM +0100, Cédric Le Goater wrote: > >> The associated HW interrupt source is simply allocated at the OPAL/HW > >> level and then MASKED. KVM only needs to

Re: [PATCH v2 03/16] KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE

2019-03-13 Thread David Gibson
On Wed, Mar 13, 2019 at 09:34:53AM +0100, Cédric Le Goater wrote: > On 2/25/19 5:35 AM, Paul Mackerras wrote: > > On Fri, Feb 22, 2019 at 12:28:27PM +0100, Cédric Le Goater wrote: > >> The user interface exposes a new capability to let QEMU connect the > >> vCPU to the XIVE KVM device if required.

Re: [PATCH 1/1] arch/powerpc: Rework local_paca to avoid LTO warnings

2019-03-13 Thread Alastair D'Silva
On Thu, 2019-03-14 at 10:54 +1100, Daniel Axtens wrote: > "Alastair D'Silva" writes: > > > From: Alastair D'Silva > > > > When building an LTO kernel, the existing code generates warnings: > > ./arch/powerpc/include/asm/paca.h:37:30: warning: register of > > ‘local_paca’ used for mu

Re: [PATCH v2 10/16] KVM: PPC: Book3S HV: XIVE: add get/set accessors for the VP XIVE state

2019-03-13 Thread David Gibson
On Wed, Mar 13, 2019 at 02:19:13PM +0100, Cédric Le Goater wrote: > On 2/25/19 4:31 AM, David Gibson wrote: > > On Fri, Feb 22, 2019 at 12:28:34PM +0100, Cédric Le Goater wrote: > >> At a VCPU level, the state of the thread interrupt management > >> registers needs to be collected. These registers

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-13 Thread Aneesh Kumar K.V
Dan Williams writes: > On Wed, Mar 6, 2019 at 1:18 AM Aneesh Kumar K.V > wrote: >> >> Dan Williams writes: >> >> > On Thu, Feb 28, 2019 at 1:40 AM Oliver wrote: >> >> >> >> On Thu, Feb 28, 2019 at 7:35 PM Aneesh Kumar K.V >> >> wrote: >> >> > >> >> > Add a flag to indicate the ability to do h

Re: [PATCH v2 06/16] KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration

2019-03-13 Thread David Gibson
On Wed, Mar 13, 2019 at 09:46:08AM +0100, Cédric Le Goater wrote: > On 3/13/19 5:03 AM, David Gibson wrote: > > On Tue, Mar 12, 2019 at 06:00:38PM +0100, Cédric Le Goater wrote: > >> On 2/25/19 3:39 AM, David Gibson wrote: > >>> On Fri, Feb 22, 2019 at 12:28:30PM +0100, Cédric Le Goater wrote: > >>

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-13 Thread Dan Williams
On Wed, Mar 13, 2019 at 8:45 PM Aneesh Kumar K.V wrote: [..] > >> Now w.r.t to failures, can device-dax do an opportunistic huge page > >> usage? > > > > device-dax explicitly disclaims the ability to do opportunistic mappings. > > > >> I haven't looked at the device-dax details fully yet. Do we m

[PATCH] powerpc/powernv: Squash sparse warnings in opal-call.c

2019-03-13 Thread Andrew Donnellan
sparse complains a lot about opal-call.c: arch/powerpc/platforms/powernv/opal-call.c:128:1: warning: symbol 'opal_invalid_call' was not declared. Should it be static? arch/powerpc/platforms/powernv/opal-call.c:129:1: warning: symbol 'opal_console_write' was not declared. Should it be static?

Re: [PATCH 2/5] ocxl: Clean up printf formats

2019-03-13 Thread Andrew Donnellan
On 13/3/19 3:06 pm, Alastair D'Silva wrote: From: Alastair D'Silva Use %# instead of using a literal '0x' Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config.c | 6 +++--- drivers/misc/ocxl/context.c | 2 +- drivers/misc/ocxl/trace.h | 10

Re: [PATCH 3/5] ocxl: read_pasid never returns an error, so make it void

2019-03-13 Thread Andrew Donnellan
On 13/3/19 3:06 pm, Alastair D'Silva wrote: From: Alastair D'Silva No need for a return value in read_pasid as it only returns 0. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config.c | 9 ++--- 1 file changed, 2 insertio

Re: [PATCH 4/5] ocxl: Remove superfluous 'extern' from headers

2019-03-13 Thread Andrew Donnellan
On 13/3/19 3:07 pm, Alastair D'Silva wrote: From: Alastair D'Silva The 'extern' keyword adds no value here. Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan --- drivers/misc/ocxl/ocxl_internal.h | 54 +++ include/misc/ocxl.h | 36 +++

Re: [PATCH v6 3/4] mm: Simplify MEMORY_ISOLATION && COMPACTION || CMA into CONTIG_ALLOC

2019-03-13 Thread Aneesh Kumar K.V
Alexandre Ghiti writes: > This condition allows to define alloc_contig_range, so simplify > it into a more accurate naming. Reviewed-by: Aneesh Kumar K.V > > Suggested-by: Vlastimil Babka > Signed-off-by: Alexandre Ghiti > Acked-by: Vlastimil Babka > --- > arch/arm64/Kconfig

Re: [PATCH v2] arch/powerpc: Rework local_paca to avoid LTO warnings

2019-03-13 Thread Christophe Leroy
Le 14/03/2019 à 03:31, Alastair D'Silva a écrit : From: Alastair D'Silva When building an LTO kernel, the existing code generates warnings: ./arch/powerpc/include/asm/paca.h:37:30: warning: register of ‘local_paca’ used for multiple global register variables register stru

Re: [PATCH v6 4/4] hugetlb: allow to free gigantic pages regardless of the configuration

2019-03-13 Thread Aneesh Kumar K.V
Alexandre Ghiti writes: > On systems without CONTIG_ALLOC activated but that support gigantic pages, > boottime reserved gigantic pages can not be freed at all. This patch > simply enables the possibility to hand back those pages to memory > allocator. > > Signed-off-by: Alexandre Ghiti > Acked-