Re: [RFC PATCH] powerpc: fix get_arch_dma_ops() for NTB devices

2019-02-04 Thread Christoph Hellwig
On Wed, Jan 30, 2019 at 11:58:40PM +1100, Michael Ellerman wrote: > Alexander Fomichev writes: > > > get_dma_ops() falls into arch-dependant get_arch_dma_ops(), which > > historically returns NULL on PowerPC. Therefore dma_set_mask() fails. > > This affects Switchtec (and probably other) NTB devi

Re: [PATCH v2 10/21] memblock: refactor internal allocation functions

2019-02-04 Thread Michael Ellerman
Mike Rapoport writes: > On Sun, Feb 03, 2019 at 08:39:20PM +1100, Michael Ellerman wrote: >> Mike Rapoport writes: >> > Currently, memblock has several internal functions with overlapping >> > functionality. They all call memblock_find_in_range_node() to find free >> > memory and then reserve the

[PATCH v3 2/2] drivers: soc: fsl: add qixis driver

2019-02-04 Thread Pankaj Bansal
FPGA on LX2160AQDS/LX2160ARDB connected on I2C bus, so add qixis driver which is basically an i2c client driver to control FPGA. Also added platform driver for MMIO based FPGA, like the one available on LS2088ARDB/LS2088AQDS. Signed-off-by: Wang Dongsheng Signed-off-by: Pankaj Bansal --- Notes

[PATCH v3 0/2] add qixis driver

2019-02-04 Thread Pankaj Bansal
FPGA on LX2160AQDS/LX2160ARDB connected on I2C bus, so add qixis driver which is basically an i2c client driver to control FPGA. Also added platform driver for MMIO based FPGA, like the one available on LS2088ARDB/LS2088AQDS. This driver is essential to control MDIO mux multiplexing. This driver

[PATCH v3 1/2] dt-bindings: soc: fsl: Document Qixis FPGA usage

2019-02-04 Thread Pankaj Bansal
an FPGA-based system controller, called “Qixis”, which manages several critical system features, including: • Reset sequencing • Power supply configuration • Board configuration • hardware configuration The qixis registers are accessible over one or more system-specific interfaces, typically I2C,

Applied "ASoC: fsl-asoc-card: fix object reference leaks in fsl_asoc_card_probe" to the asoc tree

2019-02-04 Thread Mark Brown
The patch ASoC: fsl-asoc-card: fix object reference leaks in fsl_asoc_card_probe has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the n

Re: [PATCH 03/19] KVM: PPC: Book3S HV: check the IRQ controller type

2019-02-04 Thread Cédric Le Goater
On 2/4/19 1:50 AM, David Gibson wrote: > On Wed, Jan 23, 2019 at 05:24:13PM +0100, Cédric Le Goater wrote: >> On 1/22/19 5:56 AM, Paul Mackerras wrote: >>> On Mon, Jan 07, 2019 at 07:43:15PM +0100, Cédric Le Goater wrote: We will have different KVM devices for interrupts, one for the XICS

Re: [PATCH v2] powerpc: drop page_is_ram() and walk_system_ram_range()

2019-02-04 Thread Michael Ellerman
Christophe Leroy writes: > Since commit c40dd2f76644 ("powerpc: Add System RAM to /proc/iomem") > it is possible to use the generic walk_system_ram_range() and > the generic page_is_ram(). > > To enable the use of walk_system_ram_range() by the IBM EHEA > ethernet driver, the generic function has

Re: [PATCH v15 00/13] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK

2019-02-04 Thread Michael Ellerman
Christophe Leroy writes: > The purpose of this serie is to activate CONFIG_THREAD_INFO_IN_TASK which > moves the thread_info into task_struct. Hi Christophe, I've taken this series and split some of the patches up a bit more. I'll just run it through some tests and then post my version. cheer

Re: [PATCH 05/19] KVM: PPC: Book3S HV: add a new KVM device for the XIVE native exploitation mode

2019-02-04 Thread Cédric Le Goater
On 2/4/19 5:25 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:43:17PM +0100, Cédric Le Goater wrote: >> This is the basic framework for the new KVM device supporting the XIVE >> native exploitation mode. The user interface exposes a new capability >> and a new KVM device to be used by QEMU. >

Re: [PATCH 06/19] KVM: PPC: Book3S HV: add a GET_ESB_FD control to the XIVE native device

2019-02-04 Thread Cédric Le Goater
On 2/4/19 5:45 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:43:18PM +0100, Cédric Le Goater wrote: >> This will let the guest create a memory mapping to expose the ESB MMIO >> regions used to control the interrupt sources, to trigger events, to >> EOI or to turn off the sources. >> >> Signe

Re: use generic DMA mapping code in powerpc V4

2019-02-04 Thread Christian Zigotzky
On 04 February 2019 at 08:56AM, Christoph Hellwig wrote: On Sun, Feb 03, 2019 at 05:49:02PM +0100, Christian Zigotzky wrote: OK, next step: b50f42f0fe12965ead395c76bcb6a14f00cdf65b (powerpc/dma: use the dma_direct mapping routines) git clone git://git.infradead.org/users/hch/misc.git -b powerpc

Re: [PATCH] powerpc/64s: Remove MSR_RI optimisation in system_call_exit()

2019-02-04 Thread Michael Ellerman
Nicholas Piggin writes: > Michael Ellerman's on January 17, 2019 9:35 pm: >> Currently in system_call_exit() we have an optimisation where we >> disable MSR_RI (recoverable interrupt) and MSR_EE (external interrupt >> enable) in a single mtmsrd instruction. >> >> Unfortunately this will no longe

Re: use generic DMA mapping code in powerpc V4

2019-02-04 Thread Christoph Hellwig
On Mon, Feb 04, 2019 at 01:13:54PM +0100, Christian Zigotzky wrote: >>> Results: The X1000 and X5000 boot but unfortunately the P.A. Semi Ethernet >>> doesn't work. >> Are there any interesting messages in the boot log? Can you send me >> the dmesg? >> > Here you are: http://www.xenosoft.de/dmesg_

[PATCH] soc: fsl: dpio: Use after free in dpaa2_dpio_remove()

2019-02-04 Thread Dan Carpenter
The dpaa2_io_down(priv->io) call frees "priv->io" so I've shifted the code around a little bit to avoid the use after free. Fixes: 991e873223e9 ("soc: fsl: dpio: use a cpumask to identify which cpus are unused") Signed-off-by: Dan Carpenter --- drivers/soc/fsl/dpio/dpio-driver.c | 2 +- 1 file

[PATCH 00/17] powerpc/64s: tidy and gasify exception handler code, round 1

2019-02-04 Thread Nicholas Piggin
My previous big patch was received about as well as can be expected. That is to say I'll assume everybody loved it, so we have to get there a bit more incrementally. This first round of patches was verified each patch (with several configs) to not change any generated code, to make a small step to

[PATCH 01/17] powerpc/64s/exception: fix some line wrap and semicolon inconsistencies in macros

2019-02-04 Thread Nicholas Piggin
By convention, all lines should be separated by a semicolons. Last line should have neithe semicolon or line wrap. Small cleanup before we begin. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 36 ++--- arch/powerpc/include/asm/head-64.h | 68

[PATCH 02/17] powerpc/64s/exception: remove H concatenation for EXC_HV variants

2019-02-04 Thread Nicholas Piggin
Replace all instances of this with gas macros that test the hsrr parameter and use the appropriate register names / labels. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 333 +-- arch/powerpc/include/asm/head-64.h | 8 +- arch/powerpc/k

[PATCH 03/17] powerpc/64s/exception: consolidate EXCEPTION_PROLOG_2 with _NORI variant

2019-02-04 Thread Nicholas Piggin
Switch to a gas macro that conditionally expands the RI clearing instruction. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 43 ++-- arch/powerpc/kernel/exceptions-64s.S | 6 ++-- 2 files changed, 14 insertions(+), 35 deletions(-) diff --

[PATCH 04/17] powerpc/64s/exception: move and tidy EXCEPTION_PROLOG_2 variants

2019-02-04 Thread Nicholas Piggin
- Re-name the macros to _REAL and _VIRT suffixes rather than no and _RELON suffix. - Move the macro definitions together in the file. - Move RELOCATABLE ifdef inside the _VIRT macro. Further consolidation between variants does not buy much here. Signed-off-by: Nicholas Piggin --- arch/power

[PATCH 05/17] powerpc/64s/exception: remove the "extra" macro parameter

2019-02-04 Thread Nicholas Piggin
Rather than pass in the soft-masking and KVM tests via macro that is passed to another macro to expand it, switch to usig gas macros and conditionally expand the soft-masking and KVM tests. The system reset with its idle test is open coded as it is a one-off. Signed-off-by: Nicholas Piggin ---

[PATCH 06/17] powerpc/64s/exception: consolidate maskable and non-maskable prologs

2019-02-04 Thread Nicholas Piggin
Conditionally expand the soft-masking test if a mask is passed in. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 113 +-- arch/powerpc/kernel/exceptions-64s.S | 8 +- 2 files changed, 49 insertions(+), 72 deletions(-) diff --git a/arch/p

[PATCH 07/17] powerpc/64s/exception: merge KVM handler and skip variants

2019-02-04 Thread Nicholas Piggin
Conditionally expand the skip case if it is specified. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 28 +--- arch/powerpc/include/asm/head-64.h | 8 +++ arch/powerpc/kernel/exceptions-64s.S | 2 +- 3 files changed, 15 insertion

[PATCH 08/17] powerpc/64s/exception: KVM handler can set the HSRR trap bit

2019-02-04 Thread Nicholas Piggin
Move the KVM trap HSRR bit, into the KVM handler, which can be conditionally applied when hsrr parameter is set. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 5 + arch/powerpc/include/asm/head-64.h | 7 ++- 2 files changed, 7 insertions(+), 5 deleti

[PATCH 09/17] powerpc/64s/exception: Make EXCEPTION_PROLOG_0 a gas macro for consistency with others

2019-02-04 Thread Nicholas Piggin
Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 25 arch/powerpc/kernel/exceptions-64s.S | 12 ++-- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/include/asm/exception-64s.h b/arch/powerpc/include/

[PATCH 10/17] powerpc/64s/exception: Move EXCEPTION_COMMON handler and return branches into callers

2019-02-04 Thread Nicholas Piggin
The aim is to reduce the amount of indirection it takes to get through the exception handler macros, particularly where it provides little code sharing. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 26 arch/powerpc/kernel/exceptions-64s.S

[PATCH 11/17] powerpc/64s/exception: Move EXCEPTION_COMMON additions into callers

2019-02-04 Thread Nicholas Piggin
More cases of code insertion via macros that does not add a great deal. All the additions have to be specified in the macro arguments, so they can just as well go after the macro. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 42 +++--- arch/powerp

[PATCH 12/17] powerpc/64s/exception: unwind exception-64s.h macros

2019-02-04 Thread Nicholas Piggin
Many of these macros just specify 1-4 lines which are only called a few times each at most, and often just once. Remove this indirection. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 101 --- arch/powerpc/include/asm/head-64.h | 76

[PATCH 13/17] powerpc/64s/exception: move EXCEPTION_PROLOG_2* to a more logical place

2019-02-04 Thread Nicholas Piggin
Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 113 --- 1 file changed, 57 insertions(+), 56 deletions(-) diff --git a/arch/powerpc/include/asm/exception-64s.h b/arch/powerpc/include/asm/exception-64s.h index f8f657321c88..e7e5c71b1ad0 100644 -

[PATCH 14/17] powerpc/64s/exception: remove STD_EXCEPTION_COMMON variants

2019-02-04 Thread Nicholas Piggin
These are only called in one place each. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 22 -- arch/powerpc/include/asm/head-64.h | 19 +-- 2 files changed, 17 insertions(+), 24 deletions(-) diff --git a/arch/powerpc/inclu

[PATCH 15/17] powerpc/64s/exception: move KVM related code together

2019-02-04 Thread Nicholas Piggin
Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/arch/powerpc/include/asm/exception-64s.h b/arch/powerpc/include/asm/exception-64s.h index 4d3bd10ea59a..3eb8f9a4eac8 100644 -

[PATCH 16/17] powerpc/64s/exception: move exception-64s.h code to exception-64s.S where it is used

2019-02-04 Thread Nicholas Piggin
Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/exception-64s.h | 429 --- arch/powerpc/kernel/exceptions-64s.S | 429 +++ 2 files changed, 429 insertions(+), 429 deletions(-) diff --git a/arch/powerpc/include/asm/exception-64s.h b/arch/po

[PATCH 17/17] powerpc/64s/exception: move head-64.h code to exception-64s.S where it is used

2019-02-04 Thread Nicholas Piggin
Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/head-64.h | 252 --- arch/powerpc/kernel/exceptions-64s.S | 251 ++ 2 files changed, 251 insertions(+), 252 deletions(-) diff --git a/arch/powerpc/include/asm/head-64.h b/arch/powerpc/i

Re: [PATCH 08/19] KVM: PPC: Book3S HV: add a VC_BASE control to the XIVE native device

2019-02-04 Thread Cédric Le Goater
On 2/4/19 5:49 AM, David Gibson wrote: > On Wed, Jan 23, 2019 at 05:56:26PM +0100, Cédric Le Goater wrote: >> On 1/22/19 6:14 AM, Paul Mackerras wrote: >>> On Mon, Jan 07, 2019 at 07:43:20PM +0100, Cédric Le Goater wrote: The ESB MMIO region controls the interrupt sources of the guest. QEMU >>

[PATCH RFC v3 21/21] powerpc/pci: Fix crash with enabled movable BARs

2019-02-04 Thread Sergey Miroshnichenko
Check a resource for the UNSET flags. Signed-off-by: Sergey Miroshnichenko --- arch/powerpc/platforms/powernv/pci-ioda.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c index 7db3119f8a5b

[PATCH RFC v3 00/21] PCI: Allow BAR movement during hotplug

2019-02-04 Thread Sergey Miroshnichenko
If the firmware or kernel has arranged memory for PCIe devices in a way that doesn't provide enough space for BARs of a new hotplugged device, the kernel can pause the drivers of the "obstructing" devices and move their BARs, so new BARs can fit into the freed spaces. When a driver is un-paused by

[PATCH RFC v3 05/21] PCI: hotplug: Add a flag for the movable BARs feature

2019-02-04 Thread Sergey Miroshnichenko
If a new PCIe device has been hot-plugged between the two active ones without big enough gap between their BARs, these BARs should be moved if their drivers support this feature. The drivers should be notified and paused during the procedure: 1) dev 8 (new) |

[PATCH RFC v3 02/21] PCI: Fix race condition in pci_enable/disable_device()

2019-02-04 Thread Sergey Miroshnichenko
CPU0 CPU1 pci_enable_device_mem() pci_enable_device_mem() pci_enable_bridge() pci_enable_bridge() pci_is_enabled() return false; atomic_inc_return(enable_cnt) Start actual enabling the bridge

Re: [PATCH 14/19] KVM: PPC: Book3S HV: add a control to make the XIVE EQ pages dirty

2019-02-04 Thread Cédric Le Goater
On 2/4/19 6:18 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:43:26PM +0100, Cédric Le Goater wrote: >> When the VM is stopped in a migration sequence, the sources are masked >> and the XIVE IC is synced to stabilize the EQs. When done, the KVM >> ioctl KVM_DEV_XIVE_SAVE_EQ_PAGES is called to

[PATCH RFC v3 06/21] PCI: Pause the devices with movable BARs during rescan

2019-02-04 Thread Sergey Miroshnichenko
Drivers indicate their support of movable BARs by implementing the new rescan_prepare() and rescan_done() hooks in the struct pci_driver. All device's activity must be stopped during a rescan, and iounmap() +ioremap() must be applied to every used BAR. Signed-off-by: Sergey Miroshnichenko --- d

Re: [PATCH 12/19] KVM: PPC: Book3S HV: record guest queue page address

2019-02-04 Thread Cédric Le Goater
On 2/4/19 6:15 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:43:24PM +0100, Cédric Le Goater wrote: >> The guest physical address of the event queue will be part of the >> state to transfer in the migration. Cache its value when the queue is >> configured, it will save us an OPAL call. > >

Re: [PATCH 15/19] KVM: PPC: Book3S HV: add get/set accessors for the source configuration

2019-02-04 Thread Cédric Le Goater
On 2/4/19 6:21 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:43:27PM +0100, Cédric Le Goater wrote: >> Theses are use to capure the XIVE EAS table of the KVM device, the >> configuration of the source targets. >> >> Signed-off-by: Cédric Le Goater >> --- >> arch/powerpc/include/uapi/asm/kv

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-02-04 Thread Thiago Jung Bauermann
Hello Michael, Michael S. Tsirkin writes: > On Tue, Jan 29, 2019 at 03:42:44PM -0200, Thiago Jung Bauermann wrote: >> >> Fixing address of powerpc mailing list. >> >> Thiago Jung Bauermann writes: >> >> > Hello, >> > >> > With Christoph's rework of the DMA API that recently landed, the patch

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-02-04 Thread Thiago Jung Bauermann
Christoph Hellwig writes: > On Tue, Jan 29, 2019 at 09:36:08PM -0500, Michael S. Tsirkin wrote: >> This has been discussed ad nauseum. virtio is all about compatibility. >> Losing a couple of lines of code isn't worth breaking working setups. >> People that want "just use DMA API no tricks" now

Re: [PATCH 17/19] KVM: PPC: Book3S HV: add get/set accessors for the VP XIVE state

2019-02-04 Thread Cédric Le Goater
On 2/4/19 6:26 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 08:10:04PM +0100, Cédric Le Goater wrote: >> At a VCPU level, the state of the thread context interrupt management >> registers needs to be collected. These registers are cached under the >> 'xive_saved_state.w01' field of the VCPU wh

Re: [PATCH 09/19] KVM: PPC: Book3S HV: add a SET_SOURCE control to the XIVE native device

2019-02-04 Thread Cédric Le Goater
On 2/4/19 5:57 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:43:21PM +0100, Cédric Le Goater wrote: >> Interrupt sources are simply created at the OPAL level and then >> MASKED. KVM only needs to know about their type: LSI or MSI. > > This commit message isn't very illuminating. There is r

Re: [PATCH v3 1/2] dt-bindings: soc: fsl: Document Qixis FPGA usage

2019-02-04 Thread Li Yang
Please include device tree binding mailing list and maintainers for binding patches(cc'ed now). On Mon, Feb 4, 2019 at 3:15 AM Pankaj Bansal wrote: > > an FPGA-based system controller, called “Qixis”, which > manages several critical system features, including: > • Reset sequencing > • Power supp

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-02-04 Thread Michael S. Tsirkin
On Mon, Feb 04, 2019 at 04:14:20PM -0200, Thiago Jung Bauermann wrote: > > Hello Michael, > > Michael S. Tsirkin writes: > > > On Tue, Jan 29, 2019 at 03:42:44PM -0200, Thiago Jung Bauermann wrote: > >> > >> Fixing address of powerpc mailing list. > >> > >> Thiago Jung Bauermann writes: > >> >

Re: [PATCH] soc: fsl: dpio: Use after free in dpaa2_dpio_remove()

2019-02-04 Thread Li Yang
On Mon, Feb 4, 2019 at 8:12 AM Dan Carpenter wrote: > > The dpaa2_io_down(priv->io) call frees "priv->io" so I've shifted the > code around a little bit to avoid the use after free. > > Fixes: 991e873223e9 ("soc: fsl: dpio: use a cpumask to identify which cpus > are unused") > Signed-off-by: Dan

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-02-04 Thread Michael S. Tsirkin
On Mon, Feb 04, 2019 at 04:15:41PM -0200, Thiago Jung Bauermann wrote: > > Christoph Hellwig writes: > > > On Tue, Jan 29, 2019 at 09:36:08PM -0500, Michael S. Tsirkin wrote: > >> This has been discussed ad nauseum. virtio is all about compatibility. > >> Losing a couple of lines of code isn't w

Re: [PATCH 02/17] powerpc/64s/exception: remove H concatenation for EXC_HV variants

2019-02-04 Thread kbuild test robot
Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.0-rc4 next-20190204] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 13/19] KVM: PPC: Book3S HV: add a SYNC control for the XIVE native migration

2019-02-04 Thread Cédric Le Goater
On 2/4/19 6:17 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:43:25PM +0100, Cédric Le Goater wrote: >> When migration of a VM is initiated, a first copy of the RAM is >> transferred to the destination before the VM is stopped. At that time, >> QEMU needs to perform a XIVE quiesce sequence to

Re: [PATCH v2 10/21] memblock: refactor internal allocation functions

2019-02-04 Thread Stephen Rothwell
Hi all, On Mon, 04 Feb 2019 19:45:17 +1100 Michael Ellerman wrote: > > Mike Rapoport writes: > > On Sun, Feb 03, 2019 at 08:39:20PM +1100, Michael Ellerman wrote: > >> Mike Rapoport writes: > >> > Currently, memblock has several internal functions with overlapping > >> > functionality. They

Re: [PATCH 12/17] powerpc/64s/exception: unwind exception-64s.h macros

2019-02-04 Thread kbuild test robot
Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.0-rc4 next-20190204] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] scsi: cxlflash: Prevent deadlock when adapter probe fails

2019-02-04 Thread Martin K. Petersen
Vaibhav, > Presently when an error is encountered during probe of the cxlflash > adapter, a deadlock is seen with cpu thread stuck inside > cxlflash_remove(). Below is the trace of the deadlock as logged by > khungtaskd: Applied to 5.0/scsi-fixes, thanks! -- Martin K. Petersen Oracle Lin

Re: [PATCH] powerpc/powernv/npu: Remove redundant change_pte() hook

2019-02-04 Thread Alistair Popple
On Thursday, 31 January 2019 12:11:06 PM AEDT Andrea Arcangeli wrote: > On Thu, Jan 31, 2019 at 06:30:22PM +0800, Peter Xu wrote: > > The change_pte() notifier was designed to use as a quick path to > > update secondary MMU PTEs on write permission changes or PFN changes. > > For KVM, it could redu

Re: [PATCH 09/19] KVM: PPC: Book3S HV: add a SET_SOURCE control to the XIVE native device

2019-02-04 Thread David Gibson
On Mon, Feb 04, 2019 at 08:07:20PM +0100, Cédric Le Goater wrote: > On 2/4/19 5:57 AM, David Gibson wrote: > > On Mon, Jan 07, 2019 at 07:43:21PM +0100, Cédric Le Goater wrote: [snip] > >> + sb = kvmppc_xive_create_src_block(xive, irq); > >> + if (!sb) { > >> + pr

Re: [PATCH 17/19] KVM: PPC: Book3S HV: add get/set accessors for the VP XIVE state

2019-02-04 Thread David Gibson
On Mon, Feb 04, 2019 at 07:57:26PM +0100, Cédric Le Goater wrote: > On 2/4/19 6:26 AM, David Gibson wrote: > > On Mon, Jan 07, 2019 at 08:10:04PM +0100, Cédric Le Goater wrote: > >> At a VCPU level, the state of the thread context interrupt management > >> registers needs to be collected. These reg

Re: [PATCH 06/19] KVM: PPC: Book3S HV: add a GET_ESB_FD control to the XIVE native device

2019-02-04 Thread David Gibson
On Mon, Feb 04, 2019 at 12:30:39PM +0100, Cédric Le Goater wrote: > On 2/4/19 5:45 AM, David Gibson wrote: > > On Mon, Jan 07, 2019 at 07:43:18PM +0100, Cédric Le Goater wrote: > >> This will let the guest create a memory mapping to expose the ESB MMIO > >> regions used to control the interrupt sou

Re: [PATCH 14/19] KVM: PPC: Book3S HV: add a control to make the XIVE EQ pages dirty

2019-02-04 Thread David Gibson
On Mon, Feb 04, 2019 at 04:46:00PM +0100, Cédric Le Goater wrote: > On 2/4/19 6:18 AM, David Gibson wrote: > > On Mon, Jan 07, 2019 at 07:43:26PM +0100, Cédric Le Goater wrote: > >> When the VM is stopped in a migration sequence, the sources are masked > >> and the XIVE IC is synced to stabilize th

Re: [PATCH 05/19] KVM: PPC: Book3S HV: add a new KVM device for the XIVE native exploitation mode

2019-02-04 Thread David Gibson
On Mon, Feb 04, 2019 at 12:19:07PM +0100, Cédric Le Goater wrote: > On 2/4/19 5:25 AM, David Gibson wrote: > > On Mon, Jan 07, 2019 at 07:43:17PM +0100, Cédric Le Goater wrote: > >> This is the basic framework for the new KVM device supporting the XIVE > >> native exploitation mode. The user interf

Re: [PATCH 15/19] KVM: PPC: Book3S HV: add get/set accessors for the source configuration

2019-02-04 Thread David Gibson
On Mon, Feb 04, 2019 at 05:07:28PM +0100, Cédric Le Goater wrote: > On 2/4/19 6:21 AM, David Gibson wrote: > > On Mon, Jan 07, 2019 at 07:43:27PM +0100, Cédric Le Goater wrote: > >> Theses are use to capure the XIVE EAS table of the KVM device, the > >> configuration of the source targets. > >> > >

Re: [PATCH v2] powerpc: drop page_is_ram() and walk_system_ram_range()

2019-02-04 Thread Christophe Leroy
Le 04/02/2019 à 11:24, Michael Ellerman a écrit : Christophe Leroy writes: Since commit c40dd2f76644 ("powerpc: Add System RAM to /proc/iomem") it is possible to use the generic walk_system_ram_range() and the generic page_is_ram(). To enable the use of walk_system_ram_range() by the IBM E

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-02-04 Thread Christoph Hellwig
On Mon, Feb 04, 2019 at 04:38:21PM -0500, Michael S. Tsirkin wrote: > It was designed to make, when set, as many guests as we can work > correctly, and it seems to be successful in doing exactly that. > > Unfortunately there could be legacy guests that do work correctly but > become slow. Whether