[PATCH v5] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2019-01-02 Thread Peng Hao
From: Wen Yang Currently there are some issues with the ucc_of_parse_tdm function: 1, a possible null pointer dereference in ucc_of_parse_tdm, detected by the semantic patch deref_null.cocci, with the following warning: drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is NULL but dereferenced.

Re: [PATCH v5] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2019-01-02 Thread LEROY Christophe
Peng Hao a écrit : From: Wen Yang Currently there are some issues with the ucc_of_parse_tdm function: 1, a possible null pointer dereference in ucc_of_parse_tdm, detected by the semantic patch deref_null.cocci, with the following warning: drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is

[RESEND PATCH v5] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2019-01-02 Thread Peng Hao
From: Wen Yang Currently there are some issues with the ucc_of_parse_tdm function: 1, a possible null pointer dereference in ucc_of_parse_tdm, detected by the semantic patch deref_null.cocci, with the following warning: drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is NULL but dereferenced.

Re: [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings

2019-01-02 Thread Michael Ellerman
LEROY Christophe writes: > Michael Ellerman a écrit : > >> Currently the code produces several warnings, eg: >> >> arch/powerpc/platforms/4xx/ocm.c:240:38: error: format '%llx' >> expects argument of type 'long long unsigned int', but argument 3 >> has type 'phys_addr_t {aka unsigned int}'

Re: [PATCH] jump_label: move 'asm goto' support test to Kconfig

2019-01-02 Thread Michael Ellerman
Masahiro Yamada writes: > Currently, CONFIG_JUMP_LABEL just means "I _want_ to use jump label". > > The jump label is controlled by HAVE_JUMP_LABEL, which is defined > like this: > > #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL) > # define HAVE_JUMP_LABEL > #endif > > We can i

Re: [v2] powerpc/4xx/ocm: fix compilation error

2019-01-02 Thread Michael Ellerman
On Sat, 2018-12-22 at 14:35:38 UTC, Christian Lamparter wrote: > This patch fixes a recent compilation regression in ocm: > > | ocm.c: In function ‘ocm_init_node’: > | ocm.c:182:18: error: invalid operands to binary | > | (have ‘int’ and ‘pgprot_t’ {aka ‘st

Re: powerpc/fsl: Fixed warning: orphan section `__btb_flush_fixup'

2019-01-02 Thread Michael Ellerman
On Sun, 2018-12-23 at 20:34:25 UTC, Diana Craciun wrote: > Fixed the following build warning: > powerpc-linux-gnu-ld: warning: orphan section `__btb_flush_fixup' from > `arch/powerpc/kernel/head_44x.o' being placed in section > `__btb_flush_fixup'. > > Signed-off-by: Diana Craciun Applied to pow

Re: KVM: PPC: Book3S HV: radix: Fix uninitialized var build error

2019-01-02 Thread Michael Ellerman
On Tue, 2019-01-01 at 03:55:13 UTC, Michael Ellerman wrote: > Old GCCs (4.6.3 at least), aren't able to follow the logic in > __kvmhv_copy_tofrom_guest_radix() and warn that old_pid is used > uninitialized: > > arch/powerpc/kvm/book3s_64_mmu_radix.c:75:3: error: 'old_pid' may be > used uniniti

Re: [1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings

2019-01-02 Thread Michael Ellerman
On Tue, 2019-01-01 at 03:56:00 UTC, Michael Ellerman wrote: > Currently the code produces several warnings, eg: > > arch/powerpc/platforms/4xx/ocm.c:240:38: error: format '%llx' > expects argument of type 'long long unsigned int', but argument 3 > has type 'phys_addr_t {aka unsigned int}' >

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

2019-01-02 Thread James Bottomley
On Sun, 2018-12-30 at 18:50 +0100, LEROY Christophe wrote: > Arnd Bergmann a écrit : > > On Sat, Dec 29, 2018 at 3:51 AM Michael Schmitz > > wrote: [...] > > > (On second thought - I don't want to speculate whether there's > > > weird compiler options that could result in the > > > nvram_check_ch

Re: jump_label: move 'asm goto' support test to Kconfig

2019-01-02 Thread Sedat Dilek
Hi, I was not aware that CONFIG_JUMP_LABEL Kconfig setting depends on the support of asm-goto. Currently, I am doing experiments with clang-7 and a snapshot of clang-8 on Linux/x86. These compilers have no asm-goto support. What is your recommendation for Linux >= v4.20? I am asking as it is pos

[PATCH 0/2] powerpc: Unify the system call scripts

2019-01-02 Thread Firoz Khan
System call table generation support is provided for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa architectures. The implementat- ions are almost similar across all the above archte- ctures. In order to reduce the source code across all the above architectures, create

[PATCH 1/2] powerpc: remove nargs from __SYSCALL

2019-01-02 Thread Firoz Khan
The __SYSCALL macro's arguments are system call number, system call entry name and number of arguments for the system call. Argument- nargs in __SYSCALL(nr, entry, nargs) is neither calculated nor used anywhere. So it would be better to keep the implementaion as __SYSCALL(nr, entry). This will un

[PATCH 2/2] powerpc: generate uapi header and system call table files

2019-01-02 Thread Firoz Khan
Unified system call table generation script must be run to generate unistd_32/64.h and syscall_table_32/64/c32/spu.h files. This patch will have changes which will invokes the script. This patch will generate unistd_32/64.h and syscall_table- _32/64/c32/spu.h files by the syscall table generation

Re: powerpc/pasemi: Add Nemo board IRQ initroutine

2019-01-02 Thread Darren Stevens
Hello Michael On 22/12/2018, Michael Ellerman wrote: > On Sun, 2018-08-19 at 20:21:47 UTC, Darren Stevens wrote: >> Add a IRQ init routine for the Nemo board which inits and attatches >> the i8259 found in the SB600, and a cascade routine to dispatch the >> interrupts. >> >> Signed-off-by: Darren

Re: [PATCH v8 18/25] powerpc: Implement nvram sync ioctl

2019-01-02 Thread Finn Thain
On Tue, 1 Jan 2019, I wrote: > > There are no [nvram] ioctls common to all architectures. So your example > becomes, > > static long nvram_misc_ioctl(struct file *file, unsigned int cmd, > unsigned long arg) > { > if (ops->ioctl) > return ops->ioctl(f

Re: [PATCH v8 02/25] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2019-01-02 Thread Finn Thain
On Sat, 29 Dec 2018, I wrote: > On Fri, 28 Dec 2018, LEROY Christophe wrote: > > > > --- a/drivers/char/nvram.c > > > +++ b/drivers/char/nvram.c > > > @@ -21,13 +21,6 @@ > > > * ioctl(NVRAM_SETCKS) (doesn't change contents, just makes checksum > > > valid > > > * again; use with care!) > > >

Re: jump_label: move 'asm goto' support test to Kconfig

2019-01-02 Thread Masahiro Yamada
On Wed, Jan 2, 2019 at 9:14 PM Sedat Dilek wrote: > > Hi, > > I was not aware that CONFIG_JUMP_LABEL Kconfig setting depends on the > support of asm-goto. > > Currently, I am doing experiments with clang-7 and a snapshot of > clang-8 on Linux/x86. > These compilers have no asm-goto support. > > Wh

RE: [PATCH] fsl/fman: Use GFP_ATOMIC in {memac,tgec}_add_hash_mac_address()

2019-01-02 Thread Madalin-cristian Bucur
> -Original Message- > From: Scott Wood > Sent: Friday, December 28, 2018 2:29 AM > To: Madalin-cristian Bucur > Cc: net...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > Subject: [PATCH] fsl/fman: Use GFP_ATOMIC in > {memac,tgec}_add_hash_mac_address() > > These functions are called f

Re: use generic DMA mapping code in powerpc V4

2019-01-02 Thread Christoph Hellwig
Hi Christian, happy new year and I hope you had a few restful deays off. I've pushed a new tree to: git://git.infradead.org/users/hch/misc.git powerpc-dma.6 Gitweb: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/powerpc-dma.6 Which has been rebased to the latests Linus