Re: [PATCH] treewide: remove current_text_addr

[ Trimmed the cc list because my SMTP didn't accept that many addresses. ] On Sun, 26 Aug 2018 13:25:14 -0700 Linus Torvalds wrote: > On Sun, Aug 26, 2018 at 12:32 PM H. Peter Anvin wrote: > > > > Here is a full-blown (user space) test program demonstrating the whole > > technique and how to us

11 minute NTP hw clock update racy?

We see corrupt HW clock time every now and then(really hard to reproduce) Our RTC is a DS1388 on an I2C bus. Looking at ntp_notify_cmos_timer() and it's delayed work queue impl. I wonder if there could be a race here w.r.t reboot ? Could the 11 minute update kick in just as the system is about to

Re: [PATCH 2/2] powerpc/64s/radix: Explicitly flush ERAT with local LPID invalidation

On Mon, 2018-08-27 at 13:03 +1000, Nicholas Piggin wrote: > Local radix TLB flush operations that operate on congruence classes > have explicit ERAT flushes for POWER9. The process scoped LPID flush > did not have a flush, so add it. Paul, is that an actual bug ? I think the ERAT is flushed on LPI

[PATCH] powerpc/sysdev/ipic: check primary_ipic NULL pointer before using it

ipic_get_mcp_status() is used by targets implementing NMI watchdog in target specific machine check handler in order to known whether a machine check results from a watchdog NMI reset. In case of very early machine check, primary_ipic pointer might not have been set yet, so ipic_get_mcp_status() n

Re: [PATCH] treewide: remove current_text_addr

On Sun, Aug 26, 2018 at 07:52:59PM -0700, Nick Desaulniers wrote: > On Sun, Aug 26, 2018 at 1:25 PM Linus Torvalds > > Instead, maybe we could encourage something like > > > > struct kernel_loc { const char *file; const char *fn; int line; }; > > > > #define __GEN_LOC__(n) \ > > ({ sta

Re: [PATCH 16/20] powerpc/dma: use dma_direct_{alloc,free}

On Thu, 2018-08-09 at 10:52 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2018-07-30 at 18:38 +0200, Christoph Hellwig wrote: > > These do the same functionality as the existing helpers, but do it > > simpler, and also allow the (optional) use of CMA. > > > > Note that the swiotlb code now calls

[PATCH] powerpc: wire up memtest

Add call to early_memtest() so that kernel compiled with CONFIG_MEMTEST really perform memtest at startup when requested via 'memtest' boot parameter. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/setup-common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/kernel

Re: [PATCH 2/2] powerpc/64s/radix: Explicitly flush ERAT with local LPID invalidation

On Mon, 27 Aug 2018 18:16:05 +1000 Benjamin Herrenschmidt wrote: > On Mon, 2018-08-27 at 13:03 +1000, Nicholas Piggin wrote: > > Local radix TLB flush operations that operate on congruence classes > > have explicit ERAT flushes for POWER9. The process scoped LPID flush > > did not have a flush, s

Re: [PATCH 2/2] powerpc/64s/radix: Explicitly flush ERAT with local LPID invalidation

On Mon, 27 Aug 2018 18:16:05 +1000 Benjamin Herrenschmidt wrote: > On Mon, 2018-08-27 at 13:03 +1000, Nicholas Piggin wrote: > > Local radix TLB flush operations that operate on congruence classes > > have explicit ERAT flushes for POWER9. The process scoped LPID flush > > did not have a flush, s

Re: Build regressions/improvements in v4.19-rc1

On Mon, Aug 27, 2018 at 11:50 AM Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v4.19-rc1[1] compared to v4.18[2]. > > Summarized: > - build errors: +5/-3 > - build warnings: +14732/-179 > > Note that there may be false regressions, as some l

Re: [PATCH v8 5/5] powernv/pseries: consolidate code for mce early handling.

On 08/23/2018 02:32 PM, Nicholas Piggin wrote: > On Thu, 23 Aug 2018 14:13:13 +0530 > Mahesh Jagannath Salgaonkar wrote: > >> On 08/20/2018 05:04 PM, Nicholas Piggin wrote: >>> On Sun, 19 Aug 2018 22:38:39 +0530 >>> Mahesh J Salgaonkar wrote: >>> From: Mahesh Salgaonkar Now th

Re: [PATCH] treewide: remove current_text_addr

On 08/27/18 00:33, Peter Zijlstra wrote: > > What problem are we trying to solve? _THIS_IP_ and _RET_IP_ work fine. > We're 'good' at dealing with text addresses, we use them for call stacks > and all sorts. Why does this need changing? > _RET_IP_ works fine, with the following two caveats: 1.

Re: [PATCH] treewide: remove current_text_addr

On Mon, Aug 27, 2018 at 05:26:53AM -0700, H. Peter Anvin wrote: > _THIS_IP_, however, is completely ill-defined, other than being an > address *somewhere* in the same global function (not even necessarily > the same function if the function is static!) As my experiment show, in > many (nearly) ca

[PATCH v2] drivers/video/fbdev: use ioremap_wc() instead of __ioremap(_PAGE_NO_CACHE)

_PAGE_NO_CACHE is a target specific flag. In addition, this flag is misleading because one would think it requests a noncached page whereas a noncached page is _PAGE_NO_CACHE | _PAGE_GUARDED _PAGE_NO_CACHE alone means write combined noncached page, so lets use ioremap_wc() instead. Signed-off-by:

Re: [PATCH 05/20] swiotlb: allow the architecture to provide a get_required_mask hook

On Mon, Jul 30, 2018 at 06:38:09PM +0200, Christoph Hellwig wrote: > For now this allows consolidating the powerpc code. In the long run > we should grow a generic implementation of dma_get_required_mask that > returns the dma mask required to avoid bounce buffering. > > Signed-off-by: Christoph

[PATCH v2 1/3] powerpc/32: Add ioremap_wt()

Other arches have ioremap_wt() to map IO areas write-through. Implement it on PPC as well in order to avoid drivers using __ioremap(_PAGE_WRITETHRU) Signed-off-by: Christophe Leroy --- v2: no change arch/powerpc/include/asm/io.h | 6 ++ arch/powerpc/mm/pgtable_32.c | 8 2 files c

[PATCH v2 2/3] drivers/video/fbdev: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- v2: removed unnecessary includes headers drivers/video/fbdev/controlfb.c | 5 + drivers/video/fbdev/platinumfb.c | 5 + drivers/video/fbdev/valkyriefb.c | 12 ++-- 3 file

[PATCH v2 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- v2: no change drivers/block/z2ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index d0c5bc4e0703..cfbd70520eeb 1006

Re: [PATCH v2 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

On Mon, Aug 27, 2018 at 6:10 PM Christophe Leroy wrote: > _PAGE_WRITETHRU is a target specific flag. Prefer generic functions. > > Signed-off-by: Christophe Leroy >From a Zorro bus point of view: Acked-by: Geert Uytterhoeven > --- a/drivers/block/z2ram.c > +++ b/drivers/block/z2ram.c > @@ -190

Oops running iptables -F OUTPUT

I'm getting this Oops when running iptables -F OUTPUT: [ 91.139409] Unable to handle kernel paging request for data at address 0xd001fff12f34 [ 91.139414] Faulting instruction address: 0xd16a5718 [ 91.139419] Oops: Kernel access of bad area, sig: 11 [#1] [ 91.139426] BE SMP NR

FSL/NXP P5020: USB problems with the latest Git kernels

Hello, Our users tested the RC1 of kernel 4.19 on their P5020 boards today. Unfortunately the USB bug still exists. With mem values bigger than 4096M, the USB mouse and keyboard doesn’t work. With the bootarg mem=4096M, the USB devices work without any problems. Please compile the RC1 and test

Re: [RFC PATCH 11/11] powerpc/svm: Increase SWIOTLB buffer size

On Fri, Aug 24, 2018 at 01:25:35PM -0300, Thiago Jung Bauermann wrote: > From: Anshuman Khandual > > SWIOTLB buffer default size (64MB) is not enough for large sequential write > operations which eventually leads to kernel crash like here. > > virtio-pci :00:05.0: swiotlb buffer is full (sz:

[PATCH v9 0/5] powerpc/pseries: Machine check handler improvements.

This patch series includes some improvement to Machine check handler for pSeries. First 3 patches from v7 revision are already in powerpc next. Posting rest of the patches with review comments. This patch series drops the sysctl knob patch that was proposed in v7. The SLB recovery code now uses flu

[PATCH v9 2/5] powerpc/pseries: flush SLB contents on SLB MCE errors.

From: Mahesh Salgaonkar On pseries, as of today system crashes if we get a machine check exceptions due to SLB errors. These are soft errors and can be fixed by flushing the SLBs so the kernel can continue to function instead of system crash. We do this in real mode before turning on MMU. Otherwi

[PATCH v9 3/5] powerpc/pseries: Display machine check error details.

From: Mahesh Salgaonkar Extract the MCE error details from RTAS extended log and display it to console. With this patch you should now see mce logs like below: [ 142.371818] Severe Machine check interrupt [Recovered] [ 142.371822] NIP [dca301b8]: init_module+0x1b8/0x338 [bork_kernel

[PATCH v9 4/5] powerpc/pseries: Dump the SLB contents on SLB MCE errors.

From: Mahesh Salgaonkar If we get a machine check exceptions due to SLB errors then dump the current SLB contents which will be very much helpful in debugging the root cause of SLB errors. Introduce an exclusive buffer per cpu to hold faulty SLB entries. In real mode mce handler saves the old SLB

[PATCH v9 5/5] powernv/pseries: consolidate code for mce early handling.

From: Mahesh Salgaonkar Now that other platforms also implements real mode mce handler, lets consolidate the code by sharing existing powernv machine check early code. Rename machine_check_powernv_early to machine_check_common_early and reuse the code. Signed-off-by: Mahesh Salgaonkar --- arch

[PATCH v9 1/5] powerpc/pseries: Define MCE error event section.

From: Mahesh Salgaonkar On pseries, the machine check error details are part of RTAS extended event log passed under Machine check exception section. This patch adds the definition of rtas MCE event section and related helper functions. Signed-off-by: Mahesh Salgaonkar --- --- arch/powerpc/inc

Re: FSL/NXP P5020: USB problems with the latest Git kernels

On Mon, 2018-08-27 at 20:15 +0200, Christian Zigotzky wrote: > Hello, > > Our users tested the RC1 of kernel 4.19 on their P5020 boards today. > Unfortunately the USB bug still exists. With mem values bigger than 4096M, > the USB mouse and keyboard doesn’t work. With the bootarg mem=4096M, the USB

Re: [PATCH] treewide: remove current_text_addr

On 08/27/18 06:11, Peter Zijlstra wrote: > On Mon, Aug 27, 2018 at 05:26:53AM -0700, H. Peter Anvin wrote: > >> _THIS_IP_, however, is completely ill-defined, other than being an >> address *somewhere* in the same global function (not even necessarily >> the same function if the function is static

[PATCH] powerpc: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Arnd Bergmann Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Rob Herring --- arch/powerpc/p

[PATCH] i2c: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Peter Rosin Cc: linux-...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Rob

[PATCH] macintosh: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Rob Herring --- drivers/macintosh/macio_sysfs.c | 8 +++- drivers/macintosh/w

[PATCH] misc: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Frederic Barrat Cc: Andrew Donnellan Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Rob Herring --- drivers/misc/cxl/

[PATCH] soc: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Qiang Zhao Cc: Li Yang Cc: Andy Gross Cc: David Brown Cc: Heiko Stuebner Cc: Thierry Reding Cc: Jonathan Hunter Cc: Santosh Shilimkar Cc: linuxppc-dev@lists.o

[PATCH] tty: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linux-ser...@vger.kernel.org Cc: linuxppc-dev@lists.ozla

[PATCH] sound: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Johannes Berg Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: linuxppc-dev@lists.ozlabs.org Cc: alsa-de...@alsa-project.org Signed-off-by: Rob Herring --- sound/aoa/sou

[PATCH] ASoC: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Carlo Caione Cc: Kevin H

Re: [PATCH] misc: Convert to using %pOFn instead of device_node.name

On 28/08/18 11:52, Rob Herring wrote: In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Frederic Barrat Cc: Andrew Donnellan Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: linuxppc-dev@lists.ozlabs.org Signed-off

Re: Oops running iptables -F OUTPUT

On Mon, 27 Aug 2018 19:11:01 +0200 Andreas Schwab wrote: > I'm getting this Oops when running iptables -F OUTPUT: > > [ 91.139409] Unable to handle kernel paging request for data at address > 0xd001fff12f34 > [ 91.139414] Faulting instruction address: 0xd16a5718 > [ 91.139419]

Re: [PATCH] i2c: Convert to using %pOFn instead of device_node.name

On 2018-08-28 03:52, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Peter Rosin > Cc: linux-...@vger.kernel.o