[PATCH] powerpc: store the intended structure

2017-08-13 Thread Julia Lawall
Normally the values in the resource field and the argument to ARRAY_SIZE in the num_resources are the same. In this case, the value in the reousrce field is the same as the one in the previous platform_device structure, and appears to be a copy-paste error. Replace the value in the resource field

Re: [PATCH] powerpc: store the intended structure

2017-08-13 Thread Joe Perches
On Sun, 2017-08-13 at 15:24 +0200, Julia Lawall wrote: > Normally the values in the resource field and the argument to ARRAY_SIZE > in the num_resources are the same. In this case, the value in the reousrce > field is the same as the one in the previous platform_device structure, and > appears to

Re: [PATCH] powerpc: store the intended structure

2017-08-13 Thread Julia Lawall
On Sun, 13 Aug 2017, Joe Perches wrote: > On Sun, 2017-08-13 at 15:24 +0200, Julia Lawall wrote: > > Normally the values in the resource field and the argument to ARRAY_SIZE > > in the num_resources are the same. In this case, the value in the reousrce > > field is the same as the one in the pr

qustion about eeh_add_virt_device

2017-08-13 Thread Julia Lawall
Hello, At the suggestion of Christoph Hellwig, I am working on inlining the functions stored in the err_handler field of a pci_driver structure into the pci_driver structure itself. A number of functions in the file arch/powerpc/kernel/eeh_driver.c have code like: if (!driver->err_handle

Re: [PATCH 2/2] powerpc/powernv/npu: Don't explicitly flush nmmu tlb

2017-08-13 Thread kbuild test robot
-tlb-flush-before-launching-ATSD/20170813-211752 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com

Re: [PATCH 1/3] powerpc: simplify and fix VGA default device behaviour

2017-08-13 Thread Daniel Axtens
Hi Bjorn, Thanks for reading the patch and providing some feedback. >> This will work as intended if there is only one device, but if >> there are multiple devices, we may override the device the VGA >> arbiter picked. > > This quirk only runs on VGA class devices. If there's more than one > VGA

Re: [PATCH] powerpc/perf: double unlock bug in imc_common_cpuhp_mem_free()

2017-08-13 Thread Michael Ellerman
Dan Carpenter writes: > There is a typo so we call unlock instead of lock. > > Fixes: 885dcd709ba9 ("powerpc/perf: Add nest IMC PMU support") > Signed-off-by: Dan Carpenter > --- > I also don't understand how the &nest_imc_refc[node_id].lock works. Why > can't we use ref->lock everywhere? They

Re: [PATCH] powerpc/perf: double unlock bug in imc_common_cpuhp_mem_free()

2017-08-13 Thread Madhavan Srinivasan
On Saturday 12 August 2017 01:35 AM, Dan Carpenter wrote: There is a typo so we call unlock instead of lock. Reviewed-by: Madhavan Srinivasan nest_imc_refc used to maintain list of perf sessions thats using the nest units currently. This is needed in turning off nest engine microcode when n

Re: [PATCH] powerpc/perf: double unlock bug in imc_common_cpuhp_mem_free()

2017-08-13 Thread Madhavan Srinivasan
On Monday 14 August 2017 09:00 AM, Michael Ellerman wrote: Dan Carpenter writes: There is a typo so we call unlock instead of lock. Fixes: 885dcd709ba9 ("powerpc/perf: Add nest IMC PMU support") Signed-off-by: Dan Carpenter --- I also don't understand how the &nest_imc_refc[node_id].lock w

Re: [PATCH v6 01/17] powerpc/vas: Define macros, register fields and structures

2017-08-13 Thread Michael Ellerman
Sukadev Bhattiprolu writes: > Define macros for the VAS hardware registers and bit-fields as well > as couple of data structures needed by the VAS driver. > > Signed-off-by: Sukadev Bhattiprolu > --- > Changelog[v6] > - Add some fields for FTW windows > > Changelog[v4] > - [Michael N

Re: [PATCH v6 01/17] powerpc/vas: Define macros, register fields and structures

2017-08-13 Thread Nicholas Piggin
On Mon, 14 Aug 2017 15:21:48 +1000 Michael Ellerman wrote: > Sukadev Bhattiprolu writes: > > arch/powerpc/include/asm/vas.h | 35 > > arch/powerpc/include/uapi/asm/vas.h | 25 +++ > > I thought we weren't exposing VAS to userspace yet? > > If we are then we need to get things

Re: [PATCH v2 1/8] powerpc/xive: introduce a common routine xive_queue_page_alloc()

2017-08-13 Thread David Gibson
On Fri, Aug 11, 2017 at 04:23:34PM +0200, Cédric Le Goater wrote: > This routine will be used in the spapr backend. Also introduce a short > xive_alloc_order() helper. > > Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson > --- > arch/powerpc/sysdev/xive/common.c| 16 +

Re: [PATCH v2 2/8] powerpc/xive: guest exploitation of the XIVE interrupt controller

2017-08-13 Thread David Gibson
On Fri, Aug 11, 2017 at 04:23:35PM +0200, Cédric Le Goater wrote: > This is the framework for using XIVE in a PowerVM guest. The support > is very similar to the native one in a much simpler form. > > Instead of OPAL calls, a set of Hypervisors call are used to configure > the interrupt sources an

Re: [PATCH] powerpc/64s: Add support for ASB_Notify on POWER9

2017-08-13 Thread Michael Neuling
On Sat, 2017-08-05 at 14:28 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2017-08-04 at 16:56 +0200, Christophe Lombard wrote: > > The POWER9 core supports a new feature: ASB_Notify which requires the > > support of the Special Purpose Register: TIDR. > > > > The ASB_Notify command, generated by

Re: [PATCH v6 16/17] powerpc/vas: Implement a simple FTW driver

2017-08-13 Thread Michael Ellerman
Hi Suka, Some comments inline ... Sukadev Bhattiprolu writes: > The Fast Thread Wake-up (FTW) driver provides user space applications an > interface to the Core-to-Core functionality in POWER9. The driver provides > the device node/ioctl API to applications and uses the external interfaces > t