On Dez 28 2016, "Harisangam, Sharvari (S.)"
wrote:
> + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
> + SND_SOC_DAIFMT_AC97;
This is never true.
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4
Andreas Schwab wrote:
> + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
> + SND_SOC_DAIFMT_AC97;
This is never true.
I think the right parenthesis should be at the end of the expression.
On Dez 28 2016, Timur Tabi wrote:
> Andreas Schwab wrote:
>>> > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
>>> > + SND_SOC_DAIFMT_AC97;
>> This is never true.
>
> I think the right parenthesis should be at the end of the expression.
That would still test the wrong bitfiel
On Wed, Dec 28, 2016 at 9:06 AM, Harisangam, Sharvari (S.)
wrote:
> Corrected the condition to check if ssi is configured for AC97
> mode. Other modes like dsp_a also satisfy the ANDing condition.
>
> Signed-off-by: Sharvari Harisangam
This has been fixed in 4.3 kernel by commit:
5b64c173cdea
Corrected the condition to check if ssi is configured for AC97
mode. Other modes like dsp_a also satisfy the ANDing condition.
Signed-off-by: Sharvari Harisangam
---
sound/soc/fsl/fsl_ssi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound
On Wed, Dec 28, 2016 at 03:50:57PM +0100, Andreas Schwab wrote:
> On Dez 28 2016, "Harisangam, Sharvari (S.)"
> wrote:
>
> > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
> > + SND_SOC_DAIFMT_AC97;
>
> This is never true.
>
> Andreas.
>
> --
> Andreas Schwab, sch...@
