Re: [RFC PATCH 4/9] powerpc/mm/book3s-64: Move _PAGE_PRESENT to the most significant bit

2016-02-20 Thread kbuild test robot
-Restructure-Linux-PTE-on-Book3S-64-to-radix-format/20160220-143050 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-allmodconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin

Re: Problems with THP in v4.5-rc4 on POWER

2016-02-20 Thread Aneesh Kumar K.V
Paul Mackerras writes: > On Sat, Feb 20, 2016 at 12:39:42PM +1100, Paul Mackerras wrote: >> It seems there's something wrong with our transparent hugepage >> implementation on POWER server processors as of v4.5-rc4. I have seen >> the email thread on "[BUG] random kernel crashes after THP rework

Re: [PATCH] powerpc/mm/hash: Clear the invalid slot information correctly

2016-02-20 Thread Aneesh Kumar K.V
Michael Ellerman writes: > On Fri, 2016-02-19 at 11:23 +0530, Anshuman Khandual wrote: >> On 02/18/2016 10:14 PM, Aneesh Kumar K.V wrote: >> > We can get a hash pte fault with 4k base page size and find the pte >> > already inserted with 64K base page size. In that case we need to clear > ... >>

Re: [PATCH] powerpc/mm/hash: Clear the invalid slot information correctly

2016-02-20 Thread Aneesh Kumar K.V
Balbir Singh writes: ... >> diff --git a/arch/powerpc/mm/hugepage-hash64.c >> b/arch/powerpc/mm/hugepage-hash64.c >> index 49b152b0f926..8424f46c2bf7 100644 >> --- a/arch/powerpc/mm/hugepage-hash64.c >> +++ b/arch/powerpc/mm/hugepage-hash64.c >> @@ -78,9 +78,14 @@ int __has

Re: [RFC PATCH 0/9] powerpc/mm: Restructure Linux PTE on Book3S/64 to radix format

2016-02-20 Thread Aneesh Kumar K.V
Paul Mackerras writes: > This patch series modifies the Linux PTE format used on 64-bit Book3S > processors (i.e. POWER server processors) to make the bits line up > with the PTE format used in the radix trees defined in PowerISA v3.0. > This will reduce the amount of further change required to m

[PATCH V2] powerpc/mm/hash: Clear the invalid slot information correctly

2016-02-20 Thread Aneesh Kumar K.V
We can get a hash pte fault with 4k base page size and find the pte already inserted with 64K base page size. In that case we need to clear the existing slot information from the old pte. Fix this correctly With THP, we also clear the slot information with respect to all the 64K hash pte mapping t

Re: [PATCH] powerpc/mm/hash: Clear the invalid slot information correctly

2016-02-20 Thread Aneesh Kumar K.V
Anshuman Khandual writes: > On 02/18/2016 10:14 PM, Aneesh Kumar K.V wrote: >> We can get a hash pte fault with 4k base page size and find the pte >> already inserted with 64K base page size. In that case we need to clear > > Can you please elaborate on this ? What are those situations when we >

Re: [RFC PATCH 0/9] powerpc/mm: Restructure Linux PTE on Book3S/64 to radix format

2016-02-20 Thread Aneesh Kumar K.V
"Aneesh Kumar K.V" writes: > Paul Mackerras writes: > >> This patch series modifies the Linux PTE format used on 64-bit Book3S >> processors (i.e. POWER server processors) to make the bits line up >> with the PTE format used in the radix trees defined in PowerISA v3.0. >> This will reduce the am

Re: [RFC PATCH 2/9] powerpc/mm/book3s-64: Free up 7 high-order bits in the Linux PTE

2016-02-20 Thread Aneesh Kumar K.V
Paul Mackerras writes: > This frees up bits 57-63 in the Linux PTE on 64-bit Book 3S machines. > In the 4k page case, this is done just by reducing the size of the > RPN field to 39 bits, giving 51-bit real addresses. In the 64k page > case, we had 10 unused bits in the middle of the PTE, so thi

Re: [RFC PATCH 3/9] powerpc/mm/64: Use physical addresses in upper page table tree levels

2016-02-20 Thread Aneesh Kumar K.V
Paul Mackerras writes: > This changes the Linux page tables to store physical addresses > rather than kernel virtual addresses in the upper levels of the > tree (pgd, pud and pmd) for all 64-bit machines. > > This frees up some high order bits, and will be needed with book3s > PowerISA v3.0 machi

Re: [RFC PATCH 4/9] powerpc/mm/book3s-64: Move _PAGE_PRESENT to the most significant bit

2016-02-20 Thread Aneesh Kumar K.V
Paul Mackerras writes: > This changes _PAGE_PRESENT for 64-bit Book 3S processors from 0x2 to > 0x8000___, because that is where PowerISA v3.0 CPUs in > radix mode will expect to find it. All the changes in this patch related to _PAGE_PRESENT movement or are they cleanup that got add

powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies

2016-02-20 Thread Ben Hutchings
Soft dirty bit support was only implemented for 64-bit Book3S, and 32-bit configurations currently fail to build. Fixes: 7207f43665b8 ("powerpc/mm: Add page soft dirty tracking") References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=powerpc&ver=4.5%7Erc4-1%7Eexp1&stamp=1455791718

Re: [PATCH V3 01/30] mm: Make vm_get_page_prot arch specific.

2016-02-20 Thread Benjamin Herrenschmidt
On Fri, 2016-02-19 at 08:10 +0530, Aneesh Kumar K.V wrote: > > I was hoping to do that after this series. Something similar to > > https://github.com/kvaneesh/linux/commit/0c2ac1328b678a6e187d1f2644a007204c59a047 > > " > powerpc/mm: Add helper for page flag access in ioremap_at > > Instead of u

Re: [RFC PATCH 7/9] powerpc/mm/book3s-64: Shuffle read, write, execute and user bits in PTE

2016-02-20 Thread Aneesh Kumar K.V
Paul Mackerras writes: > This moves the _PAGE_EXEC, _PAGE_RW and _PAGE_USER bits around in > the Linux PTE on 64-bit Book 3S systems to correspond with the bit > positions used in radix mode by PowerISA v3.0 CPUs. This also adds > a _PAGE_READ bit corresponding to the read permission bit in the

Re: [RFC PATCH 0/9] powerpc/mm: Restructure Linux PTE on Book3S/64 to radix format

2016-02-20 Thread Aneesh Kumar K.V
"Aneesh Kumar K.V" writes: > Paul Mackerras writes: > >> This patch series modifies the Linux PTE format used on 64-bit Book3S >> processors (i.e. POWER server processors) to make the bits line up >> with the PTE format used in the radix trees defined in PowerISA v3.0. >> This will reduce the am