Re: [PATCH] ibmvfc: byteswap scsi_id, wwpn, and node_name prior to logging

2016-02-12 Thread Johannes Thumshirn
On Thu, Feb 11, 2016 at 04:24:35PM -0600, Tyrel Datwyler wrote: > When logging async events the scsi_id, wwpn, and node_name values > are used directly from the CRQ struct which are of type __be64. This > can be confusing to someone looking through the log on a LE system. > Instead byteswap these v

Re: [PATCH v5] powerpc32: provide VIRT_CPU_ACCOUNTING

2016-02-12 Thread Denis Kirjanov
On 2/11/16, Christophe Leroy wrote: > This patch provides VIRT_CPU_ACCOUTING to PPC32 architecture. > PPC32 doesn't have the PACA structure, so we use the task_info > structure to store the accounting data. > > In order to reuse on PPC32 the PPC64 functions, all u64 data has > been replaced by 'un

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Will Deacon
On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote: > On Thu, 11 Feb 2016 21:09:42 +0200 > "Kirill A. Shutemov" wrote: > > On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: > > > Sebastian Ott reported random kernel crashes beginning with v4.5-rc1 and > > > he also bise

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Sebastian Ott
On Fri, 12 Feb 2016, Will Deacon wrote: > On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote: > > On Thu, 11 Feb 2016 21:09:42 +0200 > > "Kirill A. Shutemov" wrote: > > > On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: > > > > Sebastian Ott reported random kernel cras

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Gerald Schaefer
On Fri, 12 Feb 2016 09:34:33 +0530 "Aneesh Kumar K.V" wrote: > Gerald Schaefer writes: > > > On Thu, 11 Feb 2016 21:09:42 +0200 > > "Kirill A. Shutemov" wrote: > > > >> On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: > >> > Hi, > >> > > >> > Sebastian Ott reported random kern

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Sebastian Ott
On Thu, 11 Feb 2016, Kirill A. Shutemov wrote: > On Thu, Feb 11, 2016 at 09:09:42PM +0200, Kirill A. Shutemov wrote: > > On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: > > > Hi, > > > > > > Sebastian Ott reported random kernel crashes beginning with v4.5-rc1 and > > > he also bis

Re: [PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-12 Thread Manoj Kumar
Tyrel: Thanks for incorporating the suggestions. Reviewed-by: Manoj Kumar --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: The PAPR defines four valid header values for the first byte of a CRQ message. Namely, an unused/empty message (0x00), a valid command/response entry (0x80),

Re: [PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums

2016-02-12 Thread Manoj Kumar
Reviewed-by: Manoj Kumar --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are off by one. They are currently defined as 0x06 and 0x07 respetively. These values are defined in PAPR correctly as 0x05 and 0x06. This inco

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Kirill A. Shutemov
On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote: > On Thu, 11 Feb 2016 21:09:42 +0200 > "Kirill A. Shutemov" wrote: > > > On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: > > > Hi, > > > > > > Sebastian Ott reported random kernel crashes beginning with v4.5-rc1 an

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Will Deacon
On Fri, Feb 12, 2016 at 11:12:34AM +0100, Sebastian Ott wrote: > On Fri, 12 Feb 2016, Will Deacon wrote: > > On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote: > > > On Thu, 11 Feb 2016 21:09:42 +0200 > > > "Kirill A. Shutemov" wrote: > > > > On Thu, Feb 11, 2016 at 07:22:23PM +0100,

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Christian Borntraeger
On 02/12/2016 04:41 PM, Kirill A. Shutemov wrote: > On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote: >> On Thu, 11 Feb 2016 21:09:42 +0200 >> "Kirill A. Shutemov" wrote: >> >>> On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: Hi, Sebastian Ott reporte

Re: [PATCH v8 8/8] livepatch: Detect offset for the ftrace location during build

2016-02-12 Thread Balbir Singh
On Thu, 2016-01-28 at 16:32 +0100, Torsten Duwe wrote: > From: Petr Mladek > > Livepatch works on x86_64 and s390 only when the ftrace call > is at the very beginning of the function. But PPC is different. > We need to handle TOC and save LR there before calling the > global ftrace handler. > >

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Aneesh Kumar K.V
Gerald Schaefer writes: > On Fri, 12 Feb 2016 09:34:33 +0530 > "Aneesh Kumar K.V" wrote: > >> Gerald Schaefer writes: >> >> > On Thu, 11 Feb 2016 21:09:42 +0200 >> > "Kirill A. Shutemov" wrote: >> > >> >> On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: >> >> > Hi, >> >> > >>

Re: [PATCH v8 8/8] livepatch: Detect offset for the ftrace location during build

2016-02-12 Thread Petr Mladek
On Sat 2016-02-13 03:13:29, Balbir Singh wrote: > On Thu, 2016-01-28 at 16:32 +0100, Torsten Duwe wrote: > > From: Petr Mladek > > > > Livepatch works on x86_64 and s390 only when the ftrace call > > is at the very beginning of the function. But PPC is different. > > We need to handle TOC and sav

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread James Bottomley
On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote: > Add defines for mad version and mad os_type, and replace the magic > numbers in set_adapter_info() accordingly. > > Signed-off-by: Tyrel Datwyler > --- Is there some reason you didn't carry the review tag over from this: http://mid.gman

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread Tyrel Datwyler
On 02/12/2016 08:43 AM, James Bottomley wrote: > On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote: >> Add defines for mad version and mad os_type, and replace the magic >> numbers in set_adapter_info() accordingly. >> >> Signed-off-by: Tyrel Datwyler >> --- > > Is there some reason you did

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread James Bottomley
On Fri, 2016-02-12 at 08:51 -0800, Tyrel Datwyler wrote: > On 02/12/2016 08:43 AM, James Bottomley wrote: > > On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote: > > > Add defines for mad version and mad os_type, and replace the > > > magic > > > numbers in set_adapter_info() accordingly. > >

Re: [PATCH v2 0/7] ibmvscsi code cleanup

2016-02-12 Thread Martin K. Petersen
> "Tyrel" == Tyrel Datwyler writes: Tyrel> Fixed up a couple spots that were out of line with the PAPR in Tyrel> regards to its defined VSCSI protocol. Did away with some magic Tyrel> numbers directly in the code. Fixed a minor endian issue. Applied to 4.6/scsi-queue. (And added the missing

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread Martin K. Petersen
> "James" == James Bottomley writes: James> OK we need a re-review then ... I'll hold off pushing for now. -- Martin K. Petersen Oracle Linux Engineering ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/li

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Gerald Schaefer
On Fri, 12 Feb 2016 16:57:27 +0100 Christian Borntraeger wrote: > On 02/12/2016 04:41 PM, Kirill A. Shutemov wrote: > > On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote: > >> On Thu, 11 Feb 2016 21:09:42 +0200 > >> "Kirill A. Shutemov" wrote: > >> > >>> On Thu, Feb 11, 2016 at 07:

Re: [PATCH] mtd/ifc: Add support for IFC controller version 2.0

2016-02-12 Thread Brian Norris
On Thu, Feb 04, 2016 at 05:07:16PM -0600, Li Yang wrote: > On Wed, Feb 3, 2016 at 12:36 AM, Raghav Dogra wrote: > > The new IFC controller version 2.0 has a different memory map page. > > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB. > > This patch segregates the IFC global and

Re: [PATCH] mtd/ifc: Add support for IFC controller version 2.0

2016-02-12 Thread Scott Wood
On Fri, 2016-02-12 at 11:44 -0800, Brian Norris wrote: > On Thu, Feb 04, 2016 at 05:07:16PM -0600, Li Yang wrote: > > On Wed, Feb 3, 2016 at 12:36 AM, Raghav Dogra > > wrote: > > > The new IFC controller version 2.0 has a different memory map page. > > > Upto IFC 1.4 PAGE size is 4 KB and from IFC

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread Manoj Kumar
Reviewed-by: Manoj Kumar --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: Add defines for mad version and mad os_type, and replace the magic numbers in set_adapter_info() accordingly. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 drivers/scsi

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Kirill A. Shutemov
On Fri, Feb 12, 2016 at 06:16:40PM +0100, Gerald Schaefer wrote: > On Fri, 12 Feb 2016 16:57:27 +0100 > Christian Borntraeger wrote: > > > On 02/12/2016 04:41 PM, Kirill A. Shutemov wrote: > > > On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote: > > >> On Thu, 11 Feb 2016 21:09:42 +

Re: [PATCH v8 8/8] livepatch: Detect offset for the ftrace location during build

2016-02-12 Thread Balbir Singh
On Fri, 2016-02-12 at 17:45 +0100, Petr Mladek wrote: > On Sat 2016-02-13 03:13:29, Balbir Singh wrote: > > On Thu, 2016-01-28 at 16:32 +0100, Torsten Duwe wrote: > > > From: Petr Mladek > > > > > > Livepatch works on x86_64 and s390 only when the ftrace call > > > is at the very beginning of the

Re: [PATCH V2 01/29] powerpc/mm: add _PAGE_HASHPTE similar to 4K hash

2016-02-12 Thread Aneesh Kumar K.V
Paul Mackerras writes: > On Mon, Feb 08, 2016 at 02:50:13PM +0530, Aneesh Kumar K.V wrote: >> Not really needed. But this brings it back to as it was before > > If it's not really needed, what's the motivation for putting this > patch in? You need to explain where you are heading with this patch

Re: [PATCH V2 02/29] powerpc/mm: Split pgtable types to separate header

2016-02-12 Thread Aneesh Kumar K.V
Paul Mackerras writes: > On Mon, Feb 08, 2016 at 02:50:14PM +0530, Aneesh Kumar K.V wrote: >> We remove real_pte_t out of STRICT_MM_TYPESCHECK. We will later add >> a radix variant that is big endian >> >> Signed-off-by: Aneesh Kumar K.V > > It looks like most of what this patch does is move a

Re: [PATCH V2 00/29] Book3s abstraction in preparation for new MMU model

2016-02-12 Thread Aneesh Kumar K.V
Paul Mackerras writes: > On Mon, Feb 08, 2016 at 02:50:12PM +0530, Aneesh Kumar K.V wrote: >> Hello, >> >> This is a large series, mostly consisting of code movement. No new features >> are done in this series. The changes are done to accomodate the upcoming new >> memory >> model in future pow