Re: [PATCH] hwrng: pseries - port to new read API and fix stack corruption

2014-10-31 Thread Michael Ellerman
On Fri, 2014-10-31 at 07:50 +0100, Greg Kurz wrote: > The add_early_randomness() function in drivers/char/hw_random/core.c passes > a 16-byte buffer to pseries_rng_data_read(). Unfortunately, plpar_hcall() > returns four 64-bit values and trashes 16 bytes on the stack. Hmm, thanks. I thought I'd f

RE: [PATCH v3 1/3] QE: move qe code from arch/powerpc to drivers/soc

2014-10-31 Thread qiang.z...@freescale.com
On Oct 30, 2014, at 9:37 AM, Kumar Gala wrote: > -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Thursday, October 30, 2014 9:37 PM > To: Zhao Qiang-B45475 > Cc: linuxppc-dev@lists.ozlabs.org; linux-ker...@vger.kernel.org; Wood > Scott-B07421; Xie Xiaobo-R

Re: FSL MSI Mapping

2014-10-31 Thread Johannes Thumshirn
On Thu, Oct 30, 2014 at 02:51:57PM +1100, Michael Ellerman wrote: > On Tue, 2014-10-28 at 18:06 +0100, Johannes Thumshirn wrote: > > Hi, > > > > I got notified about your patch to support multiple MSI Vectors on Freescale > > PowerPC platforms. Is there any reason why it wasn't applied until now? I

Re: [PATCH] hwrng: pseries - port to new read API and fix stack corruption

2014-10-31 Thread Greg Kurz
On Fri, 31 Oct 2014 18:00:12 +1100 Michael Ellerman wrote: > On Fri, 2014-10-31 at 07:50 +0100, Greg Kurz wrote: > > The add_early_randomness() function in drivers/char/hw_random/core.c passes > > a 16-byte buffer to pseries_rng_data_read(). Unfortunately, plpar_hcall() > > returns four 64-bit va

Re: [PATCH] hwrng: pseries - port to new read API and fix stack corruption

2014-10-31 Thread Herbert Xu
On Fri, Oct 31, 2014 at 10:31:41AM +0100, Greg Kurz wrote: > > > > Cc'ing stable as I could reproduce back to 3.15.10 > > > > The right way to CC stable for a patch that isn't yet in upstream is to add: > > > > CC: sta...@vger.kernel.org > > > > Before your Signed-off-by. They will then pick it

Re: FSL MSI Mapping

2014-10-31 Thread Sebastian Andrzej Siewior
On 10/31/2014 09:12 AM, Johannes Thumshirn wrote: > On Thu, Oct 30, 2014 at 02:51:57PM +1100, Michael Ellerman wrote: >> Why would you not use MSI-X ? If I'm not mistaken, a PCI-E requirement is to support MSI but MSI-X is optional. And with MSI you can have multiple interrupts per single device (

Re: [PATCH 3/3] ipr: Wait for aborted command responses

2014-10-31 Thread Brian King
Adding Wendy... On 10/30/2014 05:27 PM, Brian King wrote: > Fixes a race condition in abort handling that was injected > when multiple interrupt support was added. When only a single > interrupt is present, the adapter guarantees it will send > responses for aborted commands prior to the response

Re: [PATCH 3/3] ipr: Wait for aborted command responses

2014-10-31 Thread wenxiong
I have reviewed the patch and it fixed the issue we saw in our environment recently. Thanks, Wendy Quoting Brian King : Adding Wendy... On 10/30/2014 05:27 PM, Brian King wrote: Fixes a race condition in abort handling that was injected when multiple interrupt support was added. When only

Re: [PATCH 0/2] ASoC: fsl: Use dynamic slot width for ESAI.

2014-10-31 Thread Mark Brown
On Fri, Oct 24, 2014 at 04:48:10PM -0700, Nicolin Chen wrote: > @Shengjiu, > Will you be available to test this series on Sabre Auto for both > Master and Slave cases? I'd like to wait for your Test-by. Thanks. Any ETA on the testing? signature.asc Description: Digital signature ___

Re: [PATCH 0/2] ASoC: fsl: Use dynamic slot width for ESAI.

2014-10-31 Thread Nicolin Chen
On Fri, Oct 31, 2014 at 06:12:24PM +, Mark Brown wrote: > On Fri, Oct 24, 2014 at 04:48:10PM -0700, Nicolin Chen wrote: > > > @Shengjiu, > > Will you be available to test this series on Sabre Auto for both > > Master and Slave cases? I'd like to wait for your Test-by. Thanks. > > Any ETA on t

[PATCH] powerpc: use device_online/offline() instead of cpu_up/down()

2014-10-31 Thread Dan Streetman
In powerpc pseries platform dlpar operations, Use device_online() and device_offline() instead of cpu_up() and cpu_down(). Calling cpu_up/down directly does not update the cpu device offline field, which is used to online/offline a cpu from sysfs. Calling device_online/offline instead keeps the s

[PATCH] powerpc: Replace cc constraint in inline assembly with cr0

2014-10-31 Thread Anton Blanchard
Our inline assembly only clobbers the first condition register field, but we mark all of them as being clobbered. This will cause LLVM to save and restore the non volatile condition register fields around the inline assembly, which is completely unnecessary. A simple example: void foo(void) {