The return value is unnecessary and unused, so make the functions
void instead of int.
Signed-off-by: Joe Perches
---
arch/powerpc/platforms/powernv/pci-ioda.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/p
printk calls should return void
Joe Perches (2):
powerpc: pci-ioda: Remove unnecessary return value from printk
powerpc: pci-ioda: Use a single function to emit logging messages
(compiled/untested)
arch/powerpc/platforms/powernv/pci-ioda.c | 61 +++
1 file change
No need for 3 functions when a single one will do.
Modify the function declaring macros to call the single function.
Reduces object code size a little:
$ size arch/powerpc/platforms/powernv/pci-ioda.o*
textdata bss dec hex filename
2230310736680 300567568
arch
> >+static void set_msi_irq_chip(struct pnv_phb *phb, unsigned int virq)
> >+{
> >+struct irq_data *idata;
> >+struct irq_chip *ichip;
> >+
> >+/*
> >+ * Change the IRQ chip for the MSI interrupts on PHB3.
> >+ * The corresponding IRQ chip should be populated for
> >+ * the
> >+struct device_node *pnv_pci_to_phb_node(struct pci_dev *dev)
> >+{
> >+struct device_node *np;
> >+struct property *prop = NULL;
> >+
> >+np = of_node_get(pci_device_to_OF_node(dev));
> >+
> >+/* Scan up the tree looking for the PHB node */
> >+while (np) {
> >+
On Sun, 2014-09-21 at 10:55 -0700, Joe Perches wrote:
> printk calls should return void
>
> Joe Perches (2):
> powerpc: pci-ioda: Remove unnecessary return value from printk
> powerpc: pci-ioda: Use a single function to emit logging messages
Patches look good to me.
Ben/Gavin, what do these
