Re: [PATCH] powerpc: irq work racing with timer interrupt can result in timer interrupt hang

2014-05-11 Thread Preeti U Murthy
On 05/11/2014 03:55 AM, Benjamin Herrenschmidt wrote: > On Sat, 2014-05-10 at 21:06 +0530, Preeti U Murthy wrote: >> On 05/10/2014 09:56 AM, Benjamin Herrenschmidt wrote: >>> On Fri, 2014-05-09 at 15:22 +0530, Preeti U Murthy wrote: in __timer_interrupt() outside the _else_ loop? This will ens

Re: [PATCH] powerpc: irq work racing with timer interrupt can result in timer interrupt hang

2014-05-11 Thread Benjamin Herrenschmidt
On Sun, 2014-05-11 at 13:45 +0530, Preeti U Murthy wrote: > + /* Don't adjust the decrementer if some irq work is pending > */ > + if (!test_irq_work_pending()) > + set_dec(evt); > + else > + set_dec(1); > > ^ your patch curr

Re: [PATCH] powerpc: irq work racing with timer interrupt can result in timer interrupt hang

2014-05-11 Thread Preeti U Murthy
On 05/11/2014 02:07 PM, Benjamin Herrenschmidt wrote: > On Sun, 2014-05-11 at 13:45 +0530, Preeti U Murthy wrote: >> + /* Don't adjust the decrementer if some irq work is pending >> */ >> + if (!test_irq_work_pending()) >> + set_dec(evt); >> + else >> +

Re: [PATCH] powerpc: irq work racing with timer interrupt can result in timer interrupt hang

2014-05-11 Thread Benjamin Herrenschmidt
On Sun, 2014-05-11 at 14:13 +0530, Preeti U Murthy wrote: > > Isn't this patch required too? > > @@ -503,12 +503,13 @@ void __timer_interrupt(void) > now = *next_tb - now; > if (now <= DECREMENTER_MAX) > set_dec((int)now); > -

Re: [PATCH] powerpc: irq work racing with timer interrupt can result in timer interrupt hang

2014-05-11 Thread Preeti U Murthy
On 05/11/2014 02:33 PM, Benjamin Herrenschmidt wrote: > On Sun, 2014-05-11 at 14:13 +0530, Preeti U Murthy wrote: >> >> Isn't this patch required too? >> >> @@ -503,12 +503,13 @@ void __timer_interrupt(void) >> now = *next_tb - now; >> if (now <= DECREMENTER_MAX) >>

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-11 Thread Wilfried Klaebe
Am Sun, May 11, 2014 at 01:13:47PM +0530 schrieb Anish Khurana: > SET_ETHTOOL_OPS is equivalent to : > #define SET_ETHTOOL_OPS(netdev,ops) \ > ( (netdev)->ethtool_ops = (ops) ) > > how it makes difference removing this code and replacing with the > code mentioned ? It doesn't change anything

Re: linux-next: add scottwood/linux.git

2014-05-11 Thread Stephen Rothwell
Hi Scott, On Fri, 9 May 2014 16:15:33 -0500 Scott Wood wrote: > > On Mon, 2014-03-24 at 20:09 -0500, Scott Wood wrote: > > On Mon, 2014-03-24 at 10:33 +1100, Benjamin Herrenschmidt wrote: > > > On Mon, 2014-03-24 at 10:16 +1100, Benjamin Herrenschmidt wrote: > > > > On Wed, 2014-03-19 at 23:25 -0

Re: linux-next: add scottwood/linux.git

2014-05-11 Thread Stephen Rothwell
Hi Scott, On Mon, 12 May 2014 08:23:36 +1000 Stephen Rothwell wrote: > > On Fri, 9 May 2014 16:15:33 -0500 Scott Wood wrote: > > > > On Mon, 2014-03-24 at 20:09 -0500, Scott Wood wrote: > > > On Mon, 2014-03-24 at 10:33 +1100, Benjamin Herrenschmidt wrote: > > > > On Mon, 2014-03-24 at 10:16 +1

Re: [PATCH] powerpc: fix skipping call to early_init_fdt_scan_reserved_mem

2014-05-11 Thread Benjamin Herrenschmidt
On Wed, 2014-04-30 at 01:03 -0500, Rob Herring wrote: > From: Rob Herring > > The call to early_init_fdt_scan_reserved_mem will be skipped if > reserved-ranges is not found. Move the call earlier so that it is called > unconditionally. > > Signed-off-by: Rob Herring > Cc: Marek Szyprowski Ack

Re: [PATCH] powerpc: reduce multi-hit of pcibios_setup_device() in hotplug

2014-05-11 Thread Benjamin Herrenschmidt
On Thu, 2014-05-08 at 14:30 +0800, Wei Yang wrote: > During the EEH hotplug event, pcibios_setup_device() will be invoked two > times. And the last time will trigger a warning of re-attachment of iommu > group. > > The two times are: > > pci_device_add > ... > pcibios_add_devi

Re: [PATCH] powerpc: Fix "attempt to move .org backwards" error (again)

2014-05-11 Thread Benjamin Herrenschmidt
On Fri, 2014-05-09 at 17:07 -0700, Guenter Roeck wrote: > Commit 4e243b7 (powerpc: Fix "attempt to move .org backwards" error) fixes the > allyesconfig build by moving machine_check_common to a different location. > While this fixes most of the errors, both allmodconfig and allyesconfig still > fai

Re: [PATCH] powerpc: Fix "attempt to move .org backwards" error (again)

2014-05-11 Thread Guenter Roeck
On 05/11/2014 09:12 PM, Benjamin Herrenschmidt wrote: On Fri, 2014-05-09 at 17:07 -0700, Guenter Roeck wrote: Commit 4e243b7 (powerpc: Fix "attempt to move .org backwards" error) fixes the allyesconfig build by moving machine_check_common to a different location. While this fixes most of the err

Re: [PATCH] powerpc: Fix "attempt to move .org backwards" error (again)

2014-05-11 Thread Benjamin Herrenschmidt
On Mon, 2014-05-12 at 14:12 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2014-05-09 at 17:07 -0700, Guenter Roeck wrote: > > Commit 4e243b7 (powerpc: Fix "attempt to move .org backwards" error) fixes > > the > > allyesconfig build by moving machine_check_common to a different location. > > While

Re: [PATCH] powerpc: Fix "attempt to move .org backwards" error (again)

2014-05-11 Thread Guenter Roeck
On 05/11/2014 10:37 PM, Benjamin Herrenschmidt wrote: On Mon, 2014-05-12 at 14:12 +1000, Benjamin Herrenschmidt wrote: On Fri, 2014-05-09 at 17:07 -0700, Guenter Roeck wrote: Commit 4e243b7 (powerpc: Fix "attempt to move .org backwards" error) fixes the allyesconfig build by moving machine_chec

Re: [PATCH] powerpc: Fix "attempt to move .org backwards" error (again)

2014-05-11 Thread Benjamin Herrenschmidt
On Sun, 2014-05-11 at 21:52 -0700, Guenter Roeck wrote: > Oh well, it was worth a try. Can you give me an example for a failing > configuration ? My g5 config which is close to g5_defconfig with PR KVM enabled. In any case, see my other messages. I'm waiting for all my test builders to come back

[PATCH] powerpc/ppc64: Allow allmodconfig to build (finally !)

2014-05-11 Thread Benjamin Herrenschmidt
This shuffles code around in exceptions-64s.S in order to allow an allmodconfig build to succeed. The main problems were: - We have a fixed hole from 0x7000 to 0x8000 for use by FW, under some circumstances the code before that would grow too big and hit the . = 0x7000 - The various attempts a