Re: [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

2014-04-03 Thread Hongbo Zhang
On 04/03/2014 12:35 AM, Vinod Koul wrote: On Mon, Mar 31, 2014 at 12:08:55PM +0800, Hongbo Zhang wrote: On 03/29/2014 09:45 PM, Vinod Koul wrote: On Fri, Mar 28, 2014 at 02:33:37PM +0800, Hongbo Zhang wrote: On 03/26/2014 03:01 PM, Vinod Koul wrote: On Thu, 2014-01-16 at 13:47 +0800, hongbo.

RE: [PATCH] cpuidle: add freescale e500 family porcessors idle support

2014-04-03 Thread dongsheng.w...@freescale.com
> -Original Message- > From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] > Sent: Thursday, April 03, 2014 2:29 PM > To: Wang Dongsheng-B40534; Wood Scott-B07421 > Cc: r...@rjwysocki.net; Li Yang-Leo-R58472; Jin Zhengxiong-R64188; Zhao > Chenhui- > B35336; linux...@vger.kernel.org;

Re: [PATCH 3/7] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

2014-04-03 Thread Hongbo Zhang
On 03/28/2014 11:44 AM, Hongbo Zhang wrote: On 03/11/2014 07:06 PM, Vinod Koul wrote: On Thu, Jan 16, 2014 at 01:47:22PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang There are several places where descriptors are freed using identical code. This patch puts this code into a

Re: [PATCH] cpuidle: add freescale e500 family porcessors idle support

2014-04-03 Thread Daniel Lezcano
On 04/03/2014 10:03 AM, dongsheng.w...@freescale.com wrote: -Original Message- From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] Sent: Thursday, April 03, 2014 2:29 PM To: Wang Dongsheng-B40534; Wood Scott-B07421 Cc: r...@rjwysocki.net; Li Yang-Leo-R58472; Jin Zhengxiong-R64188;

Re: [PATCH] power, sched: stop updating inside arch_update_cpu_topology() when nothing to be update

2014-04-03 Thread Srivatsa S. Bhat
On 04/02/2014 08:59 AM, Michael wang wrote: > During the testing, we encounter below WARN followed by Oops: > > WARNING: at kernel/sched/core.c:6218 > ... > NIP [c0101660] .build_sched_domains+0x11d0/0x1200 > LR [c0101358] .build_sched_domains+0xec8/0x1200 >

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread zhuyj
Hi, Claudiu Please help to review this patch. This patch is for kernel 2.6.x. Thanks a lot. Hi, Willy Please help to merge this patch to longterm: 2.6.32.61 since this problem also occurs on this kernel. Thanks a lot. Based on kernel 2.6.x, gianfar nic driver can not work well. The root c

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread Willy Tarreau
Hi Zhu, On Thu, Apr 03, 2014 at 05:11:48PM +0800, zhuyj wrote: > Hi, Claudiu > > Please help to review this patch. This patch is for kernel 2.6.x. Thanks > a lot. > > Hi, Willy > > Please help to merge this patch to longterm: 2.6.32.61 since this > problem also occurs on this kernel. Thanks a

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread zhuyj
On 04/03/2014 05:27 PM, Willy Tarreau wrote: Hi Zhu, On Thu, Apr 03, 2014 at 05:11:48PM +0800, zhuyj wrote: Hi, Claudiu Please help to review this patch. This patch is for kernel 2.6.x. Thanks a lot. Hi, Willy Please help to merge this patch to longterm: 2.6.32.61 since this problem also occ

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread Willy Tarreau
Hi Zhu, On Thu, Apr 03, 2014 at 05:57:53PM +0800, zhuyj wrote: > I reference the following 2 mainline commits. These 2 commits are based > on the current kernel 3.x and ethtool. > If we only backport these 2 commits on kernel 2.6.x, this problem will > not be fixed yet. OK fine, I just wanted t

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread zhuyj
On 04/03/2014 05:27 PM, Willy Tarreau wrote: Hi Zhu, On Thu, Apr 03, 2014 at 05:11:48PM +0800, zhuyj wrote: Hi, Claudiu Please help to review this patch. This patch is for kernel 2.6.x. Thanks a lot. Hi, Willy Please help to merge this patch to longterm: 2.6.32.61 since this problem also occ

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread zhuyj
On 04/03/2014 06:01 PM, Willy Tarreau wrote: Hi Zhu, On Thu, Apr 03, 2014 at 05:57:53PM +0800, zhuyj wrote: I reference the following 2 mainline commits. These 2 commits are based on the current kernel 3.x and ethtool. If we only backport these 2 commits on kernel 2.6.x, this problem will not b

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread Willy Tarreau
On Thu, Apr 03, 2014 at 06:15:25PM +0800, zhuyj wrote: > Hi, Willy > > I made a new patch. In long commit message, I inserted the equivalent > mainline commit > about this feature. Maybe it is better. Now this patch is in the > attachment. Please check > and merge it into kernel 2.6.32.62. Sure

Re: [PATCH RFC v10 0/6] MPC512x DMA slave s/g support, OF DMA lookup

2014-04-03 Thread Alexander Popov
Hello, 2014-03-20 18:47 GMT+04:00 Alexander Popov : > Changes in v10: > Part 2/6: > - don't use direction field of dma_slave_config in mpc_dma_device_control() > but store settings in mpc_dma_chan for both DMA_DEV_TO_MEM and > DMA_MEM_TO_DEV cases; then retrieve the needed values in >

Re: [PATCH v2] powernv: kvm: make _PAGE_NUMA take effect

2014-04-03 Thread Alexander Graf
On 03.04.14 04:36, Liu ping fan wrote: Hi Alex, could you help to pick up this patch? since v3.14 kernel can enable numa fault for powerpc. What bad happens without this patch? We map a page even though it was declared to get NUMA migrated? What happens next? I'm trying to figure out wheth

Re: [PATCH v2] powernv: kvm: make _PAGE_NUMA take effect

2014-04-03 Thread Alexander Graf
On 03.04.14 13:36, Alexander Graf wrote: On 03.04.14 04:36, Liu ping fan wrote: Hi Alex, could you help to pick up this patch? since v3.14 kernel can enable numa fault for powerpc. What bad happens without this patch? We map a page even though it was declared to get NUMA migrated? What hap

Re: [PATCH v2] powernv: kvm: make _PAGE_NUMA take effect

2014-04-03 Thread Alexander Graf
On 03.04.14 13:38, Alexander Graf wrote: On 03.04.14 13:36, Alexander Graf wrote: On 03.04.14 04:36, Liu ping fan wrote: Hi Alex, could you help to pick up this patch? since v3.14 kernel can enable numa fault for powerpc. What bad happens without this patch? We map a page even though it w

cscope: issue with symlinks in tools/testing/selftests/powerpc/copyloops/

2014-04-03 Thread Yann Droneaud
Hi, I'm using cscope to browse kernel sources, but I'm facing warnings from the tool since following commit: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=22d651dcef536c75f75537290bf3da5038e68b6b commit 22d651dcef536c75f75537290bf3da5038e68b6b Author: Michael

Re: [RFC PATCH] hugetlb: ensure hugepage access is denied if hugepages are not supported

2014-04-03 Thread Aneesh Kumar K.V
Nishanth Aravamudan writes: > On 24.03.2014 [16:02:56 -0700], Nishanth Aravamudan wrote: >> In KVM guests on Power, if the guest is not backed by hugepages, we see >> the following in the guest: >> >> AnonHugePages: 0 kB >> HugePages_Total: 0 >> HugePages_Free:0 >> HugePage

Re: Bug in reclaim logic with exhausted nodes?

2014-04-03 Thread Christoph Lameter
On Mon, 31 Mar 2014, Nishanth Aravamudan wrote: > Yep. The node exists, it's just fully exhausted at boot (due to the > presence of 16GB pages reserved at boot-time). Well if you want us to support that then I guess you need to propose patches to address this issue. > I'd appreciate a bit more g

[PATCH 00/20] FDT clean-ups and libfdt support

2014-04-03 Thread Rob Herring
From: Rob Herring This is a series of clean-ups of architecture FDT code and converts the core FDT code over to using libfdt functions. This is in preparation to add FDT based address translation parsing functions for early console support. The current MIPS lantiq and xlp DT code is buggy as bu

[PATCH 09/20] of/fdt: create common debugfs

2014-04-03 Thread Rob Herring
From: Rob Herring Both powerpc and microblaze have the same FDT blob in debugfs feature. Move this to common location and remove the powerpc and microblaze implementations. This feature could become more useful when FDT overlay support is added. This changes the path of the blob from "$arch/flat

[PATCH 20/20] of: push struct boot_param_header and defines into powerpc

2014-04-03 Thread Rob Herring
From: Rob Herring Now powerpc is the only user of struct boot_param_header and FDT defines, so they can be moved into the powerpc architecture code. Signed-off-by: Rob Herring Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/include/asm/prom.h

Re: [RFC PATCH] hugetlb: ensure hugepage access is denied if hugepages are not supported

2014-04-03 Thread Nishanth Aravamudan
On 03.04.2014 [21:49:46 +0530], Aneesh Kumar K.V wrote: > Nishanth Aravamudan writes: > > > On 24.03.2014 [16:02:56 -0700], Nishanth Aravamudan wrote: > >> In KVM guests on Power, if the guest is not backed by hugepages, we see > >> the following in the guest: > >> > >> AnonHugePages: 0

hugetlb: ensure hugepage access is denied if hugepages are not supported

2014-04-03 Thread Nishanth Aravamudan
In KVM guests on Power, in a guest not backed by hugepages, we see the following: AnonHugePages: 0 kB HugePages_Total: 0 HugePages_Free:0 HugePages_Rsvd:0 HugePages_Surp:0 Hugepagesize: 64 kB HPAGE_SHIFT == 0 in this configuration, which indicates tha

Re: hugetlb: ensure hugepage access is denied if hugepages are not supported

2014-04-03 Thread Aneesh Kumar K.V
Nishanth Aravamudan writes: > In KVM guests on Power, in a guest not backed by hugepages, we see the > following: > > AnonHugePages: 0 kB > HugePages_Total: 0 > HugePages_Free:0 > HugePages_Rsvd:0 > HugePages_Surp:0 > Hugepagesize: 64 kB > > HPAGE_SHI

[PATCH v2 1/8] DMA: Freescale: remove the unnecessary FSL_DMA_LD_DEBUG

2014-04-03 Thread hongbo.zhang
From: Hongbo Zhang Some codes are calling chan_dbg with FSL_DMA_LD_DEBUG surrounded, it is really unnecessary to use such a macro because chan_dbg is a wrapper of dev_dbg, we do have corresponding DEBUG macro to switch on/off dev_dbg, and most of the other codes are also calling chan_dbg directly

[PATCH v2 2/8] DMA: Freescale: unify register access methods

2014-04-03 Thread hongbo.zhang
From: Hongbo Zhang Methods of accessing DMA contorller registers are inconsistent, some registers are accessed by DMA_IN/OUT directly, while others are accessed by functions get/set_* which are wrappers of DMA_IN/OUT, and even for the BCR register, it is read by get_bcr but written by DMA_OUT. Th

[PATCH v2 0/8] DMA: Freescale: driver cleanups and enhancements

2014-04-03 Thread hongbo.zhang
From: Hongbo Zhang Hi Vinod Koul, Please have a look at the v2 patch set. v1 -> v2 change: The only one change is introducing a new patch[1/7] to remove the unnecessary macro FSL_DMA_LD_DEBUG, thus the total patches number is 8 now (was 7) Hongbo Zhang (8): DMA: Freescale: remove the unnecess

[PATCH v2 3/8] DMA: Freescale: remove attribute DMA_INTERRUPT of dmaengine

2014-04-03 Thread hongbo.zhang
From: Hongbo Zhang Delete attribute DMA_INTERRUPT because fsldma doesn't support this function, exception will be thrown if talitos is used to offload xor at the same time. Signed-off-by: Hongbo Zhang Signed-off-by: Qiang Liu --- drivers/dma/fsldma.c | 31 --- 1

[PATCH v2 5/8] DMA: Freescale: move functions to avoid forward declarations

2014-04-03 Thread hongbo.zhang
From: Hongbo Zhang These functions will be modified in the next patch in the series. By moving the function in a patch separate from the changes, it will make review easier. Signed-off-by: Hongbo Zhang Signed-off-by: Qiang Liu --- drivers/dma/fsldma.c | 188 +-

[PATCH v2 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

2014-04-03 Thread hongbo.zhang
From: Hongbo Zhang There are several places where descriptors are freed using identical code. This patch puts this code into a function to reduce code duplication. Signed-off-by: Hongbo Zhang Signed-off-by: Qiang Liu --- drivers/dma/fsldma.c | 30 ++ 1 file chang

[PATCH v2 6/8] DMA: Freescale: change descriptor release process for supporting async_tx

2014-04-03 Thread hongbo.zhang
From: Hongbo Zhang Fix the potential risk when enable config NET_DMA and ASYNC_TX. Async_tx is lack of support in current release process of dma descriptor, all descriptors will be released whatever is acked or no-acked by async_tx, so there is a potential race condition when dma engine is uesd b

[PATCH v2 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

2014-04-03 Thread hongbo.zhang
From: Hongbo Zhang The usage of spin_lock_irqsave() is a stronger locking mechanism than is required throughout the driver. The minimum locking required should be used instead. Interrupts will be turned off and context will be saved, it is unnecessary to use irqsave. This patch changes all insta

[PATCH v2 8/8] DMA: Freescale: add suspend resume functions for DMA driver

2014-04-03 Thread hongbo.zhang
From: Hongbo Zhang This patch adds suspend resume functions for Freescale DMA driver. .prepare callback is used to stop further descriptors from being added into the pending queue, and also issue pending queues into execution if there is any. .suspend callback makes sure all the pending jobs are

Re: [PATCH] power, sched: stop updating inside arch_update_cpu_topology() when nothing to be update

2014-04-03 Thread Michael wang
Hi, Srivatsa Thanks for your reply :) On 04/03/2014 04:50 PM, Srivatsa S. Bhat wrote: [snip] > > Now, the interesting thing to note here is that, if CPU0's node was already > set as node0, *nothing* should go wrong, since its just a redundant update. > However, if CPU0's original node mapping wa

[PATCH] powerpc/powernv: Add debugfs file to grab opalv3 trace data

2014-04-03 Thread Benjamin Herrenschmidt
From: Rusty Russell This adds files in debugfs that can be used to retrieve the OPALv3 firmware "live binary traces" which can then be parsed using a userspace tool. Signed-off-by: Rusty Russell Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/platforms/powernv/Makefile | 2

[PATCH 0/7] Build ppc64le kernel using ABIv2, supplemental patches

2014-04-03 Thread Anton Blanchard
These patches apply against my last series and fix all known ABIv2 issues. To stress the module loader and dynamic ftrace code, I built an allmodconfig kernel and inserted every module I could. I found a bunch of bugs in the modules themselves, but in the end I managed to get quite a few modules t

[PATCH 1/7] powerpc: Add _GLOBAL_TOC for ABIv2 assembly functions exported to modules

2014-04-03 Thread Anton Blanchard
If an assembly function that calls back into c code is exported to modules, we need to ensure r2 is setup correctly. There are only two places crazy enough to do it (two of which are my fault). Signed-off-by: Anton Blanchard --- arch/powerpc/include/asm/ppc_asm.h | 12 arch/powerpc/

[PATCH 2/7] powerpc: ftrace_caller, _mcount is exported to modules so needs _GLOBAL_TOC()

2014-04-03 Thread Anton Blanchard
When testing the ftrace function tracer, I realised that ftrace_caller and mcount are called from modules and they both call into C, therefore they need the ABIv2 global entry point to establish r2. Signed-off-by: Anton Blanchard --- arch/powerpc/kernel/entry_64.S | 7 ++- 1 file changed, 2

[PATCH 4/7] powerpc/modules: Create is_module_trampoline()

2014-04-03 Thread Anton Blanchard
ftrace has way too much knowledge of our kernel module trampoline layout hidden inside it. Create is_module_trampoline() that can abstract this away inside the module loader code. Signed-off-by: Anton Blanchard --- arch/powerpc/include/asm/module.h | 1 + arch/powerpc/kernel/module_64.c | 51

[PATCH 3/7] powerpc/kprobes: Fix ABIv2 issues with kprobe_lookup_name

2014-04-03 Thread Anton Blanchard
Use ppc_function_entry in places where we previously assumed function descriptors exist. Signed-off-by: Anton Blanchard --- arch/powerpc/include/asm/kprobes.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/include/asm/kprobes.h b/arch/powerpc/include/asm/k

[PATCH 5/7] powerpc/modules: Create module_trampoline_target()

2014-04-03 Thread Anton Blanchard
ftrace has way too much knowledge of our kernel module trampoline layout hidden inside it. Create module_trampoline_target() that gives the target address of a kernel module trampoline. Signed-off-by: Anton Blanchard --- arch/powerpc/include/asm/module.h | 2 ++ arch/powerpc/kernel/module_64.c

[PATCH 6/7] powerpc/ftrace: Use module loader helpers to parse trampolines

2014-04-03 Thread Anton Blanchard
Now we have is_module_trampoline() and module_trampoline_target() we can remove a bunch of intimate kernel module trampoline knowledge from ftrace. Signed-off-by: Anton Blanchard --- arch/powerpc/kernel/ftrace.c | 97 +--- 1 file changed, 20 insertions(+),

[PATCH 7/7] powerpc/ftrace: Fix ABIv2 issues with __ftrace_make_call

2014-04-03 Thread Anton Blanchard
__ftrace_make_call assumed ABIv1 TOC stack offsets, so it broke on ABIv2. While we are here, we can simplify the instruction modification code. Since we always update one instruction there is no need to probe_kernel_write and flush_icache_range, just use patch_branch. Signed-off-by: Anton Blancha

Re: [PATCH 0/7] Build ppc64le kernel using ABIv2, supplemental patches

2014-04-03 Thread Michael Neuling
Anton Blanchard wrote: > These patches apply against my last series and fix all known > ABIv2 issues. > > To stress the module loader and dynamic ftrace code, I built an > allmodconfig kernel and inserted every module I could. I found a bunch > of bugs in the modules themselves, but in the end I

[PATCH V2 0/2] FAULT_AROUND_ORDER patchset performance data for powerpc

2014-04-03 Thread Madhavan Srinivasan
Kirill A. Shutemov with faultaround patchset introduced vm_ops->map_pages() for mapping easy accessible pages around fault address in hope to reduce number of minor page faults. This patchset creates infrastructure to move the FAULT_AROUND_ORDER to arch/ using Kconfig. This will enable architectur

[PATCH V2 2/2] mm: add FAULT_AROUND_ORDER Kconfig paramater for powerpc

2014-04-03 Thread Madhavan Srinivasan
Performance data for different FAULT_AROUND_ORDER values from 4 socket Power7 system (128 Threads and 128GB memory) is below. perf stat with repeat of 5 is used to get the stddev values. This patch create FAULT_AROUND_ORDER Kconfig parameter and defaults it to 3 based on the performance data. FAUL

[PATCH V2 1/2] mm: move FAULT_AROUND_ORDER to arch/

2014-04-03 Thread Madhavan Srinivasan
Kirill A. Shutemov with faultaround patchset introduced vm_ops->map_pages() for mapping easy accessible pages around fault address in hope to reduce number of minor page faults. This patch creates infrastructure to move the FAULT_AROUND_ORDER to arch/ using Kconfig. This will enable architecture m