Re: [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Eric Dumazet
On Thu, 2012-10-18 at 20:55 -0700, Joe Perches wrote: > ethernet, ipv4, and ipv6 address testing uses 3 different api naming styles. > > ethernet uses:is__ether_addr > ipv4 uses:ipv4_is_ > ipv6 uses:ipv6_addr_ > > Standardize on the ipv6 style of _addr_ to reduce > the number of s

Re: PROBLEM: Linux 3.6.2 fails to boot on IBM Cell

2012-10-19 Thread Dennis Schridde
Am Freitag, 19. Oktober 2012, 00:17:55 schrieb Grant Likely: > What does the boot log look like with the attached patch? (compiled > only, I haven't booted with it) Please find the log attached. --Dennis blade03-tmux.log.xz Description: application/xz signature.asc Description: This is a digita

[PATCH 0/7] update USB gadget driver fsl-usb2-udc

2012-10-19 Thread Christoph Fritz
This series updates USB gadget driver fsl-usb2-udc. Christoph Fritz (7): usb: gadget: fsl_udc: simplify driver init usb: gadget: fsl_udc: protect fsl_pullup() with spin_lock usb: gadget: fsl_udc: convert to new ulc style usb: gadget: fsl_udc: drop ARCH dependency usb: gadget: fsl_udc: po

[PATCH 1/7] usb: gadget: fsl_udc: simplify driver init

2012-10-19 Thread Christoph Fritz
To initialize this driver use 'module_platform_driver' instead of '__init' and '__exit'. Signed-off-by: Christoph Fritz --- drivers/usb/gadget/fsl_udc_core.c | 37 +++-- 1 files changed, 11 insertions(+), 26 deletions(-) diff --git a/drivers/usb/gadget/fsl_udc_

[PATCH 2/7] usb: gadget: fsl_udc: protect fsl_pullup() with spin_lock

2012-10-19 Thread Christoph Fritz
This patch reworks fsl_pullup() against the background of switching over to udc_start()/udc_stop() style: Protect function fsl_pullup() with a spin_lock. Also set vbus_active as default to true. This prevents disabling USB controller if there is no driver support for an external transceiver (or GP

[PATCH 3/7] usb: gadget: fsl_udc: convert to new ulc style

2012-10-19 Thread Christoph Fritz
Convert to new UDC style registration and remove global 'udc_controller' pointer. Signed-off-by: Christoph Fritz --- drivers/usb/gadget/fsl_udc_core.c | 289 + 1 files changed, 131 insertions(+), 158 deletions(-) diff --git a/drivers/usb/gadget/fsl_udc_core.

[PATCH 4/7] usb: gadget: fsl_udc: drop ARCH dependency

2012-10-19 Thread Christoph Fritz
Drop the big-/little-endian helpers and make use of generic writel()/readl() routines. Signed-off-by: Christoph Fritz --- drivers/usb/gadget/fsl_udc_core.c | 331 + 1 files changed, 118 insertions(+), 213 deletions(-) diff --git a/drivers/usb/gadget/fsl_udc_

[PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-19 Thread Christoph Fritz
USB controller may access a wrong address for the dTD (endpoint transfer descriptor) and then hang. This happens a lot when doing tests with g_ether module and iperf, a tool for measuring maximum TCP and UDP bandwidth. This hardware bug is explained in detail by errata number 2858 for i.MX23: http

[PATCH 6/7] usb: gadget: fsl_udc: purge global pointer usb_sys_regs

2012-10-19 Thread Christoph Fritz
Move global driver pointer usb_sys_regs to private struct fsl_udc. Signed-off-by: Christoph Fritz Reviewed-by: Teresa Gamez --- drivers/usb/gadget/fsl_udc_core.c | 26 -- drivers/usb/gadget/fsl_usb2_udc.h |1 + 2 files changed, 13 insertions(+), 14 deletions(-) di

[PATCH 7/7] usb: gadget: fsl_udc: purge global pointer dr_regs

2012-10-19 Thread Christoph Fritz
Move global driver pointer dr_regs to private struct fsl_udc. Signed-off-by: Christoph Fritz --- drivers/usb/gadget/fsl_udc_core.c | 252 +++-- drivers/usb/gadget/fsl_usb2_udc.h |1 + 2 files changed, 130 insertions(+), 123 deletions(-) diff --git a/drivers/

Re: [PATCH 1/7] usb: gadget: fsl_udc: simplify driver init

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 12:24:39PM +0200, Christoph Fritz wrote: > To initialize this driver use 'module_platform_driver' instead > of '__init' and '__exit'. > > Signed-off-by: Christoph Fritz > --- > drivers/usb/gadget/fsl_udc_core.c | 37 > +++-- > 1 fil

Re: [PATCH 2/7] usb: gadget: fsl_udc: protect fsl_pullup() with spin_lock

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 12:24:40PM +0200, Christoph Fritz wrote: > This patch reworks fsl_pullup() against the background of switching over > to udc_start()/udc_stop() style: > > Protect function fsl_pullup() with a spin_lock. Also set vbus_active as > default to true. This prevents disabling

Re: [PATCH 3/7] usb: gadget: fsl_udc: convert to new ulc style

2012-10-19 Thread Felipe Balbi
Hi, typo on Subject. Should be udc, not ulc. On Fri, Oct 19, 2012 at 12:24:41PM +0200, Christoph Fritz wrote: > Convert to new UDC style registration and remove > global 'udc_controller' pointer. > > Signed-off-by: Christoph Fritz > --- > drivers/usb/gadget/fsl_udc_core.c | 289 > +++

Re: [PATCH 4/7] usb: gadget: fsl_udc: drop ARCH dependency

2012-10-19 Thread Felipe Balbi
On Fri, Oct 19, 2012 at 12:24:42PM +0200, Christoph Fritz wrote: > Drop the big-/little-endian helpers and make use of generic > writel()/readl() routines. > > Signed-off-by: Christoph Fritz > --- > drivers/usb/gadget/fsl_udc_core.c | 331 > + > 1 files chan

Re: [PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-19 Thread Felipe Balbi
On Fri, Oct 19, 2012 at 12:24:43PM +0200, Christoph Fritz wrote: > USB controller may access a wrong address for the dTD (endpoint transfer > descriptor) and then hang. This happens a lot when doing tests with > g_ether module and iperf, a tool for measuring maximum TCP and UDP > bandwidth. > > Th

Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory

2012-10-19 Thread Wen Congyang
At 10/06/2012 03:27 AM, KOSAKI Motohiro Wrote: > On Thu, Oct 4, 2012 at 10:25 PM, Yasuaki Ishimatsu > wrote: >> When calling remove_memory(), the memory should be offline. If the function >> is used to online memory, kernel panic may occur. >> >> So the patch checks whether memory is offline or no

Re: [PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-19 Thread Christoph Fritz
On Fri, 2012-10-19 at 13:30 +0300, Felipe Balbi wrote: > On Fri, Oct 19, 2012 at 12:24:43PM +0200, Christoph Fritz wrote: > > USB controller may access a wrong address for the dTD (endpoint transfer > > descriptor) and then hang. This happens a lot when doing tests with > > g_ether module and iperf

Re: [PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 12:46:48PM +0200, Christoph Fritz wrote: > On Fri, 2012-10-19 at 13:30 +0300, Felipe Balbi wrote: > > On Fri, Oct 19, 2012 at 12:24:43PM +0200, Christoph Fritz wrote: > > > USB controller may access a wrong address for the dTD (endpoint transfer > > > descriptor) and th

Re: [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Pavel Roskin
On Fri, 19 Oct 2012 09:04:14 +0200 Eric Dumazet wrote: > Yes they are some names discrepancies, thats a big deal. > > And we have alloc_skb() / kfree_skb() / skb_clone() > > Why not skb_alloc() / skb_free() / skb_clone() ? > > Some people actually know current code by name of functions, they

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-19 Thread Sukadev Bhattiprolu
Stephane Eranian [eran...@google.com] wrote: | So all in all, I think this is not a very good idea. You have to put | this into the tool or a library that auto-detects the | host CPU and programs the right set of events. | | We've had that discussion many times. Just reiterating my personal | opin

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote: > Some gadget drivers may attempt to dequeue requests for an endpoint that has > already been disabled. For example, in the UVC gadget driver, > uvc_function_set_alt() > will call usb_ep_disable() when alt setting 0 is selected. W

Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory

2012-10-19 Thread KOSAKI Motohiro
> I think it again, and found that this check is necessary. Because we only > lock memory hotplug when offlining pages. Here is the steps to offline and > remove memory: > > 1. lock memory hotplug > 2. offline a memory section > 3. unlock memory hotplug > 4. repeat 1-3 to offline all memory section

Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory

2012-10-19 Thread Wen Congyang
At 2012/10/19 18:44, Wen Congyang Wrote: At 10/06/2012 03:27 AM, KOSAKI Motohiro Wrote: On Thu, Oct 4, 2012 at 10:25 PM, Yasuaki Ishimatsu wrote: When calling remove_memory(), the memory should be offline. If the function is used to online memory, kernel panic may occur. So the patch checks

Re: [PATCH 0/7] update USB gadget driver fsl-usb2-udc

2012-10-19 Thread Sascha Hauer
Hi Christoph, What system are you working on? If it's i.MX you should use/work on the chipidea driver instead. Sascha On Fri, Oct 19, 2012 at 12:22:36PM +0200, Christoph Fritz wrote: > This series updates USB gadget driver fsl-usb2-udc. > > Christoph Fritz (7): > usb: gadget: fsl_udc: simplif

[PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-19 Thread Simon Haggett
Some gadget drivers may attempt to dequeue requests for an endpoint that has already been disabled. For example, in the UVC gadget driver, uvc_function_set_alt() will call usb_ep_disable() when alt setting 0 is selected. When the userspace application subsequently issues the VIDIOC_STREAMOFF ioctl

Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory

2012-10-19 Thread Wen Congyang
At 10/20/2012 02:33 AM, KOSAKI Motohiro Wrote: >> I think it again, and found that this check is necessary. Because we only >> lock memory hotplug when offlining pages. Here is the steps to offline and >> remove memory: >> >> 1. lock memory hotplug >> 2. offline a memory section >> 3. unlock memory

Re: [PATCH v2] powerpc: 52xx: nop out unsupported critical IRQs

2012-10-19 Thread Wolfram Sang
On Thu, Oct 11, 2012 at 11:19:15AM +0200, Wolfram Sang wrote: > Currently, when booting MPC52xx based platforms, we get: > > mpc52xx_irqhost_map: invalid irq: virq=16, l1=0, l2=3 > irq: irq-16==>hwirq-0x3 mapping failed: -22 > [WARNing skipped] > > The warning is wrong sin