RE: [PATCH v7 0/8] Raid: enable talitos xor offload for improving performance

2012-08-14 Thread Liu Qiang-B32616
Hi Vinod, Would you like to apply this series from patch 2/8 to 7/8) in your tree? The link as below, http://patchwork.ozlabs.org/patch/176023/ http://patchwork.ozlabs.org/patch/176024/ http://patchwork.ozlabs.org/patch/176025/ http://patchwork.ozlabs.org/patch/176026/ http://patchwork.ozlabs.org/

Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source

2012-08-14 Thread Zhao Chenhui
On Sat, Aug 11, 2012 at 08:19:43AM -0500, Tabi Timur-B04825 wrote: > On Tue, Aug 7, 2012 at 3:43 AM, Zhao Chenhui > wrote: > > > + return -EINVAL; > > + > > + prop = of_get_property(clk_np, "fsl,pmcdr-mask", NULL); > > + if (!prop) { > > + ret = -EINVAL; >

Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source

2012-08-14 Thread Zhao Chenhui
On Sat, Aug 11, 2012 at 08:19:43AM -0500, Tabi Timur-B04825 wrote: > On Tue, Aug 7, 2012 at 3:43 AM, Zhao Chenhui > wrote: > > > +int mpc85xx_pmc_set_wake(struct device *dev, bool enable) > > +{ > > + int ret = 0; > > + struct device_node *clk_np; > > + const u32 *prop; > > +

Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source

2012-08-14 Thread Tabi Timur-B04825
Zhao Chenhui wrote: >>> > >+#ifdef CONFIG_FSL_PMC >>> > >+extern int mpc85xx_pmc_set_wake(struct device *dev, bool enable); >>> > >+extern void mpc85xx_pmc_set_lossless_ethernet(int enable); >> > >> >Don't use 'extern' for functions. >> > > Why? I think there is no difference. It's unnecessary, an

[PATCH 3/5] drivers/net/ethernet/freescale/fs_enet: fix error return code

2012-08-14 Thread Julia Lawall
From: Julia Lawall Convert a 0 error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e,e1,e2,e3,e4,x; @@ ( if (\(ret != 0\|ret

Re: [PATCH] Powerpc 8xx CPM_UART delay in receive

2012-08-14 Thread Alan Cox
On Tue, 14 Aug 2012 16:26:28 +0200 Christophe Leroy wrote: > Hello, > > I'm not sure who to address this Patch to either > > It fixes a delay issue with CPM UART driver on Powerpc MPC8xx. > The problem is that with the actual code, the driver waits 32 IDLE patterns > before returning the recei

[PATCH] Powerpc 8xx CPM_UART delay in receive

2012-08-14 Thread Christophe Leroy
Hello, I'm not sure who to address this Patch to either It fixes a delay issue with CPM UART driver on Powerpc MPC8xx. The problem is that with the actual code, the driver waits 32 IDLE patterns before returning the received data to the upper level. It means for instance about 1 second at 300 b

[PATCH] Powerpc 8xx CPM_UART desynchronisation

2012-08-14 Thread Christophe Leroy
Hello, I'm not sure who to address this Patch to. It fixes a desynchronisation problem with CPM UART driver on Powerpc MPC8xx. The problem happens if data is received before the device is open by the user application. Signed-off-by: Christophe Leroy --- linux-3.5-vanilla/drivers/tty/serial/cp

[PATCH 5/5] arch/powerpc/platforms/powernv/pci.c: Remove potential NULL dereferences

2012-08-14 Thread Julia Lawall
From: Julia Lawall If the NULL test is necessary, the initialization involving a dereference of the tested value should be moved after the NULL test. The sematic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ type T; expression E; identifier i,fld; statement S;

Re: [PATCH v2 1/2] powerpc/mpic: Add Open-PIC global timer document

2012-08-14 Thread Scott Wood
On 08/13/2012 09:40 PM, Wang Dongsheng-B40534 wrote: +Example 2: > + > + timer: timer@010f0 { > + compatible = "open-pic,global-timer"; > + device_type = "open-pic"; > + reg = <0x010f0 4 0x01100 0x100>; > + interrupts = <0 0 3 0 > +

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

2012-08-14 Thread Scott Wood
On 08/13/2012 09:32 PM, Wang Dongsheng-B40534 wrote: > > >> -Original Message- >> From: Wood Scott-B07421 >> Sent: Tuesday, August 14, 2012 10:19 AM >> To: Wang Dongsheng-B40534 >> Cc: Wood Scott-B07421; b...@kernel.crashing.org; pau...@samba.org; >> linuxppc-dev@lists.ozlabs.org; Gala Ku

Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS

2012-08-14 Thread Kumar Gala
On Aug 10, 2012, at 5:31 PM, Timur Tabi wrote: > diff --git a/arch/powerpc/platforms/85xx/corenet_ds.c > b/arch/powerpc/platforms/85xx/corenet_ds.c > index 925b028..a79fc79 100644 > --- a/arch/powerpc/platforms/85xx/corenet_ds.c > +++ b/arch/powerpc/platforms/85xx/corenet_ds.c > @@ -106,6 +106,1

Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS

2012-08-14 Thread Timur Tabi
Kumar Gala wrote: >> > + { >> > + /* >> > + * Warning: this entry might need to be located before those >> > + * for the Fman Ethernet nodes. >> > + */ >> > + .compatible = "mdio-mux", >> > + }, >> >{} >> > }; > Under what condition would th

Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS

2012-08-14 Thread Scott Wood
On 08/14/2012 04:48 PM, Timur Tabi wrote: > Kumar Gala wrote: + { + /* + * Warning: this entry might need to be located before those + * for the Fman Ethernet nodes. + */ + .compatible = "mdio-mux", + },

Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS

2012-08-14 Thread Timur Tabi
Scott Wood wrote: > I think that was internally, and not on this specific comment wording. > I don't think that code comment adequately explains things. I don't really have any more insight to add. >> otherwise, the mdio-mux code would not prepare the mdio mus in time, and >> there would be init

Re: [PATCH v7 0/8] Raid: enable talitos xor offload for improving performance

2012-08-14 Thread Dan Williams
On Tue, Aug 14, 2012 at 2:04 AM, Liu Qiang-B32616 wrote: > Hi Vinod, > > Would you like to apply this series from patch 2/8 to 7/8) in your tree? > The link as below, > http://patchwork.ozlabs.org/patch/176023/ > http://patchwork.ozlabs.org/patch/176024/ > http://patchwork.ozlabs.org/patch/176025/

Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS

2012-08-14 Thread Scott Wood
On 08/14/2012 04:58 PM, Timur Tabi wrote: > Scott Wood wrote: > >> I think that was internally, and not on this specific comment wording. >> I don't think that code comment adequately explains things. > > I don't really have any more insight to add. My point (at least, this part of it) was that

Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS

2012-08-14 Thread Timur Tabi
Scott Wood wrote: > > If anything, I'd make the ordering be "wrong" to force that code path to > be tested -- though ideally there would be a more systematic approach to > such testing, that doesn't require inefficiency during normal boot. I can't force the ordering to be wrong, because it's the

Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS

2012-08-14 Thread Scott Wood
On 08/14/2012 06:08 PM, Timur Tabi wrote: > Scott Wood wrote: >> >> If anything, I'd make the ordering be "wrong" to force that code path to >> be tested -- though ideally there would be a more systematic approach to >> such testing, that doesn't require inefficiency during normal boot. > > I can'

[PATCH V3 0/3] tpm: Add new vTPM device driver for PPC64

2012-08-14 Thread Ashley Lai
Change log V3: - Replaced TPM_NO_EVENT_LOG macro with stubs - Removed tpm_noeventlog.c file - Called of_node_put() before return in tpm_of.c Change log V2: - Removed unnecessary tpm_bios_log_setup and tpm_bios_log_teardown functions in tpm_eventlog.h (patch 3/3). - Added more descriptions on vT

[PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-08-14 Thread Ashley Lai
This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. IBM vTPM is supported through the adjunct partition with firmware release 740 or higher. With vTPM support, each lpar is able to have its own vTPM without the physical TPM hardware. This driver provides TPM function

[PATCH V3 3/3] drivers/char/tpm: Add securityfs support for event log

2012-08-14 Thread Ashley Lai
This patch retrieves the event log data from the device tree during file open. The event log data will then displayed through securityfs. Signed-off-by: Ashley Lai --- drivers/char/tpm/Makefile |5 +++ drivers/char/tpm/tpm.h | 12 -- drivers/char/tpm/tpm_eventlog.h | 1

[PATCH V3 2/3] PPC64: Add support for instantiating SML from Open Firmware

2012-08-14 Thread Ashley Lai
This patch instantiate Stored Measurement Log (SML) and put the log address and size in the device tree. Signed-off-by: Ashley Lai --- arch/powerpc/kernel/prom_init.c | 62 +++ 1 files changed, 62 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/kern

Re: [PATCH 3/5] drivers/net/ethernet/freescale/fs_enet: fix error return code

2012-08-14 Thread David Miller
From: Julia Lawall Date: Tue, 14 Aug 2012 14:58:33 +0200 > From: Julia Lawall > > Convert a 0 error return code to a negative one, as returned elsewhere in the > function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ...

RE: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-14 Thread Jia Hongtao-B38951
> -Original Message- > From: Tabi Timur-B04825 > Sent: Saturday, August 11, 2012 9:11 PM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Wood Scott- > B07421 > Subject: Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie > initialization code > > On