Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-05-04 Thread Borislav Petkov
On Thu, May 03, 2012 at 11:16:54AM -0300, Mauro Carvalho Chehab wrote: > >> + bool enable_filter, > >> + unsigned pos[EDAC_MAX_LAYERS]) > > > > Passing the whole array as an argument instead of only a pointer to it? > > This is C, and not

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-05-04 Thread Mauro Carvalho Chehab
Em 04-05-2012 06:52, Borislav Petkov escreveu: > On Thu, May 03, 2012 at 11:16:54AM -0300, Mauro Carvalho Chehab wrote: + bool enable_filter, + unsigned pos[EDAC_MAX_LAYERS]) >>> >>> Passing the whole array as an argument instead o

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers, second version

2012-05-04 Thread Borislav Petkov
On Thu, May 03, 2012 at 11:16:54AM -0300, Mauro Carvalho Chehab wrote: > edac: Change internal representation to work with layers > > From: Mauro Carvalho Chehab > > Change the EDAC internal representation to work with non-csrow > based memory controllers. > > There are lots of those memory con

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers, second version

2012-05-04 Thread Mauro Carvalho Chehab
Em 04-05-2012 07:16, Borislav Petkov escreveu: > On Thu, May 03, 2012 at 11:16:54AM -0300, Mauro Carvalho Chehab wrote: >> edac: Change internal representation to work with layers ... >> /** >> - * edac_mc_alloc: Allocate a struct mem_ctl_info structure >> - * @size_pvt: size of private stor

Re: [PATCH 1/9] cpu: Introduce clear_tasks_mm_cpumask() helper

2012-05-04 Thread Anton Vorontsov
On Thu, Apr 26, 2012 at 04:59:11PM -0700, Andrew Morton wrote: [...] > > so its not like new tasks will ever get this cpu set in > > +* their mm mask. -- Peter Zijlstra > > +* Thus, we may use rcu_read_lock() here, instead of grabbing > > +* full-fledged tasklist_lock. > > +*/

[PATCH] cpu: Document clear_tasks_mm_cpumask()

2012-05-04 Thread Anton Vorontsov
This patch adds more comments on clear_tasks_mm_cpumask, plus adds a runtime check: the function is only suitable for offlined CPUs, and if called inappropriately, the kernel should scream aloud. Suggested-by: Andrew Morton Suggested-by: Peter Zijlstra Signed-off-by: Anton Vorontsov --- On Tue