Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Borislav Petkov
On Sun, Apr 29, 2012 at 11:16:53AM -0300, Mauro Carvalho Chehab wrote: > > Hey, are you looking at compiled code or at source code? Because I'm > > looking at source code, and it is a pretty safe bet the majority of the > > people here do that too. > > What I said is that, from source code POV, a

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Borislav Petkov
On Sun, Apr 29, 2012 at 10:49:44AM -0300, Mauro Carvalho Chehab wrote: > > [ 10.486440] EDAC MC: DCT0 chip selects: > > [ 10.486443] EDAC amd64: MC: 0: 2048MB 1: 2048MB > > [ 10.486445] EDAC amd64: MC: 2: 2048MB 3: 2048MB > > [ 10.486448] EDAC amd64: MC: 4: 0MB 5: 0MB > > [ 10

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Mauro Carvalho Chehab
Em 30-04-2012 05:15, Borislav Petkov escreveu: > On Sun, Apr 29, 2012 at 10:49:44AM -0300, Mauro Carvalho Chehab wrote: >>> [ 10.486440] EDAC MC: DCT0 chip selects: >>> [ 10.486443] EDAC amd64: MC: 0: 2048MB 1: 2048MB >>> [ 10.486445] EDAC amd64: MC: 2: 2048MB 3: 2048MB >>> [ 10.486448]

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Borislav Petkov
On Mon, Apr 30, 2012 at 07:58:33AM -0300, Mauro Carvalho Chehab wrote: > It seems you have a very short memory. Oh, puh-lease, let's don't start with the insults now. You're not a saint yourself. And maybe the fact that I'm having hard time grasping your code is maybe because it is a load of crap

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Mauro Carvalho Chehab
Em 30-04-2012 04:59, Borislav Petkov escreveu: > On Sun, Apr 29, 2012 at 11:16:53AM -0300, Mauro Carvalho Chehab wrote: >>> Hey, are you looking at compiled code or at source code? Because I'm >>> looking at source code, and it is a pretty safe bet the majority of the >>> people here do that too. >

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Mauro Carvalho Chehab
Em 30-04-2012 05:15, Borislav Petkov escreveu: > On Sun, Apr 29, 2012 at 10:49:44AM -0300, Mauro Carvalho Chehab wrote: >>> [ 10.486440] EDAC MC: DCT0 chip selects: >>> [ 10.486443] EDAC amd64: MC: 0: 2048MB 1: 2048MB >>> [ 10.486445] EDAC amd64: MC: 2: 2048MB 3: 2048MB >>> [ 10.486448]

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Mauro Carvalho Chehab
Em 30-04-2012 08:11, Borislav Petkov escreveu: > On Mon, Apr 30, 2012 at 07:58:33AM -0300, Mauro Carvalho Chehab wrote: >> For example, this is the mapping used by the second memory controller of the >> SB machine >> I'm using on my tests: >> >> [52803.640043] EDAC DEBUG: sbridge_probe: Registeri

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Borislav Petkov
On Mon, Apr 30, 2012 at 08:45:09AM -0300, Mauro Carvalho Chehab wrote: > Em 30-04-2012 08:11, Borislav Petkov escreveu: > > On Mon, Apr 30, 2012 at 07:58:33AM -0300, Mauro Carvalho Chehab wrote: > > >> For example, this is the mapping used by the second memory controller of > >> the SB machine >

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Borislav Petkov
On Mon, Apr 30, 2012 at 08:23:42AM -0300, Mauro Carvalho Chehab wrote: > With this I fully agree: you're nacking patches because it is not the way you Where? Have I written Nacked-by somewhere? > write your code, not because the code there is doing anything wrong. > > If you point anything wrong

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Mauro Carvalho Chehab
Em 30-04-2012 09:38, Borislav Petkov escreveu: > On Mon, Apr 30, 2012 at 08:45:09AM -0300, Mauro Carvalho Chehab wrote: >> Em 30-04-2012 08:11, Borislav Petkov escreveu: >>> On Mon, Apr 30, 2012 at 07:58:33AM -0300, Mauro Carvalho Chehab wrote: >>> This way it says "initializing 12 dimms" and the

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-30 Thread Mauro Carvalho Chehab
Em 30-04-2012 10:00, Mauro Carvalho Chehab escreveu: > Em 30-04-2012 09:38, Borislav Petkov escreveu: >> On Mon, Apr 30, 2012 at 08:45:09AM -0300, Mauro Carvalho Chehab wrote: >>> Em 30-04-2012 08:11, Borislav Petkov escreveu: On Mon, Apr 30, 2012 at 07:58:33AM -0300, Mauro Carvalho Chehab wro

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-30 Thread David Miller
From: Benjamin Herrenschmidt Date: Mon, 30 Apr 2012 15:26:08 +1000 > David, what's the right way to fix that ? There is no doubt that sock_fprog is the correct datastructure to use. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://li

Re: [REGRESSION][PATCH V5 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-30 Thread David Miller
From: Jan Seiffert Date: Mon, 30 Apr 2012 07:02:19 +0200 > Now the helper function from filter.c for negative offsets is exported, > it can be used it in the jit to handle negative offsets. > > First modify the asm load helper functions to handle: > - know positive offsets > - know negative offs

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-30 Thread Benjamin Herrenschmidt
On Mon, 2012-04-30 at 13:41 -0400, David Miller wrote: > From: Benjamin Herrenschmidt > Date: Mon, 30 Apr 2012 15:26:08 +1000 > > > David, what's the right way to fix that ? > > There is no doubt that sock_fprog is the correct datastructure to use. Ok, so the right fix is to email anybody who p

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-30 Thread Benjamin Herrenschmidt
On Tue, 2012-05-01 at 07:55 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2012-04-30 at 13:41 -0400, David Miller wrote: > > From: Benjamin Herrenschmidt > > Date: Mon, 30 Apr 2012 15:26:08 +1000 > > > > > David, what's the right way to fix that ? > > > > There is no doubt that sock_fprog is th

linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-04-30 Thread Hugh Dickins
Hi Paul, On 3.4.0-rc4-next-20120427 and preceding linux-nexts (I've not tried rc5-next-20120430 but expect it's the same), on PowerPC G5 quad with CONFIG_PREEMPT=y and CONFIG_DEBUG_ATOMIC_SLEEP=y, I'm getting spurious "BUG: sleeping function called from invalid co

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-04-30 Thread Paul E. McKenney
On Mon, Apr 30, 2012 at 03:37:10PM -0700, Hugh Dickins wrote: > Hi Paul, > > On 3.4.0-rc4-next-20120427 and preceding linux-nexts (I've not tried > rc5-next-20120430 but expect it's the same), on PowerPC G5 quad with > CONFIG_PREEMPT=y and CONFIG_DEBUG_ATOMIC_SLEEP=y, I&

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-04-30 Thread Benjamin Herrenschmidt
On Mon, 2012-04-30 at 15:37 -0700, Hugh Dickins wrote: > > BUG: sleeping function called from invalid context at > include/linux/pagemap.h:354 > in_atomic(): 0, irqs_disabled(): 0, pid: 6886, name: cc1 Hrm ... in_atomic and irqs_disabled are both 0 ... so yeah it smells like a preempt count prob

Re: [PATCH v3 03/17] powerpc: Add PFO support to the VIO bus

2012-04-30 Thread Benjamin Herrenschmidt
Hrm... I don't like that much: > + if (op->timeout) > + deadline = jiffies + msecs_to_jiffies(op->timeout); > + > + while (true) { > + hret = plpar_hcall_norets(H_COP, op->flags, > + vdev->resource_id, > + op->

Re: [PATCH v3 03/17] powerpc: Add PFO support to the VIO bus

2012-04-30 Thread Benjamin Herrenschmidt
> Else, what about ceding the processor ? Or at the very least reducing > the thread priority for a bit ? > > Shouldn't we also enforce to always have a timeout ? IE. Something like > 30s or so if nothing specified to avoid having the kernel just hard > lock... > > In general I don't like that s

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-04-30 Thread Hugh Dickins
On Tue, 1 May 2012, Benjamin Herrenschmidt wrote: > On Mon, 2012-04-30 at 15:37 -0700, Hugh Dickins wrote: > > > > BUG: sleeping function called from invalid context at > > include/linux/pagemap.h:354 > > in_atomic(): 0, irqs_disabled(): 0, pid: 6886, name: cc1 > > Hrm ... in_atomic and irqs_dis