Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-28 Thread Borislav Petkov
On Fri, Apr 27, 2012 at 01:07:38PM -0300, Mauro Carvalho Chehab wrote: > Yes. This is a common issue at the EDAC core: on several places, it calls the > edac debug macros (DEBUGF0...DEBUGF4) passing a __func__ as an argument, while > the debug macros already handles that. I suspect that, in the pas

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-28 Thread Borislav Petkov
On Fri, Apr 27, 2012 at 04:24:28PM -0300, Mauro Carvalho Chehab wrote: > Em 27-04-2012 15:11, Luck, Tony escreveu: > +for (i = 0; i < dimm->mci->n_layers; i++) { > +printk(KERN_CONT "%d", dimm->location[i]); > +if (i < dimm->mci->n_layers - 1)

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-28 Thread Borislav Petkov
On Fri, Apr 27, 2012 at 12:36:12PM -0300, Mauro Carvalho Chehab wrote: > The fix for it were in another patch[1], as calling them as "rank" is > needed also at the sysfs API. No, this doesn't fix it either: [ 10.486440] EDAC MC: DCT0 chip selects: [ 10.486443] EDAC amd64: MC: 0: 2048MB 1: 2

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-28 Thread Borislav Petkov
On Fri, Apr 27, 2012 at 02:52:35PM -0300, Mauro Carvalho Chehab wrote: [..] > >> +struct mem_ctl_info *new_edac_mc_alloc(unsigned edac_index, > >> + unsigned n_layers, > >> + struct edac_mc_layer *layers, > >> + b

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-28 Thread Joe Perches
On Sat, 2012-04-28 at 11:16 +0200, Borislav Petkov wrote: > On Fri, Apr 27, 2012 at 02:52:35PM -0300, Mauro Carvalho Chehab wrote: > > > All those local variables should be sorted in a reverse christmas tree > > > order: > > > > > > u32 this_is_the_longest_array_name[LENGTH]; > > > void *short

Re: Regression in 32-bit ppc kernel

2012-04-28 Thread Larry Finger
On 04/27/2012 07:42 PM, Benjamin Herrenschmidt wrote: Ok, so you do have a serial port, probably two even :-) One of them is connected to the infra red transceiver and the other one is probably connected to the internal modem. (The modem itself might not use it, some of these machines use an i2

Re: Regression in 32-bit ppc kernel

2012-04-28 Thread Andreas Schwab
Larry Finger writes: > I have done a little more debugging. The problem is definitely coming from > drivers/tty/serial/pmac_zilog.c. I am getting ChanB interrupts while open, > which causes the following code segment to return IRQ_NONE: > >if (r3 & (CHBEXT | CHBTxIP | CHBRxIP)) { >

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-28 Thread Joe Perches
On Sat, 2012-04-28 at 10:52 +0200, Borislav Petkov wrote: > On Fri, Apr 27, 2012 at 01:07:38PM -0300, Mauro Carvalho Chehab wrote: > > Yes. This is a common issue at the EDAC core: on several places, it calls > > the > > edac debug macros (DEBUGF0...DEBUGF4) passing a __func__ as an argument, > >

Re: Regression in 32-bit ppc kernel

2012-04-28 Thread Benjamin Herrenschmidt
On Sat, 2012-04-28 at 13:09 -0500, Larry Finger wrote: > I have done a little more debugging. The problem is definitely coming > from > drivers/tty/serial/pmac_zilog.c. I am getting ChanB interrupts while > open, which > causes the following code segment to return IRQ_NONE: > > if (r3 &

Re: Regression in 32-bit ppc kernel

2012-04-28 Thread Benjamin Herrenschmidt
On Sat, 2012-04-28 at 20:23 +0200, Andreas Schwab wrote: > Larry Finger writes: > > > I have done a little more debugging. The problem is definitely coming from > > drivers/tty/serial/pmac_zilog.c. I am getting ChanB interrupts while open, > > which causes the following code segment to return IRQ

Re: Regression in 32-bit ppc kernel

2012-04-28 Thread Benjamin Herrenschmidt
On Sun, 2012-04-29 at 08:41 +1000, Benjamin Herrenschmidt wrote: > On Sat, 2012-04-28 at 13:09 -0500, Larry Finger wrote: > > I have done a little more debugging. The problem is definitely coming > > from > > drivers/tty/serial/pmac_zilog.c. I am getting ChanB interrupts while > > open, which > >

Re: Regression in 32-bit ppc kernel

2012-04-28 Thread Larry Finger
On 04/28/2012 05:48 PM, Benjamin Herrenschmidt wrote: On Sat, 2012-04-28 at 20:23 +0200, Andreas Schwab wrote: Larry Finger writes: I have done a little more debugging. The problem is definitely coming from drivers/tty/serial/pmac_zilog.c. I am getting ChanB interrupts while open, which cause

Re: Regression in 32-bit ppc kernel

2012-04-28 Thread Benjamin Herrenschmidt
On Sat, 2012-04-28 at 18:17 -0500, Larry Finger wrote: > Yes, good catch by Andreas. That change does fix the problem. > > Ben - Do you want to fix the typos for open/not open with the same > patch? > Sure, if you're going to do a proper patch, by all means please fix those too :-) Does it fix a

Re: Regression in 32-bit ppc kernel

2012-04-28 Thread Larry Finger
On 04/28/2012 06:23 PM, Benjamin Herrenschmidt wrote: On Sat, 2012-04-28 at 18:17 -0500, Larry Finger wrote: Yes, good catch by Andreas. That change does fix the problem. Ben - Do you want to fix the typos for open/not open with the same patch? Sure, if you're going to do a proper patch, by a

[PATCH] tty/serial/pmac_zilog: Fix "nobody cared" IRQ message

2012-04-28 Thread Larry Finger
Following commit a79dd5a titled "tty/serial/pmac_zilog: Fix suspend & resume", my Powerbook G4 Titanium showed the following stack dump: [ 36.878225] irq 23: nobody cared (try booting with the "irqpoll" option) [ 36.878251] Call Trace: [ 36.878291] [dfff3f00] [c000984c] show_stack+0x7c/0x19