Re: [PATCH] usb:gadget: use min_t() macro instead of min()

Hi, On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > Signed-off-by: Tatyana Brokhman I need a sensible commit log for this. Why do we need to change all min() to min_t() ? -- balbi signature.asc Description: Digital signature __

RE: [PATCH] usb:gadget: use min_t() macro instead of min()

> > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > > Signed-off-by: Tatyana Brokhman > > I need a sensible commit log for this. Why do we need to change all > min() to min_t() ? > Actually, Alan asked me to make this change in one place in dummy_hcd. I wasn't aware of the

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

Hi, On Mon, Jun 13, 2011 at 02:52:34PM +0300, Tanya Brokhman wrote: > > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > > > Signed-off-by: Tatyana Brokhman > > > > I need a sensible commit log for this. Why do we need to change all > > min() to min_t() ? > > > > Actually, A

RE: [PATCH] usb:gadget: use min_t() macro instead of min()

On Mon, 13 Jun 2011, Tanya Brokhman wrote: > > > > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > > > Signed-off-by: Tatyana Brokhman > > > > I need a sensible commit log for this. Why do we need to change all > > min() to min_t() ? > > > > Actually, Alan asked me to make

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

On Sun, 12 Jun 2011, Hugh Dickins wrote: > 3.0-rc won't boot with SLUB on my PowerPC G5: kernel BUG at mm/slub.c:1950! > Bisected to 1759415e630e "slub: Remove CONFIG_CMPXCHG_LOCAL ifdeffery". > > After giving myself a medal for finding the BUG on line 1950 of mm/slub.c > (it's actually the >

RE: [PATCH] usb:gadget: use min_t() macro instead of min()

> > The change I suggested involved replacing two typecasts with a single > min_t. All (or almost all) the places this patch touches currently > contain only one typecast, so the motivation for changing them is a lot > weaker. > You're right. So what's the final call on this one? Do you think it

RE: [PATCH] usb:gadget: use min_t() macro instead of min()

On Mon, 13 Jun 2011, Tanya Brokhman wrote: > > > > The change I suggested involved replacing two typecasts with a single > > min_t. All (or almost all) the places this patch touches currently > > contain only one typecast, so the motivation for changing them is a lot > > weaker. > > > You're ri

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

Hi, On Mon, Jun 13, 2011 at 03:03:44PM -0400, Alan Stern wrote: > > > The change I suggested involved replacing two typecasts with a single > > > min_t. All (or almost all) the places this patch touches currently > > > contain only one typecast, so the motivation for changing them is a lot > > >

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

On Mon, 13 Jun 2011, Pekka Enberg wrote: > > Hmmm.. The allocpercpu in alloc_kmem_cache_cpus should take care of the > > alignment. Uhh.. I see that a patch that removes the #ifdef CMPXCHG_LOCAL > > was not applied? Pekka? > > This patch? > > http://git.kernel.org/?p=linux/kernel/git/penberg/slab-

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

On Mon, Jun 13, 2011 at 1:34 PM, Pekka Enberg wrote: > On Mon, Jun 13, 2011 at 10:29 PM, Christoph Lameter wrote: >> On Mon, 13 Jun 2011, Pekka Enberg wrote: >> >>> > Hmmm.. The allocpercpu in alloc_kmem_cache_cpus should take care of the >>> > alignment. Uhh.. I see that a patch that removes the

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

On Mon, 2011-06-13 at 12:59 -0500, Christoph Lameter wrote: > On Sun, 12 Jun 2011, Hugh Dickins wrote: > > > 3.0-rc won't boot with SLUB on my PowerPC G5: kernel BUG at mm/slub.c:1950! > > Bisected to 1759415e630e "slub: Remove CONFIG_CMPXCHG_LOCAL ifdeffery". > > > > After giving myself a medal f

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

On Mon, Jun 13, 2011 at 10:29 PM, Christoph Lameter wrote: > On Mon, 13 Jun 2011, Pekka Enberg wrote: > >> > Hmmm.. The allocpercpu in alloc_kmem_cache_cpus should take care of the >> > alignment. Uhh.. I see that a patch that removes the #ifdef CMPXCHG_LOCAL >> > was not applied? Pekka? >> >> Thi

[PATCH 1/2] mm: Move definition of MIN_MEMORY_BLOCK_SIZE to a header

The macro MIN_MEMORY_BLOCK_SIZE is currently defined twice in two .c files, and I need it in a third one to fix a powerpc bug, so let's first move it into a header Signed-off-by: Benjamin Herrenschmidt --- Ingo, Thomas: Who needs to ack the x86 bit ? I'd like to send that to Linus asap with the

[PATCH 2/2] powerpc/mm: Fix memory_block_size_bytes() for non-pseries

Just compiling pseries in the kernel causes it to override memory_block_size_bytes() regardless of what is the runtime platform. This cleans up the implementation of that function, fixing a bug or two while at it, so that it's harmless (and potentially useful) for other platforms. Without this, bu

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

On Mon, 2011-06-13 at 14:00 -0700, Hugh Dickins wrote: > On Mon, Jun 13, 2011 at 1:34 PM, Pekka Enberg wrote: > > On Mon, Jun 13, 2011 at 10:29 PM, Christoph Lameter wrote: > >> On Mon, 13 Jun 2011, Pekka Enberg wrote: > >> > >>> > Hmmm.. The allocpercpu in alloc_kmem_cache_cpus should take care

[PATCH] tqm8540: add description for onboard flash

Signed-off-by: Dmitry Eremin-Solenikov --- arch/powerpc/boot/dts/tqm8540.dts | 40 + 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/boot/dts/tqm8540.dts b/arch/powerpc/boot/dts/tqm8540.dts index b5c0940..987c862 100644 --- a/arc