RE: [PATCH v2 5/5] xhci: Remove recursive call to xhci_handle_event

2011-03-30 Thread David Laight
> > - xhci_handle_event(xhci); > > + while (xhci_handle_event(xhci)) {} > > > > I must admit I dislike the style with empty loop bodies... I would use an explicit 'continue;' for the body of an otherwise empty loop. David ___ Linuxppc-

Re: [PATCH] powerpc: dtc: remove obsolete .gitignore entries

2011-03-30 Thread Wolfram Sang
On Sat, Mar 12, 2011 at 05:44:10PM +0100, Wolfram Sang wrote: > dtc was moved and .gitignores have been added to the new location. So, we can > delete the old, forgotten ones. > > Signed-off-by: Wolfram Sang > Cc: Benjamin Herrenschmidt Ping. Is this one more for Ben or more for Grant? > --- >

Re: checking status semantics with compatible functions

2011-03-30 Thread Kumar Gala
[Adding proper lists on CC] - k On Mar 30, 2011, at 3:07 AM, Kumar Gala wrote: > Grant, > > We have a few helper functions like: > > drivers/of/base.c:EXPORT_SYMBOL(of_device_is_compatible); > drivers/of/base.c:EXPORT_SYMBOL(of_find_compatible_node); > > That we use in places like arch/powerp

[PATCH v4]PPC4xx: Adding PCI(E) MSI support

2011-03-30 Thread Rupjyoti Sarmah
This patch adds MSI support for 440SPe, 460Ex, 460Sx and 405Ex. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Tirumala R Marri --- v4: * Updated the coding style as per recommendation by Philipp * The goto style code removed as per suggestion v3: * Rebased to Josh next tree * Cleanup and re

[PATCH] powerpc: rename get_irq_desc_data and get_irq_desc_chip

2011-03-30 Thread Richard Cochran
These two functions disappeared in commit 0c6f8a8b917ad361319c8ace3e9f28e69bfdb4c1 "genirq: Remove compat code" but they still exist in qe_ic.h. This patch renames the function to their new names. Signed-off-by: Richard Cochran --- arch/powerpc/include/asm/qe_ic.h | 16 --

Re: [PATCH] powerpc: rename get_irq_desc_data and get_irq_desc_chip

2011-03-30 Thread Thomas Gleixner
On Wed, 30 Mar 2011, Richard Cochran wrote: > These two functions disappeared in commit > > 0c6f8a8b917ad361319c8ace3e9f28e69bfdb4c1 > "genirq: Remove compat code" > > but they still exist in qe_ic.h. > This patch renames the function to their new names. oops. I really need to figure ou

Re: checking status semantics with compatible functions

2011-03-30 Thread Grant Likely
On Wed, Mar 30, 2011 at 03:26:29AM -0500, Kumar Gala wrote: > [Adding proper lists on CC] > > - k > > On Mar 30, 2011, at 3:07 AM, Kumar Gala wrote: > > > Grant, > > > > We have a few helper functions like: > > > > drivers/of/base.c:EXPORT_SYMBOL(of_device_is_compatible); > > drivers/of/base.c

Re: [PATCH] POWER: perf_event: Skip updating kernel counters if register value shrinks

2011-03-30 Thread Eric B Munson
On Wed, 30 Mar 2011, Benjamin Herrenschmidt wrote: > On Tue, 2011-03-29 at 10:25 -0400, Eric B Munson wrote: > > Here I made the assumption that the hardware would never remove more events > > in > > a speculative roll back than it had added. This is not a situation I > > encoutered in my limite

Re: mmotm threatens ppc preemption again

2011-03-30 Thread Andrew Morton
On Mon, 21 Mar 2011 13:22:30 +1100 Benjamin Herrenschmidt wrote: > On Sun, 2011-03-20 at 19:20 -0700, Hugh Dickins wrote: > > > As long as the races to avoid are between map/unmap vs. access, yes, it > > > -should- be fine, and we used to not do demand faulting on kernel space > > > (but for how

Re: mmotm threatens ppc preemption again

2011-03-30 Thread Jeremy Fitzhardinge
On 03/30/2011 01:53 PM, Andrew Morton wrote: > On Mon, 21 Mar 2011 13:22:30 +1100 > Benjamin Herrenschmidt wrote: > >> On Sun, 2011-03-20 at 19:20 -0700, Hugh Dickins wrote: As long as the races to avoid are between map/unmap vs. access, yes, it -should- be fine, and we used to not do de

Re: [PATCH v2 5/5] xhci: Remove recursive call to xhci_handle_event

2011-03-30 Thread Matt Evans
On 30/03/11 07:00, Dmitry Torokhov wrote: > On Sunday, March 27, 2011 09:53:00 pm Matt Evans wrote: >> @@ -2282,7 +2284,7 @@ hw_died: >> /* FIXME this should be a delayed service routine >> * that clears the EHB. >> */ >> -xhci_handle_event(xhci); >> +while (xhci_handle_eve

Re: mmotm threatens ppc preemption again

2011-03-30 Thread Benjamin Herrenschmidt
On Wed, 2011-03-30 at 14:07 -0700, Jeremy Fitzhardinge wrote: > >1. Change the locking rules for kernel updates to also require a pte lock >2. Special-case batched kernel updates to include a pte lock >3. Make Power deal with preemption during a batched kernel update >4. Never do b

Re: How to define an I2C-to-SPI bridge device ?

2011-03-30 Thread Grant Likely
On Tue, Mar 29, 2011 at 06:21:50PM +0200, Andre Schwarz wrote: > On 03/25/2011 10:28 AM, Andre Schwarz wrote: > >Grant, Anton, > > got it. > providing modalis = "spidev" within spi_board_info works like a charme ... Good. Glad you got it sorted out. g. _

Re: [PATCH] POWER: perf_event: Skip updating kernel counters if register value shrinks

2011-03-30 Thread Benjamin Herrenschmidt
On Wed, 2011-03-30 at 14:36 -0400, Eric B Munson wrote: > On Wed, 30 Mar 2011, Benjamin Herrenschmidt wrote: > > > On Tue, 2011-03-29 at 10:25 -0400, Eric B Munson wrote: > > > Here I made the assumption that the hardware would never remove more > > > events in > > > a speculative roll back than