Re: [RFC PATCH 13/15] dt/serial: Eliminate users of of_platform_{, un}register_driver

2011-02-25 Thread Arnd Bergmann
On Wednesday 23 February 2011, Grant Likely wrote: > Get rid of users of of_platform_driver in drivers/serial. The > of_platform_{,un}register_driver functions are going away, so the > users need to be converted to using the platform_bus_type directly. > > Signed-off-by: Grant Likely of_serial

Re: [RFC PATCH 01/15] dt/powerpc: move of_bus_type infrastructure to ibmebus

2011-02-25 Thread Arnd Bergmann
On Wednesday 23 February 2011, Grant Likely wrote: > arch/powerpc/kernel/ibmebus.c is the only remaining user of the > of_bus_type support code for initializing the bus and registering > drivers. All others have either been switched to the vanilla platform > bus or already have their own infrastru

RE: Open Firmware and interrupt trigger

2011-02-25 Thread Benjamin Herrenschmidt
On Fri, 2011-02-25 at 08:29 +0100, Robert Thorhuus wrote: > Thank you Benjamin! > > Sorry for not using your qouting schema :( > > Benjamin, you are right about the IRQ flags. Those interrupt.h flags > seems to differ from my processor reference manual. Check the bindings or the driver. IE. What

Re: [RFC PATCH 01/15] dt/powerpc: move of_bus_type infrastructure to ibmebus

2011-02-25 Thread Benjamin Herrenschmidt
On Thu, 2011-02-24 at 15:46 +0100, Arnd Bergmann wrote: > On Wednesday 23 February 2011, Grant Likely wrote: > > arch/powerpc/kernel/ibmebus.c is the only remaining user of the > > of_bus_type support code for initializing the bus and registering > > drivers. All others have either been switched t

Re: Resources used by driver ?

2011-02-25 Thread Guillaume Dargaud
On Wednesday 16 February 2011 08:01:10 Srivatsan S wrote: > You can use oprofile to profile the functions of your module. Follow the > link. > http://oprofile.sourceforge.net/ OK, after some wrestling, I got oprofile installed in my OS (buildroot 2011.02- rc

Re: Resources used by driver ?

2011-02-25 Thread Guillaume Dargaud
> When I start oprofile, I get the following: > # opcontrol --vmlinux=/vmlinux > The specified file /vmlinux does not seem to be valid > Make sure you are using the non-compressed image file (e.g. vmlinux not > vmlinuz) Sorry, I had an incomplete install of objdump/binutils on my target. I'm now

RE: [RFC PATCH 06/15] dt: xilinx_hwicap: merge platform and of_platformdriver bindings

2011-02-25 Thread Stephen Neuendorffer
Minor nit below Acked-by: Stephen Neuendorffer Steve > -Original Message- > From: linuxppc-dev-bounces+stephen=neuendorffer.n...@lists.ozlabs.org [mailto:linuxppc-dev- > bounces+stephen=neuendorffer.n...@lists.ozlabs.org] On Behalf Of Grant Likely > Sent: Tuesday, February 22, 2011 8:34

[PATCH] rapidio: Fix sysfs config attribute to access 16MB of maint space

2011-02-25 Thread Alexandre Bounine
Fixes sysfs config attribute to allow access to entire 16MB maintenance space of RapidIO devices. Signed-off-by: Alexandre Bounine Cc: Kumar Gala Cc: Matt Porter Cc: Li Yang Cc: Thomas Moll Cc: Micha Nelissen --- drivers/rapidio/rio-sysfs.c | 12 ++-- include/linux/rio_regs.h|

[PATCH -mm V2] rapidio: Add new sysfs attributes

2011-02-25 Thread Alexandre Bounine
Add new sysfs attributes. 1. Routing information required to to reach the RIO device: destid - device destination ID (real for for endpoint, route for switch) hopcount - hopcount for maintenance requests (switches only) 2. device linking information: lprev - name of device that precedes the given

Re: [PATCH] tty/serial: Relax the device_type restriction from of_serial

2011-02-25 Thread Grant Likely
Hi Arnd and Ben, I forgot to cc you guys on this patch. Greg has it in his tree, but I wanted to make sure you noticed it. If you have any objections, let me know and I'll ask Greg to drop it. Thanks, g. On Tue, Feb 22, 2011 at 7:12 PM, Grant Likely wrote: > There is no need to test for a de

Re: [PATCH] tty/serial: Relax the device_type restriction from of_serial

2011-02-25 Thread Benjamin Herrenschmidt
On Fri, 2011-02-25 at 12:22 -0700, Grant Likely wrote: > Hi Arnd and Ben, > > I forgot to cc you guys on this patch. Greg has it in his tree, but I > wanted to make sure you noticed it. If you have any objections, let > me know and I'll ask Greg to drop it. No objection. Device-types are a thin

[PATCH v4 0/2] powerpc: Open PIC binding and "pic-no-reset"

2011-02-25 Thread Meador Inge
This patch set provides a binding for Open PIC and implements support for a new property, specified by that binding, called "pic-no-reset". v4 - Per Ben's feedback the protected sources implementation was left completely intact. As such, the DTS cleanup and "protected-sources" removal p

[PATCH v4 2/2] powerpc: make MPIC honor the "pic-no-reset" device tree property

2011-02-25 Thread Meador Inge
This property, defined in the Open PIC binding, tells the kernel not to use the reset bit in the global configuration register. Additionally, its presence mandates that only sources which are actually used (i.e. appear in the device tree) should have their VECPRI bits initialized. Although, "pic-

[PATCH v4 1/2] powerpc: document the Open PIC device tree binding

2011-02-25 Thread Meador Inge
This binding documents several properties that have been in use for quite some time, and adds one new property 'pic-no-reset', which controls the runtime initialization behavior of the PIC. More specifically, the presence of 'pic-no-reset' mandates that the PIC shall not be reset during runtime in

[PATCH 0/8] fsldma: lockup fixes

2011-02-25 Thread Ira W. Snyder
Hello everyone, I've been chasing random infrequent controller lockups in the fsldma driver for a long time. I finally managed to find the problem and fix it. I'm not quite sure about the exact sequence of events which causes the race condition, but it is related to using the hardware registers to

[PATCH 3/8] fsldma: improve link descriptor debugging

2011-02-25 Thread Ira W. Snyder
This adds better tracking to link descriptor allocations, callbacks, and frees. This makes it much easier to track errors with link descriptors. Signed-off-by: Ira W. Snyder --- drivers/dma/fsldma.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/dri

[PATCH 1/8] fsldma: move related helper functions near each other

2011-02-25 Thread Ira W. Snyder
This is a purely cosmetic cleanup. It is nice to have related functions right next to each other in the code. Signed-off-by: Ira W. Snyder --- drivers/dma/fsldma.c | 116 +++-- 1 files changed, 64 insertions(+), 52 deletions(-) diff --git a/drivers/d

[PATCH 4/8] fsldma: minor codingstyle and consistency fixes

2011-02-25 Thread Ira W. Snyder
This fixes some minor violations of the coding style. It also changes the style of the device_prep_dma_*() function definitions so they are identical. Signed-off-by: Ira W. Snyder --- drivers/dma/fsldma.c | 29 + drivers/dma/fsldma.h |4 ++-- 2 files changed, 15

[PATCH 2/8] fsldma: use channel name in printk output

2011-02-25 Thread Ira W. Snyder
This makes debugging the driver much easier when multiple channels are running concurrently. In addition, you can see how much descriptor memory each channel has allocated via the dmapool API in sysfs. Signed-off-by: Ira W. Snyder --- drivers/dma/fsldma.c | 60 +++--

[PATCH 7/8] dmatest: fix automatic buffer unmap type

2011-02-25 Thread Ira W. Snyder
The dmatest code relies on the DMAEngine API to automatically call dma_unmap_single() on src buffers. The flags it passes are incorrect, fix them. Signed-off-by: Ira W. Snyder --- drivers/dma/dmatest.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/dma/dma

[PATCH 8/8] fsldma: reduce locking during descriptor cleanup

2011-02-25 Thread Ira W. Snyder
This merges the fsl_chan_ld_cleanup() function into the dma_do_tasklet() function to reduce locking overhead. In the best case, we will be able to keep the DMA controller busy while we are freeing used descriptors. In all cases, the spinlock is grabbed two times fewer than before on each transactio

[PATCH 6/8] fsldma: support async_tx dependencies and automatic unmapping

2011-02-25 Thread Ira W. Snyder
Previous to this patch, the dma_run_dependencies() function has been called while holding desc_lock. This function can call tx_submit() for other descriptors, which may try to re-grab the lock. Avoid this by moving the descriptors to be cleaned up to a temporary list, and dropping the lock before c

[PATCH 5/8] fsldma: fix controller lockups

2011-02-25 Thread Ira W. Snyder
Enabling poisoning in the dmapool API quickly showed that the DMA controller was fetching descriptors that should not have been in use. This has caused intermittent controller lockups during testing. I have been unable to figure out the exact set of conditions which cause this to happen. However,