RE: [PATCH 2/7] PowerPC: add unlikely() to BUG_ON()

2011-01-28 Thread David Laight
> > +#define __BUG_ON(x) do { \ > > if (__builtin_constant_p(x)) { \ > > if (x) \ > > BUG(); \ > > @@ -85,6 +86,8 @@ > > }

RE: [PATCH v2] gianfar: Fall back to software tcp/udp checksum on oldercontrollers

2011-01-28 Thread David Laight
> + if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12) > + && ((unsigned long)fcb % 0x20) > 0x18)) { You need to check the generated code, but I think you need: if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12)) && unlikely(((unsigned long)

Re: [PATCH 2/7] PowerPC: add unlikely() to BUG_ON()

2011-01-28 Thread Andreas Schwab
"David Laight" writes: > Also, as (I think) in some of the generated code quoted, > use of __builtin_expect() with a boolean expression can > force some versions of gcc to generate the integer > value of the expression That's more likely a side effect of the definition of likely/unlikely: they e

Buxybox for powerpc not compiling

2011-01-28 Thread Giriprasad Deviprasad
Hi All,  I am trying to compile busybox-1.17.1 for mpc8250 based powerpc architecture. My settings are as : export LDFLAGS="-nostdlib -L/opt/mpc8250/tools/ppc_6xx/usr/lib/" export LIBRARY_PATH=/opt/mpc8250/tools/ppc_6xx/usr/lib/ echo $PATH /usr/lib/qt-3.3/bin:/usr/kerberos/sbin:/usr/kerberos/bi

Busybox for powerpc not compiling

2011-01-28 Thread Giriprasad Deviprasad
Hi All,  I am trying to compile busybox-1.17.1 for mpc8250 based powerpc architecture. My settings are as : export LDFLAGS="-nostdlib -L/opt/mpc8250/tools/ppc_6xx/usr/lib/" export LIBRARY_PATH=/opt/mpc8250/tools/ppc_6xx/usr/lib/ echo $PATH /usr/lib/qt-3.3/bin:/usr/kerberos/sbin:/usr/kerberos/bi

Re: [PATCH 2/7] PowerPC: add unlikely() to BUG_ON()

2011-01-28 Thread Coly Li
On 2011年01月28日 18:14, Andreas Schwab Wrote: "David Laight" writes: Also, as (I think) in some of the generated code quoted, use of __builtin_expect() with a boolean expression can force some versions of gcc to generate the integer value of the expression That's more likely a side effect of t

Need help for USB OTG feature for Canyonlands PPC460EX Board

2011-01-28 Thread sunny bhayani
Hi All, I am trying to enable the USB DWC OTG feature for Canyonlands PPC460EX Board, and am using the 2.6.30 kernel from denx. Now the issue is I am selecting the "USB Gadget" feature from the kernel menuconfig, but the kernel log only shows, dwc_otg: version 2.60a 22-NOV-2006 The probe() fun

Re: [PATCH v2] gianfar: Fall back to software tcp/udp checksum on oldercontrollers

2011-01-28 Thread Scott Wood
On Fri, 28 Jan 2011 09:10:46 + David Laight wrote: > > > + if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12) > > +&& ((unsigned long)fcb % 0x20) > 0x18)) { > > You need to check the generated code, but I think you need: > > if (unlikely(gfar_has_erra

PCIe end-point on FPGA doesn't show up on PCI bus when configured

2011-01-28 Thread Matias Garcia
I'm running a vanilla linux 2.6.37 kernel on a Freescale P2020 dual-core processor, and have the following conundrum: I configure the FPGA which brings up a PCIe interface to the processor. I scan both PCI buses on the system (I believe the second bus is behind the Freescale integrated bridge o

Re: [PATCH v2] gianfar: Fall back to software tcp/udp checksum on oldercontrollers

2011-01-28 Thread David Miller
From: Scott Wood Date: Fri, 28 Jan 2011 10:56:10 -0600 > On Fri, 28 Jan 2011 09:10:46 + > David Laight wrote: > >> >> > + if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12) >> > + && ((unsigned long)fcb % 0x20) > 0x18)) { >> >> You need to check the generat

Re: PCIe end-point on FPGA doesn't show up on PCI bus when configured

2011-01-28 Thread Elie De Brauwer
On 01/28/11 19:37, Matias Garcia wrote: I'm running a vanilla linux 2.6.37 kernel on a Freescale P2020 dual-core processor, and have the following conundrum: I configure the FPGA which brings up a PCIe interface to the processor. I scan both PCI buses on the system (I believe the second bus is be