Re: More patches pushed to powerpc.git master and powerpc-next branches (second try)

2008-04-17 Thread Michael Ellerman
Hi Paul, Can you grab these when you're bored? http://patchwork.ozlabs.org/linuxppc/patch?q=ellerman&id=17653 http://patchwork.ozlabs.org/linuxppc/patch?q=ellerman&id=17654 http://patchwork.ozlabs.org/linuxppc/patch?q=ellerman&id=17655 http://patchwork.ozlabs.org/linuxppc/patch?q=ellerman&id=1765

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Benjamin Herrenschmidt
> > > otoh, if only one .c file will ever call this function then I think that > > > all problems are solved by > > > > > > a) moving the above ifdeffery into the .c file > > > b) adding a comment explaining which arch file must provide the override > > > c) directly including that file from with

Re: [RFC/PATCH 1/4] Move xics_setup_8259_cascade() into platforms/pseries/setup.c

2008-04-17 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > The code in xics.c to setup the i8259 cascaded irq handler is not really > xics specific, so move it into setup.c - we will clean this up further in > a subsequent patch. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by

Re: [RFC/PATCH 2/4] Turn xics_setup_8259_cascade() into a generic pseries_setup_i8259_cascade()

2008-04-17 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > Remove the xics references from xics_setup_8259_cascade(), and merge the > good bits from the almost identical logic in pseries_mpic_init_IRQ(). > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <

Re: [RFC/PATCH 3/4] Use pseries_setup_i8259_cascade() in pseries_mpic_init_IRQ()

2008-04-17 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > pseries_mpic_init_IRQ() implements the same logic as the xics code did to > find the i8259 cascade irq. Now that we've pulled that logic out into > pseries_setup_i8259_cascade() we can use it in the mpic code. > > Signed-off-by: Michael

Re: [RFC/PATCH 4/4] Simplify xics direct/lpar irq_host setup

2008-04-17 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > The xics code currently has a direct and lpar variant of xics_host_map, the > only difference being which irq_chip they use. If we remember which irq_chip > we're using we can combine these two routines. That also allows us to have a > s

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Andrew Morton
On Fri, 18 Apr 2008 13:58:06 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > otoh, if only one .c file will ever call this function then I think that > > > > all problems are solved by > > > > > > > > a) moving the above ifdeffery into the .c file > > > > b) adding a comment e

Re: [PATCH 1/5] [POWERPC] sysdev: implement FSL GTM support

2008-04-17 Thread Kumar Gala
On Apr 17, 2008, at 5:47 PM, Anton Vorontsov wrote: On Thu, Apr 17, 2008 at 11:28:32PM +0400, Anton Vorontsov wrote: GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Kyle McMartin
On Fri, Apr 18, 2008 at 01:58:06PM +1000, Benjamin Herrenschmidt wrote: > Well, looking there, I saw we already used weak symbols for that so what > about the patch below ? If you're ok, I'll re-send with appropriate sob > & adapted powerpc part. > This is definitely the cleanest way to do this f

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Michael Ellerman
On Thu, 2008-04-17 at 21:19 -0700, Andrew Morton wrote: > On Fri, 18 Apr 2008 13:58:06 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> > wrote: > > > > > > > > otoh, if only one .c file will ever call this function then I think > > > > > that > > > > > all problems are solved by > > > > > > >

Re: [RFC/PATCH 3/4] Use pseries_setup_i8259_cascade() in pseries_mpic_init_IRQ()

2008-04-17 Thread Michael Ellerman
On Fri, 2008-04-18 at 14:15 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > > pseries_mpic_init_IRQ() implements the same logic as the xics code did to > > find the i8259 cascade irq. Now that we've pulled that logic out into > > pseries_setup_i82

[POWERPC] Optimize fls64() on 64-bit processors

2008-04-17 Thread Paul Mackerras
64-bit powerpc processors can find the leftmost 1 bit in a 64-bit doubleword in one instruction, so use that rather than using the generic fls64(), which does two 32-bit fls() calls. Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]> --- This is on top of a patch from Alexander van Heukelum that wa

[PATCH 2.6.26?] Raise the upper limit of NR_CPUS.

2008-04-17 Thread Tony Breeds
As the pacas are statically initialised increasing NR_CPUS beyond 128, means that any additional pacas will be empty ... which is bad. This patch adds the required functionality to fill in any excess pacas at runtime. Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> --- I know it's late, but can t

2.6.25-mm1 on the g5

2008-04-17 Thread Andrew Morton
It had been running happily and hard for a couple of hours when: registered taskstats version 1 Freeing unused kernel memory: 304k freed windfarm: CPUs control loops started. EXT3-fs: INFO: recovery required on readonly filesystem. EXT3-fs: write access will be enabled during recovery. kjournald

Re: 2.6.25-mm1 on the g5

2008-04-17 Thread Paul Mackerras
Andrew Morton writes: > It had been running happily and hard for a couple of hours when: Looks like the bug that Kamalesh Babulal reported and which I have been chasing without success so far. > That's a pretty crappy trace. Perhaps netconsole lost some of it, dunno. Yeah, there's a bug in the

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Benjamin Herrenschmidt
> > so what > > about the patch below ? > > I like it, but the compiler won't ;) > > > If you're ok, I'll re-send with appropriate sob > > & adapted powerpc part. > > Sure. > > > +void __init __attribute__((weak) thread_info_cache_init(void) > > s/weak)/weak))/ Yeah, missing quilt ref :-) I

[PATCH 1/3] Add thread_info_cache_init() weak hook

2008-04-17 Thread Benjamin Herrenschmidt
Some architecture need to maintain a kmem cache for thread info structures. (next patch adds that to powerpc to fix an alignment problem). There is no good arch callback to use to initialize that cache that I can find, so this adds a new one in the form of a weak function whose default is empty.

[PATCH 2/3] [POWERPC] Fix kernel stack allocation alignment

2008-04-17 Thread Benjamin Herrenschmidt
The powerpc kernel stacks need to be naturally aligned, as they contain the thread info at the bottom, which is obtained by clearing the low bits of the stack pointer. However, when using 64K pages (the stack is smaller than a page), we use kmalloc to allocate it, which doesn't provide that guaran

[PATCH 3/3] Use __weak macro for smp_setup_processor_id

2008-04-17 Thread Benjamin Herrenschmidt
Use the __weak macro instead of the longer __attribute__ ((weak)) form Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> -- init/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-work.orig/init/main.c 2008-04-18 16:44:32.0 +1000 +++ linux-work/init/main.c

<    1   2